mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-28 11:18:45 +07:00
staging: comedi: usbdux: clarify bipolar ai data
Use the comedi_range_is_bipolar() helper instead of checking the 'range' index against a magic number. Also, use the s->maxdata to calculate the value needed to munge the value for bipolar data instead of the magic number. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
a79b4cdb52
commit
91891f7cc6
@ -1002,8 +1002,10 @@ static int usbdux_ai_insn_read(struct comedi_device *dev,
|
||||
goto ai_read_exit;
|
||||
|
||||
val = le16_to_cpu(devpriv->insn_buffer[1]);
|
||||
if (range <= 1)
|
||||
val ^= 0x800;
|
||||
|
||||
/* bipolar data is two's-complement */
|
||||
if (comedi_range_is_bipolar(s, range))
|
||||
val ^= ((s->maxdata + 1) >> 1);
|
||||
|
||||
data[i] = val;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user