AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-12-26 11:35:07 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

staging: i4l: pcbit: edss1: use setup_timer() and mod_timer().

Browse Source 
Use setup_timer() instead of init_timer(), being the preferred/standard
way to set a timer up.

Also, quoting the mod_timer() function comment:
-> mod_timer() is a more efficient way to update the expire field of an
   active timer (if the timer is inactive it will be activated).

Use setup_timer and mod_timer to setup and arm a timer, to make the code
cleaner and easier to read.

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Muhammad Falak R Wani 2016-05-11 19:25:00 +05:30 committed by Greg Kroah-Hartman
parent fd2b75d888
commit 8df7a2221c
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/staging/i4l/pcbit/edss1.c
View File

@ -298,11 +298,8 @@ void pcbit_fsm_event(struct pcbit_dev *dev, struct pcbit_chan *chan,
break; break;
if (tentry->init != 0xff) { if (tentry->init != 0xff) {
init_timer(&chan->fsm_timer); setup_timer(&chan->fsm_timer, &pcbit_fsm_timer, (ulong)chan);
chan->fsm_timer.function = &pcbit_fsm_timer; mod_timer(&chan->fsm_timer, jiffies + tentry->timeout * HZ);
chan->fsm_timer.data = (ulong) chan;
chan->fsm_timer.expires = jiffies + tentry->timeout * HZ;
add_timer(&chan->fsm_timer);
} }
spin_unlock_irqrestore(&dev->lock, flags); spin_unlock_irqrestore(&dev->lock, flags);