AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-11-24 11:30:53 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

RDMA/efa: Remove redundant udata check from alloc ucontext response

Browse Source 
The alloc ucontext flow is always called with a valid udata, there's no
need to test whether it's NULL.

While at it, the 'udata->outlen' check is removed as well as we copy the
minimum between the size of the response and outlen, so in case of zero
outlen, zero bytes will be copied.

Link: https://lore.kernel.org/r/20200818110835.54299-1-galpress@amazon.com
Reviewed-by: Firas JahJah <firasj@amazon.com>
Reviewed-by: Yossi Leybovich <sleybo@amazon.com>
Signed-off-by: Gal Pressman <galpress@amazon.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
This commit is contained in:
Gal Pressman 2020-08-18 14:08:35 +03:00 committed by Jason Gunthorpe
parent 62cbff3267
commit 8d9290a4a8
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/infiniband/hw/efa/efa_verbs.c
View File

@ -1698,12 +1698,10 @@ int efa_alloc_ucontext(struct ib_ucontext *ibucontext, struct ib_udata *udata)
resp.max_tx_batch = dev->dev_attr.max_tx_batch; resp.max_tx_batch = dev->dev_attr.max_tx_batch;
resp.min_sq_wr = dev->dev_attr.min_sq_depth; resp.min_sq_wr = dev->dev_attr.min_sq_depth;
if (udata && udata->outlen) { err = ib_copy_to_udata(udata, &resp,
err = ib_copy_to_udata(udata, &resp, min(sizeof(resp), udata->outlen));
min(sizeof(resp), udata->outlen)); if (err)
if (err) goto err_dealloc_uar;
goto err_dealloc_uar;
}
return 0; return 0;