From 893ded36e06de1f9826b6303b5733fbc4990a97a Mon Sep 17 00:00:00 2001 From: Daniel Vetter Date: Thu, 21 Feb 2019 16:59:51 +0100 Subject: [PATCH] staging/vboxvideo: Another FIXME item Found while grepping around. Signed-off-by: Daniel Vetter Cc: Hans de Goede Cc: Greg Kroah-Hartman Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Liviu Dudau Reviewed-by: Greg Kroah-Hartman Signed-off-by: Hans de Goede Link: https://patchwork.freedesktop.org/patch/msgid/20190221155951.19855-1-daniel.vetter@ffwll.ch --- drivers/staging/vboxvideo/vbox_irq.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/staging/vboxvideo/vbox_irq.c b/drivers/staging/vboxvideo/vbox_irq.c index 195484713365..89944134ea86 100644 --- a/drivers/staging/vboxvideo/vbox_irq.c +++ b/drivers/staging/vboxvideo/vbox_irq.c @@ -123,6 +123,11 @@ static void vbox_update_mode_hints(struct vbox_private *vbox) validate_or_set_position_hints(vbox); drm_modeset_lock_all(dev); + /* + * FIXME: this needs to use drm_connector_list_iter and some real + * locking for the actual data it changes, not the deprecated + * drm_modeset_lock_all() shotgun approach. + */ list_for_each_entry(connector, &dev->mode_config.connector_list, head) { vbox_conn = to_vbox_connector(connector);