AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2025-04-03 05:57:57 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

drm/i915/skl: Consider plane rotation when calculating stride in skl_do_mmio_flip

Browse Source 
Previously rotation was ignored and wrong stride programmed
into the plane registers resulting in a corrupt image on screen.

v2: Do not access potentialy old plane state at flip time,
    but store the rotation value at the time of queing the flip.
    (Ville)

v3: No need to pass rotation to intel_queue_mmio_flip since it
    is available in the crtc. (Ville)

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Testcase: igt/kms_rotation_crc/primary-rotation-90-flip-stress (SKL)
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Sonika Jindal <sonika.jindal@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:
Tvrtko Ursulin 2015-10-20 16:20:21 +01:00 committed by Daniel Vetter
parent 54bf1ce633
commit 86efe24a85
2 changed files with 17 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
drivers/gpu/drm/i915/intel_display.c
View File

@ -11113,13 +11113,14 @@ static bool use_mmio_flip(struct intel_engine_cs *ring,
} }
static void skl_do_mmio_flip(struct intel_crtc *intel_crtc, static void skl_do_mmio_flip(struct intel_crtc *intel_crtc,
unsigned int rotation,
struct intel_unpin_work *work) struct intel_unpin_work *work)
{ {
struct drm_device *dev = intel_crtc->base.dev; struct drm_device *dev = intel_crtc->base.dev;
struct drm_i915_private *dev_priv = dev->dev_private; struct drm_i915_private *dev_priv = dev->dev_private;
struct drm_framebuffer *fb = intel_crtc->base.primary->fb; struct drm_framebuffer *fb = intel_crtc->base.primary->fb;
const enum pipe pipe = intel_crtc->pipe; const enum pipe pipe = intel_crtc->pipe;
u32 ctl, stride; u32 ctl, stride, tile_height;
ctl = I915_READ(PLANE_CTL(pipe, 0)); ctl = I915_READ(PLANE_CTL(pipe, 0));
ctl &= ~PLANE_CTL_TILED_MASK; ctl &= ~PLANE_CTL_TILED_MASK;
@ -11143,9 +11144,16 @@ static void skl_do_mmio_flip(struct intel_crtc *intel_crtc,
* The stride is either expressed as a multiple of 64 bytes chunks for * The stride is either expressed as a multiple of 64 bytes chunks for
* linear buffers or in number of tiles for tiled buffers. * linear buffers or in number of tiles for tiled buffers.
*/ */
stride = fb->pitches[0] / if (intel_rotation_90_or_270(rotation)) {
intel_fb_stride_alignment(dev, fb->modifier[0], /* stride = Surface height in tiles */
fb->pixel_format); tile_height = intel_tile_height(dev, fb->pixel_format,
fb->modifier[0], 0);
stride = DIV_ROUND_UP(fb->height, tile_height);
} else {
stride = fb->pitches[0] /
intel_fb_stride_alignment(dev, fb->modifier[0],
fb->pixel_format);
}
/* /*
* Both PLANE_CTL and PLANE_STRIDE are not updated on vblank but on * Both PLANE_CTL and PLANE_STRIDE are not updated on vblank but on
@ -11203,7 +11211,7 @@ static void intel_do_mmio_flip(struct intel_mmio_flip *mmio_flip)
intel_pipe_update_start(crtc); intel_pipe_update_start(crtc);
if (INTEL_INFO(mmio_flip->i915)->gen >= 9) if (INTEL_INFO(mmio_flip->i915)->gen >= 9)
skl_do_mmio_flip(crtc, work); skl_do_mmio_flip(crtc, mmio_flip->rotation, work);
else else
/* use_mmio_flip() retricts MMIO flips to ilk+ */ /* use_mmio_flip() retricts MMIO flips to ilk+ */
ilk_do_mmio_flip(crtc, work); ilk_do_mmio_flip(crtc, work);
@ -11230,10 +11238,7 @@ static void intel_mmio_flip_work_func(struct work_struct *work)
static int intel_queue_mmio_flip(struct drm_device *dev, static int intel_queue_mmio_flip(struct drm_device *dev,
struct drm_crtc *crtc, struct drm_crtc *crtc,
struct drm_framebuffer *fb, struct drm_i915_gem_object *obj)
struct drm_i915_gem_object *obj,
struct intel_engine_cs *ring,
uint32_t flags)
{ {
struct intel_mmio_flip *mmio_flip; struct intel_mmio_flip *mmio_flip;
@ -11244,6 +11249,7 @@ static int intel_queue_mmio_flip(struct drm_device *dev,
mmio_flip->i915 = to_i915(dev); mmio_flip->i915 = to_i915(dev);
mmio_flip->req = i915_gem_request_reference(obj->last_write_req); mmio_flip->req = i915_gem_request_reference(obj->last_write_req);
mmio_flip->crtc = to_intel_crtc(crtc); mmio_flip->crtc = to_intel_crtc(crtc);
mmio_flip->rotation = crtc->primary->state->rotation;
INIT_WORK(&mmio_flip->work, intel_mmio_flip_work_func); INIT_WORK(&mmio_flip->work, intel_mmio_flip_work_func);
schedule_work(&mmio_flip->work); schedule_work(&mmio_flip->work);
@ -11460,8 +11466,7 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc,
work->gtt_offset += intel_crtc->dspaddr_offset; work->gtt_offset += intel_crtc->dspaddr_offset;
if (mmio_flip) { if (mmio_flip) {
ret = intel_queue_mmio_flip(dev, crtc, fb, obj, ring, ret = intel_queue_mmio_flip(dev, crtc, obj);
page_flip_flags);
if (ret) if (ret)
goto cleanup_unpin; goto cleanup_unpin;

1
drivers/gpu/drm/i915/intel_drv.h
View File

@ -493,6 +493,7 @@ struct intel_mmio_flip {
struct drm_i915_private *i915; struct drm_i915_private *i915;
struct drm_i915_gem_request *req; struct drm_i915_gem_request *req;
struct intel_crtc *crtc; struct intel_crtc *crtc;
unsigned int rotation;
}; };
struct skl_pipe_wm { struct skl_pipe_wm {