AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2025-01-21 19:11:19 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

media: staging: atomisp: Do not set GPIO twice

Browse Source 
gpiod_get() configures GPIO line at the time of successful request.
Thus, no need to do this explicitly.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Andy Shevchenko 2017-09-27 14:25:00 -04:00 committed by Mauro Carvalho Chehab
parent e19c92059a
commit 81050aff30
1 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c
View File

@ -409,21 +409,11 @@ static struct gmin_subdev *gmin_subdev_add(struct v4l2_subdev *subdev)
if (!ret)
clk_disable_unprepare(gmin_subdevs[i].pmc_clk);
if (!IS_ERR(gmin_subdevs[i].gpio0)) {
ret = gpiod_direction_output(gmin_subdevs[i].gpio0, 0);
if (ret)
dev_err(dev, "gpio0 set output failed: %d\n", ret);
} else {
if (IS_ERR(gmin_subdevs[i].gpio0))
gmin_subdevs[i].gpio0 = NULL;
}
if (!IS_ERR(gmin_subdevs[i].gpio1)) {
ret = gpiod_direction_output(gmin_subdevs[i].gpio1, 0);
if (ret)
dev_err(dev, "gpio1 set output failed: %d\n", ret);
} else {
if (IS_ERR(gmin_subdevs[i].gpio1))
gmin_subdevs[i].gpio1 = NULL;
}
if (pmic_id == PMIC_REGULATOR) {
gmin_subdevs[i].v1p8_reg = regulator_get(dev, "V1P8SX");