AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-12-25 03:04:35 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

drm/msm: fix an error code in the ioctl

Browse Source 
The copy_to/from_user() functions return the number of bytes remaining
to be copied but we should return -EFAULT to the user.

Fixes: f05c83e774 ("drm/msm: add uapi to get/set debug name")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rob Clark <robdclark@gmail.com>
This commit is contained in:
Dan Carpenter 2019-02-14 10:19:27 +03:00 committed by Rob Clark
parent b6bd458c16
commit 7cce8e4efe
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/gpu/drm/msm/msm_drv.c
View File

@ -851,8 +851,9 @@ static int msm_ioctl_gem_info(struct drm_device *dev, void *data,
ret = -EINVAL; ret = -EINVAL;
break; break;
} }
ret = copy_from_user(msm_obj->name, if (copy_from_user(msm_obj->name, u64_to_user_ptr(args->value),
u64_to_user_ptr(args->value), args->len); args->len))
ret = -EFAULT;
msm_obj->name[args->len] = '\0'; msm_obj->name[args->len] = '\0';
for (i = 0; i < args->len; i++) { for (i = 0; i < args->len; i++) {
if (!isprint(msm_obj->name[i])) { if (!isprint(msm_obj->name[i])) {
@ -868,8 +869,9 @@ static int msm_ioctl_gem_info(struct drm_device *dev, void *data,
} }
args->len = strlen(msm_obj->name); args->len = strlen(msm_obj->name);
if (args->value) { if (args->value) {
ret = copy_to_user(u64_to_user_ptr(args->value), if (copy_to_user(u64_to_user_ptr(args->value),
msm_obj->name, args->len); msm_obj->name, args->len))
ret = -EFAULT;
} }
break; break;
} }