AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-11-25 02:20:52 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

gianfar: Fix overflow check and return value for gfar_get_cls_all()

Browse Source 
This function may currently fill one entry beyond the end of the
array it is given.  It also doesn't return an error code in case
it does detect overflow.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ben Hutchings 2011-09-06 12:44:25 +00:00 committed by David S. Miller
parent 22e83a2926
commit 710778ff87
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/gianfar_ethtool.c
View File

@ -1669,10 +1669,10 @@ static int gfar_get_cls_all(struct gfar_private *priv,
u32 i = 0; u32 i = 0;
list_for_each_entry(comp, &priv->rx_list.list, list) { list_for_each_entry(comp, &priv->rx_list.list, list) {
if (i <= cmd->rule_cnt) { if (i == cmd->rule_cnt)
rule_locs[i] = comp->fs.location; return -EMSGSIZE;
i++; rule_locs[i] = comp->fs.location;
} i++;
} }
cmd->data = MAX_FILER_IDX; cmd->data = MAX_FILER_IDX;