AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-11-30 02:16:42 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

[PATCH] x86-64: Use irq_domain in ioapic_retrigger_irq

Browse Source 
Thanks to YH Lu for spotting this.  It appears I missed this function when I
refactored allocate_irq_vector and introduced irq_domain, with the result that
all retriggered irqs would go to cpu 0 even if we were not prepared to receive
them there.

While reviewing YH's patch I also noticed that this function was missing
locking, and since I am now reading two values from two diffrent arrays that
looks like a race we might be able to hit in the real world.

Cc: Yinghai Lu <yinghai.lu@amd.com>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Andi Kleen <ak@suse.de>
This commit is contained in:
Eric W. Biederman 2006-10-21 18:37:02 +02:00 committed by Andi Kleen
parent a1bae67243
commit 6bf2dafad1
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
arch/x86_64/kernel/io_apic.c
View File

@ -1255,12 +1255,15 @@ static int ioapic_retrigger_irq(unsigned int irq)
{
cpumask_t mask;
unsigned vector;
unsigned long flags;
spin_lock_irqsave(&vector_lock, flags);
vector = irq_vector[irq];
cpus_clear(mask);
cpu_set(vector >> 8, mask);
cpu_set(first_cpu(irq_domain[irq]), mask);
send_IPI_mask(mask, vector & 0xff);
send_IPI_mask(mask, vector);
spin_unlock_irqrestore(&vector_lock, flags);
return 1;
}