mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-11-24 21:30:53 +07:00
[PATCH] fix: dmi_check_system
Background: 1) dmi_check_system() returns the count of the number of matches. Zero thus means no matches. 2) A match callback can return nonzero to stop the match checking. Bug: The count is incremented after we check for the nonzero return value, so it does not reflect the actual count. We could say this is intended, for some dumb reason, except that it means that a match on the first check returns zero--no matches--if the callback returns nonzero. Attached patch implements the count before calling the callback and thus before potentially short-circuiting. Signed-off-by: Robert Love <rml@novell.com> Cc: Andrey Panin <pazke@donpac.ru> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
parent
ebad6a4230
commit
640e803376
@ -248,9 +248,9 @@ int dmi_check_system(struct dmi_system_id *list)
|
||||
/* No match */
|
||||
goto fail;
|
||||
}
|
||||
count++;
|
||||
if (d->callback && d->callback(d))
|
||||
break;
|
||||
count++;
|
||||
fail: d++;
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user