AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-12-15 22:46:41 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

media: sun8i: Fix an error handling path in 'deinterlace_runtime_resume()'

Browse Source 
It is spurious to call 'clk_disable_unprepare()' when
'clk_prepare_enable()' has not been called yet.
Re-order the error handling path to avoid it.

Fixes: a4260ea495 ("media: sun4i: Add H3 deinterlace driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
[hverkuil-cisco@xs4all.nl: err_exlusive_rate -> err_exclusive_rate]
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Christophe JAILLET 2020-05-05 09:50:34 +02:00 committed by Mauro Carvalho Chehab
parent f4d12d8009
commit 62eedb3561
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/media/platform/sunxi/sun8i-di/sun8i-di.c
View File

@ -941,7 +941,7 @@ static int deinterlace_runtime_resume(struct device *device)
if (ret) {
dev_err(dev->dev, "Failed to enable bus clock\n");
goto err_exlusive_rate;
goto err_exclusive_rate;
}
ret = clk_prepare_enable(dev->mod_clk);
@ -969,14 +969,14 @@ static int deinterlace_runtime_resume(struct device *device)
return 0;
err_exlusive_rate:
clk_rate_exclusive_put(dev->mod_clk);
err_ram_clk:
clk_disable_unprepare(dev->ram_clk);
err_mod_clk:
clk_disable_unprepare(dev->mod_clk);
err_bus_clk:
clk_disable_unprepare(dev->bus_clk);
err_exclusive_rate:
clk_rate_exclusive_put(dev->mod_clk);
return ret;
}