AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-12-23 16:34:38 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

staging: vchiq_core: Bail out if ref_count is unexpected

Browse Source 
If the ref counter of service has an unexpected value then we better
bail out.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Stefan Wahren 2017-05-26 00:26:23 +02:00 committed by Greg Kroah-Hartman
parent 6b8db0bce3
commit 5d1a94bb28
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
View File

@ -175,7 +175,7 @@ find_service_by_handle(VCHIQ_SERVICE_HANDLE_T handle)
service = handle_to_service(handle); service = handle_to_service(handle);
if (service && (service->srvstate != VCHIQ_SRVSTATE_FREE) && if (service && (service->srvstate != VCHIQ_SRVSTATE_FREE) &&
(service->handle == handle)) { (service->handle == handle)) {
BUG_ON(service->ref_count == 0); WARN_ON(service->ref_count == 0);
service->ref_count++; service->ref_count++;
} else } else
service = NULL; service = NULL;
@ -197,7 +197,7 @@ find_service_by_port(VCHIQ_STATE_T *state, int localport)
spin_lock(&service_spinlock); spin_lock(&service_spinlock);
service = state->services[localport]; service = state->services[localport];
if (service && (service->srvstate != VCHIQ_SRVSTATE_FREE)) { if (service && (service->srvstate != VCHIQ_SRVSTATE_FREE)) {
BUG_ON(service->ref_count == 0); WARN_ON(service->ref_count == 0);
service->ref_count++; service->ref_count++;
} else } else
service = NULL; service = NULL;
@ -221,7 +221,7 @@ find_service_for_instance(VCHIQ_INSTANCE_T instance,
if (service && (service->srvstate != VCHIQ_SRVSTATE_FREE) && if (service && (service->srvstate != VCHIQ_SRVSTATE_FREE) &&
(service->handle == handle) && (service->handle == handle) &&
(service->instance == instance)) { (service->instance == instance)) {
BUG_ON(service->ref_count == 0); WARN_ON(service->ref_count == 0);
service->ref_count++; service->ref_count++;
} else } else
service = NULL; service = NULL;
@ -246,7 +246,7 @@ find_closed_service_for_instance(VCHIQ_INSTANCE_T instance,
(service->srvstate == VCHIQ_SRVSTATE_CLOSED)) && (service->srvstate == VCHIQ_SRVSTATE_CLOSED)) &&
(service->handle == handle) && (service->handle == handle) &&
(service->instance == instance)) { (service->instance == instance)) {
BUG_ON(service->ref_count == 0); WARN_ON(service->ref_count == 0);
service->ref_count++; service->ref_count++;
} else } else
service = NULL; service = NULL;
@ -273,7 +273,7 @@ next_service_by_instance(VCHIQ_STATE_T *state, VCHIQ_INSTANCE_T instance,
if (srv && (srv->srvstate != VCHIQ_SRVSTATE_FREE) && if (srv && (srv->srvstate != VCHIQ_SRVSTATE_FREE) &&
(srv->instance == instance)) { (srv->instance == instance)) {
service = srv; service = srv;
BUG_ON(service->ref_count == 0); WARN_ON(service->ref_count == 0);
service->ref_count++; service->ref_count++;
break; break;
} }
@ -291,7 +291,7 @@ lock_service(VCHIQ_SERVICE_T *service)
spin_lock(&service_spinlock); spin_lock(&service_spinlock);
WARN_ON(!service); WARN_ON(!service);
if (service) { if (service) {
BUG_ON(service->ref_count == 0); WARN_ON(service->ref_count == 0);
service->ref_count++; service->ref_count++;
} }
spin_unlock(&service_spinlock); spin_unlock(&service_spinlock);
@ -305,7 +305,10 @@ unlock_service(VCHIQ_SERVICE_T *service)
WARN(1, "%s: service is NULL\n", __func__); WARN(1, "%s: service is NULL\n", __func__);
goto unlock; goto unlock;
} }
BUG_ON(service->ref_count == 0); if (!service->ref_count) {
WARN(1, "%s: ref_count is zero\n", __func__);
goto unlock;
}
service->ref_count--; service->ref_count--;
if (!service->ref_count) { if (!service->ref_count) {
VCHIQ_STATE_T *state = service->state; VCHIQ_STATE_T *state = service->state;