mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-19 00:47:22 +07:00
wil6210: fix break that is never reached because of zero'ing of a retry counter
There is a check on the retry counter invalid_buf_id_retry that is always
false because invalid_buf_id_retry is initialized to zero on each iteration
of a while-loop. Fix this by initializing the retry counter before the
while-loop starts.
Addresses-Coverity: ("Logically dead code")
Fixes: b4a967b7d0
("wil6210: reset buff id in status message after completion")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Maya Erez <merez@codeaurora.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This commit is contained in:
parent
ea0c3e2a47
commit
5b1413f00b
@ -869,6 +869,7 @@ static struct sk_buff *wil_sring_reap_rx_edma(struct wil6210_priv *wil,
|
||||
u8 data_offset;
|
||||
struct wil_rx_status_extended *s;
|
||||
u16 sring_idx = sring - wil->srings;
|
||||
int invalid_buff_id_retry;
|
||||
|
||||
BUILD_BUG_ON(sizeof(struct wil_rx_status_extended) > sizeof(skb->cb));
|
||||
|
||||
@ -882,9 +883,9 @@ static struct sk_buff *wil_sring_reap_rx_edma(struct wil6210_priv *wil,
|
||||
/* Extract the buffer ID from the status message */
|
||||
buff_id = le16_to_cpu(wil_rx_status_get_buff_id(msg));
|
||||
|
||||
invalid_buff_id_retry = 0;
|
||||
while (!buff_id) {
|
||||
struct wil_rx_status_extended *s;
|
||||
int invalid_buff_id_retry = 0;
|
||||
|
||||
wil_dbg_txrx(wil,
|
||||
"buff_id is not updated yet by HW, (swhead 0x%x)\n",
|
||||
|
Loading…
Reference in New Issue
Block a user