AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-12-26 08:35:06 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

greybus: connection: Send protocol version for firmware protocol

Browse Source 
As per greybus specs, we need to send the protocol version for firmware
protocol and so this special case Hack.

Probably we should always send the protocol version AP supports and kill
this hack completely. But then it requires updates to specs as well, and
that should be done after some discussion.

For now, add a FIXME for that and a special case for firmware protocol.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Viresh Kumar 2015-08-12 09:19:34 +05:30 committed by Greg Kroah-Hartman
parent 90f1b617d8
commit 58dab0f2a8
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/staging/greybus/connection.c
View File

@ -421,7 +421,19 @@ int gb_connection_init(struct gb_connection *connection)
* this for SVC as that is initiated by the SVC.
*/
if (connection->hd_cport_id != GB_SVC_CPORT_ID) {
ret = gb_protocol_get_version(connection, false);
bool send_request = false;
/*
* We need to send the protocol version of the firmware protocol
* supported by AP and so this special case.
*/
if (connection->protocol->id == GREYBUS_PROTOCOL_FIRMWARE)
send_request = true;
// FIXME: Should we always send the protocol version AP can
// support ?
ret = gb_protocol_get_version(connection, send_request);
if (ret) {
dev_err(&connection->dev,
"Failed to get version CPort-%d (%d)\n",