net: fec_main: Use dev_err() instead of pr_err()

dev_err() is more appropriate for printing error messages inside
drivers, so switch to dev_err().

Signed-off-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Fabio Estevam 2019-06-07 09:14:18 -03:00 committed by David S. Miller
parent c976507441
commit 517a772c6c

View File

@ -2446,30 +2446,31 @@ static int
fec_enet_set_coalesce(struct net_device *ndev, struct ethtool_coalesce *ec) fec_enet_set_coalesce(struct net_device *ndev, struct ethtool_coalesce *ec)
{ {
struct fec_enet_private *fep = netdev_priv(ndev); struct fec_enet_private *fep = netdev_priv(ndev);
struct device *dev = &fep->pdev->dev;
unsigned int cycle; unsigned int cycle;
if (!(fep->quirks & FEC_QUIRK_HAS_COALESCE)) if (!(fep->quirks & FEC_QUIRK_HAS_COALESCE))
return -EOPNOTSUPP; return -EOPNOTSUPP;
if (ec->rx_max_coalesced_frames > 255) { if (ec->rx_max_coalesced_frames > 255) {
pr_err("Rx coalesced frames exceed hardware limitation\n"); dev_err(dev, "Rx coalesced frames exceed hardware limitation\n");
return -EINVAL; return -EINVAL;
} }
if (ec->tx_max_coalesced_frames > 255) { if (ec->tx_max_coalesced_frames > 255) {
pr_err("Tx coalesced frame exceed hardware limitation\n"); dev_err(dev, "Tx coalesced frame exceed hardware limitation\n");
return -EINVAL; return -EINVAL;
} }
cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr); cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr);
if (cycle > 0xFFFF) { if (cycle > 0xFFFF) {
pr_err("Rx coalesced usec exceed hardware limitation\n"); dev_err(dev, "Rx coalesced usec exceed hardware limitation\n");
return -EINVAL; return -EINVAL;
} }
cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr); cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr);
if (cycle > 0xFFFF) { if (cycle > 0xFFFF) {
pr_err("Rx coalesced usec exceed hardware limitation\n"); dev_err(dev, "Rx coalesced usec exceed hardware limitation\n");
return -EINVAL; return -EINVAL;
} }