AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-11-24 22:40:53 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

net: phy: Avoid multiple suspends

Browse Source 
It is currently possible for a PHY device to be suspended as part of a
network device driver's suspend call while it is still being attached to
that net_device, either via phy_suspend() or implicitly via phy_stop().

Later on, when the MDIO bus controller get suspended, we would attempt
to suspend again the PHY because it is still attached to a network
device.

This is both a waste of time and creates an opportunity for improper
clock/power management bugs to creep in.

Fixes: 803dd9c77a ("net: phy: avoid suspending twice a PHY")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Florian Fainelli 2020-02-20 15:34:53 -08:00 committed by David S. Miller
parent 44343418d0
commit 503ba7c696
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/phy/phy_device.c
View File

@ -247,7 +247,7 @@ static bool mdio_bus_phy_may_suspend(struct phy_device *phydev)
* MDIO bus driver and clock gated at this point. * MDIO bus driver and clock gated at this point.
*/ */
if (!netdev) if (!netdev)
return !phydev->suspended; goto out;
if (netdev->wol_enabled) if (netdev->wol_enabled)
return false; return false;
@ -267,7 +267,8 @@ static bool mdio_bus_phy_may_suspend(struct phy_device *phydev)
if (device_may_wakeup(&netdev->dev)) if (device_may_wakeup(&netdev->dev))
return false; return false;
return true; out:
return !phydev->suspended;
} }
static int mdio_bus_phy_suspend(struct device *dev) static int mdio_bus_phy_suspend(struct device *dev)