ext4: avoid possible double brelse() in add_new_gdb() on error path

Fixes: b40971426a ("ext4: add error checking to calls to ...")
Reported-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org # 2.6.38
This commit is contained in:
Theodore Ts'o 2018-11-06 17:18:17 -05:00
parent feaf264ce7
commit 4f32c38b46

View File

@ -871,6 +871,7 @@ static int add_new_gdb(handle_t *handle, struct inode *inode,
err = ext4_handle_dirty_metadata(handle, NULL, gdb_bh); err = ext4_handle_dirty_metadata(handle, NULL, gdb_bh);
if (unlikely(err)) { if (unlikely(err)) {
ext4_std_error(sb, err); ext4_std_error(sb, err);
iloc.bh = NULL;
goto exit_inode; goto exit_inode;
} }
brelse(dind); brelse(dind);