AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2025-03-11 23:27:42 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

IB/mlx4: Fix race when detaching a QP from a multicast group

Browse Source 
When detaching the last QP from an MCG entry, we need to make
sure that at any time, there will be no entry with zero number of
QPs which is linked to the list of the MCGs of the corresponding
hash index.  So don't write back the MCG entry if we are removing the
last QP; just unlink the entry.

Also, remove an unnecessary MCG read when attaching a QP requires
allocation of a new entry in the AMGM.

Signed-off-by: Eli Cohen <eli@mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
This commit is contained in:
Eli Cohen 2008-04-16 21:09:35 -07:00 committed by Roland Dreier
parent c83b5b1cb2
commit 4dc51b3258
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/net/mlx4/mcg.c
View File

@ -190,10 +190,6 @@ int mlx4_multicast_attach(struct mlx4_dev *dev, struct mlx4_qp *qp, u8 gid[16])
}
index += dev->caps.num_mgms;
err = mlx4_READ_MCG(dev, index, mailbox);
if (err)
goto out;
memset(mgm, 0, sizeof *mgm);
memcpy(mgm->gid, gid, 16);
}
@ -301,12 +297,10 @@ int mlx4_multicast_detach(struct mlx4_dev *dev, struct mlx4_qp *qp, u8 gid[16])
mgm->qp[loc] = mgm->qp[i - 1];
mgm->qp[i - 1] = 0;
err = mlx4_WRITE_MCG(dev, index, mailbox);
if (err)
goto out;
if (i != 1)
if (i != 1) {
err = mlx4_WRITE_MCG(dev, index, mailbox);
goto out;
}
if (prev == -1) {
/* Remove entry from MGM */