AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-11-25 05:20:49 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

spi: coldfire-qspi: fix error return code in mcfqspi_probe()

Browse Source 
If pdev->dev.platform_data is not set, mcfqspi_probe() will return 0
and release all the resources, in this case, we should return a error
code instead of 0.
This patch fix to return -ENOENT in this case and move the check for
pdev->dev.platform_data to the begin of this function.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
This commit is contained in:
Wei Yongjun 2013-05-16 13:11:32 +08:00 committed by Mark Brown
parent f722406faa
commit 4a577f5275
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/spi/spi-coldfire-qspi.c
View File

@ -408,6 +408,12 @@ static int mcfqspi_probe(struct platform_device *pdev)
struct mcfqspi_platform_data *pdata; struct mcfqspi_platform_data *pdata;
int status; int status;
pdata = pdev->dev.platform_data;
if (!pdata) {
dev_dbg(&pdev->dev, "platform data is missing\n");
return -ENOENT;
}
master = spi_alloc_master(&pdev->dev, sizeof(*mcfqspi)); master = spi_alloc_master(&pdev->dev, sizeof(*mcfqspi));
if (master == NULL) { if (master == NULL) {
dev_dbg(&pdev->dev, "spi_alloc_master failed\n"); dev_dbg(&pdev->dev, "spi_alloc_master failed\n");
@ -458,11 +464,6 @@ static int mcfqspi_probe(struct platform_device *pdev)
} }
clk_enable(mcfqspi->clk); clk_enable(mcfqspi->clk);
pdata = pdev->dev.platform_data;
if (!pdata) {
dev_dbg(&pdev->dev, "platform data is missing\n");
goto fail4;
}
master->bus_num = pdata->bus_num; master->bus_num = pdata->bus_num;
master->num_chipselect = pdata->num_chipselect; master->num_chipselect = pdata->num_chipselect;