From 422efd032775757c41e9579facd9656a87bf4f00 Mon Sep 17 00:00:00 2001 From: Vivien Didelot Date: Wed, 12 Jun 2019 18:33:44 -0400 Subject: [PATCH] net: dsa: mv88e6xxx: do not flood CPU with unknown multicast The DSA ports must flood unknown unicast and multicast, but the switch must not flood the CPU ports with unknown multicast, as this results in a lot of undesirable traffic that the network stack needs to filter in software. Signed-off-by: Vivien Didelot Signed-off-by: David S. Miller --- drivers/net/dsa/mv88e6xxx/chip.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 6691120bd283..9b3d6091d300 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -2058,15 +2058,13 @@ static int mv88e6xxx_setup_message_port(struct mv88e6xxx_chip *chip, int port) static int mv88e6xxx_setup_egress_floods(struct mv88e6xxx_chip *chip, int port) { struct dsa_switch *ds = chip->ds; - bool flood; + bool uc = dsa_is_dsa_port(ds, port) || dsa_is_cpu_port(ds, port); + bool mc = dsa_is_dsa_port(ds, port); - /* Upstream ports flood frames with unknown unicast or multicast DA */ - flood = dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port); - if (chip->info->ops->port_set_egress_floods) - return chip->info->ops->port_set_egress_floods(chip, port, - flood, flood); + if (!chip->info->ops->port_set_egress_floods) + return 0; - return 0; + return chip->info->ops->port_set_egress_floods(chip, port, uc, mc); } static int mv88e6xxx_serdes_power(struct mv88e6xxx_chip *chip, int port,