pinctrl: qcom: fix up errorpath

This fixes up:
commit 464231fb1f
"pinctrl: ssbi-gpio: Be sure to clamp return value"
commit b9164f0493
"gpio: ssbi-mpp: Be sure to clamp return value"
as I managed to screw up some of the logic when clamping
the return values.

Cc: Björn Andersson <bjorn@kryo.se>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Linus Walleij 2016-01-05 10:23:28 +01:00
parent 427e0dc57d
commit 33203f5b94
2 changed files with 4 additions and 4 deletions

View File

@ -487,10 +487,10 @@ static int pm8xxx_gpio_get(struct gpio_chip *chip, unsigned offset)
} else { } else {
ret = irq_get_irqchip_state(pin->irq, IRQCHIP_STATE_LINE_LEVEL, &state); ret = irq_get_irqchip_state(pin->irq, IRQCHIP_STATE_LINE_LEVEL, &state);
if (!ret) if (!ret)
ret = state; ret = !!state;
} }
return !!ret; return ret;
} }
static void pm8xxx_gpio_set(struct gpio_chip *chip, unsigned offset, int value) static void pm8xxx_gpio_set(struct gpio_chip *chip, unsigned offset, int value)

View File

@ -506,9 +506,9 @@ static int pm8xxx_mpp_get(struct gpio_chip *chip, unsigned offset)
ret = irq_get_irqchip_state(pin->irq, IRQCHIP_STATE_LINE_LEVEL, &state); ret = irq_get_irqchip_state(pin->irq, IRQCHIP_STATE_LINE_LEVEL, &state);
if (!ret) if (!ret)
ret = state; ret = !!state;
return !!ret; return ret;
} }
static void pm8xxx_mpp_set(struct gpio_chip *chip, unsigned offset, int value) static void pm8xxx_mpp_set(struct gpio_chip *chip, unsigned offset, int value)