mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-11-25 00:00:52 +07:00
xfrm: unbreak xfrm_sk_policy_lookup
if we succeed grabbing the refcount, then
if (err && !xfrm_pol_hold_rcu)
will evaluate to false so this hits last else branch which then
sets policy to ERR_PTR(0).
Fixes: ae33786f73
("xfrm: policy: only use rcu in xfrm_sk_policy_lookup")
Reported-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Tested-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
This commit is contained in:
parent
7f92083eb5
commit
330e832abd
@ -1268,12 +1268,14 @@ static struct xfrm_policy *xfrm_sk_policy_lookup(const struct sock *sk, int dir,
|
||||
err = security_xfrm_policy_lookup(pol->security,
|
||||
fl->flowi_secid,
|
||||
policy_to_flow_dir(dir));
|
||||
if (!err && !xfrm_pol_hold_rcu(pol))
|
||||
goto again;
|
||||
else if (err == -ESRCH)
|
||||
if (!err) {
|
||||
if (!xfrm_pol_hold_rcu(pol))
|
||||
goto again;
|
||||
} else if (err == -ESRCH) {
|
||||
pol = NULL;
|
||||
else
|
||||
} else {
|
||||
pol = ERR_PTR(err);
|
||||
}
|
||||
} else
|
||||
pol = NULL;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user