mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-11-24 03:40:52 +07:00
fs: Check for invalid i_uid in may_follow_link()
Filesystem uids which don't map into a user namespace may result in inode->i_uid being INVALID_UID. A symlink and its parent could have different owners in the filesystem can both get mapped to INVALID_UID, which may result in following a symlink when this would not have otherwise been permitted when protected symlinks are enabled. Signed-off-by: Seth Forshee <seth.forshee@canonical.com> Acked-by: Serge Hallyn <serge.hallyn@canonical.com> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
This commit is contained in:
parent
0d4d717f25
commit
2d7f9e2ad3
@ -901,6 +901,7 @@ static inline int may_follow_link(struct nameidata *nd)
|
||||
{
|
||||
const struct inode *inode;
|
||||
const struct inode *parent;
|
||||
kuid_t puid;
|
||||
|
||||
if (!sysctl_protected_symlinks)
|
||||
return 0;
|
||||
@ -916,7 +917,8 @@ static inline int may_follow_link(struct nameidata *nd)
|
||||
return 0;
|
||||
|
||||
/* Allowed if parent directory and link owner match. */
|
||||
if (uid_eq(parent->i_uid, inode->i_uid))
|
||||
puid = parent->i_uid;
|
||||
if (uid_valid(puid) && uid_eq(puid, inode->i_uid))
|
||||
return 0;
|
||||
|
||||
if (nd->flags & LOOKUP_RCU)
|
||||
|
Loading…
Reference in New Issue
Block a user