mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-05 11:06:40 +07:00
mmc: vub300: Use common code in __download_offload_pseudocode()
Add a jump target so that a specific string copy operation is stored only once at the end of this function implementation. Replace two calls of the function "strncpy" by goto statements. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
This commit is contained in:
parent
7f8e446b03
commit
2d1d31dda7
@ -1246,12 +1246,8 @@ static void __download_offload_pseudocode(struct vub300_mmc_host *vub300,
|
||||
USB_RECIP_DEVICE, 0x0000, 0x0000,
|
||||
xfer_buffer, xfer_length, HZ);
|
||||
kfree(xfer_buffer);
|
||||
if (retval < 0) {
|
||||
strncpy(vub300->vub_name,
|
||||
"SDIO pseudocode download failed",
|
||||
sizeof(vub300->vub_name));
|
||||
return;
|
||||
}
|
||||
if (retval < 0)
|
||||
goto copy_error_message;
|
||||
} else {
|
||||
dev_err(&vub300->udev->dev,
|
||||
"not enough memory for xfer buffer to send"
|
||||
@ -1293,12 +1289,8 @@ static void __download_offload_pseudocode(struct vub300_mmc_host *vub300,
|
||||
USB_RECIP_DEVICE, 0x0000, 0x0000,
|
||||
xfer_buffer, xfer_length, HZ);
|
||||
kfree(xfer_buffer);
|
||||
if (retval < 0) {
|
||||
strncpy(vub300->vub_name,
|
||||
"SDIO pseudocode download failed",
|
||||
sizeof(vub300->vub_name));
|
||||
return;
|
||||
}
|
||||
if (retval < 0)
|
||||
goto copy_error_message;
|
||||
} else {
|
||||
dev_err(&vub300->udev->dev,
|
||||
"not enough memory for xfer buffer to send"
|
||||
@ -1351,6 +1343,12 @@ static void __download_offload_pseudocode(struct vub300_mmc_host *vub300,
|
||||
sizeof(vub300->vub_name));
|
||||
return;
|
||||
}
|
||||
|
||||
return;
|
||||
|
||||
copy_error_message:
|
||||
strncpy(vub300->vub_name, "SDIO pseudocode download failed",
|
||||
sizeof(vub300->vub_name));
|
||||
}
|
||||
|
||||
/*
|
||||
|
Loading…
Reference in New Issue
Block a user