AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-12-17 02:46:59 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

net: phy: sfp: handle cases where neither BR, min nor BR, max is given

Browse Source 
When computing the bitrate using values read from an SFP module EEPROM,
we use the nominal BR plus BR,min and BR,max to determine the
boundaries. But in some cases BR,min and BR,max aren't provided, which
led the SFP code to end up having the nominal value for both the minimum
and maximum bitrate values. When using a passive cable, the nominal
value should be used as the maximum one, and there is no minimum one
so we should use 0.

Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Antoine Tenart 2018-05-04 17:21:03 +02:00 committed by David S. Miller
parent 8d42eada64
commit 2b999ba899
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/net/phy/sfp-bus.c
View File

@ -132,6 +132,13 @@ void sfp_parse_support(struct sfp_bus *bus, const struct sfp_eeprom_id *id,
br_max = br_nom + br_nom * id->ext.br_min / 100;
br_min = br_nom - br_nom * id->ext.br_min / 100;
}
/* When using passive cables, in case neither BR,min nor BR,max
* are specified, set br_min to 0 as the nominal value is then
* used as the maximum.
*/
if (br_min == br_max && id->base.sfp_ct_passive)
br_min = 0;
}
/* Set ethtool support from the compliance fields. */