AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-11-24 00:10:51 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

vfs: Use sequence counter with associated spinlock

Browse Source 
A sequence counter write side critical section must be protected by some
form of locking to serialize writers. A plain seqcount_t does not
contain the information of which lock must be held when entering a write
side critical section.

Use the new seqcount_spinlock_t data type, which allows to associate a
spinlock with the sequence counter. This enables lockdep to verify that
the spinlock used for writer serialization is held when the write side
critical section is entered.

If lockdep is disabled this lock association is compiled out and has
neither storage size nor runtime overhead.

Signed-off-by: Ahmed S. Darwish <a.darwish@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20200720155530.1173732-19-a.darwish@linutronix.de
This commit is contained in:
Ahmed S. Darwish 2020-07-20 17:55:24 +02:00 committed by Peter Zijlstra
parent 025e82bcbc
commit 2647537197
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/dcache.c
View File

@ -1746,7 +1746,7 @@ static struct dentry *__d_alloc(struct super_block *sb, const struct qstr *name)
dentry->d_lockref.count = 1; dentry->d_lockref.count = 1;
dentry->d_flags = 0; dentry->d_flags = 0;
spin_lock_init(&dentry->d_lock); spin_lock_init(&dentry->d_lock);
seqcount_init(&dentry->d_seq); seqcount_spinlock_init(&dentry->d_seq, &dentry->d_lock);
dentry->d_inode = NULL; dentry->d_inode = NULL;
dentry->d_parent = dentry; dentry->d_parent = dentry;
dentry->d_sb = sb; dentry->d_sb = sb;

4
fs/fs_struct.c
View File

@ -117,7 +117,7 @@ struct fs_struct *copy_fs_struct(struct fs_struct *old)
fs->users = 1; fs->users = 1;
fs->in_exec = 0; fs->in_exec = 0;
spin_lock_init(&fs->lock); spin_lock_init(&fs->lock);
seqcount_init(&fs->seq); seqcount_spinlock_init(&fs->seq, &fs->lock);
fs->umask = old->umask; fs->umask = old->umask;
spin_lock(&old->lock); spin_lock(&old->lock);
@ -163,6 +163,6 @@ EXPORT_SYMBOL(current_umask);
struct fs_struct init_fs = { struct fs_struct init_fs = {
.users = 1, .users = 1,
.lock = __SPIN_LOCK_UNLOCKED(init_fs.lock), .lock = __SPIN_LOCK_UNLOCKED(init_fs.lock),
.seq = SEQCNT_ZERO(init_fs.seq), .seq = SEQCNT_SPINLOCK_ZERO(init_fs.seq, &init_fs.lock),
.umask = 0022, .umask = 0022,
}; };

2
include/linux/dcache.h
View File

@ -89,7 +89,7 @@ extern struct dentry_stat_t dentry_stat;
struct dentry { struct dentry {
/* RCU lookup touched fields */ /* RCU lookup touched fields */
unsigned int d_flags; /* protected by d_lock */ unsigned int d_flags; /* protected by d_lock */
seqcount_t d_seq; /* per dentry seqlock */ seqcount_spinlock_t d_seq; /* per dentry seqlock */
struct hlist_bl_node d_hash; /* lookup hash list */ struct hlist_bl_node d_hash; /* lookup hash list */
struct dentry *d_parent; /* parent directory */ struct dentry *d_parent; /* parent directory */
struct qstr d_name; struct qstr d_name;

2
include/linux/fs_struct.h
View File

@ -9,7 +9,7 @@
struct fs_struct { struct fs_struct {
int users; int users;
spinlock_t lock; spinlock_t lock;
seqcount_t seq; seqcount_spinlock_t seq;
int umask; int umask;
int in_exec; int in_exec;
struct path root, pwd; struct path root, pwd;