AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-11-24 22:40:53 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

rlimit: Rewrite non-sensical RLIMIT_CPU comment

Browse Source 
The comment above the function which arms RLIMIT_CPU in the posix CPU timer
code makes no sense at all. It claims that the kernel does not return an
error code when it rejected the attempt to set RLIMIT_CPU. That's clearly
bogus as the code does an error check and the rlimit is only set and
activated when the permission checks are ok. In case of a rejection an
appropriate error code is returned.

This is a historical and outdated comment which got dragged along even when
the rlimit handling code was rewritten.

Replace it with an explanation why the setup function is not called when
the rlimit value is RLIM_INFINITY and how the 'disarming' is handled.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Link: https://lkml.kernel.org/r/20190821192922.185511287@linutronix.de
This commit is contained in:
Thomas Gleixner 2019-08-21 21:09:18 +02:00
parent fe0517f893
commit 24db4dd90d
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
kernel/sys.c
View File

@ -1576,10 +1576,9 @@ int do_prlimit(struct task_struct *tsk, unsigned int resource,
task_unlock(tsk->group_leader); task_unlock(tsk->group_leader);
/* /*
* RLIMIT_CPU handling. Note that the kernel fails to return an error * RLIMIT_CPU handling. Arm the posix CPU timer if the limit is not
* code if it rejected the user's attempt to set RLIMIT_CPU. This is a * infite. In case of RLIM_INFINITY the posix CPU timer code
* very long-standing error, and fixing it now risks breakage of * ignores the rlimit.
* applications, so we live with it
*/ */
if (!retval && new_rlim && resource == RLIMIT_CPU && if (!retval && new_rlim && resource == RLIMIT_CPU &&
new_rlim->rlim_cur != RLIM_INFINITY && new_rlim->rlim_cur != RLIM_INFINITY &&