AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-12-26 06:05:03 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

arptables: use match, target and data copy_to_user helpers

Browse Source 
Convert arptables to copying entries, matches and targets one by one,
using the xt_match_to_user and xt_target_to_user helper functions.

Signed-off-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
This commit is contained in:
Willem de Bruijn 2017-01-02 17:19:43 -05:00 committed by Pablo Neira Ayuso
parent e47ddb2c46
commit 244b531bee
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
net/ipv4/netfilter/arp_tables.c
View File

@ -677,11 +677,6 @@ static int copy_entries_to_user(unsigned int total_size,
return PTR_ERR(counters); return PTR_ERR(counters);
loc_cpu_entry = private->entries; loc_cpu_entry = private->entries;
/* ... then copy entire thing ... */
if (copy_to_user(userptr, loc_cpu_entry, total_size) != 0) {
ret = -EFAULT;
goto free_counters;
}
/* FIXME: use iterator macros --RR */ /* FIXME: use iterator macros --RR */
/* ... then go back and fix counters and names */ /* ... then go back and fix counters and names */
@ -689,6 +684,10 @@ static int copy_entries_to_user(unsigned int total_size,
const struct xt_entry_target *t; const struct xt_entry_target *t;
e = (struct arpt_entry *)(loc_cpu_entry + off); e = (struct arpt_entry *)(loc_cpu_entry + off);
if (copy_to_user(userptr + off, e, sizeof(*e))) {
ret = -EFAULT;
goto free_counters;
}
if (copy_to_user(userptr + off if (copy_to_user(userptr + off
+ offsetof(struct arpt_entry, counters), + offsetof(struct arpt_entry, counters),
&counters[num], &counters[num],
@ -698,11 +697,7 @@ static int copy_entries_to_user(unsigned int total_size,
} }
t = arpt_get_target_c(e); t = arpt_get_target_c(e);
if (copy_to_user(userptr + off + e->target_offset if (xt_target_to_user(t, userptr + off + e->target_offset)) {
+ offsetof(struct xt_entry_target,
u.user.name),
t->u.kernel.target->name,
strlen(t->u.kernel.target->name)+1) != 0) {
ret = -EFAULT; ret = -EFAULT;
goto free_counters; goto free_counters;
} }