staging: comedi: pcl816: use comedi_request_region()

Use comedi_request_region() to request the I/O region used by this
driver.

Remove the noise when the board is first attached as well as the
error message when the request_region() fails, comedi_request_reqion()
will output the error message if necessary.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2013-04-09 16:10:53 -07:00 committed by Greg Kroah-Hartman
parent 92e5c90dcc
commit 22b580f07e

View File

@ -981,25 +981,16 @@ static int pcl816_attach(struct comedi_device *dev, struct comedi_devconfig *it)
const struct pcl816_board *board = comedi_board(dev); const struct pcl816_board *board = comedi_board(dev);
struct pcl816_private *devpriv; struct pcl816_private *devpriv;
int ret; int ret;
unsigned long iobase;
unsigned int irq, dma; unsigned int irq, dma;
unsigned long pages; unsigned long pages;
/* int i; */ /* int i; */
struct comedi_subdevice *s; struct comedi_subdevice *s;
/* claim our I/O space */ ret = comedi_request_region(dev, it->options[0], board->io_range);
iobase = it->options[0]; if (ret)
printk("comedi%d: pcl816: board=%s, ioport=0x%03lx", dev->minor, return ret;
board->name, iobase);
if (!request_region(iobase, board->io_range, dev->board_name)) { if (pcl816_check(dev->iobase)) {
printk("I/O port conflict\n");
return -EIO;
}
dev->iobase = iobase;
if (pcl816_check(iobase)) {
printk(KERN_ERR ", I cann't detect board. FAIL!\n"); printk(KERN_ERR ", I cann't detect board. FAIL!\n");
return -EIO; return -EIO;
} }