AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-11-26 00:40:55 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

dsa: factor freeing of dsa_platform_data

Browse Source 
This patch factors the freeing of the struct dsa_platform_data
manipulated by the driver identically in two places to a single
function.

Signed-off-by: Florian Fainelli <florian@openwrt.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Florian Fainelli 2013-03-25 05:03:39 +00:00 committed by David S. Miller
parent 4c64f1f70c
commit 2116824503
1 changed files with 18 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
net/dsa/dsa.c
View File

@ -343,6 +343,21 @@ static int dsa_of_setup_routing_table(struct dsa_platform_data *pd,
return ret; return ret;
} }
static void dsa_of_free_platform_data(struct dsa_platform_data *pd)
{
int i;
int port_index;
for (i = 0; i < pd->nr_chips; i++) {
port_index = 0;
while (pd->chip[i].port_names &&
pd->chip[i].port_names[++port_index])
kfree(pd->chip[i].port_names[port_index]);
kfree(pd->chip[i].rtable);
}
kfree(pd->chip);
}
static int dsa_of_probe(struct platform_device *pdev) static int dsa_of_probe(struct platform_device *pdev)
{ {
struct device_node *np = pdev->dev.of_node; struct device_node *np = pdev->dev.of_node;
@ -354,7 +369,7 @@ static int dsa_of_probe(struct platform_device *pdev)
const char *port_name; const char *port_name;
int chip_index, port_index; int chip_index, port_index;
const unsigned int *sw_addr, *port_reg; const unsigned int *sw_addr, *port_reg;
int ret, i; int ret;
mdio = of_parse_phandle(np, "dsa,mii-bus", 0); mdio = of_parse_phandle(np, "dsa,mii-bus", 0);
if (!mdio) if (!mdio)
@ -439,14 +454,7 @@ static int dsa_of_probe(struct platform_device *pdev)
return 0; return 0;
out_free_chip: out_free_chip:
for (i = 0; i < pd->nr_chips; i++) { dsa_of_free_platform_data(pd);
port_index = 0;
while (pd->chip[i].port_names &&
pd->chip[i].port_names[++port_index])
kfree(pd->chip[i].port_names[port_index]);
kfree(pd->chip[i].rtable);
}
kfree(pd->chip);
out_free: out_free:
kfree(pd); kfree(pd);
pdev->dev.platform_data = NULL; pdev->dev.platform_data = NULL;
@ -456,21 +464,11 @@ static int dsa_of_probe(struct platform_device *pdev)
static void dsa_of_remove(struct platform_device *pdev) static void dsa_of_remove(struct platform_device *pdev)
{ {
struct dsa_platform_data *pd = pdev->dev.platform_data; struct dsa_platform_data *pd = pdev->dev.platform_data;
int i;
int port_index;
if (!pdev->dev.of_node) if (!pdev->dev.of_node)
return; return;
for (i = 0; i < pd->nr_chips; i++) { dsa_of_free_platform_data(pd);
port_index = 0;
while (pd->chip[i].port_names &&
pd->chip[i].port_names[++port_index])
kfree(pd->chip[i].port_names[port_index]);
kfree(pd->chip[i].rtable);
}
kfree(pd->chip);
kfree(pd); kfree(pd);
} }
#else #else