AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2025-04-05 21:58:11 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

kernel/smp.c: use '|=' for csd_lock

Browse Source 
csd_lock() uses assignment to data->flags rather than |=.  That is not
buggy at present because only one bit (CSD_FLAG_LOCK) is defined in
call_single_data.flags.

But it will become buggy if we later add another flag, so fix it now.

Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
liguang 2013-04-30 15:27:25 -07:00 committed by Linus Torvalds
parent ef3b101925
commit 1def1dc917
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
kernel/smp.c
View File

@ -109,7 +109,7 @@ static void csd_lock_wait(struct call_single_data *data)
static void csd_lock(struct call_single_data *data) static void csd_lock(struct call_single_data *data)
{ {
csd_lock_wait(data); csd_lock_wait(data);
data->flags = CSD_FLAG_LOCK; data->flags |= CSD_FLAG_LOCK;
/* /*
* prevent CPU from reordering the above assignment * prevent CPU from reordering the above assignment