drm/amdkfd: fix ref count leak when pm_runtime_get_sync fails

The call to pm_runtime_get_sync increments the counter even in case of
failure, leading to incorrect ref count.
In case of failure, decrement the ref count before returning.

Reviewed-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Alex Deucher 2020-06-17 14:52:07 -04:00
parent e520d3e0d2
commit 1c1ada37af

View File

@ -1116,9 +1116,11 @@ struct kfd_process_device *kfd_bind_process_to_device(struct kfd_dev *dev,
*/ */
if (!pdd->runtime_inuse) { if (!pdd->runtime_inuse) {
err = pm_runtime_get_sync(dev->ddev->dev); err = pm_runtime_get_sync(dev->ddev->dev);
if (err < 0) if (err < 0) {
pm_runtime_put_autosuspend(dev->ddev->dev);
return ERR_PTR(err); return ERR_PTR(err);
} }
}
err = kfd_iommu_bind_process_to_device(pdd); err = kfd_iommu_bind_process_to_device(pdd);
if (err) if (err)