AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-11-25 17:40:54 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

Silence a few warnings in auxdisplay.

Browse Source 
- A couple of uninitialized warnings reported by the build service.
 
   - A doc comment warning under W=1.
 
   - Three fall through comments not recognized under W=1.
 -----BEGIN PGP SIGNATURE-----
 
 iQIcBAABCgAGBQJaqBPYAAoJEBl8i3NobSFtdEYP/3z6LEp5TEh0NSu3k+/qkwMJ
 bOJahu8nE0dPrnR63i6XP2LrJVt+7fzTWlGBpEaoUjLCFjeOYlYaW1mqw28ebr+z
 hZK4k+vlXBvOJ6LwA3qx45cPokSkNRalqXSYb7A63NL5dp7lLqOQFh+MR//g0KYX
 pvABUvBn9HBpqzGCWlouMLVyX7uRZd0A8ZS+H2dIyvXC214C7IW2LH2afBrfp/Od
 q+AuFhxEV51smTuvXw9mtQThFuiJIrbPR53lA7UkKR2r5+PjLL8PS+UBaXOyUtNc
 4yRp00FhaiHXY9RTQIhw10pRmB6hVjGfFuv3OW/3ZL4IjHpfjuz+MS0RKhigp+zm
 4+l8BxJ2chuNmqH2W6J9J/HD3mweWBb7EwvkQDE8dtziUQ0lGFDF3v/6hzt/Ti+s
 BGRUqeYJZQSRpd1BlZWKen2lndI4KVv6sTIDfvqIQzCgAPA6a3Ot2CKT3Frtce6Z
 ILHRhJv1eZHKQ5bGzGgnFyGsSt8IRF8eZeAUq7nJV0OVBh+zPMAdzjguMBJ0GIwj
 lHNmE88WeIcnwZDcv5Hs4Ym4Rz1RRaw5H5RAc9qnfvkDq9Ki5TjtZvq5JsxPjmoR
 pfCLMtZLbS7dQrpOBn1zUlqFgTAjPvxb1RY3OFZuQIcmMsVMTAOErV3z9xl4lM65
 4pzb7NMkAlC3OdGyCIkA
 =guYj
 -----END PGP SIGNATURE-----

Merge tag 'auxdisplay-for-linus-v4.16-rc6' of git://github.com/ojeda/linux

Pull auxdisplay fixes from Miguel Ojeda:
 "Silence a few warnings in auxdisplay.

   - a couple of uninitialized warnings reported by the build service

   - a doc comment warning under W=1

   - three fall-through comments not recognized under W=1"

* tag 'auxdisplay-for-linus-v4.16-rc6' of git://github.com/ojeda/linux:
  auxdisplay: img-ascii-lcd: Silence 2 uninitialized warnings
  auxdisplay: img-ascii-lcd: Fix doc comment to silence warnings
  auxdisplay: panel: Change comments to silence fallthrough warnings
This commit is contained in:
Linus Torvalds 2018-03-14 09:46:14 -07:00
commit 1a7f74968d
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/auxdisplay/img-ascii-lcd.c
View File

@ -97,7 +97,7 @@ static struct img_ascii_lcd_config boston_config = {
static void malta_update(struct img_ascii_lcd_ctx *ctx) static void malta_update(struct img_ascii_lcd_ctx *ctx)
{ {
unsigned int i; unsigned int i;
int err; int err = 0;
for (i = 0; i < ctx->cfg->num_chars; i++) { for (i = 0; i < ctx->cfg->num_chars; i++) {
err = regmap_write(ctx->regmap, err = regmap_write(ctx->regmap,
@ -180,7 +180,7 @@ static int sead3_wait_lcd_idle(struct img_ascii_lcd_ctx *ctx)
static void sead3_update(struct img_ascii_lcd_ctx *ctx) static void sead3_update(struct img_ascii_lcd_ctx *ctx)
{ {
unsigned int i; unsigned int i;
int err; int err = 0;
for (i = 0; i < ctx->cfg->num_chars; i++) { for (i = 0; i < ctx->cfg->num_chars; i++) {
err = sead3_wait_lcd_idle(ctx); err = sead3_wait_lcd_idle(ctx);
@ -224,7 +224,7 @@ MODULE_DEVICE_TABLE(of, img_ascii_lcd_matches);
/** /**
* img_ascii_lcd_scroll() - scroll the display by a character * img_ascii_lcd_scroll() - scroll the display by a character
* @arg: really a pointer to the private data structure * @t: really a pointer to the private data structure
* *
* Scroll the current message along the LCD by one character, rearming the * Scroll the current message along the LCD by one character, rearming the
* timer if required. * timer if required.

6
drivers/auxdisplay/panel.c
View File

@ -1372,7 +1372,7 @@ static void panel_process_inputs(void)
break; break;
input->rise_timer = 0; input->rise_timer = 0;
input->state = INPUT_ST_RISING; input->state = INPUT_ST_RISING;
/* no break here, fall through */ /* fall through */
case INPUT_ST_RISING: case INPUT_ST_RISING:
if ((phys_curr & input->mask) != input->value) { if ((phys_curr & input->mask) != input->value) {
input->state = INPUT_ST_LOW; input->state = INPUT_ST_LOW;
@ -1385,11 +1385,11 @@ static void panel_process_inputs(void)
} }
input->high_timer = 0; input->high_timer = 0;
input->state = INPUT_ST_HIGH; input->state = INPUT_ST_HIGH;
/* no break here, fall through */ /* fall through */
case INPUT_ST_HIGH: case INPUT_ST_HIGH:
if (input_state_high(input)) if (input_state_high(input))
break; break;
/* no break here, fall through */ /* fall through */
case INPUT_ST_FALLING: case INPUT_ST_FALLING:
input_state_falling(input); input_state_falling(input);
} }