mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-11-24 01:30:55 +07:00
opp: Call the missing clk_put() on error
commit 0e1d9ca1766f5d95fb881f57b6c4a1ffa63d4648 upstream.
Fix the clock reference counting by calling the missing clk_put() in the
error path.
Cc: v5.10 <stable@vger.kernel.org> # v5.10
Fixes: dd461cd918
("opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER")
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
e8322837a2
commit
1a58c171a5
@ -1111,7 +1111,7 @@ static struct opp_table *_allocate_opp_table(struct device *dev, int index)
|
|||||||
ret = dev_pm_opp_of_find_icc_paths(dev, opp_table);
|
ret = dev_pm_opp_of_find_icc_paths(dev, opp_table);
|
||||||
if (ret) {
|
if (ret) {
|
||||||
if (ret == -EPROBE_DEFER)
|
if (ret == -EPROBE_DEFER)
|
||||||
goto remove_opp_dev;
|
goto put_clk;
|
||||||
|
|
||||||
dev_warn(dev, "%s: Error finding interconnect paths: %d\n",
|
dev_warn(dev, "%s: Error finding interconnect paths: %d\n",
|
||||||
__func__, ret);
|
__func__, ret);
|
||||||
@ -1125,6 +1125,9 @@ static struct opp_table *_allocate_opp_table(struct device *dev, int index)
|
|||||||
list_add(&opp_table->node, &opp_tables);
|
list_add(&opp_table->node, &opp_tables);
|
||||||
return opp_table;
|
return opp_table;
|
||||||
|
|
||||||
|
put_clk:
|
||||||
|
if (!IS_ERR(opp_table->clk))
|
||||||
|
clk_put(opp_table->clk);
|
||||||
remove_opp_dev:
|
remove_opp_dev:
|
||||||
_remove_opp_dev(opp_dev, opp_table);
|
_remove_opp_dev(opp_dev, opp_table);
|
||||||
err:
|
err:
|
||||||
|
Loading…
Reference in New Issue
Block a user