AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2025-01-22 08:34:55 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

net: phylink: ensure link is down when changing interface

Browse Source 
The only PHYs that are used with phylink which change their interface
are the BCM84881 and MV88X3310 family, both of which only change their
interface modes on link-up events.  However, rather than relying upon
this behaviour by the PHY, we should give a stronger guarantee when
resolving that the link will be down whenever we change the interface
mode.  This patch implements that stronger guarantee for resolve.

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Russell King 2020-07-21 12:04:00 +01:00 committed by David S. Miller
parent 319bfafe34
commit 16319a7d31
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/net/phy/phylink.c
View File

@ -620,8 +620,18 @@ static void phylink_resolve(struct work_struct *w)
}
}
if (mac_config)
if (mac_config) {
if (link_state.interface != pl->link_config.interface) {
/* The interface has changed, force the link down and
* then reconfigure.
*/
if (cur_link_state) {
phylink_link_down(pl);
cur_link_state = false;
}
}
phylink_mac_config(pl, &link_state);
}
if (link_state.link != cur_link_state) {
pl->old_link_state = link_state.link;