ARM: dts: lpc32xx: ea3250: beautify gpio keys children nodes

Regarding the 'gpio_keys' device node a dtc reports a couple of
warnings:

  Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary
  #address-cells/#size-cells without "ranges" or child "reg" property

  Warning (unit_address_vs_reg): /gpio_keys/button@21: node has
  a unit name, but no reg property

The change fixes these issues and adds empty lines between adjacent
children device nodes. The device node itself is renamed by substituting
an underscore by hyphen to follow the standard naming convention
of device tree nodes.

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
This commit is contained in:
Vladimir Zapolskiy 2019-01-29 21:20:47 +02:00
parent ec54b138b1
commit 0293adf76a

View File

@ -23,56 +23,64 @@ memory@80000000 {
reg = <0x80000000 0x4000000>; reg = <0x80000000 0x4000000>;
}; };
gpio_keys { gpio-keys {
compatible = "gpio-keys"; compatible = "gpio-keys";
#address-cells = <1>;
#size-cells = <0>;
autorepeat; autorepeat;
button@21 {
button {
label = "Interrupt Key"; label = "Interrupt Key";
linux,code = <103>; linux,code = <103>;
gpios = <&gpio 4 1 0>; /* GPI_P3 1 */ gpios = <&gpio 4 1 0>; /* GPI_P3 1 */
}; };
key1 { key1 {
label = "KEY1"; label = "KEY1";
linux,code = <1>; linux,code = <1>;
gpios = <&pca9532 0 0>; gpios = <&pca9532 0 0>;
}; };
key2 { key2 {
label = "KEY2"; label = "KEY2";
linux,code = <2>; linux,code = <2>;
gpios = <&pca9532 1 0>; gpios = <&pca9532 1 0>;
}; };
key3 { key3 {
label = "KEY3"; label = "KEY3";
linux,code = <3>; linux,code = <3>;
gpios = <&pca9532 2 0>; gpios = <&pca9532 2 0>;
}; };
key4 { key4 {
label = "KEY4"; label = "KEY4";
linux,code = <4>; linux,code = <4>;
gpios = <&pca9532 3 0>; gpios = <&pca9532 3 0>;
}; };
joy0 { joy0 {
label = "Joystick Key 0"; label = "Joystick Key 0";
linux,code = <10>; linux,code = <10>;
gpios = <&gpio 2 0 0>; /* P2.0 */ gpios = <&gpio 2 0 0>; /* P2.0 */
}; };
joy1 { joy1 {
label = "Joystick Key 1"; label = "Joystick Key 1";
linux,code = <11>; linux,code = <11>;
gpios = <&gpio 2 1 0>; /* P2.1 */ gpios = <&gpio 2 1 0>; /* P2.1 */
}; };
joy2 { joy2 {
label = "Joystick Key 2"; label = "Joystick Key 2";
linux,code = <12>; linux,code = <12>;
gpios = <&gpio 2 2 0>; /* P2.2 */ gpios = <&gpio 2 2 0>; /* P2.2 */
}; };
joy3 { joy3 {
label = "Joystick Key 3"; label = "Joystick Key 3";
linux,code = <13>; linux,code = <13>;
gpios = <&gpio 2 3 0>; /* P2.3 */ gpios = <&gpio 2 3 0>; /* P2.3 */
}; };
joy4 { joy4 {
label = "Joystick Key 4"; label = "Joystick Key 4";
linux,code = <14>; linux,code = <14>;