2019-05-09 08:00:19 +07:00
|
|
|
# SPDX-License-Identifier: GPL-2.0
|
2007-10-19 13:41:08 +07:00
|
|
|
# Makefile for Linux samples code
|
|
|
|
|
2020-04-29 10:45:25 +07:00
|
|
|
subdir-$(CONFIG_SAMPLE_AUXDISPLAY) += auxdisplay
|
samples: binderfs: really compile this sample and fix build issues
Even after commit c624adc9cb6e ("samples: fix binderfs sample"), this
sample is never compiled.
'hostprogs' teaches Kbuild that this is a host program, but not enough
to order to compile it. You must add it to 'always-y' to really compile
it.
Since this sample has never been compiled in upstream, various issues
are left unnoticed.
[1] compilers without <linux/android/binderfs.h> are still widely used
<linux/android/binderfs.h> is only available since commit c13295ad219d
("binderfs: rename header to binderfs.h"), i.e., Linux 5.0
If your compiler is based on UAPI headers older than Linux 5.0, you
will see the following error:
samples/binderfs/binderfs_example.c:16:10: fatal error: linux/android/binderfs.h: No such file or directory
#include <linux/android/binderfs.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
You cannot rely on compilers having such a new header.
The common approach is to install UAPI headers of this kernel into
usr/include, and then add it to the header search path.
I added 'depends on HEADERS_INSTALL' in Kconfig, and '-I usr/include'
compiler flag in Makefile.
[2] compile the sample for target architecture
Because headers_install works for the target architecture, only the
native compiler was able to build sample code that requires
'-I usr/include'.
Commit 7f3a59db274c ("kbuild: add infrastructure to build userspace
programs") added the new syntax 'userprogs' to compile user-space
programs for the target architecture.
Use it, and then 'ifndef CROSS_COMPILE' will go away.
I added 'depends on CC_CAN_LINK' because $(CC) is not necessarily
capable of linking user-space programs.
[3] use subdir-y to descend into samples/binderfs
Since this directory does not contain any kernel-space code, it has no
point in generating built-in.a or modules.order.
Replace obj-$(CONFIG_...) with subdir-$(CONFIG_...).
[4] -Wunused-variable warning
If I compile this, I see the following warning.
samples/binderfs/binderfs_example.c: In function 'main':
samples/binderfs/binderfs_example.c:21:9: warning: unused variable 'len' [-Wunused-variable]
21 | size_t len;
| ^~~
I removed the unused 'len'.
[5] CONFIG_ANDROID_BINDERFS is not required
Since this is a user-space standalone program, it is independent of
the kernel configuration.
Remove 'depends on ANDROID_BINDERFS'.
Fixes: 9762dc1432e1 ("samples: add binderfs sample program")
Fixes: c624adc9cb6e ("samples: fix binderfs sample")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-06-07 10:20:53 +07:00
|
|
|
subdir-$(CONFIG_SAMPLE_ANDROID_BINDERFS) += binderfs
|
2019-05-09 08:00:19 +07:00
|
|
|
obj-$(CONFIG_SAMPLE_CONFIGFS) += configfs/
|
|
|
|
obj-$(CONFIG_SAMPLE_CONNECTOR) += connector/
|
2019-06-04 17:13:59 +07:00
|
|
|
subdir-$(CONFIG_SAMPLE_HIDRAW) += hidraw
|
2019-05-09 08:00:19 +07:00
|
|
|
obj-$(CONFIG_SAMPLE_HW_BREAKPOINT) += hw_breakpoint/
|
|
|
|
obj-$(CONFIG_SAMPLE_KDB) += kdb/
|
|
|
|
obj-$(CONFIG_SAMPLE_KFIFO) += kfifo/
|
|
|
|
obj-$(CONFIG_SAMPLE_KOBJECT) += kobject/
|
|
|
|
obj-$(CONFIG_SAMPLE_KPROBES) += kprobes/
|
|
|
|
obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch/
|
2019-06-04 17:13:59 +07:00
|
|
|
subdir-$(CONFIG_SAMPLE_PIDFD) += pidfd
|
2019-05-09 08:00:19 +07:00
|
|
|
obj-$(CONFIG_SAMPLE_QMI_CLIENT) += qmi/
|
|
|
|
obj-$(CONFIG_SAMPLE_RPMSG_CLIENT) += rpmsg/
|
|
|
|
subdir-$(CONFIG_SAMPLE_SECCOMP) += seccomp
|
2020-04-29 10:45:26 +07:00
|
|
|
subdir-$(CONFIG_SAMPLE_TIMER) += timers
|
2019-05-09 08:00:19 +07:00
|
|
|
obj-$(CONFIG_SAMPLE_TRACE_EVENTS) += trace_events/
|
|
|
|
obj-$(CONFIG_SAMPLE_TRACE_PRINTK) += trace_printk/
|
2019-11-09 01:12:33 +07:00
|
|
|
obj-$(CONFIG_SAMPLE_FTRACE_DIRECT) += ftrace/
|
2019-11-21 02:08:39 +07:00
|
|
|
obj-$(CONFIG_SAMPLE_TRACE_ARRAY) += ftrace/
|
2020-04-29 10:45:19 +07:00
|
|
|
subdir-$(CONFIG_SAMPLE_UHID) += uhid
|
2019-05-09 08:00:19 +07:00
|
|
|
obj-$(CONFIG_VIDEO_PCI_SKELETON) += v4l/
|
|
|
|
obj-y += vfio-mdev/
|
|
|
|
subdir-$(CONFIG_SAMPLE_VFS) += vfs
|
2019-10-10 20:27:10 +07:00
|
|
|
obj-$(CONFIG_SAMPLE_INTEL_MEI) += mei/
|
2020-04-29 10:45:27 +07:00
|
|
|
subdir-$(CONFIG_SAMPLE_WATCHDOG) += watchdog
|
2020-01-15 00:07:11 +07:00
|
|
|
subdir-$(CONFIG_SAMPLE_WATCH_QUEUE) += watch_queue
|