License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 21:07:57 +07:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
2006-10-11 15:20:50 +07:00
|
|
|
/*
|
2006-10-11 15:20:53 +07:00
|
|
|
* linux/fs/ext4/fsync.c
|
2006-10-11 15:20:50 +07:00
|
|
|
*
|
|
|
|
* Copyright (C) 1993 Stephen Tweedie (sct@redhat.com)
|
|
|
|
* from
|
|
|
|
* Copyright (C) 1992 Remy Card (card@masi.ibp.fr)
|
|
|
|
* Laboratoire MASI - Institut Blaise Pascal
|
|
|
|
* Universite Pierre et Marie Curie (Paris VI)
|
|
|
|
* from
|
|
|
|
* linux/fs/minix/truncate.c Copyright (C) 1991, 1992 Linus Torvalds
|
|
|
|
*
|
2006-10-11 15:20:53 +07:00
|
|
|
* ext4fs fsync primitive
|
2006-10-11 15:20:50 +07:00
|
|
|
*
|
|
|
|
* Big-endian to little-endian byte-swapping/bitmaps by
|
|
|
|
* David S. Miller (davem@caip.rutgers.edu), 1995
|
|
|
|
*
|
|
|
|
* Removed unnecessary code duplication for little endian machines
|
|
|
|
* and excessive __inline__s.
|
|
|
|
* Andi Kleen, 1997
|
|
|
|
*
|
|
|
|
* Major simplications and cleanup - we only need to do the metadata, because
|
|
|
|
* we can depend on generic_block_fdatasync() to sync the data blocks.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/time.h>
|
|
|
|
#include <linux/fs.h>
|
|
|
|
#include <linux/sched.h>
|
|
|
|
#include <linux/writeback.h>
|
2008-07-12 06:27:31 +07:00
|
|
|
#include <linux/blkdev.h>
|
2009-06-17 22:48:11 +07:00
|
|
|
|
2008-04-30 05:13:32 +07:00
|
|
|
#include "ext4.h"
|
|
|
|
#include "ext4_jbd2.h"
|
2006-10-11 15:20:50 +07:00
|
|
|
|
2009-06-17 22:48:11 +07:00
|
|
|
#include <trace/events/ext4.h>
|
|
|
|
|
2010-05-17 19:00:00 +07:00
|
|
|
/*
|
|
|
|
* If we're not journaling and this is a just-created file, we have to
|
|
|
|
* sync our parent directory (if it was freshly created) since
|
|
|
|
* otherwise it will only be written by writeback, leaving a huge
|
|
|
|
* window during which a crash may lose the file. This may apply for
|
|
|
|
* the parent directory's parent as well, and so on recursively, if
|
|
|
|
* they are also freshly created.
|
|
|
|
*/
|
ext4: sync the directory inode in ext4_sync_parent()
ext4 has taken the stance that, in the absence of a journal,
when an fsync/fdatasync of an inode is done, the parent
directory should be sync'ed if this inode entry is new.
ext4_sync_parent(), which implements this, does indeed sync
the dirent pages for parent directories, but it does not
sync the directory *inode*. This patch fixes this.
Also now return error status from ext4_sync_parent().
I tested this using a power fail test, which panics a
machine running a file server getting requests from a
client. Without this patch, on about every other test run,
the server is missing many, many files that had been synced.
With this patch, on > 6 runs, I see zero files being lost.
Google-Bug-Id: 4179519
Signed-off-by: Curt Wohlgemuth <curtw@google.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2011-04-11 09:05:31 +07:00
|
|
|
static int ext4_sync_parent(struct inode *inode)
|
2010-05-17 19:00:00 +07:00
|
|
|
{
|
|
|
|
struct dentry *dentry = NULL;
|
2011-07-30 23:34:19 +07:00
|
|
|
struct inode *next;
|
ext4: sync the directory inode in ext4_sync_parent()
ext4 has taken the stance that, in the absence of a journal,
when an fsync/fdatasync of an inode is done, the parent
directory should be sync'ed if this inode entry is new.
ext4_sync_parent(), which implements this, does indeed sync
the dirent pages for parent directories, but it does not
sync the directory *inode*. This patch fixes this.
Also now return error status from ext4_sync_parent().
I tested this using a power fail test, which panics a
machine running a file server getting requests from a
client. Without this patch, on about every other test run,
the server is missing many, many files that had been synced.
With this patch, on > 6 runs, I see zero files being lost.
Google-Bug-Id: 4179519
Signed-off-by: Curt Wohlgemuth <curtw@google.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2011-04-11 09:05:31 +07:00
|
|
|
int ret = 0;
|
2010-05-17 19:00:00 +07:00
|
|
|
|
2011-07-30 23:34:19 +07:00
|
|
|
if (!ext4_test_inode_state(inode, EXT4_STATE_NEWENTRY))
|
|
|
|
return 0;
|
|
|
|
inode = igrab(inode);
|
|
|
|
while (ext4_test_inode_state(inode, EXT4_STATE_NEWENTRY)) {
|
2010-05-17 19:00:00 +07:00
|
|
|
ext4_clear_inode_state(inode, EXT4_STATE_NEWENTRY);
|
2012-06-10 00:19:12 +07:00
|
|
|
dentry = d_find_any_alias(inode);
|
2011-07-30 23:34:19 +07:00
|
|
|
if (!dentry)
|
2010-05-17 19:00:00 +07:00
|
|
|
break;
|
2015-03-18 05:25:59 +07:00
|
|
|
next = igrab(d_inode(dentry->d_parent));
|
2011-07-30 23:34:19 +07:00
|
|
|
dput(dentry);
|
|
|
|
if (!next)
|
|
|
|
break;
|
|
|
|
iput(inode);
|
|
|
|
inode = next;
|
2016-09-06 10:21:43 +07:00
|
|
|
/*
|
|
|
|
* The directory inode may have gone through rmdir by now. But
|
|
|
|
* the inode itself and its blocks are still allocated (we hold
|
|
|
|
* a reference to the inode so it didn't go through
|
|
|
|
* ext4_evict_inode()) and so we are safe to flush metadata
|
|
|
|
* blocks and the inode.
|
|
|
|
*/
|
ext4: sync the directory inode in ext4_sync_parent()
ext4 has taken the stance that, in the absence of a journal,
when an fsync/fdatasync of an inode is done, the parent
directory should be sync'ed if this inode entry is new.
ext4_sync_parent(), which implements this, does indeed sync
the dirent pages for parent directories, but it does not
sync the directory *inode*. This patch fixes this.
Also now return error status from ext4_sync_parent().
I tested this using a power fail test, which panics a
machine running a file server getting requests from a
client. Without this patch, on about every other test run,
the server is missing many, many files that had been synced.
With this patch, on > 6 runs, I see zero files being lost.
Google-Bug-Id: 4179519
Signed-off-by: Curt Wohlgemuth <curtw@google.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2011-04-11 09:05:31 +07:00
|
|
|
ret = sync_mapping_buffers(inode->i_mapping);
|
|
|
|
if (ret)
|
|
|
|
break;
|
2012-12-11 02:06:03 +07:00
|
|
|
ret = sync_inode_metadata(inode, 1);
|
ext4: sync the directory inode in ext4_sync_parent()
ext4 has taken the stance that, in the absence of a journal,
when an fsync/fdatasync of an inode is done, the parent
directory should be sync'ed if this inode entry is new.
ext4_sync_parent(), which implements this, does indeed sync
the dirent pages for parent directories, but it does not
sync the directory *inode*. This patch fixes this.
Also now return error status from ext4_sync_parent().
I tested this using a power fail test, which panics a
machine running a file server getting requests from a
client. Without this patch, on about every other test run,
the server is missing many, many files that had been synced.
With this patch, on > 6 runs, I see zero files being lost.
Google-Bug-Id: 4179519
Signed-off-by: Curt Wohlgemuth <curtw@google.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2011-04-11 09:05:31 +07:00
|
|
|
if (ret)
|
|
|
|
break;
|
2010-05-17 19:00:00 +07:00
|
|
|
}
|
2011-07-30 23:34:19 +07:00
|
|
|
iput(inode);
|
ext4: sync the directory inode in ext4_sync_parent()
ext4 has taken the stance that, in the absence of a journal,
when an fsync/fdatasync of an inode is done, the parent
directory should be sync'ed if this inode entry is new.
ext4_sync_parent(), which implements this, does indeed sync
the dirent pages for parent directories, but it does not
sync the directory *inode*. This patch fixes this.
Also now return error status from ext4_sync_parent().
I tested this using a power fail test, which panics a
machine running a file server getting requests from a
client. Without this patch, on about every other test run,
the server is missing many, many files that had been synced.
With this patch, on > 6 runs, I see zero files being lost.
Google-Bug-Id: 4179519
Signed-off-by: Curt Wohlgemuth <curtw@google.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2011-04-11 09:05:31 +07:00
|
|
|
return ret;
|
2010-05-17 19:00:00 +07:00
|
|
|
}
|
|
|
|
|
2006-10-11 15:20:50 +07:00
|
|
|
/*
|
2006-10-11 15:20:53 +07:00
|
|
|
* akpm: A new design for ext4_sync_file().
|
2006-10-11 15:20:50 +07:00
|
|
|
*
|
|
|
|
* This is only called from sys_fsync(), sys_fdatasync() and sys_msync().
|
|
|
|
* There cannot be a transaction open by this task.
|
|
|
|
* Another task could have dirtied this inode. Its data can be in any
|
|
|
|
* state in the journalling system.
|
|
|
|
*
|
|
|
|
* What we do is just kick off a commit and wait on it. This will snapshot the
|
|
|
|
* inode to disk.
|
|
|
|
*/
|
|
|
|
|
2011-07-17 07:44:56 +07:00
|
|
|
int ext4_sync_file(struct file *file, loff_t start, loff_t end, int datasync)
|
2006-10-11 15:20:50 +07:00
|
|
|
{
|
2010-05-26 22:53:25 +07:00
|
|
|
struct inode *inode = file->f_mapping->host;
|
2009-12-09 11:51:10 +07:00
|
|
|
struct ext4_inode_info *ei = EXT4_I(inode);
|
2008-07-12 06:27:31 +07:00
|
|
|
journal_t *journal = EXT4_SB(inode->i_sb)->s_journal;
|
2013-06-05 01:40:09 +07:00
|
|
|
int ret = 0, err;
|
2009-12-09 11:51:10 +07:00
|
|
|
tid_t commit_tid;
|
2011-05-24 23:00:54 +07:00
|
|
|
bool needs_barrier = false;
|
2006-10-11 15:20:50 +07:00
|
|
|
|
2017-02-05 13:28:48 +07:00
|
|
|
if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb))))
|
|
|
|
return -EIO;
|
|
|
|
|
2007-10-17 05:38:25 +07:00
|
|
|
J_ASSERT(ext4_journal_current_handle() == NULL);
|
2006-10-11 15:20:50 +07:00
|
|
|
|
2011-03-22 08:38:05 +07:00
|
|
|
trace_ext4_sync_file_enter(file, datasync);
|
2008-10-06 07:50:06 +07:00
|
|
|
|
2017-07-17 14:45:34 +07:00
|
|
|
if (sb_rdonly(inode->i_sb)) {
|
2013-06-13 09:38:04 +07:00
|
|
|
/* Make sure that we read updated s_mount_flags value */
|
|
|
|
smp_rmb();
|
|
|
|
if (EXT4_SB(inode->i_sb)->s_mount_flags & EXT4_MF_FS_ABORTED)
|
|
|
|
ret = -EROFS;
|
2013-06-05 01:40:39 +07:00
|
|
|
goto out;
|
2013-06-13 09:38:04 +07:00
|
|
|
}
|
2009-12-09 11:51:10 +07:00
|
|
|
|
2010-05-17 19:00:00 +07:00
|
|
|
if (!journal) {
|
2019-02-01 11:41:11 +07:00
|
|
|
ret = __generic_file_fsync(file, start, end, datasync);
|
2016-09-06 10:21:43 +07:00
|
|
|
if (!ret)
|
ext4: sync the directory inode in ext4_sync_parent()
ext4 has taken the stance that, in the absence of a journal,
when an fsync/fdatasync of an inode is done, the parent
directory should be sync'ed if this inode entry is new.
ext4_sync_parent(), which implements this, does indeed sync
the dirent pages for parent directories, but it does not
sync the directory *inode*. This patch fixes this.
Also now return error status from ext4_sync_parent().
I tested this using a power fail test, which panics a
machine running a file server getting requests from a
client. Without this patch, on about every other test run,
the server is missing many, many files that had been synced.
With this patch, on > 6 runs, I see zero files being lost.
Google-Bug-Id: 4179519
Signed-off-by: Curt Wohlgemuth <curtw@google.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2011-04-11 09:05:31 +07:00
|
|
|
ret = ext4_sync_parent(inode);
|
2016-06-27 05:25:01 +07:00
|
|
|
if (test_opt(inode->i_sb, BARRIER))
|
|
|
|
goto issue_flush;
|
2013-06-05 01:40:39 +07:00
|
|
|
goto out;
|
2010-05-17 19:00:00 +07:00
|
|
|
}
|
2009-12-09 11:51:10 +07:00
|
|
|
|
2019-02-01 11:41:11 +07:00
|
|
|
ret = file_write_and_wait_range(file, start, end);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
2006-10-11 15:20:50 +07:00
|
|
|
/*
|
2009-12-09 11:51:10 +07:00
|
|
|
* data=writeback,ordered:
|
2006-10-11 15:20:50 +07:00
|
|
|
* The caller's filemap_fdatawrite()/wait will sync the data.
|
2009-12-09 11:51:10 +07:00
|
|
|
* Metadata is in the journal, we wait for proper transaction to
|
|
|
|
* commit here.
|
2006-10-11 15:20:50 +07:00
|
|
|
*
|
|
|
|
* data=journal:
|
|
|
|
* filemap_fdatawrite won't do anything (the buffers are clean).
|
2006-10-11 15:20:53 +07:00
|
|
|
* ext4_force_commit will write the file data into the journal and
|
2006-10-11 15:20:50 +07:00
|
|
|
* will wait on that.
|
|
|
|
* filemap_fdatawait() will encounter a ton of newly-dirtied pages
|
|
|
|
* (they were dirtied by commit). But that's OK - the blocks are
|
|
|
|
* safe in-journal, which is all fsync() needs to ensure.
|
|
|
|
*/
|
2011-03-22 08:38:05 +07:00
|
|
|
if (ext4_should_journal_data(inode)) {
|
|
|
|
ret = ext4_force_commit(inode->i_sb);
|
|
|
|
goto out;
|
|
|
|
}
|
2006-10-11 15:20:50 +07:00
|
|
|
|
2009-12-09 11:51:10 +07:00
|
|
|
commit_tid = datasync ? ei->i_datasync_tid : ei->i_sync_tid;
|
2011-05-24 23:00:54 +07:00
|
|
|
if (journal->j_flags & JBD2_BARRIER &&
|
|
|
|
!jbd2_trans_will_send_data_barrier(journal, commit_tid))
|
|
|
|
needs_barrier = true;
|
ext4/jbd2: don't wait (forever) for stale tid caused by wraparound
In the case where an inode has a very stale transaction id (tid) in
i_datasync_tid or i_sync_tid, it's possible that after a very large
(2**31) number of transactions, that the tid number space might wrap,
causing tid_geq()'s calculations to fail.
Commit deeeaf13 "jbd2: fix fsync() tid wraparound bug", later modified
by commit e7b04ac0 "jbd2: don't wake kjournald unnecessarily",
attempted to fix this problem, but it only avoided kjournald spinning
forever by fixing the logic in jbd2_log_start_commit().
Unfortunately, in the codepaths in fs/ext4/fsync.c and fs/ext4/inode.c
that might call jbd2_log_start_commit() with a stale tid, those
functions will subsequently call jbd2_log_wait_commit() with the same
stale tid, and then wait for a very long time. To fix this, we
replace the calls to jbd2_log_start_commit() and
jbd2_log_wait_commit() with a call to a new function,
jbd2_complete_transaction(), which will correctly handle stale tid's.
As a bonus, jbd2_complete_transaction() will avoid locking
j_state_lock for writing unless a commit needs to be started. This
should have a small (but probably not measurable) improvement for
ext4's scalability.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reported-by: Ben Hutchings <ben@decadent.org.uk>
Reported-by: George Barnett <gbarnett@atlassian.com>
Cc: stable@vger.kernel.org
2013-04-04 09:02:52 +07:00
|
|
|
ret = jbd2_complete_transaction(journal, commit_tid);
|
2012-08-17 20:58:17 +07:00
|
|
|
if (needs_barrier) {
|
2016-06-27 05:25:01 +07:00
|
|
|
issue_flush:
|
2012-08-17 20:58:17 +07:00
|
|
|
err = blkdev_issue_flush(inode->i_sb->s_bdev, GFP_KERNEL, NULL);
|
|
|
|
if (!ret)
|
|
|
|
ret = err;
|
|
|
|
}
|
2013-06-05 01:40:09 +07:00
|
|
|
out:
|
2018-12-31 12:11:07 +07:00
|
|
|
err = file_check_and_advance_wb_err(file);
|
|
|
|
if (ret == 0)
|
|
|
|
ret = err;
|
2011-03-22 08:38:05 +07:00
|
|
|
trace_ext4_sync_file_exit(inode, ret);
|
2006-10-11 15:20:50 +07:00
|
|
|
return ret;
|
|
|
|
}
|