2008-10-23 05:47:49 +07:00
|
|
|
/*
|
|
|
|
* Copyright (c) 2007 Mellanox Technologies. All rights reserved.
|
|
|
|
*
|
|
|
|
* This software is available to you under a choice of one of two
|
|
|
|
* licenses. You may choose to be licensed under the terms of the GNU
|
|
|
|
* General Public License (GPL) Version 2, available from the file
|
|
|
|
* COPYING in the main directory of this source tree, or the
|
|
|
|
* OpenIB.org BSD license below:
|
|
|
|
*
|
|
|
|
* Redistribution and use in source and binary forms, with or
|
|
|
|
* without modification, are permitted provided that the following
|
|
|
|
* conditions are met:
|
|
|
|
*
|
|
|
|
* - Redistributions of source code must retain the above
|
|
|
|
* copyright notice, this list of conditions and the following
|
|
|
|
* disclaimer.
|
|
|
|
*
|
|
|
|
* - Redistributions in binary form must reproduce the above
|
|
|
|
* copyright notice, this list of conditions and the following
|
|
|
|
* disclaimer in the documentation and/or other materials
|
|
|
|
* provided with the distribution.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
|
|
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
|
|
|
|
* BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
|
|
|
|
* ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
|
|
|
|
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
|
|
* SOFTWARE.
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
2013-07-10 21:13:17 +07:00
|
|
|
#include <net/busy_poll.h>
|
2016-07-20 02:16:50 +07:00
|
|
|
#include <linux/bpf.h>
|
2008-10-23 05:47:49 +07:00
|
|
|
#include <linux/mlx4/cq.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 15:04:11 +07:00
|
|
|
#include <linux/slab.h>
|
2008-10-23 05:47:49 +07:00
|
|
|
#include <linux/mlx4/qp.h>
|
|
|
|
#include <linux/skbuff.h>
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 08:06:00 +07:00
|
|
|
#include <linux/rculist.h>
|
2008-10-23 05:47:49 +07:00
|
|
|
#include <linux/if_ether.h>
|
|
|
|
#include <linux/if_vlan.h>
|
|
|
|
#include <linux/vmalloc.h>
|
2014-06-29 15:54:55 +07:00
|
|
|
#include <linux/irq.h>
|
2008-10-23 05:47:49 +07:00
|
|
|
|
2014-11-09 18:51:53 +07:00
|
|
|
#if IS_ENABLED(CONFIG_IPV6)
|
|
|
|
#include <net/ip6_checksum.h>
|
|
|
|
#endif
|
|
|
|
|
2008-10-23 05:47:49 +07:00
|
|
|
#include "mlx4_en.h"
|
|
|
|
|
2013-06-23 22:17:56 +07:00
|
|
|
static int mlx4_alloc_pages(struct mlx4_en_priv *priv,
|
|
|
|
struct mlx4_en_rx_alloc *page_alloc,
|
|
|
|
const struct mlx4_en_frag_info *frag_info,
|
|
|
|
gfp_t _gfp)
|
|
|
|
{
|
|
|
|
int order;
|
|
|
|
struct page *page;
|
|
|
|
dma_addr_t dma;
|
|
|
|
|
2016-07-20 02:16:52 +07:00
|
|
|
for (order = frag_info->order; ;) {
|
2013-06-23 22:17:56 +07:00
|
|
|
gfp_t gfp = _gfp;
|
|
|
|
|
|
|
|
if (order)
|
2016-04-18 18:33:54 +07:00
|
|
|
gfp |= __GFP_COMP | __GFP_NOWARN | __GFP_NOMEMALLOC;
|
2013-06-23 22:17:56 +07:00
|
|
|
page = alloc_pages(gfp, order);
|
|
|
|
if (likely(page))
|
|
|
|
break;
|
|
|
|
if (--order < 0 ||
|
|
|
|
((PAGE_SIZE << order) < frag_info->frag_size))
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
dma = dma_map_page(priv->ddev, page, 0, PAGE_SIZE << order,
|
2016-07-20 02:16:52 +07:00
|
|
|
frag_info->dma_dir);
|
2016-09-20 18:39:39 +07:00
|
|
|
if (unlikely(dma_mapping_error(priv->ddev, dma))) {
|
2013-06-23 22:17:56 +07:00
|
|
|
put_page(page);
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
2013-10-07 18:38:12 +07:00
|
|
|
page_alloc->page_size = PAGE_SIZE << order;
|
2013-06-23 22:17:56 +07:00
|
|
|
page_alloc->page = page;
|
|
|
|
page_alloc->dma = dma;
|
2014-11-02 21:26:15 +07:00
|
|
|
page_alloc->page_offset = 0;
|
2013-06-23 22:17:56 +07:00
|
|
|
/* Not doing get_page() for each frag is a big win
|
2014-10-10 18:48:17 +07:00
|
|
|
* on asymetric workloads. Note we can not use atomic_set().
|
2013-06-23 22:17:56 +07:00
|
|
|
*/
|
2016-03-18 04:19:26 +07:00
|
|
|
page_ref_add(page, page_alloc->page_size / frag_info->frag_stride - 1);
|
2013-06-23 22:17:56 +07:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2012-07-16 14:01:53 +07:00
|
|
|
static int mlx4_en_alloc_frags(struct mlx4_en_priv *priv,
|
|
|
|
struct mlx4_en_rx_desc *rx_desc,
|
|
|
|
struct mlx4_en_rx_alloc *frags,
|
2013-06-23 22:17:56 +07:00
|
|
|
struct mlx4_en_rx_alloc *ring_alloc,
|
|
|
|
gfp_t gfp)
|
2008-10-23 05:47:49 +07:00
|
|
|
{
|
2012-07-16 14:01:53 +07:00
|
|
|
struct mlx4_en_rx_alloc page_alloc[MLX4_EN_MAX_RX_FRAGS];
|
2013-06-23 22:17:56 +07:00
|
|
|
const struct mlx4_en_frag_info *frag_info;
|
2008-10-23 05:47:49 +07:00
|
|
|
struct page *page;
|
2012-07-16 14:01:53 +07:00
|
|
|
int i;
|
2008-10-23 05:47:49 +07:00
|
|
|
|
2012-07-16 14:01:53 +07:00
|
|
|
for (i = 0; i < priv->num_frags; i++) {
|
|
|
|
frag_info = &priv->frag_info[i];
|
2013-06-23 22:17:56 +07:00
|
|
|
page_alloc[i] = ring_alloc[i];
|
2013-10-07 18:38:12 +07:00
|
|
|
page_alloc[i].page_offset += frag_info->frag_stride;
|
|
|
|
|
|
|
|
if (page_alloc[i].page_offset + frag_info->frag_stride <=
|
|
|
|
ring_alloc[i].page_size)
|
2013-06-23 22:17:56 +07:00
|
|
|
continue;
|
2013-10-07 18:38:12 +07:00
|
|
|
|
2016-09-20 18:39:39 +07:00
|
|
|
if (unlikely(mlx4_alloc_pages(priv, &page_alloc[i],
|
|
|
|
frag_info, gfp)))
|
2013-06-23 22:17:56 +07:00
|
|
|
goto out;
|
2012-07-16 14:01:53 +07:00
|
|
|
}
|
2008-10-23 05:47:49 +07:00
|
|
|
|
2012-07-16 14:01:53 +07:00
|
|
|
for (i = 0; i < priv->num_frags; i++) {
|
|
|
|
frags[i] = ring_alloc[i];
|
2016-12-08 06:53:13 +07:00
|
|
|
frags[i].page_offset += priv->frag_info[i].rx_headroom;
|
|
|
|
rx_desc->data[i].addr = cpu_to_be64(frags[i].dma +
|
|
|
|
frags[i].page_offset);
|
2012-07-16 14:01:53 +07:00
|
|
|
ring_alloc[i] = page_alloc[i];
|
2008-10-23 05:47:49 +07:00
|
|
|
}
|
2012-07-16 14:01:53 +07:00
|
|
|
|
2008-10-23 05:47:49 +07:00
|
|
|
return 0;
|
2012-07-16 14:01:53 +07:00
|
|
|
|
|
|
|
out:
|
|
|
|
while (i--) {
|
2013-06-23 22:17:56 +07:00
|
|
|
if (page_alloc[i].page != ring_alloc[i].page) {
|
2012-07-16 14:01:53 +07:00
|
|
|
dma_unmap_page(priv->ddev, page_alloc[i].dma,
|
2016-07-20 02:16:52 +07:00
|
|
|
page_alloc[i].page_size,
|
|
|
|
priv->frag_info[i].dma_dir);
|
2013-06-23 22:17:56 +07:00
|
|
|
page = page_alloc[i].page;
|
2016-04-18 18:34:05 +07:00
|
|
|
/* Revert changes done by mlx4_alloc_pages */
|
|
|
|
page_ref_sub(page, page_alloc[i].page_size /
|
|
|
|
priv->frag_info[i].frag_stride - 1);
|
2013-06-23 22:17:56 +07:00
|
|
|
put_page(page);
|
|
|
|
}
|
2012-07-16 14:01:53 +07:00
|
|
|
}
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void mlx4_en_free_frag(struct mlx4_en_priv *priv,
|
|
|
|
struct mlx4_en_rx_alloc *frags,
|
|
|
|
int i)
|
|
|
|
{
|
2013-06-23 22:17:56 +07:00
|
|
|
const struct mlx4_en_frag_info *frag_info = &priv->frag_info[i];
|
2013-10-07 18:38:13 +07:00
|
|
|
u32 next_frag_end = frags[i].page_offset + 2 * frag_info->frag_stride;
|
2012-07-16 14:01:53 +07:00
|
|
|
|
2013-10-07 18:38:13 +07:00
|
|
|
|
|
|
|
if (next_frag_end > frags[i].page_size)
|
2013-10-07 18:38:12 +07:00
|
|
|
dma_unmap_page(priv->ddev, frags[i].dma, frags[i].page_size,
|
2016-07-20 02:16:52 +07:00
|
|
|
frag_info->dma_dir);
|
2013-06-23 22:17:56 +07:00
|
|
|
|
2012-07-16 14:01:53 +07:00
|
|
|
if (frags[i].page)
|
|
|
|
put_page(frags[i].page);
|
2008-10-23 05:47:49 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static int mlx4_en_init_allocator(struct mlx4_en_priv *priv,
|
|
|
|
struct mlx4_en_rx_ring *ring)
|
|
|
|
{
|
|
|
|
int i;
|
2013-06-23 22:17:56 +07:00
|
|
|
struct mlx4_en_rx_alloc *page_alloc;
|
2008-10-23 05:47:49 +07:00
|
|
|
|
|
|
|
for (i = 0; i < priv->num_frags; i++) {
|
2013-06-23 22:17:56 +07:00
|
|
|
const struct mlx4_en_frag_info *frag_info = &priv->frag_info[i];
|
2008-10-23 05:47:49 +07:00
|
|
|
|
2013-06-23 22:17:56 +07:00
|
|
|
if (mlx4_alloc_pages(priv, &ring->page_alloc[i],
|
2014-11-02 21:26:16 +07:00
|
|
|
frag_info, GFP_KERNEL | __GFP_COLD))
|
2012-07-16 14:01:53 +07:00
|
|
|
goto out;
|
2015-02-03 22:57:19 +07:00
|
|
|
|
|
|
|
en_dbg(DRV, priv, " frag %d allocator: - size:%d frags:%d\n",
|
|
|
|
i, ring->page_alloc[i].page_size,
|
2016-03-18 04:19:26 +07:00
|
|
|
page_ref_count(ring->page_alloc[i].page));
|
2008-10-23 05:47:49 +07:00
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
out:
|
|
|
|
while (i--) {
|
2013-06-23 22:17:56 +07:00
|
|
|
struct page *page;
|
|
|
|
|
2008-10-23 05:47:49 +07:00
|
|
|
page_alloc = &ring->page_alloc[i];
|
2012-07-16 14:01:53 +07:00
|
|
|
dma_unmap_page(priv->ddev, page_alloc->dma,
|
2016-07-20 02:16:52 +07:00
|
|
|
page_alloc->page_size,
|
|
|
|
priv->frag_info[i].dma_dir);
|
2013-06-23 22:17:56 +07:00
|
|
|
page = page_alloc->page;
|
2016-04-18 18:34:05 +07:00
|
|
|
/* Revert changes done by mlx4_alloc_pages */
|
|
|
|
page_ref_sub(page, page_alloc->page_size /
|
|
|
|
priv->frag_info[i].frag_stride - 1);
|
2013-06-23 22:17:56 +07:00
|
|
|
put_page(page);
|
2008-10-23 05:47:49 +07:00
|
|
|
page_alloc->page = NULL;
|
|
|
|
}
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void mlx4_en_destroy_allocator(struct mlx4_en_priv *priv,
|
|
|
|
struct mlx4_en_rx_ring *ring)
|
|
|
|
{
|
|
|
|
struct mlx4_en_rx_alloc *page_alloc;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < priv->num_frags; i++) {
|
2013-06-23 22:17:56 +07:00
|
|
|
const struct mlx4_en_frag_info *frag_info = &priv->frag_info[i];
|
|
|
|
|
2008-10-23 05:47:49 +07:00
|
|
|
page_alloc = &ring->page_alloc[i];
|
2009-06-02 03:27:13 +07:00
|
|
|
en_dbg(DRV, priv, "Freeing allocator:%d count:%d\n",
|
|
|
|
i, page_count(page_alloc->page));
|
2008-10-23 05:47:49 +07:00
|
|
|
|
2012-07-16 14:01:53 +07:00
|
|
|
dma_unmap_page(priv->ddev, page_alloc->dma,
|
2016-07-20 02:16:52 +07:00
|
|
|
page_alloc->page_size, frag_info->dma_dir);
|
2013-10-07 18:38:12 +07:00
|
|
|
while (page_alloc->page_offset + frag_info->frag_stride <
|
|
|
|
page_alloc->page_size) {
|
2013-06-23 22:17:56 +07:00
|
|
|
put_page(page_alloc->page);
|
2013-10-07 18:38:12 +07:00
|
|
|
page_alloc->page_offset += frag_info->frag_stride;
|
2013-06-23 22:17:56 +07:00
|
|
|
}
|
2008-10-23 05:47:49 +07:00
|
|
|
page_alloc->page = NULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void mlx4_en_init_rx_desc(struct mlx4_en_priv *priv,
|
|
|
|
struct mlx4_en_rx_ring *ring, int index)
|
|
|
|
{
|
|
|
|
struct mlx4_en_rx_desc *rx_desc = ring->buf + ring->stride * index;
|
|
|
|
int possible_frags;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
/* Set size and memtype fields */
|
|
|
|
for (i = 0; i < priv->num_frags; i++) {
|
|
|
|
rx_desc->data[i].byte_count =
|
|
|
|
cpu_to_be32(priv->frag_info[i].frag_size);
|
|
|
|
rx_desc->data[i].lkey = cpu_to_be32(priv->mdev->mr.key);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* If the number of used fragments does not fill up the ring stride,
|
|
|
|
* remaining (unused) fragments must be padded with null address/size
|
|
|
|
* and a special memory key */
|
|
|
|
possible_frags = (ring->stride - sizeof(struct mlx4_en_rx_desc)) / DS_SIZE;
|
|
|
|
for (i = priv->num_frags; i < possible_frags; i++) {
|
|
|
|
rx_desc->data[i].byte_count = 0;
|
|
|
|
rx_desc->data[i].lkey = cpu_to_be32(MLX4_EN_MEMTYPE_PAD);
|
|
|
|
rx_desc->data[i].addr = 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static int mlx4_en_prepare_rx_desc(struct mlx4_en_priv *priv,
|
2013-06-23 22:17:56 +07:00
|
|
|
struct mlx4_en_rx_ring *ring, int index,
|
|
|
|
gfp_t gfp)
|
2008-10-23 05:47:49 +07:00
|
|
|
{
|
|
|
|
struct mlx4_en_rx_desc *rx_desc = ring->buf + (index * ring->stride);
|
2012-07-16 14:01:53 +07:00
|
|
|
struct mlx4_en_rx_alloc *frags = ring->rx_info +
|
|
|
|
(index << priv->log_rx_info);
|
2008-10-23 05:47:49 +07:00
|
|
|
|
2016-07-20 02:16:52 +07:00
|
|
|
if (ring->page_cache.index > 0) {
|
|
|
|
frags[0] = ring->page_cache.buf[--ring->page_cache.index];
|
2016-12-08 06:53:13 +07:00
|
|
|
rx_desc->data[0].addr = cpu_to_be64(frags[0].dma +
|
|
|
|
frags[0].page_offset);
|
2016-07-20 02:16:52 +07:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2013-06-23 22:17:56 +07:00
|
|
|
return mlx4_en_alloc_frags(priv, rx_desc, frags, ring->page_alloc, gfp);
|
2008-10-23 05:47:49 +07:00
|
|
|
}
|
|
|
|
|
2015-04-30 21:32:46 +07:00
|
|
|
static inline bool mlx4_en_is_ring_empty(struct mlx4_en_rx_ring *ring)
|
|
|
|
{
|
|
|
|
return ring->prod == ring->cons;
|
|
|
|
}
|
|
|
|
|
2008-10-23 05:47:49 +07:00
|
|
|
static inline void mlx4_en_update_rx_prod_db(struct mlx4_en_rx_ring *ring)
|
|
|
|
{
|
|
|
|
*ring->wqres.db.db = cpu_to_be32(ring->prod & 0xffff);
|
|
|
|
}
|
|
|
|
|
2009-05-24 10:17:11 +07:00
|
|
|
static void mlx4_en_free_rx_desc(struct mlx4_en_priv *priv,
|
|
|
|
struct mlx4_en_rx_ring *ring,
|
|
|
|
int index)
|
|
|
|
{
|
2012-07-16 14:01:53 +07:00
|
|
|
struct mlx4_en_rx_alloc *frags;
|
2009-05-24 10:17:11 +07:00
|
|
|
int nr;
|
|
|
|
|
2012-07-16 14:01:53 +07:00
|
|
|
frags = ring->rx_info + (index << priv->log_rx_info);
|
2009-05-24 10:17:11 +07:00
|
|
|
for (nr = 0; nr < priv->num_frags; nr++) {
|
2009-06-02 03:27:13 +07:00
|
|
|
en_dbg(DRV, priv, "Freeing fragment:%d\n", nr);
|
2012-07-16 14:01:53 +07:00
|
|
|
mlx4_en_free_frag(priv, frags, nr);
|
2009-05-24 10:17:11 +07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-10-23 05:47:49 +07:00
|
|
|
static int mlx4_en_fill_rx_buffers(struct mlx4_en_priv *priv)
|
|
|
|
{
|
|
|
|
struct mlx4_en_rx_ring *ring;
|
|
|
|
int ring_ind;
|
|
|
|
int buf_ind;
|
2009-05-24 10:17:11 +07:00
|
|
|
int new_size;
|
2008-10-23 05:47:49 +07:00
|
|
|
|
|
|
|
for (buf_ind = 0; buf_ind < priv->prof->rx_ring_size; buf_ind++) {
|
|
|
|
for (ring_ind = 0; ring_ind < priv->rx_ring_num; ring_ind++) {
|
2013-11-07 17:19:52 +07:00
|
|
|
ring = priv->rx_ring[ring_ind];
|
2008-10-23 05:47:49 +07:00
|
|
|
|
|
|
|
if (mlx4_en_prepare_rx_desc(priv, ring,
|
2013-06-23 22:17:56 +07:00
|
|
|
ring->actual_size,
|
2014-11-02 21:26:16 +07:00
|
|
|
GFP_KERNEL | __GFP_COLD)) {
|
2008-10-23 05:47:49 +07:00
|
|
|
if (ring->actual_size < MLX4_EN_MIN_RX_SIZE) {
|
2014-05-08 02:52:57 +07:00
|
|
|
en_err(priv, "Failed to allocate enough rx buffers\n");
|
2008-10-23 05:47:49 +07:00
|
|
|
return -ENOMEM;
|
|
|
|
} else {
|
2009-05-24 10:17:11 +07:00
|
|
|
new_size = rounddown_pow_of_two(ring->actual_size);
|
2014-05-08 02:52:57 +07:00
|
|
|
en_warn(priv, "Only %d buffers allocated reducing ring size to %d\n",
|
2009-06-02 03:27:13 +07:00
|
|
|
ring->actual_size, new_size);
|
2009-05-24 10:17:11 +07:00
|
|
|
goto reduce_rings;
|
2008-10-23 05:47:49 +07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
ring->actual_size++;
|
|
|
|
ring->prod++;
|
|
|
|
}
|
|
|
|
}
|
2009-05-24 10:17:11 +07:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
reduce_rings:
|
|
|
|
for (ring_ind = 0; ring_ind < priv->rx_ring_num; ring_ind++) {
|
2013-11-07 17:19:52 +07:00
|
|
|
ring = priv->rx_ring[ring_ind];
|
2009-05-24 10:17:11 +07:00
|
|
|
while (ring->actual_size > new_size) {
|
|
|
|
ring->actual_size--;
|
|
|
|
ring->prod--;
|
|
|
|
mlx4_en_free_rx_desc(priv, ring, ring->actual_size);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-10-23 05:47:49 +07:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void mlx4_en_free_rx_buf(struct mlx4_en_priv *priv,
|
|
|
|
struct mlx4_en_rx_ring *ring)
|
|
|
|
{
|
|
|
|
int index;
|
|
|
|
|
2009-06-02 03:27:13 +07:00
|
|
|
en_dbg(DRV, priv, "Freeing Rx buf - cons:%d prod:%d\n",
|
|
|
|
ring->cons, ring->prod);
|
2008-10-23 05:47:49 +07:00
|
|
|
|
|
|
|
/* Unmap and free Rx buffers */
|
2015-04-30 21:32:46 +07:00
|
|
|
while (!mlx4_en_is_ring_empty(ring)) {
|
2008-10-23 05:47:49 +07:00
|
|
|
index = ring->cons & ring->size_mask;
|
2009-06-02 03:27:13 +07:00
|
|
|
en_dbg(DRV, priv, "Processing descriptor:%d\n", index);
|
2009-05-24 10:17:11 +07:00
|
|
|
mlx4_en_free_rx_desc(priv, ring, index);
|
2008-10-23 05:47:49 +07:00
|
|
|
++ring->cons;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-02-21 17:39:17 +07:00
|
|
|
void mlx4_en_set_num_rx_rings(struct mlx4_en_dev *mdev)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
int num_of_eqs;
|
2014-02-21 17:39:18 +07:00
|
|
|
int num_rx_rings;
|
2014-02-21 17:39:17 +07:00
|
|
|
struct mlx4_dev *dev = mdev->dev;
|
|
|
|
|
|
|
|
mlx4_foreach_port(i, dev, MLX4_PORT_TYPE_ETH) {
|
2015-05-31 13:30:16 +07:00
|
|
|
num_of_eqs = max_t(int, MIN_RX_RINGS,
|
|
|
|
min_t(int,
|
|
|
|
mlx4_get_eqs_per_port(mdev->dev, i),
|
|
|
|
DEF_RX_RINGS));
|
2014-02-21 17:39:17 +07:00
|
|
|
|
2014-07-22 19:44:12 +07:00
|
|
|
num_rx_rings = mlx4_low_memory_profile() ? MIN_RX_RINGS :
|
|
|
|
min_t(int, num_of_eqs,
|
|
|
|
netif_get_num_default_rss_queues());
|
2014-02-21 17:39:17 +07:00
|
|
|
mdev->profile.prof[i].rx_ring_num =
|
2014-02-21 17:39:18 +07:00
|
|
|
rounddown_pow_of_two(num_rx_rings);
|
2014-02-21 17:39:17 +07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-10-23 05:47:49 +07:00
|
|
|
int mlx4_en_create_rx_ring(struct mlx4_en_priv *priv,
|
2013-11-07 17:19:52 +07:00
|
|
|
struct mlx4_en_rx_ring **pring,
|
2013-11-07 17:19:54 +07:00
|
|
|
u32 size, u16 stride, int node)
|
2008-10-23 05:47:49 +07:00
|
|
|
{
|
|
|
|
struct mlx4_en_dev *mdev = priv->mdev;
|
2013-11-07 17:19:52 +07:00
|
|
|
struct mlx4_en_rx_ring *ring;
|
2012-07-16 14:01:53 +07:00
|
|
|
int err = -ENOMEM;
|
2008-10-23 05:47:49 +07:00
|
|
|
int tmp;
|
|
|
|
|
2013-11-07 17:19:54 +07:00
|
|
|
ring = kzalloc_node(sizeof(*ring), GFP_KERNEL, node);
|
2013-11-07 17:19:52 +07:00
|
|
|
if (!ring) {
|
2013-11-07 17:19:54 +07:00
|
|
|
ring = kzalloc(sizeof(*ring), GFP_KERNEL);
|
|
|
|
if (!ring) {
|
|
|
|
en_err(priv, "Failed to allocate RX ring structure\n");
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
2013-11-07 17:19:52 +07:00
|
|
|
}
|
|
|
|
|
2008-10-23 05:47:49 +07:00
|
|
|
ring->prod = 0;
|
|
|
|
ring->cons = 0;
|
|
|
|
ring->size = size;
|
|
|
|
ring->size_mask = size - 1;
|
|
|
|
ring->stride = stride;
|
|
|
|
ring->log_stride = ffs(ring->stride) - 1;
|
2009-08-07 09:28:18 +07:00
|
|
|
ring->buf_size = ring->size * ring->stride + TXBB_SIZE;
|
2008-10-23 05:47:49 +07:00
|
|
|
|
|
|
|
tmp = size * roundup_pow_of_two(MLX4_EN_MAX_RX_FRAGS *
|
2012-07-16 14:01:53 +07:00
|
|
|
sizeof(struct mlx4_en_rx_alloc));
|
2013-11-07 17:19:54 +07:00
|
|
|
ring->rx_info = vmalloc_node(tmp, node);
|
2013-11-07 17:19:52 +07:00
|
|
|
if (!ring->rx_info) {
|
2013-11-07 17:19:54 +07:00
|
|
|
ring->rx_info = vmalloc(tmp);
|
|
|
|
if (!ring->rx_info) {
|
|
|
|
err = -ENOMEM;
|
|
|
|
goto err_ring;
|
|
|
|
}
|
2013-11-07 17:19:52 +07:00
|
|
|
}
|
2012-01-29 19:56:23 +07:00
|
|
|
|
2009-06-02 03:27:13 +07:00
|
|
|
en_dbg(DRV, priv, "Allocated rx_info ring at addr:%p size:%d\n",
|
2008-10-23 05:47:49 +07:00
|
|
|
ring->rx_info, tmp);
|
|
|
|
|
2013-11-07 17:19:54 +07:00
|
|
|
/* Allocate HW buffers on provided NUMA node */
|
2015-01-25 21:59:35 +07:00
|
|
|
set_dev_node(&mdev->dev->persist->pdev->dev, node);
|
2016-05-04 18:50:15 +07:00
|
|
|
err = mlx4_alloc_hwq_res(mdev->dev, &ring->wqres, ring->buf_size);
|
2015-01-25 21:59:35 +07:00
|
|
|
set_dev_node(&mdev->dev->persist->pdev->dev, mdev->dev->numa_node);
|
2008-10-23 05:47:49 +07:00
|
|
|
if (err)
|
2013-11-07 17:19:52 +07:00
|
|
|
goto err_info;
|
2008-10-23 05:47:49 +07:00
|
|
|
|
|
|
|
ring->buf = ring->wqres.buf.direct.buf;
|
|
|
|
|
2013-04-23 13:06:49 +07:00
|
|
|
ring->hwtstamp_rx_filter = priv->hwtstamp_config.rx_filter;
|
|
|
|
|
2013-11-07 17:19:52 +07:00
|
|
|
*pring = ring;
|
2008-10-23 05:47:49 +07:00
|
|
|
return 0;
|
|
|
|
|
2013-11-07 17:19:52 +07:00
|
|
|
err_info:
|
2008-10-23 05:47:49 +07:00
|
|
|
vfree(ring->rx_info);
|
|
|
|
ring->rx_info = NULL;
|
2013-11-07 17:19:52 +07:00
|
|
|
err_ring:
|
|
|
|
kfree(ring);
|
|
|
|
*pring = NULL;
|
|
|
|
|
2008-10-23 05:47:49 +07:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
int mlx4_en_activate_rx_rings(struct mlx4_en_priv *priv)
|
|
|
|
{
|
|
|
|
struct mlx4_en_rx_ring *ring;
|
|
|
|
int i;
|
|
|
|
int ring_ind;
|
|
|
|
int err;
|
|
|
|
int stride = roundup_pow_of_two(sizeof(struct mlx4_en_rx_desc) +
|
|
|
|
DS_SIZE * priv->num_frags);
|
|
|
|
|
|
|
|
for (ring_ind = 0; ring_ind < priv->rx_ring_num; ring_ind++) {
|
2013-11-07 17:19:52 +07:00
|
|
|
ring = priv->rx_ring[ring_ind];
|
2008-10-23 05:47:49 +07:00
|
|
|
|
|
|
|
ring->prod = 0;
|
|
|
|
ring->cons = 0;
|
|
|
|
ring->actual_size = 0;
|
2013-11-07 17:19:52 +07:00
|
|
|
ring->cqn = priv->rx_cq[ring_ind]->mcq.cqn;
|
2008-10-23 05:47:49 +07:00
|
|
|
|
|
|
|
ring->stride = stride;
|
2016-12-29 23:37:10 +07:00
|
|
|
if (ring->stride <= TXBB_SIZE) {
|
|
|
|
/* Stamp first unused send wqe */
|
|
|
|
__be32 *ptr = (__be32 *)ring->buf;
|
|
|
|
__be32 stamp = cpu_to_be32(1 << STAMP_SHIFT);
|
|
|
|
*ptr = stamp;
|
|
|
|
/* Move pointer to start of rx section */
|
2009-08-07 09:28:18 +07:00
|
|
|
ring->buf += TXBB_SIZE;
|
2016-12-29 23:37:10 +07:00
|
|
|
}
|
2009-08-07 09:28:18 +07:00
|
|
|
|
2008-10-23 05:47:49 +07:00
|
|
|
ring->log_stride = ffs(ring->stride) - 1;
|
|
|
|
ring->buf_size = ring->size * ring->stride;
|
|
|
|
|
|
|
|
memset(ring->buf, 0, ring->buf_size);
|
|
|
|
mlx4_en_update_rx_prod_db(ring);
|
|
|
|
|
2012-07-16 14:01:53 +07:00
|
|
|
/* Initialize all descriptors */
|
2008-10-23 05:47:49 +07:00
|
|
|
for (i = 0; i < ring->size; i++)
|
|
|
|
mlx4_en_init_rx_desc(priv, ring, i);
|
|
|
|
|
|
|
|
/* Initialize page allocators */
|
|
|
|
err = mlx4_en_init_allocator(priv, ring);
|
|
|
|
if (err) {
|
2009-06-02 03:27:13 +07:00
|
|
|
en_err(priv, "Failed initializing ring allocator\n");
|
2011-04-07 06:25:45 +07:00
|
|
|
if (ring->stride <= TXBB_SIZE)
|
|
|
|
ring->buf -= TXBB_SIZE;
|
2009-04-20 11:24:28 +07:00
|
|
|
ring_ind--;
|
|
|
|
goto err_allocator;
|
2008-10-23 05:47:49 +07:00
|
|
|
}
|
|
|
|
}
|
2008-11-26 07:53:32 +07:00
|
|
|
err = mlx4_en_fill_rx_buffers(priv);
|
|
|
|
if (err)
|
2008-10-23 05:47:49 +07:00
|
|
|
goto err_buffers;
|
|
|
|
|
|
|
|
for (ring_ind = 0; ring_ind < priv->rx_ring_num; ring_ind++) {
|
2013-11-07 17:19:52 +07:00
|
|
|
ring = priv->rx_ring[ring_ind];
|
2008-10-23 05:47:49 +07:00
|
|
|
|
2010-08-24 10:45:20 +07:00
|
|
|
ring->size_mask = ring->actual_size - 1;
|
2008-10-23 05:47:49 +07:00
|
|
|
mlx4_en_update_rx_prod_db(ring);
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
err_buffers:
|
|
|
|
for (ring_ind = 0; ring_ind < priv->rx_ring_num; ring_ind++)
|
2013-11-07 17:19:52 +07:00
|
|
|
mlx4_en_free_rx_buf(priv, priv->rx_ring[ring_ind]);
|
2008-10-23 05:47:49 +07:00
|
|
|
|
|
|
|
ring_ind = priv->rx_ring_num - 1;
|
|
|
|
err_allocator:
|
|
|
|
while (ring_ind >= 0) {
|
2013-11-07 17:19:52 +07:00
|
|
|
if (priv->rx_ring[ring_ind]->stride <= TXBB_SIZE)
|
|
|
|
priv->rx_ring[ring_ind]->buf -= TXBB_SIZE;
|
|
|
|
mlx4_en_destroy_allocator(priv, priv->rx_ring[ring_ind]);
|
2008-10-23 05:47:49 +07:00
|
|
|
ring_ind--;
|
|
|
|
}
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2015-04-30 21:32:46 +07:00
|
|
|
/* We recover from out of memory by scheduling our napi poll
|
|
|
|
* function (mlx4_en_process_cq), which tries to allocate
|
|
|
|
* all missing RX buffers (call to mlx4_en_refill_rx_buffers).
|
|
|
|
*/
|
|
|
|
void mlx4_en_recover_from_oom(struct mlx4_en_priv *priv)
|
|
|
|
{
|
|
|
|
int ring;
|
|
|
|
|
|
|
|
if (!priv->port_up)
|
|
|
|
return;
|
|
|
|
|
|
|
|
for (ring = 0; ring < priv->rx_ring_num; ring++) {
|
|
|
|
if (mlx4_en_is_ring_empty(priv->rx_ring[ring]))
|
|
|
|
napi_reschedule(&priv->rx_cq[ring]->napi);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-07-20 02:16:52 +07:00
|
|
|
/* When the rx ring is running in page-per-packet mode, a released frame can go
|
|
|
|
* directly into a small cache, to avoid unmapping or touching the page
|
|
|
|
* allocator. In bpf prog performance scenarios, buffers are either forwarded
|
|
|
|
* or dropped, never converted to skbs, so every page can come directly from
|
|
|
|
* this cache when it is sized to be a multiple of the napi budget.
|
|
|
|
*/
|
|
|
|
bool mlx4_en_rx_recycle(struct mlx4_en_rx_ring *ring,
|
|
|
|
struct mlx4_en_rx_alloc *frame)
|
|
|
|
{
|
|
|
|
struct mlx4_en_page_cache *cache = &ring->page_cache;
|
|
|
|
|
|
|
|
if (cache->index >= MLX4_EN_CACHE_SIZE)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
cache->buf[cache->index++] = *frame;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2008-10-23 05:47:49 +07:00
|
|
|
void mlx4_en_destroy_rx_ring(struct mlx4_en_priv *priv,
|
2013-11-07 17:19:52 +07:00
|
|
|
struct mlx4_en_rx_ring **pring,
|
|
|
|
u32 size, u16 stride)
|
2008-10-23 05:47:49 +07:00
|
|
|
{
|
|
|
|
struct mlx4_en_dev *mdev = priv->mdev;
|
2013-11-07 17:19:52 +07:00
|
|
|
struct mlx4_en_rx_ring *ring = *pring;
|
2016-07-21 07:22:33 +07:00
|
|
|
struct bpf_prog *old_prog;
|
2008-10-23 05:47:49 +07:00
|
|
|
|
net/mlx4_en: protect ring->xdp_prog with rcu_read_lock
Depending on the preempt mode, the bpf_prog stored in xdp_prog may be
freed despite the use of call_rcu inside bpf_prog_put. The situation is
possible when running in PREEMPT_RCU=y mode, for instance, since the rcu
callback for destroying the bpf prog can run even during the bh handling
in the mlx4 rx path.
Several options were considered before this patch was settled on:
Add a napi_synchronize loop in mlx4_xdp_set, which would occur after all
of the rings are updated with the new program.
This approach has the disadvantage that as the number of rings
increases, the speed of update will slow down significantly due to
napi_synchronize's msleep(1).
Add a new rcu_head in bpf_prog_aux, to be used by a new bpf_prog_put_bh.
The action of the bpf_prog_put_bh would be to then call bpf_prog_put
later. Those drivers that consume a bpf prog in a bh context (like mlx4)
would then use the bpf_prog_put_bh instead when the ring is up. This has
the problem of complexity, in maintaining proper refcnts and rcu lists,
and would likely be harder to review. In addition, this approach to
freeing must be exclusive with other frees of the bpf prog, for instance
a _bh prog must not be referenced from a prog array that is consumed by
a non-_bh prog.
The placement of rcu_read_lock in this patch is functionally the same as
putting an rcu_read_lock in napi_poll. Actually doing so could be a
potentially controversial change, but would bring the implementation in
line with sk_busy_loop (though of course the nature of those two paths
is substantially different), and would also avoid future copy/paste
problems with future supporters of XDP. Still, this patch does not take
that opinionated option.
Testing was done with kernels in either PREEMPT_RCU=y or
CONFIG_PREEMPT_VOLUNTARY=y+PREEMPT_RCU=n modes, with neither exhibiting
any drawback. With PREEMPT_RCU=n, the extra call to rcu_read_lock did
not show up in the perf report whatsoever, and with PREEMPT_RCU=y the
overhead of rcu_read_lock (according to perf) was the same before/after.
In the rx path, rcu_read_lock is eventually called for every packet
from netif_receive_skb_internal, so the napi poll call's rcu_read_lock
is easily amortized.
v2:
Remove extra rcu_read_lock in mlx4_en_process_rx_cq body
Annotate xdp_prog with __rcu, and convert all usages to rcu_assign or
rcu_dereference[_protected] as appropriate.
Add explicit mutex lock around rcu_assign instead of xchg loop.
Fixes: d576acf0a22 ("net/mlx4_en: add page recycle to prepare rx ring for tx support")
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Signed-off-by: Brenden Blanco <bblanco@plumgrid.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2016-09-04 11:29:58 +07:00
|
|
|
old_prog = rcu_dereference_protected(
|
|
|
|
ring->xdp_prog,
|
|
|
|
lockdep_is_held(&mdev->state_lock));
|
2016-07-21 07:22:33 +07:00
|
|
|
if (old_prog)
|
|
|
|
bpf_prog_put(old_prog);
|
2012-02-06 15:39:49 +07:00
|
|
|
mlx4_free_hwq_res(mdev->dev, &ring->wqres, size * stride + TXBB_SIZE);
|
2008-10-23 05:47:49 +07:00
|
|
|
vfree(ring->rx_info);
|
|
|
|
ring->rx_info = NULL;
|
2013-11-07 17:19:52 +07:00
|
|
|
kfree(ring);
|
|
|
|
*pring = NULL;
|
2008-10-23 05:47:49 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
void mlx4_en_deactivate_rx_ring(struct mlx4_en_priv *priv,
|
|
|
|
struct mlx4_en_rx_ring *ring)
|
|
|
|
{
|
2016-07-20 02:16:52 +07:00
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < ring->page_cache.index; i++) {
|
|
|
|
struct mlx4_en_rx_alloc *frame = &ring->page_cache.buf[i];
|
|
|
|
|
|
|
|
dma_unmap_page(priv->ddev, frame->dma, frame->page_size,
|
|
|
|
priv->frag_info[0].dma_dir);
|
|
|
|
put_page(frame->page);
|
|
|
|
}
|
|
|
|
ring->page_cache.index = 0;
|
2008-10-23 05:47:49 +07:00
|
|
|
mlx4_en_free_rx_buf(priv, ring);
|
2009-08-07 09:28:18 +07:00
|
|
|
if (ring->stride <= TXBB_SIZE)
|
|
|
|
ring->buf -= TXBB_SIZE;
|
2008-10-23 05:47:49 +07:00
|
|
|
mlx4_en_destroy_allocator(priv, ring);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static int mlx4_en_complete_rx_desc(struct mlx4_en_priv *priv,
|
|
|
|
struct mlx4_en_rx_desc *rx_desc,
|
2012-07-16 14:01:53 +07:00
|
|
|
struct mlx4_en_rx_alloc *frags,
|
2011-10-20 01:49:52 +07:00
|
|
|
struct sk_buff *skb,
|
2008-10-23 05:47:49 +07:00
|
|
|
int length)
|
|
|
|
{
|
2011-10-20 01:49:52 +07:00
|
|
|
struct skb_frag_struct *skb_frags_rx = skb_shinfo(skb)->frags;
|
2008-10-23 05:47:49 +07:00
|
|
|
struct mlx4_en_frag_info *frag_info;
|
|
|
|
int nr;
|
|
|
|
dma_addr_t dma;
|
|
|
|
|
2012-07-16 14:01:53 +07:00
|
|
|
/* Collect used fragments while replacing them in the HW descriptors */
|
2008-10-23 05:47:49 +07:00
|
|
|
for (nr = 0; nr < priv->num_frags; nr++) {
|
|
|
|
frag_info = &priv->frag_info[nr];
|
|
|
|
if (length <= frag_info->frag_prefix_size)
|
|
|
|
break;
|
2016-09-20 18:39:39 +07:00
|
|
|
if (unlikely(!frags[nr].page))
|
2012-07-16 14:01:53 +07:00
|
|
|
goto fail;
|
2008-10-23 05:47:49 +07:00
|
|
|
|
|
|
|
dma = be64_to_cpu(rx_desc->data[nr].addr);
|
2012-07-16 14:01:53 +07:00
|
|
|
dma_sync_single_for_cpu(priv->ddev, dma, frag_info->frag_size,
|
|
|
|
DMA_FROM_DEVICE);
|
2008-10-23 05:47:49 +07:00
|
|
|
|
2012-07-16 14:01:53 +07:00
|
|
|
/* Save page reference in skb */
|
|
|
|
__skb_frag_set_page(&skb_frags_rx[nr], frags[nr].page);
|
|
|
|
skb_frag_size_set(&skb_frags_rx[nr], frag_info->frag_size);
|
2013-10-07 18:38:12 +07:00
|
|
|
skb_frags_rx[nr].page_offset = frags[nr].page_offset;
|
2012-07-16 14:01:53 +07:00
|
|
|
skb->truesize += frag_info->frag_stride;
|
2013-06-23 22:17:56 +07:00
|
|
|
frags[nr].page = NULL;
|
2008-10-23 05:47:49 +07:00
|
|
|
}
|
|
|
|
/* Adjust size of last fragment to match actual length */
|
2009-08-09 06:54:21 +07:00
|
|
|
if (nr > 0)
|
2011-10-19 04:00:24 +07:00
|
|
|
skb_frag_size_set(&skb_frags_rx[nr - 1],
|
|
|
|
length - priv->frag_info[nr - 1].frag_prefix_size);
|
2008-10-23 05:47:49 +07:00
|
|
|
return nr;
|
|
|
|
|
|
|
|
fail:
|
|
|
|
while (nr > 0) {
|
|
|
|
nr--;
|
2011-10-20 06:01:45 +07:00
|
|
|
__skb_frag_unref(&skb_frags_rx[nr]);
|
2008-10-23 05:47:49 +07:00
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static struct sk_buff *mlx4_en_rx_skb(struct mlx4_en_priv *priv,
|
|
|
|
struct mlx4_en_rx_desc *rx_desc,
|
2012-07-16 14:01:53 +07:00
|
|
|
struct mlx4_en_rx_alloc *frags,
|
2008-10-23 05:47:49 +07:00
|
|
|
unsigned int length)
|
|
|
|
{
|
|
|
|
struct sk_buff *skb;
|
|
|
|
void *va;
|
|
|
|
int used_frags;
|
|
|
|
dma_addr_t dma;
|
|
|
|
|
2012-02-05 09:50:38 +07:00
|
|
|
skb = netdev_alloc_skb(priv->dev, SMALL_PACKET_SIZE + NET_IP_ALIGN);
|
2016-09-20 18:39:39 +07:00
|
|
|
if (unlikely(!skb)) {
|
2009-06-02 03:27:13 +07:00
|
|
|
en_dbg(RX_ERR, priv, "Failed allocating skb\n");
|
2008-10-23 05:47:49 +07:00
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
skb_reserve(skb, NET_IP_ALIGN);
|
|
|
|
skb->len = length;
|
|
|
|
|
|
|
|
/* Get pointer to first fragment so we could copy the headers into the
|
|
|
|
* (linear part of the) skb */
|
2013-10-07 18:38:12 +07:00
|
|
|
va = page_address(frags[0].page) + frags[0].page_offset;
|
2008-10-23 05:47:49 +07:00
|
|
|
|
|
|
|
if (length <= SMALL_PACKET_SIZE) {
|
|
|
|
/* We are copying all relevant data to the skb - temporarily
|
2012-07-16 14:01:53 +07:00
|
|
|
* sync buffers for the copy */
|
2008-10-23 05:47:49 +07:00
|
|
|
dma = be64_to_cpu(rx_desc->data[0].addr);
|
2012-03-06 11:03:34 +07:00
|
|
|
dma_sync_single_for_cpu(priv->ddev, dma, length,
|
2010-02-05 01:57:42 +07:00
|
|
|
DMA_FROM_DEVICE);
|
2008-10-23 05:47:49 +07:00
|
|
|
skb_copy_to_linear_data(skb, va, length);
|
|
|
|
skb->tail += length;
|
|
|
|
} else {
|
2014-09-06 08:29:45 +07:00
|
|
|
unsigned int pull_len;
|
|
|
|
|
2008-10-23 05:47:49 +07:00
|
|
|
/* Move relevant fragments to skb */
|
2012-07-16 14:01:53 +07:00
|
|
|
used_frags = mlx4_en_complete_rx_desc(priv, rx_desc, frags,
|
|
|
|
skb, length);
|
2009-04-27 03:42:57 +07:00
|
|
|
if (unlikely(!used_frags)) {
|
|
|
|
kfree_skb(skb);
|
|
|
|
return NULL;
|
|
|
|
}
|
2008-10-23 05:47:49 +07:00
|
|
|
skb_shinfo(skb)->nr_frags = used_frags;
|
|
|
|
|
2014-09-06 08:29:45 +07:00
|
|
|
pull_len = eth_get_headlen(va, SMALL_PACKET_SIZE);
|
2008-10-23 05:47:49 +07:00
|
|
|
/* Copy headers into the skb linear buffer */
|
2014-09-06 08:29:45 +07:00
|
|
|
memcpy(skb->data, va, pull_len);
|
|
|
|
skb->tail += pull_len;
|
2008-10-23 05:47:49 +07:00
|
|
|
|
|
|
|
/* Skip headers in first fragment */
|
2014-09-06 08:29:45 +07:00
|
|
|
skb_shinfo(skb)->frags[0].page_offset += pull_len;
|
2008-10-23 05:47:49 +07:00
|
|
|
|
|
|
|
/* Adjust size of first fragment */
|
2014-09-06 08:29:45 +07:00
|
|
|
skb_frag_size_sub(&skb_shinfo(skb)->frags[0], pull_len);
|
|
|
|
skb->data_len = length - pull_len;
|
2008-10-23 05:47:49 +07:00
|
|
|
}
|
|
|
|
return skb;
|
|
|
|
}
|
|
|
|
|
2010-08-24 10:46:18 +07:00
|
|
|
static void validate_loopback(struct mlx4_en_priv *priv, struct sk_buff *skb)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
int offset = ETH_HLEN;
|
|
|
|
|
|
|
|
for (i = 0; i < MLX4_LOOPBACK_TEST_PAYLOAD; i++, offset++) {
|
|
|
|
if (*(skb->data + offset) != (unsigned char) (i & 0xff))
|
|
|
|
goto out_loopback;
|
|
|
|
}
|
|
|
|
/* Loopback found */
|
|
|
|
priv->loopback_ok = 1;
|
|
|
|
|
|
|
|
out_loopback:
|
|
|
|
dev_kfree_skb_any(skb);
|
|
|
|
}
|
2008-10-23 05:47:49 +07:00
|
|
|
|
2016-11-21 00:24:36 +07:00
|
|
|
static bool mlx4_en_refill_rx_buffers(struct mlx4_en_priv *priv,
|
|
|
|
struct mlx4_en_rx_ring *ring)
|
2012-07-16 14:01:53 +07:00
|
|
|
{
|
2016-11-21 00:24:36 +07:00
|
|
|
u32 missing = ring->actual_size - (ring->prod - ring->cons);
|
2012-07-16 14:01:53 +07:00
|
|
|
|
2016-11-21 00:24:36 +07:00
|
|
|
/* Try to batch allocations, but not too much. */
|
|
|
|
if (missing < 8)
|
|
|
|
return false;
|
|
|
|
do {
|
|
|
|
if (mlx4_en_prepare_rx_desc(priv, ring,
|
|
|
|
ring->prod & ring->size_mask,
|
2014-11-02 21:26:16 +07:00
|
|
|
GFP_ATOMIC | __GFP_COLD))
|
2012-07-16 14:01:53 +07:00
|
|
|
break;
|
|
|
|
ring->prod++;
|
2016-11-21 00:24:36 +07:00
|
|
|
} while (--missing);
|
|
|
|
|
|
|
|
return true;
|
2012-07-16 14:01:53 +07:00
|
|
|
}
|
|
|
|
|
2014-11-09 18:51:53 +07:00
|
|
|
/* When hardware doesn't strip the vlan, we need to calculate the checksum
|
|
|
|
* over it and add it to the hardware's checksum calculation
|
|
|
|
*/
|
|
|
|
static inline __wsum get_fixed_vlan_csum(__wsum hw_checksum,
|
|
|
|
struct vlan_hdr *vlanh)
|
|
|
|
{
|
|
|
|
return csum_add(hw_checksum, *(__wsum *)vlanh);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Although the stack expects checksum which doesn't include the pseudo
|
|
|
|
* header, the HW adds it. To address that, we are subtracting the pseudo
|
|
|
|
* header checksum from the checksum value provided by the HW.
|
|
|
|
*/
|
|
|
|
static void get_fixed_ipv4_csum(__wsum hw_checksum, struct sk_buff *skb,
|
|
|
|
struct iphdr *iph)
|
|
|
|
{
|
|
|
|
__u16 length_for_csum = 0;
|
|
|
|
__wsum csum_pseudo_header = 0;
|
|
|
|
|
|
|
|
length_for_csum = (be16_to_cpu(iph->tot_len) - (iph->ihl << 2));
|
|
|
|
csum_pseudo_header = csum_tcpudp_nofold(iph->saddr, iph->daddr,
|
|
|
|
length_for_csum, iph->protocol, 0);
|
|
|
|
skb->csum = csum_sub(hw_checksum, csum_pseudo_header);
|
|
|
|
}
|
|
|
|
|
|
|
|
#if IS_ENABLED(CONFIG_IPV6)
|
|
|
|
/* In IPv6 packets, besides subtracting the pseudo header checksum,
|
|
|
|
* we also compute/add the IP header checksum which
|
|
|
|
* is not added by the HW.
|
|
|
|
*/
|
|
|
|
static int get_fixed_ipv6_csum(__wsum hw_checksum, struct sk_buff *skb,
|
|
|
|
struct ipv6hdr *ipv6h)
|
|
|
|
{
|
|
|
|
__wsum csum_pseudo_hdr = 0;
|
|
|
|
|
2016-09-20 18:39:39 +07:00
|
|
|
if (unlikely(ipv6h->nexthdr == IPPROTO_FRAGMENT ||
|
|
|
|
ipv6h->nexthdr == IPPROTO_HOPOPTS))
|
2014-11-09 18:51:53 +07:00
|
|
|
return -1;
|
2016-05-04 19:00:33 +07:00
|
|
|
hw_checksum = csum_add(hw_checksum, (__force __wsum)htons(ipv6h->nexthdr));
|
2014-11-09 18:51:53 +07:00
|
|
|
|
|
|
|
csum_pseudo_hdr = csum_partial(&ipv6h->saddr,
|
|
|
|
sizeof(ipv6h->saddr) + sizeof(ipv6h->daddr), 0);
|
|
|
|
csum_pseudo_hdr = csum_add(csum_pseudo_hdr, (__force __wsum)ipv6h->payload_len);
|
|
|
|
csum_pseudo_hdr = csum_add(csum_pseudo_hdr, (__force __wsum)ntohs(ipv6h->nexthdr));
|
|
|
|
|
|
|
|
skb->csum = csum_sub(hw_checksum, csum_pseudo_hdr);
|
|
|
|
skb->csum = csum_add(skb->csum, csum_partial(ipv6h, sizeof(struct ipv6hdr), 0));
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
static int check_csum(struct mlx4_cqe *cqe, struct sk_buff *skb, void *va,
|
2015-06-25 15:29:43 +07:00
|
|
|
netdev_features_t dev_features)
|
2014-11-09 18:51:53 +07:00
|
|
|
{
|
|
|
|
__wsum hw_checksum = 0;
|
|
|
|
|
|
|
|
void *hdr = (u8 *)va + sizeof(struct ethhdr);
|
|
|
|
|
|
|
|
hw_checksum = csum_unfold((__force __sum16)cqe->checksum);
|
|
|
|
|
2015-07-27 18:46:33 +07:00
|
|
|
if (cqe->vlan_my_qpn & cpu_to_be32(MLX4_CQE_CVLAN_PRESENT_MASK) &&
|
2015-06-25 15:29:43 +07:00
|
|
|
!(dev_features & NETIF_F_HW_VLAN_CTAG_RX)) {
|
2014-11-09 18:51:53 +07:00
|
|
|
hw_checksum = get_fixed_vlan_csum(hw_checksum, hdr);
|
|
|
|
hdr += sizeof(struct vlan_hdr);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (cqe->status & cpu_to_be16(MLX4_CQE_STATUS_IPV4))
|
|
|
|
get_fixed_ipv4_csum(hw_checksum, skb, hdr);
|
|
|
|
#if IS_ENABLED(CONFIG_IPV6)
|
|
|
|
else if (cqe->status & cpu_to_be16(MLX4_CQE_STATUS_IPV6))
|
2016-09-20 18:39:39 +07:00
|
|
|
if (unlikely(get_fixed_ipv6_csum(hw_checksum, skb, hdr)))
|
2014-11-09 18:51:53 +07:00
|
|
|
return -1;
|
|
|
|
#endif
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-10-23 05:47:49 +07:00
|
|
|
int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int budget)
|
|
|
|
{
|
|
|
|
struct mlx4_en_priv *priv = netdev_priv(dev);
|
2013-04-23 13:06:49 +07:00
|
|
|
struct mlx4_en_dev *mdev = priv->mdev;
|
2008-10-23 05:47:49 +07:00
|
|
|
struct mlx4_cqe *cqe;
|
2013-11-07 17:19:52 +07:00
|
|
|
struct mlx4_en_rx_ring *ring = priv->rx_ring[cq->ring];
|
2012-07-16 14:01:53 +07:00
|
|
|
struct mlx4_en_rx_alloc *frags;
|
2008-10-23 05:47:49 +07:00
|
|
|
struct mlx4_en_rx_desc *rx_desc;
|
2016-07-20 02:16:50 +07:00
|
|
|
struct bpf_prog *xdp_prog;
|
2016-07-20 02:16:55 +07:00
|
|
|
int doorbell_pending;
|
2008-10-23 05:47:49 +07:00
|
|
|
struct sk_buff *skb;
|
|
|
|
int index;
|
|
|
|
int nr;
|
|
|
|
unsigned int length;
|
|
|
|
int polled = 0;
|
|
|
|
int ip_summed;
|
2012-10-21 21:59:24 +07:00
|
|
|
int factor = priv->cqe_factor;
|
2013-04-23 13:06:49 +07:00
|
|
|
u64 timestamp;
|
2013-12-23 21:09:44 +07:00
|
|
|
bool l2_tunnel;
|
2008-10-23 05:47:49 +07:00
|
|
|
|
2016-09-20 18:39:39 +07:00
|
|
|
if (unlikely(!priv->port_up))
|
2008-10-23 05:47:49 +07:00
|
|
|
return 0;
|
|
|
|
|
2016-09-20 18:39:39 +07:00
|
|
|
if (unlikely(budget <= 0))
|
2014-03-15 08:05:58 +07:00
|
|
|
return polled;
|
|
|
|
|
net/mlx4_en: protect ring->xdp_prog with rcu_read_lock
Depending on the preempt mode, the bpf_prog stored in xdp_prog may be
freed despite the use of call_rcu inside bpf_prog_put. The situation is
possible when running in PREEMPT_RCU=y mode, for instance, since the rcu
callback for destroying the bpf prog can run even during the bh handling
in the mlx4 rx path.
Several options were considered before this patch was settled on:
Add a napi_synchronize loop in mlx4_xdp_set, which would occur after all
of the rings are updated with the new program.
This approach has the disadvantage that as the number of rings
increases, the speed of update will slow down significantly due to
napi_synchronize's msleep(1).
Add a new rcu_head in bpf_prog_aux, to be used by a new bpf_prog_put_bh.
The action of the bpf_prog_put_bh would be to then call bpf_prog_put
later. Those drivers that consume a bpf prog in a bh context (like mlx4)
would then use the bpf_prog_put_bh instead when the ring is up. This has
the problem of complexity, in maintaining proper refcnts and rcu lists,
and would likely be harder to review. In addition, this approach to
freeing must be exclusive with other frees of the bpf prog, for instance
a _bh prog must not be referenced from a prog array that is consumed by
a non-_bh prog.
The placement of rcu_read_lock in this patch is functionally the same as
putting an rcu_read_lock in napi_poll. Actually doing so could be a
potentially controversial change, but would bring the implementation in
line with sk_busy_loop (though of course the nature of those two paths
is substantially different), and would also avoid future copy/paste
problems with future supporters of XDP. Still, this patch does not take
that opinionated option.
Testing was done with kernels in either PREEMPT_RCU=y or
CONFIG_PREEMPT_VOLUNTARY=y+PREEMPT_RCU=n modes, with neither exhibiting
any drawback. With PREEMPT_RCU=n, the extra call to rcu_read_lock did
not show up in the perf report whatsoever, and with PREEMPT_RCU=y the
overhead of rcu_read_lock (according to perf) was the same before/after.
In the rx path, rcu_read_lock is eventually called for every packet
from netif_receive_skb_internal, so the napi poll call's rcu_read_lock
is easily amortized.
v2:
Remove extra rcu_read_lock in mlx4_en_process_rx_cq body
Annotate xdp_prog with __rcu, and convert all usages to rcu_assign or
rcu_dereference[_protected] as appropriate.
Add explicit mutex lock around rcu_assign instead of xchg loop.
Fixes: d576acf0a22 ("net/mlx4_en: add page recycle to prepare rx ring for tx support")
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Signed-off-by: Brenden Blanco <bblanco@plumgrid.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2016-09-04 11:29:58 +07:00
|
|
|
/* Protect accesses to: ring->xdp_prog, priv->mac_hash list */
|
|
|
|
rcu_read_lock();
|
|
|
|
xdp_prog = rcu_dereference(ring->xdp_prog);
|
2016-07-20 02:16:55 +07:00
|
|
|
doorbell_pending = 0;
|
2016-07-20 02:16:50 +07:00
|
|
|
|
2008-10-23 05:47:49 +07:00
|
|
|
/* We assume a 1:1 mapping between CQEs and Rx descriptors, so Rx
|
|
|
|
* descriptor offset can be deduced from the CQE index instead of
|
|
|
|
* reading 'cqe->index' */
|
|
|
|
index = cq->mcq.cons_index & ring->size_mask;
|
2014-09-18 15:51:01 +07:00
|
|
|
cqe = mlx4_en_get_cqe(cq->buf, index, priv->cqe_size) + factor;
|
2008-10-23 05:47:49 +07:00
|
|
|
|
|
|
|
/* Process all completed CQEs */
|
|
|
|
while (XNOR(cqe->owner_sr_opcode & MLX4_CQE_OWNER_MASK,
|
|
|
|
cq->mcq.cons_index & cq->size)) {
|
|
|
|
|
2012-07-16 14:01:53 +07:00
|
|
|
frags = ring->rx_info + (index << priv->log_rx_info);
|
2008-10-23 05:47:49 +07:00
|
|
|
rx_desc = ring->buf + (index << ring->log_stride);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* make sure we read the CQE after we read the ownership bit
|
|
|
|
*/
|
2015-04-09 08:49:36 +07:00
|
|
|
dma_rmb();
|
2008-10-23 05:47:49 +07:00
|
|
|
|
|
|
|
/* Drop packet on bad receive or bad checksum */
|
|
|
|
if (unlikely((cqe->owner_sr_opcode & MLX4_CQE_OPCODE_MASK) ==
|
|
|
|
MLX4_CQE_OPCODE_ERROR)) {
|
2014-05-08 02:52:57 +07:00
|
|
|
en_err(priv, "CQE completed in error - vendor syndrom:%d syndrom:%d\n",
|
|
|
|
((struct mlx4_err_cqe *)cqe)->vendor_err_syndrome,
|
|
|
|
((struct mlx4_err_cqe *)cqe)->syndrome);
|
2008-10-23 05:47:49 +07:00
|
|
|
goto next;
|
|
|
|
}
|
|
|
|
if (unlikely(cqe->badfcs_enc & MLX4_CQE_BAD_FCS)) {
|
2009-06-02 03:27:13 +07:00
|
|
|
en_dbg(RX_ERR, priv, "Accepted frame with bad FCS\n");
|
2008-10-23 05:47:49 +07:00
|
|
|
goto next;
|
|
|
|
}
|
|
|
|
|
2013-02-07 09:25:19 +07:00
|
|
|
/* Check if we need to drop the packet if SRIOV is not enabled
|
|
|
|
* and not performing the selftest or flb disabled
|
|
|
|
*/
|
|
|
|
if (priv->flags & MLX4_EN_FLAG_RX_FILTER_NEEDED) {
|
|
|
|
struct ethhdr *ethh;
|
|
|
|
dma_addr_t dma;
|
|
|
|
/* Get pointer to first fragment since we haven't
|
|
|
|
* skb yet and cast it to ethhdr struct
|
|
|
|
*/
|
|
|
|
dma = be64_to_cpu(rx_desc->data[0].addr);
|
|
|
|
dma_sync_single_for_cpu(priv->ddev, dma, sizeof(*ethh),
|
|
|
|
DMA_FROM_DEVICE);
|
|
|
|
ethh = (struct ethhdr *)(page_address(frags[0].page) +
|
2013-10-07 18:38:12 +07:00
|
|
|
frags[0].page_offset);
|
2013-02-07 09:25:19 +07:00
|
|
|
|
2013-02-07 09:25:25 +07:00
|
|
|
if (is_multicast_ether_addr(ethh->h_dest)) {
|
|
|
|
struct mlx4_mac_entry *entry;
|
|
|
|
struct hlist_head *bucket;
|
|
|
|
unsigned int mac_hash;
|
|
|
|
|
|
|
|
/* Drop the packet, since HW loopback-ed it */
|
|
|
|
mac_hash = ethh->h_source[MLX4_EN_MAC_HASH_IDX];
|
|
|
|
bucket = &priv->mac_hash[mac_hash];
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 08:06:00 +07:00
|
|
|
hlist_for_each_entry_rcu(entry, bucket, hlist) {
|
2013-02-07 09:25:25 +07:00
|
|
|
if (ether_addr_equal_64bits(entry->mac,
|
net/mlx4_en: protect ring->xdp_prog with rcu_read_lock
Depending on the preempt mode, the bpf_prog stored in xdp_prog may be
freed despite the use of call_rcu inside bpf_prog_put. The situation is
possible when running in PREEMPT_RCU=y mode, for instance, since the rcu
callback for destroying the bpf prog can run even during the bh handling
in the mlx4 rx path.
Several options were considered before this patch was settled on:
Add a napi_synchronize loop in mlx4_xdp_set, which would occur after all
of the rings are updated with the new program.
This approach has the disadvantage that as the number of rings
increases, the speed of update will slow down significantly due to
napi_synchronize's msleep(1).
Add a new rcu_head in bpf_prog_aux, to be used by a new bpf_prog_put_bh.
The action of the bpf_prog_put_bh would be to then call bpf_prog_put
later. Those drivers that consume a bpf prog in a bh context (like mlx4)
would then use the bpf_prog_put_bh instead when the ring is up. This has
the problem of complexity, in maintaining proper refcnts and rcu lists,
and would likely be harder to review. In addition, this approach to
freeing must be exclusive with other frees of the bpf prog, for instance
a _bh prog must not be referenced from a prog array that is consumed by
a non-_bh prog.
The placement of rcu_read_lock in this patch is functionally the same as
putting an rcu_read_lock in napi_poll. Actually doing so could be a
potentially controversial change, but would bring the implementation in
line with sk_busy_loop (though of course the nature of those two paths
is substantially different), and would also avoid future copy/paste
problems with future supporters of XDP. Still, this patch does not take
that opinionated option.
Testing was done with kernels in either PREEMPT_RCU=y or
CONFIG_PREEMPT_VOLUNTARY=y+PREEMPT_RCU=n modes, with neither exhibiting
any drawback. With PREEMPT_RCU=n, the extra call to rcu_read_lock did
not show up in the perf report whatsoever, and with PREEMPT_RCU=y the
overhead of rcu_read_lock (according to perf) was the same before/after.
In the rx path, rcu_read_lock is eventually called for every packet
from netif_receive_skb_internal, so the napi poll call's rcu_read_lock
is easily amortized.
v2:
Remove extra rcu_read_lock in mlx4_en_process_rx_cq body
Annotate xdp_prog with __rcu, and convert all usages to rcu_assign or
rcu_dereference[_protected] as appropriate.
Add explicit mutex lock around rcu_assign instead of xchg loop.
Fixes: d576acf0a22 ("net/mlx4_en: add page recycle to prepare rx ring for tx support")
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Signed-off-by: Brenden Blanco <bblanco@plumgrid.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2016-09-04 11:29:58 +07:00
|
|
|
ethh->h_source))
|
2013-02-07 09:25:25 +07:00
|
|
|
goto next;
|
|
|
|
}
|
|
|
|
}
|
2013-02-07 09:25:19 +07:00
|
|
|
}
|
2011-12-13 11:16:38 +07:00
|
|
|
|
2008-10-23 05:47:49 +07:00
|
|
|
/*
|
|
|
|
* Packet is OK - process it.
|
|
|
|
*/
|
|
|
|
length = be32_to_cpu(cqe->byte_cnt);
|
2011-11-15 02:25:36 +07:00
|
|
|
length -= ring->fcs_del;
|
2013-12-23 21:09:44 +07:00
|
|
|
l2_tunnel = (dev->hw_enc_features & NETIF_F_RXCSUM) &&
|
|
|
|
(cqe->vlan_my_qpn & cpu_to_be32(MLX4_CQE_L2_TUNNEL));
|
2008-10-23 05:47:49 +07:00
|
|
|
|
2016-07-20 02:16:50 +07:00
|
|
|
/* A bpf program gets first chance to drop the packet. It may
|
|
|
|
* read bytes but not past the end of the frag.
|
|
|
|
*/
|
|
|
|
if (xdp_prog) {
|
|
|
|
struct xdp_buff xdp;
|
|
|
|
dma_addr_t dma;
|
2016-12-08 06:53:13 +07:00
|
|
|
void *orig_data;
|
2016-07-20 02:16:50 +07:00
|
|
|
u32 act;
|
|
|
|
|
|
|
|
dma = be64_to_cpu(rx_desc->data[0].addr);
|
|
|
|
dma_sync_single_for_cpu(priv->ddev, dma,
|
|
|
|
priv->frag_info[0].frag_size,
|
|
|
|
DMA_FROM_DEVICE);
|
|
|
|
|
2016-12-08 06:53:13 +07:00
|
|
|
xdp.data_hard_start = page_address(frags[0].page);
|
|
|
|
xdp.data = xdp.data_hard_start + frags[0].page_offset;
|
2016-07-20 02:16:50 +07:00
|
|
|
xdp.data_end = xdp.data + length;
|
2016-12-08 06:53:13 +07:00
|
|
|
orig_data = xdp.data;
|
2016-07-20 02:16:50 +07:00
|
|
|
|
|
|
|
act = bpf_prog_run_xdp(xdp_prog, &xdp);
|
2016-12-08 06:53:13 +07:00
|
|
|
|
|
|
|
if (xdp.data != orig_data) {
|
|
|
|
length = xdp.data_end - xdp.data;
|
|
|
|
frags[0].page_offset = xdp.data -
|
|
|
|
xdp.data_hard_start;
|
|
|
|
}
|
|
|
|
|
2016-07-20 02:16:50 +07:00
|
|
|
switch (act) {
|
|
|
|
case XDP_PASS:
|
|
|
|
break;
|
2016-07-20 02:16:55 +07:00
|
|
|
case XDP_TX:
|
2016-11-02 22:12:25 +07:00
|
|
|
if (likely(!mlx4_en_xmit_frame(ring, frags, dev,
|
2016-11-02 22:12:24 +07:00
|
|
|
length, cq->ring,
|
2016-09-20 18:39:39 +07:00
|
|
|
&doorbell_pending)))
|
2016-07-20 02:16:55 +07:00
|
|
|
goto consumed;
|
2016-11-02 22:12:25 +07:00
|
|
|
goto xdp_drop_no_cnt; /* Drop on xmit failure */
|
2016-07-20 02:16:50 +07:00
|
|
|
default:
|
|
|
|
bpf_warn_invalid_xdp_action(act);
|
|
|
|
case XDP_ABORTED:
|
|
|
|
case XDP_DROP:
|
2016-11-02 22:12:25 +07:00
|
|
|
ring->xdp_drop++;
|
|
|
|
xdp_drop_no_cnt:
|
2016-09-20 18:39:39 +07:00
|
|
|
if (likely(mlx4_en_rx_recycle(ring, frags)))
|
2016-07-20 02:16:52 +07:00
|
|
|
goto consumed;
|
2016-07-20 02:16:50 +07:00
|
|
|
goto next;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-11-02 22:12:25 +07:00
|
|
|
ring->bytes += length;
|
|
|
|
ring->packets++;
|
|
|
|
|
2011-04-15 11:50:49 +07:00
|
|
|
if (likely(dev->features & NETIF_F_RXCSUM)) {
|
2014-11-09 18:51:53 +07:00
|
|
|
if (cqe->status & cpu_to_be16(MLX4_CQE_STATUS_TCP |
|
|
|
|
MLX4_CQE_STATUS_UDP)) {
|
|
|
|
if ((cqe->status & cpu_to_be16(MLX4_CQE_STATUS_IPOK)) &&
|
|
|
|
cqe->checksum == cpu_to_be16(0xffff)) {
|
|
|
|
ip_summed = CHECKSUM_UNNECESSARY;
|
|
|
|
ring->csum_ok++;
|
|
|
|
} else {
|
|
|
|
ip_summed = CHECKSUM_NONE;
|
|
|
|
ring->csum_none++;
|
|
|
|
}
|
2008-10-23 05:47:49 +07:00
|
|
|
} else {
|
2014-11-09 18:51:53 +07:00
|
|
|
if (priv->flags & MLX4_EN_FLAG_RX_CSUM_NON_TCP_UDP &&
|
|
|
|
(cqe->status & cpu_to_be16(MLX4_CQE_STATUS_IPV4 |
|
|
|
|
MLX4_CQE_STATUS_IPV6))) {
|
|
|
|
ip_summed = CHECKSUM_COMPLETE;
|
|
|
|
ring->csum_complete++;
|
|
|
|
} else {
|
|
|
|
ip_summed = CHECKSUM_NONE;
|
|
|
|
ring->csum_none++;
|
|
|
|
}
|
2008-10-23 05:47:49 +07:00
|
|
|
}
|
|
|
|
} else {
|
|
|
|
ip_summed = CHECKSUM_NONE;
|
2011-10-18 08:50:56 +07:00
|
|
|
ring->csum_none++;
|
2008-10-23 05:47:49 +07:00
|
|
|
}
|
|
|
|
|
2014-11-09 18:51:52 +07:00
|
|
|
/* This packet is eligible for GRO if it is:
|
|
|
|
* - DIX Ethernet (type interpretation)
|
|
|
|
* - TCP/IP (v4)
|
|
|
|
* - without IP options
|
|
|
|
* - not an IP fragment
|
|
|
|
*/
|
2015-11-18 21:30:58 +07:00
|
|
|
if (dev->features & NETIF_F_GRO) {
|
2014-11-09 18:51:52 +07:00
|
|
|
struct sk_buff *gro_skb = napi_get_frags(&cq->napi);
|
|
|
|
if (!gro_skb)
|
|
|
|
goto next;
|
|
|
|
|
|
|
|
nr = mlx4_en_complete_rx_desc(priv,
|
|
|
|
rx_desc, frags, gro_skb,
|
|
|
|
length);
|
|
|
|
if (!nr)
|
|
|
|
goto next;
|
|
|
|
|
2014-11-09 18:51:53 +07:00
|
|
|
if (ip_summed == CHECKSUM_COMPLETE) {
|
|
|
|
void *va = skb_frag_address(skb_shinfo(gro_skb)->frags);
|
2015-06-25 15:29:43 +07:00
|
|
|
if (check_csum(cqe, gro_skb, va,
|
|
|
|
dev->features)) {
|
2014-11-09 18:51:53 +07:00
|
|
|
ip_summed = CHECKSUM_NONE;
|
|
|
|
ring->csum_none++;
|
|
|
|
ring->csum_complete--;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-11-09 18:51:52 +07:00
|
|
|
skb_shinfo(gro_skb)->nr_frags = nr;
|
|
|
|
gro_skb->len = length;
|
|
|
|
gro_skb->data_len = length;
|
|
|
|
gro_skb->ip_summed = ip_summed;
|
|
|
|
|
|
|
|
if (l2_tunnel && ip_summed == CHECKSUM_UNNECESSARY)
|
2014-12-11 15:57:51 +07:00
|
|
|
gro_skb->csum_level = 1;
|
|
|
|
|
2014-11-09 18:51:52 +07:00
|
|
|
if ((cqe->vlan_my_qpn &
|
2015-07-27 18:46:33 +07:00
|
|
|
cpu_to_be32(MLX4_CQE_CVLAN_PRESENT_MASK)) &&
|
2014-11-09 18:51:52 +07:00
|
|
|
(dev->features & NETIF_F_HW_VLAN_CTAG_RX)) {
|
|
|
|
u16 vid = be16_to_cpu(cqe->sl_vid);
|
|
|
|
|
|
|
|
__vlan_hwaccel_put_tag(gro_skb, htons(ETH_P_8021Q), vid);
|
2015-07-27 18:46:34 +07:00
|
|
|
} else if ((be32_to_cpu(cqe->vlan_my_qpn) &
|
|
|
|
MLX4_CQE_SVLAN_PRESENT_MASK) &&
|
|
|
|
(dev->features & NETIF_F_HW_VLAN_STAG_RX)) {
|
|
|
|
__vlan_hwaccel_put_tag(gro_skb,
|
|
|
|
htons(ETH_P_8021AD),
|
|
|
|
be16_to_cpu(cqe->sl_vid));
|
2014-11-09 18:51:52 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
if (dev->features & NETIF_F_RXHASH)
|
|
|
|
skb_set_hash(gro_skb,
|
|
|
|
be32_to_cpu(cqe->immed_rss_invalid),
|
2015-07-02 18:24:44 +07:00
|
|
|
(ip_summed == CHECKSUM_UNNECESSARY) ?
|
|
|
|
PKT_HASH_TYPE_L4 :
|
|
|
|
PKT_HASH_TYPE_L3);
|
2014-11-09 18:51:52 +07:00
|
|
|
|
|
|
|
skb_record_rx_queue(gro_skb, cq->ring);
|
|
|
|
|
|
|
|
if (ring->hwtstamp_rx_filter == HWTSTAMP_FILTER_ALL) {
|
|
|
|
timestamp = mlx4_en_get_cqe_ts(cqe);
|
|
|
|
mlx4_en_fill_hwtstamps(mdev,
|
|
|
|
skb_hwtstamps(gro_skb),
|
|
|
|
timestamp);
|
|
|
|
}
|
|
|
|
|
|
|
|
napi_gro_frags(&cq->napi);
|
|
|
|
goto next;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* GRO not possible, complete processing here */
|
2012-07-16 14:01:53 +07:00
|
|
|
skb = mlx4_en_rx_skb(priv, rx_desc, frags, length);
|
2016-09-20 18:39:39 +07:00
|
|
|
if (unlikely(!skb)) {
|
2016-04-20 20:01:18 +07:00
|
|
|
ring->dropped++;
|
2008-10-23 05:47:49 +07:00
|
|
|
goto next;
|
|
|
|
}
|
|
|
|
|
2016-09-20 18:39:40 +07:00
|
|
|
if (unlikely(priv->validate_loopback)) {
|
2010-08-24 10:46:18 +07:00
|
|
|
validate_loopback(priv, skb);
|
|
|
|
goto next;
|
|
|
|
}
|
|
|
|
|
2014-11-09 18:51:53 +07:00
|
|
|
if (ip_summed == CHECKSUM_COMPLETE) {
|
2015-06-25 15:29:43 +07:00
|
|
|
if (check_csum(cqe, skb, skb->data, dev->features)) {
|
2014-11-09 18:51:53 +07:00
|
|
|
ip_summed = CHECKSUM_NONE;
|
|
|
|
ring->csum_complete--;
|
|
|
|
ring->csum_none++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-10-23 05:47:49 +07:00
|
|
|
skb->ip_summed = ip_summed;
|
|
|
|
skb->protocol = eth_type_trans(skb, dev);
|
2009-01-28 07:22:32 +07:00
|
|
|
skb_record_rx_queue(skb, cq->ring);
|
2008-10-23 05:47:49 +07:00
|
|
|
|
2014-08-28 11:27:53 +07:00
|
|
|
if (l2_tunnel && ip_summed == CHECKSUM_UNNECESSARY)
|
|
|
|
skb->csum_level = 1;
|
2013-12-23 21:09:44 +07:00
|
|
|
|
2011-10-18 08:51:24 +07:00
|
|
|
if (dev->features & NETIF_F_RXHASH)
|
2013-12-18 14:31:23 +07:00
|
|
|
skb_set_hash(skb,
|
|
|
|
be32_to_cpu(cqe->immed_rss_invalid),
|
2015-07-02 18:24:44 +07:00
|
|
|
(ip_summed == CHECKSUM_UNNECESSARY) ?
|
|
|
|
PKT_HASH_TYPE_L4 :
|
|
|
|
PKT_HASH_TYPE_L3);
|
2011-10-18 08:51:24 +07:00
|
|
|
|
2013-04-23 13:06:49 +07:00
|
|
|
if ((be32_to_cpu(cqe->vlan_my_qpn) &
|
2015-07-27 18:46:33 +07:00
|
|
|
MLX4_CQE_CVLAN_PRESENT_MASK) &&
|
2013-04-23 13:06:49 +07:00
|
|
|
(dev->features & NETIF_F_HW_VLAN_CTAG_RX))
|
2013-04-19 09:04:30 +07:00
|
|
|
__vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q), be16_to_cpu(cqe->sl_vid));
|
2015-07-27 18:46:34 +07:00
|
|
|
else if ((be32_to_cpu(cqe->vlan_my_qpn) &
|
|
|
|
MLX4_CQE_SVLAN_PRESENT_MASK) &&
|
|
|
|
(dev->features & NETIF_F_HW_VLAN_STAG_RX))
|
|
|
|
__vlan_hwaccel_put_tag(skb, htons(ETH_P_8021AD),
|
|
|
|
be16_to_cpu(cqe->sl_vid));
|
2011-07-20 11:54:22 +07:00
|
|
|
|
2013-04-23 13:06:49 +07:00
|
|
|
if (ring->hwtstamp_rx_filter == HWTSTAMP_FILTER_ALL) {
|
|
|
|
timestamp = mlx4_en_get_cqe_ts(cqe);
|
|
|
|
mlx4_en_fill_hwtstamps(mdev, skb_hwtstamps(skb),
|
|
|
|
timestamp);
|
|
|
|
}
|
|
|
|
|
2015-11-18 21:30:58 +07:00
|
|
|
napi_gro_receive(&cq->napi, skb);
|
2008-10-23 05:47:49 +07:00
|
|
|
next:
|
2012-07-16 14:01:53 +07:00
|
|
|
for (nr = 0; nr < priv->num_frags; nr++)
|
|
|
|
mlx4_en_free_frag(priv, frags, nr);
|
|
|
|
|
2016-07-20 02:16:52 +07:00
|
|
|
consumed:
|
2008-10-23 05:47:49 +07:00
|
|
|
++cq->mcq.cons_index;
|
|
|
|
index = (cq->mcq.cons_index) & ring->size_mask;
|
2014-09-18 15:51:01 +07:00
|
|
|
cqe = mlx4_en_get_cqe(cq->buf, index, priv->cqe_size) + factor;
|
2012-11-16 19:44:56 +07:00
|
|
|
if (++polled == budget)
|
2008-10-23 05:47:49 +07:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
out:
|
net/mlx4_en: protect ring->xdp_prog with rcu_read_lock
Depending on the preempt mode, the bpf_prog stored in xdp_prog may be
freed despite the use of call_rcu inside bpf_prog_put. The situation is
possible when running in PREEMPT_RCU=y mode, for instance, since the rcu
callback for destroying the bpf prog can run even during the bh handling
in the mlx4 rx path.
Several options were considered before this patch was settled on:
Add a napi_synchronize loop in mlx4_xdp_set, which would occur after all
of the rings are updated with the new program.
This approach has the disadvantage that as the number of rings
increases, the speed of update will slow down significantly due to
napi_synchronize's msleep(1).
Add a new rcu_head in bpf_prog_aux, to be used by a new bpf_prog_put_bh.
The action of the bpf_prog_put_bh would be to then call bpf_prog_put
later. Those drivers that consume a bpf prog in a bh context (like mlx4)
would then use the bpf_prog_put_bh instead when the ring is up. This has
the problem of complexity, in maintaining proper refcnts and rcu lists,
and would likely be harder to review. In addition, this approach to
freeing must be exclusive with other frees of the bpf prog, for instance
a _bh prog must not be referenced from a prog array that is consumed by
a non-_bh prog.
The placement of rcu_read_lock in this patch is functionally the same as
putting an rcu_read_lock in napi_poll. Actually doing so could be a
potentially controversial change, but would bring the implementation in
line with sk_busy_loop (though of course the nature of those two paths
is substantially different), and would also avoid future copy/paste
problems with future supporters of XDP. Still, this patch does not take
that opinionated option.
Testing was done with kernels in either PREEMPT_RCU=y or
CONFIG_PREEMPT_VOLUNTARY=y+PREEMPT_RCU=n modes, with neither exhibiting
any drawback. With PREEMPT_RCU=n, the extra call to rcu_read_lock did
not show up in the perf report whatsoever, and with PREEMPT_RCU=y the
overhead of rcu_read_lock (according to perf) was the same before/after.
In the rx path, rcu_read_lock is eventually called for every packet
from netif_receive_skb_internal, so the napi poll call's rcu_read_lock
is easily amortized.
v2:
Remove extra rcu_read_lock in mlx4_en_process_rx_cq body
Annotate xdp_prog with __rcu, and convert all usages to rcu_assign or
rcu_dereference[_protected] as appropriate.
Add explicit mutex lock around rcu_assign instead of xchg loop.
Fixes: d576acf0a22 ("net/mlx4_en: add page recycle to prepare rx ring for tx support")
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Signed-off-by: Brenden Blanco <bblanco@plumgrid.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2016-09-04 11:29:58 +07:00
|
|
|
rcu_read_unlock();
|
2016-07-20 02:16:55 +07:00
|
|
|
|
2016-11-21 00:24:36 +07:00
|
|
|
if (polled) {
|
|
|
|
if (doorbell_pending)
|
|
|
|
mlx4_en_xmit_doorbell(priv->tx_ring[TX_XDP][cq->ring]);
|
|
|
|
|
|
|
|
mlx4_cq_set_ci(&cq->mcq);
|
|
|
|
wmb(); /* ensure HW sees CQ consumer before we post new buffers */
|
|
|
|
ring->cons = cq->mcq.cons_index;
|
|
|
|
}
|
2008-10-23 05:47:49 +07:00
|
|
|
AVG_PERF_COUNTER(priv->pstats.rx_coal_avg, polled);
|
2016-11-21 00:24:36 +07:00
|
|
|
|
|
|
|
if (mlx4_en_refill_rx_buffers(priv, ring))
|
|
|
|
mlx4_en_update_rx_prod_db(ring);
|
|
|
|
|
2008-10-23 05:47:49 +07:00
|
|
|
return polled;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
void mlx4_en_rx_irq(struct mlx4_cq *mcq)
|
|
|
|
{
|
|
|
|
struct mlx4_en_cq *cq = container_of(mcq, struct mlx4_en_cq, mcq);
|
|
|
|
struct mlx4_en_priv *priv = netdev_priv(cq->dev);
|
|
|
|
|
2014-10-30 06:54:45 +07:00
|
|
|
if (likely(priv->port_up))
|
|
|
|
napi_schedule_irqoff(&cq->napi);
|
2008-10-23 05:47:49 +07:00
|
|
|
else
|
|
|
|
mlx4_en_arm_cq(priv, cq);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Rx CQ polling - called by NAPI */
|
|
|
|
int mlx4_en_poll_rx_cq(struct napi_struct *napi, int budget)
|
|
|
|
{
|
|
|
|
struct mlx4_en_cq *cq = container_of(napi, struct mlx4_en_cq, napi);
|
|
|
|
struct net_device *dev = cq->dev;
|
|
|
|
struct mlx4_en_priv *priv = netdev_priv(dev);
|
|
|
|
int done;
|
|
|
|
|
|
|
|
done = mlx4_en_process_rx_cq(dev, cq, budget);
|
|
|
|
|
|
|
|
/* If we used up all the quota - we're probably not done yet... */
|
2014-05-14 16:15:10 +07:00
|
|
|
if (done == budget) {
|
2014-06-29 15:54:55 +07:00
|
|
|
const struct cpumask *aff;
|
2015-09-15 18:34:05 +07:00
|
|
|
struct irq_data *idata;
|
|
|
|
int cpu_curr;
|
2014-06-29 15:54:55 +07:00
|
|
|
|
2008-10-23 05:47:49 +07:00
|
|
|
INC_PERF_COUNTER(priv->pstats.napi_quota);
|
2014-06-29 15:54:55 +07:00
|
|
|
|
|
|
|
cpu_curr = smp_processor_id();
|
2015-09-15 18:34:05 +07:00
|
|
|
idata = irq_desc_get_irq_data(cq->irq_desc);
|
|
|
|
aff = irq_data_get_affinity_mask(idata);
|
2014-06-29 15:54:55 +07:00
|
|
|
|
2014-11-11 05:07:20 +07:00
|
|
|
if (likely(cpumask_test_cpu(cpu_curr, aff)))
|
|
|
|
return budget;
|
|
|
|
|
|
|
|
/* Current cpu is not according to smp_irq_affinity -
|
2016-11-21 00:24:36 +07:00
|
|
|
* probably affinity changed. Need to stop this NAPI
|
|
|
|
* poll, and restart it on the right CPU.
|
|
|
|
* Try to avoid returning a too small value (like 0),
|
|
|
|
* to not fool net_rx_action() and its netdev_budget
|
2014-11-11 05:07:20 +07:00
|
|
|
*/
|
2016-11-21 00:24:36 +07:00
|
|
|
if (done)
|
|
|
|
done--;
|
2008-10-23 05:47:49 +07:00
|
|
|
}
|
2014-11-07 12:10:11 +07:00
|
|
|
/* Done for now */
|
2016-11-16 01:15:14 +07:00
|
|
|
if (napi_complete_done(napi, done))
|
|
|
|
mlx4_en_arm_cq(priv, cq);
|
2008-10-23 05:47:49 +07:00
|
|
|
return done;
|
|
|
|
}
|
|
|
|
|
2013-06-23 22:17:56 +07:00
|
|
|
static const int frag_sizes[] = {
|
2008-10-23 05:47:49 +07:00
|
|
|
FRAG_SZ0,
|
|
|
|
FRAG_SZ1,
|
|
|
|
FRAG_SZ2,
|
|
|
|
FRAG_SZ3
|
|
|
|
};
|
|
|
|
|
|
|
|
void mlx4_en_calc_rx_buf(struct net_device *dev)
|
|
|
|
{
|
|
|
|
struct mlx4_en_priv *priv = netdev_priv(dev);
|
2016-07-20 02:16:50 +07:00
|
|
|
int eff_mtu = MLX4_EN_EFF_MTU(dev->mtu);
|
2008-10-23 05:47:49 +07:00
|
|
|
int i = 0;
|
|
|
|
|
2016-07-20 02:16:52 +07:00
|
|
|
/* bpf requires buffers to be set up as 1 packet per page.
|
|
|
|
* This only works when num_frags == 1.
|
|
|
|
*/
|
2016-11-02 22:12:24 +07:00
|
|
|
if (priv->tx_ring_num[TX_XDP]) {
|
2016-12-08 06:53:12 +07:00
|
|
|
priv->frag_info[0].order = 0;
|
|
|
|
priv->frag_info[0].frag_size = eff_mtu;
|
|
|
|
priv->frag_info[0].frag_prefix_size = 0;
|
|
|
|
/* This will gain efficient xdp frame recycling at the
|
|
|
|
* expense of more costly truesize accounting
|
2016-07-20 02:16:52 +07:00
|
|
|
*/
|
2016-12-08 06:53:12 +07:00
|
|
|
priv->frag_info[0].frag_stride = PAGE_SIZE;
|
|
|
|
priv->frag_info[0].dma_dir = PCI_DMA_BIDIRECTIONAL;
|
2016-12-08 06:53:13 +07:00
|
|
|
priv->frag_info[0].rx_headroom = XDP_PACKET_HEADROOM;
|
2016-12-08 06:53:12 +07:00
|
|
|
i = 1;
|
|
|
|
} else {
|
|
|
|
int buf_size = 0;
|
|
|
|
|
|
|
|
while (buf_size < eff_mtu) {
|
|
|
|
priv->frag_info[i].order = MLX4_EN_ALLOC_PREFER_ORDER;
|
|
|
|
priv->frag_info[i].frag_size =
|
|
|
|
(eff_mtu > buf_size + frag_sizes[i]) ?
|
|
|
|
frag_sizes[i] : eff_mtu - buf_size;
|
|
|
|
priv->frag_info[i].frag_prefix_size = buf_size;
|
|
|
|
priv->frag_info[i].frag_stride =
|
|
|
|
ALIGN(priv->frag_info[i].frag_size,
|
|
|
|
SMP_CACHE_BYTES);
|
|
|
|
priv->frag_info[i].dma_dir = PCI_DMA_FROMDEVICE;
|
2016-12-08 06:53:13 +07:00
|
|
|
priv->frag_info[i].rx_headroom = 0;
|
2016-12-08 06:53:12 +07:00
|
|
|
buf_size += priv->frag_info[i].frag_size;
|
|
|
|
i++;
|
|
|
|
}
|
2008-10-23 05:47:49 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
priv->num_frags = i;
|
|
|
|
priv->rx_skb_size = eff_mtu;
|
2012-07-16 14:01:53 +07:00
|
|
|
priv->log_rx_info = ROUNDUP_LOG2(i * sizeof(struct mlx4_en_rx_alloc));
|
2008-10-23 05:47:49 +07:00
|
|
|
|
2014-05-08 02:52:57 +07:00
|
|
|
en_dbg(DRV, priv, "Rx buffer scatter-list (effective-mtu:%d num_frags:%d):\n",
|
|
|
|
eff_mtu, priv->num_frags);
|
2008-10-23 05:47:49 +07:00
|
|
|
for (i = 0; i < priv->num_frags; i++) {
|
2013-06-23 22:17:56 +07:00
|
|
|
en_err(priv,
|
2014-11-02 21:26:15 +07:00
|
|
|
" frag:%d - size:%d prefix:%d stride:%d\n",
|
2013-06-23 22:17:56 +07:00
|
|
|
i,
|
|
|
|
priv->frag_info[i].frag_size,
|
|
|
|
priv->frag_info[i].frag_prefix_size,
|
|
|
|
priv->frag_info[i].frag_stride);
|
2008-10-23 05:47:49 +07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* RSS related functions */
|
|
|
|
|
2009-08-07 09:28:18 +07:00
|
|
|
static int mlx4_en_config_rss_qp(struct mlx4_en_priv *priv, int qpn,
|
|
|
|
struct mlx4_en_rx_ring *ring,
|
2008-10-23 05:47:49 +07:00
|
|
|
enum mlx4_qp_state *state,
|
|
|
|
struct mlx4_qp *qp)
|
|
|
|
{
|
|
|
|
struct mlx4_en_dev *mdev = priv->mdev;
|
|
|
|
struct mlx4_qp_context *context;
|
|
|
|
int err = 0;
|
|
|
|
|
2013-02-07 18:46:27 +07:00
|
|
|
context = kmalloc(sizeof(*context), GFP_KERNEL);
|
|
|
|
if (!context)
|
2008-10-23 05:47:49 +07:00
|
|
|
return -ENOMEM;
|
|
|
|
|
2014-05-11 19:15:12 +07:00
|
|
|
err = mlx4_qp_alloc(mdev->dev, qpn, qp, GFP_KERNEL);
|
2008-10-23 05:47:49 +07:00
|
|
|
if (err) {
|
2009-06-02 03:27:13 +07:00
|
|
|
en_err(priv, "Failed to allocate qp #%x\n", qpn);
|
2008-10-23 05:47:49 +07:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
qp->event = mlx4_en_sqp_event;
|
|
|
|
|
|
|
|
memset(context, 0, sizeof *context);
|
2010-08-24 10:45:20 +07:00
|
|
|
mlx4_en_fill_qp_context(priv, ring->actual_size, ring->stride, 0, 0,
|
2012-04-05 04:33:24 +07:00
|
|
|
qpn, ring->cqn, -1, context);
|
2009-08-07 09:28:18 +07:00
|
|
|
context->db_rec_addr = cpu_to_be64(ring->wqres.db.dma);
|
2008-10-23 05:47:49 +07:00
|
|
|
|
2011-10-18 08:50:42 +07:00
|
|
|
/* Cancel FCS removal if FW allows */
|
2011-11-15 02:25:36 +07:00
|
|
|
if (mdev->dev->caps.flags & MLX4_DEV_CAP_FLAG_FCS_KEEP) {
|
2011-10-18 08:50:42 +07:00
|
|
|
context->param3 |= cpu_to_be32(1 << 29);
|
2015-04-02 20:31:21 +07:00
|
|
|
if (priv->dev->features & NETIF_F_RXFCS)
|
|
|
|
ring->fcs_del = 0;
|
|
|
|
else
|
|
|
|
ring->fcs_del = ETH_FCS_LEN;
|
2011-11-15 02:25:36 +07:00
|
|
|
} else
|
|
|
|
ring->fcs_del = 0;
|
2011-10-18 08:50:42 +07:00
|
|
|
|
2009-08-07 09:28:18 +07:00
|
|
|
err = mlx4_qp_to_ready(mdev->dev, &ring->wqres.mtt, context, qp, state);
|
2008-10-23 05:47:49 +07:00
|
|
|
if (err) {
|
|
|
|
mlx4_qp_remove(mdev->dev, qp);
|
|
|
|
mlx4_qp_free(mdev->dev, qp);
|
|
|
|
}
|
2009-08-07 09:28:18 +07:00
|
|
|
mlx4_en_update_rx_prod_db(ring);
|
2008-10-23 05:47:49 +07:00
|
|
|
out:
|
|
|
|
kfree(context);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2012-07-05 11:03:50 +07:00
|
|
|
int mlx4_en_create_drop_qp(struct mlx4_en_priv *priv)
|
|
|
|
{
|
|
|
|
int err;
|
|
|
|
u32 qpn;
|
|
|
|
|
net/mlx4: Add A0 hybrid steering
A0 hybrid steering is a form of high performance flow steering.
By using this mode, mlx4 cards use a fast limited table based steering,
in order to enable fast steering of unicast packets to a QP.
In order to implement A0 hybrid steering we allocate resources
from different zones:
(1) General range
(2) Special MAC-assigned QPs [RSS, Raw-Ethernet] each has its own region.
When we create a rss QP or a raw ethernet (A0 steerable and BF ready) QP,
we try hard to allocate the QP from range (2). Otherwise, we try hard not
to allocate from this range. However, when the system is pushed to its
limits and one needs every resource, the allocator uses every region it can.
Meaning, when we run out of raw-eth qps, the allocator allocates from the
general range (and the special-A0 area is no longer active). If we run out
of RSS qps, the mechanism tries to allocate from the raw-eth QP zone. If that
is also exhausted, the allocator will allocate from the general range
(and the A0 region is no longer active).
Note that if a raw-eth qp is allocated from the general range, it attempts
to allocate the range such that bits 6 and 7 (blueflame bits) in the
QP number are not set.
When the feature is used in SRIOV, the VF has to notify the PF what
kind of QP attributes it needs. In order to do that, along with the
"Eth QP blueflame" bit, we reserve a new "A0 steerable QP". According
to the combination of these bits, the PF tries to allocate a suitable QP.
In order to maintain backward compatibility (with older PFs), the PF
notifies which QP attributes it supports via QUERY_FUNC_CAP command.
Signed-off-by: Matan Barak <matanb@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-12-11 15:57:57 +07:00
|
|
|
err = mlx4_qp_reserve_range(priv->mdev->dev, 1, 1, &qpn,
|
|
|
|
MLX4_RESERVE_A0_QP);
|
2012-07-05 11:03:50 +07:00
|
|
|
if (err) {
|
|
|
|
en_err(priv, "Failed reserving drop qpn\n");
|
|
|
|
return err;
|
|
|
|
}
|
2014-05-11 19:15:12 +07:00
|
|
|
err = mlx4_qp_alloc(priv->mdev->dev, qpn, &priv->drop_qp, GFP_KERNEL);
|
2012-07-05 11:03:50 +07:00
|
|
|
if (err) {
|
|
|
|
en_err(priv, "Failed allocating drop qp\n");
|
|
|
|
mlx4_qp_release_range(priv->mdev->dev, qpn, 1);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
void mlx4_en_destroy_drop_qp(struct mlx4_en_priv *priv)
|
|
|
|
{
|
|
|
|
u32 qpn;
|
|
|
|
|
|
|
|
qpn = priv->drop_qp.qpn;
|
|
|
|
mlx4_qp_remove(priv->mdev->dev, &priv->drop_qp);
|
|
|
|
mlx4_qp_free(priv->mdev->dev, &priv->drop_qp);
|
|
|
|
mlx4_qp_release_range(priv->mdev->dev, qpn, 1);
|
|
|
|
}
|
|
|
|
|
2008-10-23 05:47:49 +07:00
|
|
|
/* Allocate rx qp's and configure them according to rss map */
|
|
|
|
int mlx4_en_config_rss_steer(struct mlx4_en_priv *priv)
|
|
|
|
{
|
|
|
|
struct mlx4_en_dev *mdev = priv->mdev;
|
|
|
|
struct mlx4_en_rss_map *rss_map = &priv->rss_map;
|
|
|
|
struct mlx4_qp_context context;
|
2011-11-27 02:54:58 +07:00
|
|
|
struct mlx4_rss_context *rss_context;
|
2012-01-18 05:54:55 +07:00
|
|
|
int rss_rings;
|
2008-10-23 05:47:49 +07:00
|
|
|
void *ptr;
|
2011-11-27 02:54:58 +07:00
|
|
|
u8 rss_mask = (MLX4_RSS_IPV4 | MLX4_RSS_TCP_IPV4 | MLX4_RSS_IPV6 |
|
2011-11-27 02:55:02 +07:00
|
|
|
MLX4_RSS_TCP_IPV6);
|
2009-08-07 09:28:18 +07:00
|
|
|
int i, qpn;
|
2008-10-23 05:47:49 +07:00
|
|
|
int err = 0;
|
|
|
|
int good_qps = 0;
|
|
|
|
|
2009-06-02 03:27:13 +07:00
|
|
|
en_dbg(DRV, priv, "Configuring rss steering\n");
|
2009-08-07 09:27:51 +07:00
|
|
|
err = mlx4_qp_reserve_range(mdev->dev, priv->rx_ring_num,
|
|
|
|
priv->rx_ring_num,
|
net/mlx4: Change QP allocation scheme
When using BF (Blue-Flame), the QPN overrides the VLAN, CV, and SV fields
in the WQE. Thus, BF may only be used for QPNs with bits 6,7 unset.
The current Ethernet driver code reserves a Tx QP range with 256b alignment.
This is wrong because if there are more than 64 Tx QPs in use,
QPNs >= base + 65 will have bits 6/7 set.
This problem is not specific for the Ethernet driver, any entity that
tries to reserve more than 64 BF-enabled QPs should fail. Also, using
ranges is not necessary here and is wasteful.
The new mechanism introduced here will support reservation for
"Eth QPs eligible for BF" for all drivers: bare-metal, multi-PF, and VFs
(when hypervisors support WC in VMs). The flow we use is:
1. In mlx4_en, allocate Tx QPs one by one instead of a range allocation,
and request "BF enabled QPs" if BF is supported for the function
2. In the ALLOC_RES FW command, change param1 to:
a. param1[23:0] - number of QPs
b. param1[31-24] - flags controlling QPs reservation
Bit 31 refers to Eth blueflame supported QPs. Those QPs must have
bits 6 and 7 unset in order to be used in Ethernet.
Bits 24-30 of the flags are currently reserved.
When a function tries to allocate a QP, it states the required attributes
for this QP. Those attributes are considered "best-effort". If an attribute,
such as Ethernet BF enabled QP, is a must-have attribute, the function has
to check that attribute is supported before trying to do the allocation.
In a lower layer of the code, mlx4_qp_reserve_range masks out the bits
which are unsupported. If SRIOV is used, the PF validates those attributes
and masks out unsupported attributes as well. In order to notify VFs which
attributes are supported, the VF uses QUERY_FUNC_CAP command. This command's
mailbox is filled by the PF, which notifies which QP allocation attributes
it supports.
Signed-off-by: Eugenia Emantayev <eugenia@mellanox.co.il>
Signed-off-by: Matan Barak <matanb@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-12-11 15:57:54 +07:00
|
|
|
&rss_map->base_qpn, 0);
|
2008-10-23 05:47:49 +07:00
|
|
|
if (err) {
|
2009-08-07 09:27:51 +07:00
|
|
|
en_err(priv, "Failed reserving %d qps\n", priv->rx_ring_num);
|
2008-10-23 05:47:49 +07:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2009-08-07 09:27:51 +07:00
|
|
|
for (i = 0; i < priv->rx_ring_num; i++) {
|
2008-10-23 05:47:49 +07:00
|
|
|
qpn = rss_map->base_qpn + i;
|
2013-11-07 17:19:52 +07:00
|
|
|
err = mlx4_en_config_rss_qp(priv, qpn, priv->rx_ring[i],
|
2008-10-23 05:47:49 +07:00
|
|
|
&rss_map->state[i],
|
|
|
|
&rss_map->qps[i]);
|
|
|
|
if (err)
|
|
|
|
goto rss_err;
|
|
|
|
|
|
|
|
++good_qps;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Configure RSS indirection qp */
|
2014-05-11 19:15:12 +07:00
|
|
|
err = mlx4_qp_alloc(mdev->dev, priv->base_qpn, &rss_map->indir_qp, GFP_KERNEL);
|
2008-10-23 05:47:49 +07:00
|
|
|
if (err) {
|
2009-06-02 03:27:13 +07:00
|
|
|
en_err(priv, "Failed to allocate RSS indirection QP\n");
|
2011-03-23 05:38:31 +07:00
|
|
|
goto rss_err;
|
2008-10-23 05:47:49 +07:00
|
|
|
}
|
|
|
|
rss_map->indir_qp.event = mlx4_en_sqp_event;
|
|
|
|
mlx4_en_fill_qp_context(priv, 0, 0, 0, 1, priv->base_qpn,
|
2013-11-07 17:19:52 +07:00
|
|
|
priv->rx_ring[0]->cqn, -1, &context);
|
2008-10-23 05:47:49 +07:00
|
|
|
|
2012-01-18 05:54:55 +07:00
|
|
|
if (!priv->prof->rss_rings || priv->prof->rss_rings > priv->rx_ring_num)
|
|
|
|
rss_rings = priv->rx_ring_num;
|
|
|
|
else
|
|
|
|
rss_rings = priv->prof->rss_rings;
|
|
|
|
|
2011-11-27 02:54:58 +07:00
|
|
|
ptr = ((void *) &context) + offsetof(struct mlx4_qp_context, pri_path)
|
|
|
|
+ MLX4_RSS_OFFSET_IN_QPC_PRI_PATH;
|
2011-06-17 02:08:06 +07:00
|
|
|
rss_context = ptr;
|
2012-01-18 05:54:55 +07:00
|
|
|
rss_context->base_qpn = cpu_to_be32(ilog2(rss_rings) << 24 |
|
2008-10-23 05:47:49 +07:00
|
|
|
(rss_map->base_qpn));
|
2011-12-20 04:53:38 +07:00
|
|
|
rss_context->default_qpn = cpu_to_be32(rss_map->base_qpn);
|
2011-11-27 02:55:02 +07:00
|
|
|
if (priv->mdev->profile.udp_rss) {
|
|
|
|
rss_mask |= MLX4_RSS_UDP_IPV4 | MLX4_RSS_UDP_IPV6;
|
|
|
|
rss_context->base_qpn_udp = rss_context->default_qpn;
|
|
|
|
}
|
2013-12-23 21:09:44 +07:00
|
|
|
|
|
|
|
if (mdev->dev->caps.tunnel_offload_mode == MLX4_TUNNEL_OFFLOAD_MODE_VXLAN) {
|
|
|
|
en_info(priv, "Setting RSS context tunnel type to RSS on inner headers\n");
|
|
|
|
rss_mask |= MLX4_RSS_BY_INNER_HEADERS;
|
|
|
|
}
|
|
|
|
|
2010-08-24 10:46:42 +07:00
|
|
|
rss_context->flags = rss_mask;
|
2011-11-27 02:54:58 +07:00
|
|
|
rss_context->hash_fn = MLX4_RSS_HASH_TOP;
|
2014-12-02 23:12:11 +07:00
|
|
|
if (priv->rss_hash_fn == ETH_RSS_HASH_XOR) {
|
|
|
|
rss_context->hash_fn = MLX4_RSS_HASH_XOR;
|
|
|
|
} else if (priv->rss_hash_fn == ETH_RSS_HASH_TOP) {
|
|
|
|
rss_context->hash_fn = MLX4_RSS_HASH_TOP;
|
|
|
|
memcpy(rss_context->rss_key, priv->rss_key,
|
|
|
|
MLX4_EN_RSS_KEY_SIZE);
|
|
|
|
} else {
|
|
|
|
en_err(priv, "Unknown RSS hash function requested\n");
|
|
|
|
err = -EINVAL;
|
|
|
|
goto indir_err;
|
|
|
|
}
|
2008-10-23 05:47:49 +07:00
|
|
|
err = mlx4_qp_to_ready(mdev->dev, &priv->res.mtt, &context,
|
|
|
|
&rss_map->indir_qp, &rss_map->indir_state);
|
|
|
|
if (err)
|
|
|
|
goto indir_err;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
indir_err:
|
|
|
|
mlx4_qp_modify(mdev->dev, NULL, rss_map->indir_state,
|
|
|
|
MLX4_QP_STATE_RST, NULL, 0, 0, &rss_map->indir_qp);
|
|
|
|
mlx4_qp_remove(mdev->dev, &rss_map->indir_qp);
|
|
|
|
mlx4_qp_free(mdev->dev, &rss_map->indir_qp);
|
|
|
|
rss_err:
|
|
|
|
for (i = 0; i < good_qps; i++) {
|
|
|
|
mlx4_qp_modify(mdev->dev, NULL, rss_map->state[i],
|
|
|
|
MLX4_QP_STATE_RST, NULL, 0, 0, &rss_map->qps[i]);
|
|
|
|
mlx4_qp_remove(mdev->dev, &rss_map->qps[i]);
|
|
|
|
mlx4_qp_free(mdev->dev, &rss_map->qps[i]);
|
|
|
|
}
|
2009-08-07 09:27:51 +07:00
|
|
|
mlx4_qp_release_range(mdev->dev, rss_map->base_qpn, priv->rx_ring_num);
|
2008-10-23 05:47:49 +07:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
void mlx4_en_release_rss_steer(struct mlx4_en_priv *priv)
|
|
|
|
{
|
|
|
|
struct mlx4_en_dev *mdev = priv->mdev;
|
|
|
|
struct mlx4_en_rss_map *rss_map = &priv->rss_map;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
mlx4_qp_modify(mdev->dev, NULL, rss_map->indir_state,
|
|
|
|
MLX4_QP_STATE_RST, NULL, 0, 0, &rss_map->indir_qp);
|
|
|
|
mlx4_qp_remove(mdev->dev, &rss_map->indir_qp);
|
|
|
|
mlx4_qp_free(mdev->dev, &rss_map->indir_qp);
|
|
|
|
|
2009-08-07 09:27:51 +07:00
|
|
|
for (i = 0; i < priv->rx_ring_num; i++) {
|
2008-10-23 05:47:49 +07:00
|
|
|
mlx4_qp_modify(mdev->dev, NULL, rss_map->state[i],
|
|
|
|
MLX4_QP_STATE_RST, NULL, 0, 0, &rss_map->qps[i]);
|
|
|
|
mlx4_qp_remove(mdev->dev, &rss_map->qps[i]);
|
|
|
|
mlx4_qp_free(mdev->dev, &rss_map->qps[i]);
|
|
|
|
}
|
2009-08-07 09:27:51 +07:00
|
|
|
mlx4_qp_release_range(mdev->dev, rss_map->base_qpn, priv->rx_ring_num);
|
2008-10-23 05:47:49 +07:00
|
|
|
}
|