2005-04-17 05:20:36 +07:00
|
|
|
/*
|
2008-06-10 23:20:56 +07:00
|
|
|
* zfcp device driver
|
2005-04-17 05:20:36 +07:00
|
|
|
*
|
2008-06-10 23:20:56 +07:00
|
|
|
* Registration and callback for the s390 common I/O layer.
|
2005-04-17 05:20:36 +07:00
|
|
|
*
|
2012-07-20 16:15:04 +07:00
|
|
|
* Copyright IBM Corp. 2002, 2010
|
2005-04-17 05:20:36 +07:00
|
|
|
*/
|
|
|
|
|
2008-12-25 19:39:53 +07:00
|
|
|
#define KMSG_COMPONENT "zfcp"
|
|
|
|
#define pr_fmt(fmt) KMSG_COMPONENT ": " fmt
|
|
|
|
|
2011-07-30 14:25:15 +07:00
|
|
|
#include <linux/module.h>
|
2005-04-17 05:20:36 +07:00
|
|
|
#include "zfcp_ext.h"
|
2010-02-17 17:18:50 +07:00
|
|
|
#include "zfcp_reqlist.h"
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2009-05-15 18:18:21 +07:00
|
|
|
#define ZFCP_MODEL_PRIV 0x4
|
|
|
|
|
2009-11-24 22:54:00 +07:00
|
|
|
static DEFINE_SPINLOCK(zfcp_ccw_adapter_ref_lock);
|
|
|
|
|
|
|
|
struct zfcp_adapter *zfcp_ccw_adapter_by_cdev(struct ccw_device *cdev)
|
|
|
|
{
|
|
|
|
struct zfcp_adapter *adapter;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&zfcp_ccw_adapter_ref_lock, flags);
|
|
|
|
adapter = dev_get_drvdata(&cdev->dev);
|
|
|
|
if (adapter)
|
|
|
|
kref_get(&adapter->ref);
|
|
|
|
spin_unlock_irqrestore(&zfcp_ccw_adapter_ref_lock, flags);
|
|
|
|
return adapter;
|
|
|
|
}
|
|
|
|
|
|
|
|
void zfcp_ccw_adapter_put(struct zfcp_adapter *adapter)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&zfcp_ccw_adapter_ref_lock, flags);
|
|
|
|
kref_put(&adapter->ref, zfcp_adapter_release);
|
|
|
|
spin_unlock_irqrestore(&zfcp_ccw_adapter_ref_lock, flags);
|
|
|
|
}
|
|
|
|
|
[SCSI] zfcp: Do not wakeup while suspended
If the mapping of FCP device bus ID and corresponding subchannel
is modified while the Linux image is suspended, the resume of FCP
devices can fail. During resume, zfcp gets callbacks from cio regarding
the modified subchannels but they can be arbitrarily mixed with the
restore/resume callback. Since the cio callbacks would trigger
adapter recovery, zfcp could wakeup before the resume callback.
Therefore, ignore the cio callbacks regarding subchannels while
being suspended. We can safely do so, since zfcp does not deal itself
with subchannels. For problem determination purposes, we still trace the
ignored callback events.
The following kernel messages could be seen on resume:
kernel: <WWPN>: parent <FCP device bus ID> should not be sleeping
As part of adapter reopen recovery, zfcp performs auto port scanning
which can erroneously try to register new remote ports with
scsi_transport_fc and the device core code complains about the parent
(adapter) still sleeping.
kernel: zfcp.3dff9c: <FCP device bus ID>:\
Setting up the QDIO connection to the FCP adapter failed
<last kernel message repeated 3 more times>
kernel: zfcp.574d43: <FCP device bus ID>:\
ERP cannot recover an error on the FCP device
In such cases, the adapter gave up recovery and remained blocked along
with its child objects: remote ports and LUNs/scsi devices. Even the
adapter shutdown as part of giving up recovery failed because the ccw
device state remained disconnected. Later, the corresponding remote
ports ran into dev_loss_tmo. As a result, the LUNs were erroneously
not available again after resume.
Even a manually triggered adapter recovery (e.g. sysfs attribute
failed, or device offline/online via sysfs) could not recover the
adapter due to the remaining disconnected state of the corresponding
ccw device.
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org> #2.6.32+
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
2012-09-04 20:23:32 +07:00
|
|
|
/**
|
|
|
|
* zfcp_ccw_activate - activate adapter and wait for it to finish
|
|
|
|
* @cdev: pointer to belonging ccw device
|
|
|
|
* @clear: Status flags to clear.
|
|
|
|
* @tag: s390dbf trace record tag
|
|
|
|
*/
|
|
|
|
static int zfcp_ccw_activate(struct ccw_device *cdev, int clear, char *tag)
|
2009-06-16 15:30:34 +07:00
|
|
|
{
|
2009-11-24 22:54:00 +07:00
|
|
|
struct zfcp_adapter *adapter = zfcp_ccw_adapter_by_cdev(cdev);
|
2009-06-16 15:30:34 +07:00
|
|
|
|
2009-08-18 20:43:27 +07:00
|
|
|
if (!adapter)
|
|
|
|
return 0;
|
|
|
|
|
[SCSI] zfcp: Do not wakeup while suspended
If the mapping of FCP device bus ID and corresponding subchannel
is modified while the Linux image is suspended, the resume of FCP
devices can fail. During resume, zfcp gets callbacks from cio regarding
the modified subchannels but they can be arbitrarily mixed with the
restore/resume callback. Since the cio callbacks would trigger
adapter recovery, zfcp could wakeup before the resume callback.
Therefore, ignore the cio callbacks regarding subchannels while
being suspended. We can safely do so, since zfcp does not deal itself
with subchannels. For problem determination purposes, we still trace the
ignored callback events.
The following kernel messages could be seen on resume:
kernel: <WWPN>: parent <FCP device bus ID> should not be sleeping
As part of adapter reopen recovery, zfcp performs auto port scanning
which can erroneously try to register new remote ports with
scsi_transport_fc and the device core code complains about the parent
(adapter) still sleeping.
kernel: zfcp.3dff9c: <FCP device bus ID>:\
Setting up the QDIO connection to the FCP adapter failed
<last kernel message repeated 3 more times>
kernel: zfcp.574d43: <FCP device bus ID>:\
ERP cannot recover an error on the FCP device
In such cases, the adapter gave up recovery and remained blocked along
with its child objects: remote ports and LUNs/scsi devices. Even the
adapter shutdown as part of giving up recovery failed because the ccw
device state remained disconnected. Later, the corresponding remote
ports ran into dev_loss_tmo. As a result, the LUNs were erroneously
not available again after resume.
Even a manually triggered adapter recovery (e.g. sysfs attribute
failed, or device offline/online via sysfs) could not recover the
adapter due to the remaining disconnected state of the corresponding
ccw device.
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org> #2.6.32+
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
2012-09-04 20:23:32 +07:00
|
|
|
zfcp_erp_clear_adapter_status(adapter, clear);
|
2010-09-08 19:40:01 +07:00
|
|
|
zfcp_erp_set_adapter_status(adapter, ZFCP_STATUS_COMMON_RUNNING);
|
2009-06-16 15:30:34 +07:00
|
|
|
zfcp_erp_adapter_reopen(adapter, ZFCP_STATUS_COMMON_ERP_FAILED,
|
[SCSI] zfcp: Do not wakeup while suspended
If the mapping of FCP device bus ID and corresponding subchannel
is modified while the Linux image is suspended, the resume of FCP
devices can fail. During resume, zfcp gets callbacks from cio regarding
the modified subchannels but they can be arbitrarily mixed with the
restore/resume callback. Since the cio callbacks would trigger
adapter recovery, zfcp could wakeup before the resume callback.
Therefore, ignore the cio callbacks regarding subchannels while
being suspended. We can safely do so, since zfcp does not deal itself
with subchannels. For problem determination purposes, we still trace the
ignored callback events.
The following kernel messages could be seen on resume:
kernel: <WWPN>: parent <FCP device bus ID> should not be sleeping
As part of adapter reopen recovery, zfcp performs auto port scanning
which can erroneously try to register new remote ports with
scsi_transport_fc and the device core code complains about the parent
(adapter) still sleeping.
kernel: zfcp.3dff9c: <FCP device bus ID>:\
Setting up the QDIO connection to the FCP adapter failed
<last kernel message repeated 3 more times>
kernel: zfcp.574d43: <FCP device bus ID>:\
ERP cannot recover an error on the FCP device
In such cases, the adapter gave up recovery and remained blocked along
with its child objects: remote ports and LUNs/scsi devices. Even the
adapter shutdown as part of giving up recovery failed because the ccw
device state remained disconnected. Later, the corresponding remote
ports ran into dev_loss_tmo. As a result, the LUNs were erroneously
not available again after resume.
Even a manually triggered adapter recovery (e.g. sysfs attribute
failed, or device offline/online via sysfs) could not recover the
adapter due to the remaining disconnected state of the corresponding
ccw device.
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org> #2.6.32+
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
2012-09-04 20:23:32 +07:00
|
|
|
tag);
|
zfcp: auto port scan resiliency
This patch improves the Fibre Channel port scan behaviour of the zfcp lldd.
Without it the zfcp device driver may churn up the storage area network by
excessive scanning and scan bursts, particularly in big virtual server
environments, potentially resulting in interference of virtual servers and
reduced availability of storage connectivity.
The two main issues as to the zfcp device drivers automatic port scan in
virtual server environments are frequency and simultaneity.
On the one hand, there is no point in allowing lots of ports scans
in a row. It makes sense, though, to make sure that a scan is conducted
eventually if there has been any indication for potential SAN changes.
On the other hand, lots of virtual servers receiving the same indication
for a SAN change had better not attempt to conduct a scan instantly,
that is, at the same time.
Hence this patch has a two-fold approach for better port scanning:
the introduction of a rate limit to amend frequency issues, and the
introduction of a short random backoff to amend simultaneity issues.
Both approaches boil down to deferred port scans, with delays
comprising parts for both approaches.
The new port scan behaviour is summarised best by:
NEW: NEW:
no_auto_port_rescan random rate flush
backoff limit =wait
adapter resume/thaw yes yes no yes*
adapter online (user) no yes no yes*
port rescan (user) no no no yes
adapter recovery (user) yes yes yes no
adapter recovery (other) yes yes yes no
incoming ELS yes yes yes no
incoming ELS lost yes yes yes no
Implementation is straight-forward by converting an existing worker to
a delayed worker. But care is needed whenever that worker is going to be
flushed (in order to make sure work has been completed), since a flush
operation cancels the timer set up for deferred execution (see * above).
There is a small race window whenever a port scan work starts
running up to the point in time of storing the time stamp for that port
scan. The impact is negligible. Closing that gap isn't trivial, though, and
would the destroy the beauty of a simple work-to-delayed-work conversion.
Signed-off-by: Martin Peschke <mpeschke@linux.vnet.ibm.com>
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
2014-11-13 20:59:48 +07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* We want to scan ports here, with some random backoff and without
|
|
|
|
* rate limit. Recovery has already scheduled a port scan for us,
|
|
|
|
* but with both random delay and rate limit. Nevertheless we get
|
|
|
|
* what we want here by flushing the scheduled work after sleeping
|
|
|
|
* an equivalent random time.
|
|
|
|
* Let the port scan random delay elapse first. If recovery finishes
|
|
|
|
* up to that point in time, that would be perfect for both recovery
|
|
|
|
* and port scan. If not, i.e. recovery takes ages, there was no
|
|
|
|
* point in waiting a random delay on top of the time consumed by
|
|
|
|
* recovery.
|
|
|
|
*/
|
|
|
|
msleep(zfcp_fc_port_scan_backoff());
|
2009-06-16 15:30:34 +07:00
|
|
|
zfcp_erp_wait(adapter);
|
zfcp: auto port scan resiliency
This patch improves the Fibre Channel port scan behaviour of the zfcp lldd.
Without it the zfcp device driver may churn up the storage area network by
excessive scanning and scan bursts, particularly in big virtual server
environments, potentially resulting in interference of virtual servers and
reduced availability of storage connectivity.
The two main issues as to the zfcp device drivers automatic port scan in
virtual server environments are frequency and simultaneity.
On the one hand, there is no point in allowing lots of ports scans
in a row. It makes sense, though, to make sure that a scan is conducted
eventually if there has been any indication for potential SAN changes.
On the other hand, lots of virtual servers receiving the same indication
for a SAN change had better not attempt to conduct a scan instantly,
that is, at the same time.
Hence this patch has a two-fold approach for better port scanning:
the introduction of a rate limit to amend frequency issues, and the
introduction of a short random backoff to amend simultaneity issues.
Both approaches boil down to deferred port scans, with delays
comprising parts for both approaches.
The new port scan behaviour is summarised best by:
NEW: NEW:
no_auto_port_rescan random rate flush
backoff limit =wait
adapter resume/thaw yes yes no yes*
adapter online (user) no yes no yes*
port rescan (user) no no no yes
adapter recovery (user) yes yes yes no
adapter recovery (other) yes yes yes no
incoming ELS yes yes yes no
incoming ELS lost yes yes yes no
Implementation is straight-forward by converting an existing worker to
a delayed worker. But care is needed whenever that worker is going to be
flushed (in order to make sure work has been completed), since a flush
operation cancels the timer set up for deferred execution (see * above).
There is a small race window whenever a port scan work starts
running up to the point in time of storing the time stamp for that port
scan. The impact is negligible. Closing that gap isn't trivial, though, and
would the destroy the beauty of a simple work-to-delayed-work conversion.
Signed-off-by: Martin Peschke <mpeschke@linux.vnet.ibm.com>
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
2014-11-13 20:59:48 +07:00
|
|
|
flush_delayed_work(&adapter->scan_work);
|
2009-06-16 15:30:34 +07:00
|
|
|
|
2009-11-24 22:54:00 +07:00
|
|
|
zfcp_ccw_adapter_put(adapter);
|
|
|
|
|
2009-06-16 15:30:34 +07:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-05-15 18:18:21 +07:00
|
|
|
static struct ccw_device_id zfcp_ccw_device_id[] = {
|
|
|
|
{ CCW_DEVICE_DEVTYPE(0x1731, 0x3, 0x1732, 0x3) },
|
|
|
|
{ CCW_DEVICE_DEVTYPE(0x1731, 0x3, 0x1732, ZFCP_MODEL_PRIV) },
|
|
|
|
{},
|
|
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(ccw, zfcp_ccw_device_id);
|
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
/**
|
|
|
|
* zfcp_ccw_probe - probe function of zfcp driver
|
2009-11-24 22:54:00 +07:00
|
|
|
* @cdev: pointer to belonging ccw device
|
2005-04-17 05:20:36 +07:00
|
|
|
*
|
2009-08-18 20:43:27 +07:00
|
|
|
* This function gets called by the common i/o layer for each FCP
|
|
|
|
* device found on the current system. This is only a stub to make cio
|
|
|
|
* work: To only allocate adapter resources for devices actually used,
|
|
|
|
* the allocation is deferred to the first call to ccw_set_online.
|
2005-04-17 05:20:36 +07:00
|
|
|
*/
|
2009-11-24 22:54:00 +07:00
|
|
|
static int zfcp_ccw_probe(struct ccw_device *cdev)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2009-08-18 20:43:27 +07:00
|
|
|
return 0;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* zfcp_ccw_remove - remove function of zfcp driver
|
2009-11-24 22:54:00 +07:00
|
|
|
* @cdev: pointer to belonging ccw device
|
2005-04-17 05:20:36 +07:00
|
|
|
*
|
|
|
|
* This function gets called by the common i/o layer and removes an adapter
|
|
|
|
* from the system. Task of this function is to get rid of all units and
|
|
|
|
* ports that belong to this adapter. And in addition all resources of this
|
|
|
|
* adapter will be freed too.
|
|
|
|
*/
|
2009-11-24 22:54:00 +07:00
|
|
|
static void zfcp_ccw_remove(struct ccw_device *cdev)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
|
|
|
struct zfcp_adapter *adapter;
|
|
|
|
struct zfcp_port *port, *p;
|
|
|
|
struct zfcp_unit *unit, *u;
|
2008-10-01 17:42:20 +07:00
|
|
|
LIST_HEAD(unit_remove_lh);
|
|
|
|
LIST_HEAD(port_remove_lh);
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2009-11-24 22:54:00 +07:00
|
|
|
ccw_device_set_offline(cdev);
|
2009-09-24 15:23:24 +07:00
|
|
|
|
2009-11-24 22:54:00 +07:00
|
|
|
adapter = zfcp_ccw_adapter_by_cdev(cdev);
|
2009-11-24 22:53:58 +07:00
|
|
|
if (!adapter)
|
|
|
|
return;
|
|
|
|
|
|
|
|
write_lock_irq(&adapter->port_list_lock);
|
|
|
|
list_for_each_entry_safe(port, p, &adapter->port_list, list) {
|
|
|
|
write_lock(&port->unit_list_lock);
|
2009-11-24 22:54:05 +07:00
|
|
|
list_for_each_entry_safe(unit, u, &port->unit_list, list)
|
2009-11-24 22:53:58 +07:00
|
|
|
list_move(&unit->list, &unit_remove_lh);
|
|
|
|
write_unlock(&port->unit_list_lock);
|
|
|
|
list_move(&port->list, &port_remove_lh);
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
2009-11-24 22:53:58 +07:00
|
|
|
write_unlock_irq(&adapter->port_list_lock);
|
2009-11-24 22:54:00 +07:00
|
|
|
zfcp_ccw_adapter_put(adapter); /* put from zfcp_ccw_adapter_by_cdev */
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2009-11-24 22:53:59 +07:00
|
|
|
list_for_each_entry_safe(unit, u, &unit_remove_lh, list)
|
2013-04-26 21:13:49 +07:00
|
|
|
device_unregister(&unit->dev);
|
2009-11-24 22:53:59 +07:00
|
|
|
|
|
|
|
list_for_each_entry_safe(port, p, &port_remove_lh, list)
|
2013-04-26 21:13:48 +07:00
|
|
|
device_unregister(&port->dev);
|
2009-11-24 22:53:59 +07:00
|
|
|
|
2009-11-24 22:54:00 +07:00
|
|
|
zfcp_adapter_unregister(adapter);
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* zfcp_ccw_set_online - set_online function of zfcp driver
|
2009-11-24 22:54:00 +07:00
|
|
|
* @cdev: pointer to belonging ccw device
|
2005-04-17 05:20:36 +07:00
|
|
|
*
|
2009-08-18 20:43:27 +07:00
|
|
|
* This function gets called by the common i/o layer and sets an
|
|
|
|
* adapter into state online. The first call will allocate all
|
|
|
|
* adapter resources that will be retained until the device is removed
|
|
|
|
* via zfcp_ccw_remove.
|
|
|
|
*
|
|
|
|
* Setting an fcp device online means that it will be registered with
|
|
|
|
* the SCSI stack, that the QDIO queues will be set up and that the
|
|
|
|
* adapter will be opened.
|
2005-04-17 05:20:36 +07:00
|
|
|
*/
|
2009-11-24 22:54:00 +07:00
|
|
|
static int zfcp_ccw_set_online(struct ccw_device *cdev)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2009-11-24 22:54:00 +07:00
|
|
|
struct zfcp_adapter *adapter = zfcp_ccw_adapter_by_cdev(cdev);
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2009-08-18 20:43:27 +07:00
|
|
|
if (!adapter) {
|
2009-11-24 22:54:00 +07:00
|
|
|
adapter = zfcp_adapter_enqueue(cdev);
|
|
|
|
|
|
|
|
if (IS_ERR(adapter)) {
|
|
|
|
dev_err(&cdev->dev,
|
2009-08-18 20:43:27 +07:00
|
|
|
"Setting up data structures for the "
|
|
|
|
"FCP adapter failed\n");
|
2009-11-24 22:54:00 +07:00
|
|
|
return PTR_ERR(adapter);
|
2009-08-18 20:43:27 +07:00
|
|
|
}
|
2009-11-24 22:54:00 +07:00
|
|
|
kref_get(&adapter->ref);
|
2009-08-18 20:43:27 +07:00
|
|
|
}
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2006-08-02 16:05:16 +07:00
|
|
|
/* initialize request counter */
|
2010-02-17 17:18:50 +07:00
|
|
|
BUG_ON(!zfcp_reqlist_isempty(adapter->req_list));
|
2006-08-02 16:05:16 +07:00
|
|
|
adapter->req_no = 0;
|
|
|
|
|
[SCSI] zfcp: Do not wakeup while suspended
If the mapping of FCP device bus ID and corresponding subchannel
is modified while the Linux image is suspended, the resume of FCP
devices can fail. During resume, zfcp gets callbacks from cio regarding
the modified subchannels but they can be arbitrarily mixed with the
restore/resume callback. Since the cio callbacks would trigger
adapter recovery, zfcp could wakeup before the resume callback.
Therefore, ignore the cio callbacks regarding subchannels while
being suspended. We can safely do so, since zfcp does not deal itself
with subchannels. For problem determination purposes, we still trace the
ignored callback events.
The following kernel messages could be seen on resume:
kernel: <WWPN>: parent <FCP device bus ID> should not be sleeping
As part of adapter reopen recovery, zfcp performs auto port scanning
which can erroneously try to register new remote ports with
scsi_transport_fc and the device core code complains about the parent
(adapter) still sleeping.
kernel: zfcp.3dff9c: <FCP device bus ID>:\
Setting up the QDIO connection to the FCP adapter failed
<last kernel message repeated 3 more times>
kernel: zfcp.574d43: <FCP device bus ID>:\
ERP cannot recover an error on the FCP device
In such cases, the adapter gave up recovery and remained blocked along
with its child objects: remote ports and LUNs/scsi devices. Even the
adapter shutdown as part of giving up recovery failed because the ccw
device state remained disconnected. Later, the corresponding remote
ports ran into dev_loss_tmo. As a result, the LUNs were erroneously
not available again after resume.
Even a manually triggered adapter recovery (e.g. sysfs attribute
failed, or device offline/online via sysfs) could not recover the
adapter due to the remaining disconnected state of the corresponding
ccw device.
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org> #2.6.32+
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
2012-09-04 20:23:32 +07:00
|
|
|
zfcp_ccw_activate(cdev, 0, "ccsonl1");
|
zfcp: auto port scan resiliency
This patch improves the Fibre Channel port scan behaviour of the zfcp lldd.
Without it the zfcp device driver may churn up the storage area network by
excessive scanning and scan bursts, particularly in big virtual server
environments, potentially resulting in interference of virtual servers and
reduced availability of storage connectivity.
The two main issues as to the zfcp device drivers automatic port scan in
virtual server environments are frequency and simultaneity.
On the one hand, there is no point in allowing lots of ports scans
in a row. It makes sense, though, to make sure that a scan is conducted
eventually if there has been any indication for potential SAN changes.
On the other hand, lots of virtual servers receiving the same indication
for a SAN change had better not attempt to conduct a scan instantly,
that is, at the same time.
Hence this patch has a two-fold approach for better port scanning:
the introduction of a rate limit to amend frequency issues, and the
introduction of a short random backoff to amend simultaneity issues.
Both approaches boil down to deferred port scans, with delays
comprising parts for both approaches.
The new port scan behaviour is summarised best by:
NEW: NEW:
no_auto_port_rescan random rate flush
backoff limit =wait
adapter resume/thaw yes yes no yes*
adapter online (user) no yes no yes*
port rescan (user) no no no yes
adapter recovery (user) yes yes yes no
adapter recovery (other) yes yes yes no
incoming ELS yes yes yes no
incoming ELS lost yes yes yes no
Implementation is straight-forward by converting an existing worker to
a delayed worker. But care is needed whenever that worker is going to be
flushed (in order to make sure work has been completed), since a flush
operation cancels the timer set up for deferred execution (see * above).
There is a small race window whenever a port scan work starts
running up to the point in time of storing the time stamp for that port
scan. The impact is negligible. Closing that gap isn't trivial, though, and
would the destroy the beauty of a simple work-to-delayed-work conversion.
Signed-off-by: Martin Peschke <mpeschke@linux.vnet.ibm.com>
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
2014-11-13 20:59:48 +07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* We want to scan ports here, always, with some random delay and
|
|
|
|
* without rate limit - basically what zfcp_ccw_activate() has
|
|
|
|
* achieved for us. Not quite! That port scan depended on
|
|
|
|
* !no_auto_port_rescan. So let's cover the no_auto_port_rescan
|
|
|
|
* case here to make sure a port scan is done unconditionally.
|
|
|
|
* Since zfcp_ccw_activate() has waited the desired random time,
|
|
|
|
* we can immediately schedule and flush a port scan for the
|
|
|
|
* remaining cases.
|
|
|
|
*/
|
2012-09-04 20:23:35 +07:00
|
|
|
zfcp_fc_inverse_conditional_port_scan(adapter);
|
zfcp: auto port scan resiliency
This patch improves the Fibre Channel port scan behaviour of the zfcp lldd.
Without it the zfcp device driver may churn up the storage area network by
excessive scanning and scan bursts, particularly in big virtual server
environments, potentially resulting in interference of virtual servers and
reduced availability of storage connectivity.
The two main issues as to the zfcp device drivers automatic port scan in
virtual server environments are frequency and simultaneity.
On the one hand, there is no point in allowing lots of ports scans
in a row. It makes sense, though, to make sure that a scan is conducted
eventually if there has been any indication for potential SAN changes.
On the other hand, lots of virtual servers receiving the same indication
for a SAN change had better not attempt to conduct a scan instantly,
that is, at the same time.
Hence this patch has a two-fold approach for better port scanning:
the introduction of a rate limit to amend frequency issues, and the
introduction of a short random backoff to amend simultaneity issues.
Both approaches boil down to deferred port scans, with delays
comprising parts for both approaches.
The new port scan behaviour is summarised best by:
NEW: NEW:
no_auto_port_rescan random rate flush
backoff limit =wait
adapter resume/thaw yes yes no yes*
adapter online (user) no yes no yes*
port rescan (user) no no no yes
adapter recovery (user) yes yes yes no
adapter recovery (other) yes yes yes no
incoming ELS yes yes yes no
incoming ELS lost yes yes yes no
Implementation is straight-forward by converting an existing worker to
a delayed worker. But care is needed whenever that worker is going to be
flushed (in order to make sure work has been completed), since a flush
operation cancels the timer set up for deferred execution (see * above).
There is a small race window whenever a port scan work starts
running up to the point in time of storing the time stamp for that port
scan. The impact is negligible. Closing that gap isn't trivial, though, and
would the destroy the beauty of a simple work-to-delayed-work conversion.
Signed-off-by: Martin Peschke <mpeschke@linux.vnet.ibm.com>
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
2014-11-13 20:59:48 +07:00
|
|
|
flush_delayed_work(&adapter->scan_work);
|
2009-11-24 22:54:00 +07:00
|
|
|
zfcp_ccw_adapter_put(adapter);
|
|
|
|
return 0;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
[SCSI] zfcp: Do not wakeup while suspended
If the mapping of FCP device bus ID and corresponding subchannel
is modified while the Linux image is suspended, the resume of FCP
devices can fail. During resume, zfcp gets callbacks from cio regarding
the modified subchannels but they can be arbitrarily mixed with the
restore/resume callback. Since the cio callbacks would trigger
adapter recovery, zfcp could wakeup before the resume callback.
Therefore, ignore the cio callbacks regarding subchannels while
being suspended. We can safely do so, since zfcp does not deal itself
with subchannels. For problem determination purposes, we still trace the
ignored callback events.
The following kernel messages could be seen on resume:
kernel: <WWPN>: parent <FCP device bus ID> should not be sleeping
As part of adapter reopen recovery, zfcp performs auto port scanning
which can erroneously try to register new remote ports with
scsi_transport_fc and the device core code complains about the parent
(adapter) still sleeping.
kernel: zfcp.3dff9c: <FCP device bus ID>:\
Setting up the QDIO connection to the FCP adapter failed
<last kernel message repeated 3 more times>
kernel: zfcp.574d43: <FCP device bus ID>:\
ERP cannot recover an error on the FCP device
In such cases, the adapter gave up recovery and remained blocked along
with its child objects: remote ports and LUNs/scsi devices. Even the
adapter shutdown as part of giving up recovery failed because the ccw
device state remained disconnected. Later, the corresponding remote
ports ran into dev_loss_tmo. As a result, the LUNs were erroneously
not available again after resume.
Even a manually triggered adapter recovery (e.g. sysfs attribute
failed, or device offline/online via sysfs) could not recover the
adapter due to the remaining disconnected state of the corresponding
ccw device.
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org> #2.6.32+
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
2012-09-04 20:23:32 +07:00
|
|
|
* zfcp_ccw_offline_sync - shut down adapter and wait for it to finish
|
2009-11-24 22:54:00 +07:00
|
|
|
* @cdev: pointer to belonging ccw device
|
[SCSI] zfcp: Do not wakeup while suspended
If the mapping of FCP device bus ID and corresponding subchannel
is modified while the Linux image is suspended, the resume of FCP
devices can fail. During resume, zfcp gets callbacks from cio regarding
the modified subchannels but they can be arbitrarily mixed with the
restore/resume callback. Since the cio callbacks would trigger
adapter recovery, zfcp could wakeup before the resume callback.
Therefore, ignore the cio callbacks regarding subchannels while
being suspended. We can safely do so, since zfcp does not deal itself
with subchannels. For problem determination purposes, we still trace the
ignored callback events.
The following kernel messages could be seen on resume:
kernel: <WWPN>: parent <FCP device bus ID> should not be sleeping
As part of adapter reopen recovery, zfcp performs auto port scanning
which can erroneously try to register new remote ports with
scsi_transport_fc and the device core code complains about the parent
(adapter) still sleeping.
kernel: zfcp.3dff9c: <FCP device bus ID>:\
Setting up the QDIO connection to the FCP adapter failed
<last kernel message repeated 3 more times>
kernel: zfcp.574d43: <FCP device bus ID>:\
ERP cannot recover an error on the FCP device
In such cases, the adapter gave up recovery and remained blocked along
with its child objects: remote ports and LUNs/scsi devices. Even the
adapter shutdown as part of giving up recovery failed because the ccw
device state remained disconnected. Later, the corresponding remote
ports ran into dev_loss_tmo. As a result, the LUNs were erroneously
not available again after resume.
Even a manually triggered adapter recovery (e.g. sysfs attribute
failed, or device offline/online via sysfs) could not recover the
adapter due to the remaining disconnected state of the corresponding
ccw device.
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org> #2.6.32+
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
2012-09-04 20:23:32 +07:00
|
|
|
* @set: Status flags to set.
|
|
|
|
* @tag: s390dbf trace record tag
|
2005-04-17 05:20:36 +07:00
|
|
|
*
|
|
|
|
* This function gets called by the common i/o layer and sets an adapter
|
2007-05-09 16:01:24 +07:00
|
|
|
* into state offline.
|
2005-04-17 05:20:36 +07:00
|
|
|
*/
|
[SCSI] zfcp: Do not wakeup while suspended
If the mapping of FCP device bus ID and corresponding subchannel
is modified while the Linux image is suspended, the resume of FCP
devices can fail. During resume, zfcp gets callbacks from cio regarding
the modified subchannels but they can be arbitrarily mixed with the
restore/resume callback. Since the cio callbacks would trigger
adapter recovery, zfcp could wakeup before the resume callback.
Therefore, ignore the cio callbacks regarding subchannels while
being suspended. We can safely do so, since zfcp does not deal itself
with subchannels. For problem determination purposes, we still trace the
ignored callback events.
The following kernel messages could be seen on resume:
kernel: <WWPN>: parent <FCP device bus ID> should not be sleeping
As part of adapter reopen recovery, zfcp performs auto port scanning
which can erroneously try to register new remote ports with
scsi_transport_fc and the device core code complains about the parent
(adapter) still sleeping.
kernel: zfcp.3dff9c: <FCP device bus ID>:\
Setting up the QDIO connection to the FCP adapter failed
<last kernel message repeated 3 more times>
kernel: zfcp.574d43: <FCP device bus ID>:\
ERP cannot recover an error on the FCP device
In such cases, the adapter gave up recovery and remained blocked along
with its child objects: remote ports and LUNs/scsi devices. Even the
adapter shutdown as part of giving up recovery failed because the ccw
device state remained disconnected. Later, the corresponding remote
ports ran into dev_loss_tmo. As a result, the LUNs were erroneously
not available again after resume.
Even a manually triggered adapter recovery (e.g. sysfs attribute
failed, or device offline/online via sysfs) could not recover the
adapter due to the remaining disconnected state of the corresponding
ccw device.
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org> #2.6.32+
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
2012-09-04 20:23:32 +07:00
|
|
|
static int zfcp_ccw_offline_sync(struct ccw_device *cdev, int set, char *tag)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2009-11-24 22:54:00 +07:00
|
|
|
struct zfcp_adapter *adapter = zfcp_ccw_adapter_by_cdev(cdev);
|
|
|
|
|
|
|
|
if (!adapter)
|
|
|
|
return 0;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
[SCSI] zfcp: Do not wakeup while suspended
If the mapping of FCP device bus ID and corresponding subchannel
is modified while the Linux image is suspended, the resume of FCP
devices can fail. During resume, zfcp gets callbacks from cio regarding
the modified subchannels but they can be arbitrarily mixed with the
restore/resume callback. Since the cio callbacks would trigger
adapter recovery, zfcp could wakeup before the resume callback.
Therefore, ignore the cio callbacks regarding subchannels while
being suspended. We can safely do so, since zfcp does not deal itself
with subchannels. For problem determination purposes, we still trace the
ignored callback events.
The following kernel messages could be seen on resume:
kernel: <WWPN>: parent <FCP device bus ID> should not be sleeping
As part of adapter reopen recovery, zfcp performs auto port scanning
which can erroneously try to register new remote ports with
scsi_transport_fc and the device core code complains about the parent
(adapter) still sleeping.
kernel: zfcp.3dff9c: <FCP device bus ID>:\
Setting up the QDIO connection to the FCP adapter failed
<last kernel message repeated 3 more times>
kernel: zfcp.574d43: <FCP device bus ID>:\
ERP cannot recover an error on the FCP device
In such cases, the adapter gave up recovery and remained blocked along
with its child objects: remote ports and LUNs/scsi devices. Even the
adapter shutdown as part of giving up recovery failed because the ccw
device state remained disconnected. Later, the corresponding remote
ports ran into dev_loss_tmo. As a result, the LUNs were erroneously
not available again after resume.
Even a manually triggered adapter recovery (e.g. sysfs attribute
failed, or device offline/online via sysfs) could not recover the
adapter due to the remaining disconnected state of the corresponding
ccw device.
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org> #2.6.32+
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
2012-09-04 20:23:32 +07:00
|
|
|
zfcp_erp_set_adapter_status(adapter, set);
|
|
|
|
zfcp_erp_adapter_shutdown(adapter, 0, tag);
|
2005-04-17 05:20:36 +07:00
|
|
|
zfcp_erp_wait(adapter);
|
2009-11-24 22:54:00 +07:00
|
|
|
|
|
|
|
zfcp_ccw_adapter_put(adapter);
|
2005-04-17 05:20:36 +07:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
[SCSI] zfcp: Do not wakeup while suspended
If the mapping of FCP device bus ID and corresponding subchannel
is modified while the Linux image is suspended, the resume of FCP
devices can fail. During resume, zfcp gets callbacks from cio regarding
the modified subchannels but they can be arbitrarily mixed with the
restore/resume callback. Since the cio callbacks would trigger
adapter recovery, zfcp could wakeup before the resume callback.
Therefore, ignore the cio callbacks regarding subchannels while
being suspended. We can safely do so, since zfcp does not deal itself
with subchannels. For problem determination purposes, we still trace the
ignored callback events.
The following kernel messages could be seen on resume:
kernel: <WWPN>: parent <FCP device bus ID> should not be sleeping
As part of adapter reopen recovery, zfcp performs auto port scanning
which can erroneously try to register new remote ports with
scsi_transport_fc and the device core code complains about the parent
(adapter) still sleeping.
kernel: zfcp.3dff9c: <FCP device bus ID>:\
Setting up the QDIO connection to the FCP adapter failed
<last kernel message repeated 3 more times>
kernel: zfcp.574d43: <FCP device bus ID>:\
ERP cannot recover an error on the FCP device
In such cases, the adapter gave up recovery and remained blocked along
with its child objects: remote ports and LUNs/scsi devices. Even the
adapter shutdown as part of giving up recovery failed because the ccw
device state remained disconnected. Later, the corresponding remote
ports ran into dev_loss_tmo. As a result, the LUNs were erroneously
not available again after resume.
Even a manually triggered adapter recovery (e.g. sysfs attribute
failed, or device offline/online via sysfs) could not recover the
adapter due to the remaining disconnected state of the corresponding
ccw device.
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org> #2.6.32+
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
2012-09-04 20:23:32 +07:00
|
|
|
/**
|
|
|
|
* zfcp_ccw_set_offline - set_offline function of zfcp driver
|
|
|
|
* @cdev: pointer to belonging ccw device
|
|
|
|
*
|
|
|
|
* This function gets called by the common i/o layer and sets an adapter
|
|
|
|
* into state offline.
|
|
|
|
*/
|
|
|
|
static int zfcp_ccw_set_offline(struct ccw_device *cdev)
|
|
|
|
{
|
|
|
|
return zfcp_ccw_offline_sync(cdev, 0, "ccsoff1");
|
|
|
|
}
|
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
/**
|
2008-06-10 23:20:56 +07:00
|
|
|
* zfcp_ccw_notify - ccw notify function
|
2009-11-24 22:54:00 +07:00
|
|
|
* @cdev: pointer to belonging ccw device
|
2005-04-17 05:20:36 +07:00
|
|
|
* @event: indicates if adapter was detached or attached
|
|
|
|
*
|
|
|
|
* This function gets called by the common i/o layer if an adapter has gone
|
|
|
|
* or reappeared.
|
|
|
|
*/
|
2009-11-24 22:54:00 +07:00
|
|
|
static int zfcp_ccw_notify(struct ccw_device *cdev, int event)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2009-11-24 22:54:00 +07:00
|
|
|
struct zfcp_adapter *adapter = zfcp_ccw_adapter_by_cdev(cdev);
|
|
|
|
|
|
|
|
if (!adapter)
|
|
|
|
return 1;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
|
|
|
switch (event) {
|
|
|
|
case CIO_GONE:
|
[SCSI] zfcp: Do not wakeup while suspended
If the mapping of FCP device bus ID and corresponding subchannel
is modified while the Linux image is suspended, the resume of FCP
devices can fail. During resume, zfcp gets callbacks from cio regarding
the modified subchannels but they can be arbitrarily mixed with the
restore/resume callback. Since the cio callbacks would trigger
adapter recovery, zfcp could wakeup before the resume callback.
Therefore, ignore the cio callbacks regarding subchannels while
being suspended. We can safely do so, since zfcp does not deal itself
with subchannels. For problem determination purposes, we still trace the
ignored callback events.
The following kernel messages could be seen on resume:
kernel: <WWPN>: parent <FCP device bus ID> should not be sleeping
As part of adapter reopen recovery, zfcp performs auto port scanning
which can erroneously try to register new remote ports with
scsi_transport_fc and the device core code complains about the parent
(adapter) still sleeping.
kernel: zfcp.3dff9c: <FCP device bus ID>:\
Setting up the QDIO connection to the FCP adapter failed
<last kernel message repeated 3 more times>
kernel: zfcp.574d43: <FCP device bus ID>:\
ERP cannot recover an error on the FCP device
In such cases, the adapter gave up recovery and remained blocked along
with its child objects: remote ports and LUNs/scsi devices. Even the
adapter shutdown as part of giving up recovery failed because the ccw
device state remained disconnected. Later, the corresponding remote
ports ran into dev_loss_tmo. As a result, the LUNs were erroneously
not available again after resume.
Even a manually triggered adapter recovery (e.g. sysfs attribute
failed, or device offline/online via sysfs) could not recover the
adapter due to the remaining disconnected state of the corresponding
ccw device.
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org> #2.6.32+
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
2012-09-04 20:23:32 +07:00
|
|
|
if (atomic_read(&adapter->status) &
|
|
|
|
ZFCP_STATUS_ADAPTER_SUSPENDED) { /* notification ignore */
|
|
|
|
zfcp_dbf_hba_basic("ccnigo1", adapter);
|
|
|
|
break;
|
|
|
|
}
|
2009-11-24 22:54:00 +07:00
|
|
|
dev_warn(&cdev->dev, "The FCP device has been detached\n");
|
2010-12-02 21:16:16 +07:00
|
|
|
zfcp_erp_adapter_shutdown(adapter, 0, "ccnoti1");
|
2005-04-17 05:20:36 +07:00
|
|
|
break;
|
|
|
|
case CIO_NO_PATH:
|
2009-11-24 22:54:00 +07:00
|
|
|
dev_warn(&cdev->dev,
|
2008-10-01 17:42:15 +07:00
|
|
|
"The CHPID for the FCP device is offline\n");
|
2010-12-02 21:16:16 +07:00
|
|
|
zfcp_erp_adapter_shutdown(adapter, 0, "ccnoti2");
|
2005-04-17 05:20:36 +07:00
|
|
|
break;
|
|
|
|
case CIO_OPER:
|
[SCSI] zfcp: Do not wakeup while suspended
If the mapping of FCP device bus ID and corresponding subchannel
is modified while the Linux image is suspended, the resume of FCP
devices can fail. During resume, zfcp gets callbacks from cio regarding
the modified subchannels but they can be arbitrarily mixed with the
restore/resume callback. Since the cio callbacks would trigger
adapter recovery, zfcp could wakeup before the resume callback.
Therefore, ignore the cio callbacks regarding subchannels while
being suspended. We can safely do so, since zfcp does not deal itself
with subchannels. For problem determination purposes, we still trace the
ignored callback events.
The following kernel messages could be seen on resume:
kernel: <WWPN>: parent <FCP device bus ID> should not be sleeping
As part of adapter reopen recovery, zfcp performs auto port scanning
which can erroneously try to register new remote ports with
scsi_transport_fc and the device core code complains about the parent
(adapter) still sleeping.
kernel: zfcp.3dff9c: <FCP device bus ID>:\
Setting up the QDIO connection to the FCP adapter failed
<last kernel message repeated 3 more times>
kernel: zfcp.574d43: <FCP device bus ID>:\
ERP cannot recover an error on the FCP device
In such cases, the adapter gave up recovery and remained blocked along
with its child objects: remote ports and LUNs/scsi devices. Even the
adapter shutdown as part of giving up recovery failed because the ccw
device state remained disconnected. Later, the corresponding remote
ports ran into dev_loss_tmo. As a result, the LUNs were erroneously
not available again after resume.
Even a manually triggered adapter recovery (e.g. sysfs attribute
failed, or device offline/online via sysfs) could not recover the
adapter due to the remaining disconnected state of the corresponding
ccw device.
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org> #2.6.32+
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
2012-09-04 20:23:32 +07:00
|
|
|
if (atomic_read(&adapter->status) &
|
|
|
|
ZFCP_STATUS_ADAPTER_SUSPENDED) { /* notification ignore */
|
|
|
|
zfcp_dbf_hba_basic("ccniop1", adapter);
|
|
|
|
break;
|
|
|
|
}
|
2009-11-24 22:54:00 +07:00
|
|
|
dev_info(&cdev->dev, "The FCP device is operational again\n");
|
2010-09-08 19:40:01 +07:00
|
|
|
zfcp_erp_set_adapter_status(adapter,
|
|
|
|
ZFCP_STATUS_COMMON_RUNNING);
|
2008-04-18 17:51:55 +07:00
|
|
|
zfcp_erp_adapter_reopen(adapter, ZFCP_STATUS_COMMON_ERP_FAILED,
|
2010-12-02 21:16:16 +07:00
|
|
|
"ccnoti4");
|
2005-04-17 05:20:36 +07:00
|
|
|
break;
|
2009-04-01 00:16:05 +07:00
|
|
|
case CIO_BOXED:
|
2009-11-24 22:54:00 +07:00
|
|
|
dev_warn(&cdev->dev, "The FCP device did not respond within "
|
|
|
|
"the specified time\n");
|
2010-12-02 21:16:16 +07:00
|
|
|
zfcp_erp_adapter_shutdown(adapter, 0, "ccnoti5");
|
2009-04-01 00:16:05 +07:00
|
|
|
break;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
2009-11-24 22:54:00 +07:00
|
|
|
|
|
|
|
zfcp_ccw_adapter_put(adapter);
|
2005-04-17 05:20:36 +07:00
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2008-06-10 23:20:56 +07:00
|
|
|
* zfcp_ccw_shutdown - handle shutdown from cio
|
|
|
|
* @cdev: device for adapter to shutdown.
|
2005-04-17 05:20:36 +07:00
|
|
|
*/
|
2008-06-10 23:20:56 +07:00
|
|
|
static void zfcp_ccw_shutdown(struct ccw_device *cdev)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2009-11-24 22:54:00 +07:00
|
|
|
struct zfcp_adapter *adapter = zfcp_ccw_adapter_by_cdev(cdev);
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2009-09-24 15:23:23 +07:00
|
|
|
if (!adapter)
|
2009-11-24 22:54:00 +07:00
|
|
|
return;
|
2009-09-24 15:23:23 +07:00
|
|
|
|
2010-12-02 21:16:16 +07:00
|
|
|
zfcp_erp_adapter_shutdown(adapter, 0, "ccshut1");
|
2005-04-17 05:20:36 +07:00
|
|
|
zfcp_erp_wait(adapter);
|
2009-08-18 20:43:27 +07:00
|
|
|
zfcp_erp_thread_kill(adapter);
|
2009-11-24 22:54:00 +07:00
|
|
|
|
|
|
|
zfcp_ccw_adapter_put(adapter);
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
[SCSI] zfcp: Do not wakeup while suspended
If the mapping of FCP device bus ID and corresponding subchannel
is modified while the Linux image is suspended, the resume of FCP
devices can fail. During resume, zfcp gets callbacks from cio regarding
the modified subchannels but they can be arbitrarily mixed with the
restore/resume callback. Since the cio callbacks would trigger
adapter recovery, zfcp could wakeup before the resume callback.
Therefore, ignore the cio callbacks regarding subchannels while
being suspended. We can safely do so, since zfcp does not deal itself
with subchannels. For problem determination purposes, we still trace the
ignored callback events.
The following kernel messages could be seen on resume:
kernel: <WWPN>: parent <FCP device bus ID> should not be sleeping
As part of adapter reopen recovery, zfcp performs auto port scanning
which can erroneously try to register new remote ports with
scsi_transport_fc and the device core code complains about the parent
(adapter) still sleeping.
kernel: zfcp.3dff9c: <FCP device bus ID>:\
Setting up the QDIO connection to the FCP adapter failed
<last kernel message repeated 3 more times>
kernel: zfcp.574d43: <FCP device bus ID>:\
ERP cannot recover an error on the FCP device
In such cases, the adapter gave up recovery and remained blocked along
with its child objects: remote ports and LUNs/scsi devices. Even the
adapter shutdown as part of giving up recovery failed because the ccw
device state remained disconnected. Later, the corresponding remote
ports ran into dev_loss_tmo. As a result, the LUNs were erroneously
not available again after resume.
Even a manually triggered adapter recovery (e.g. sysfs attribute
failed, or device offline/online via sysfs) could not recover the
adapter due to the remaining disconnected state of the corresponding
ccw device.
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org> #2.6.32+
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
2012-09-04 20:23:32 +07:00
|
|
|
static int zfcp_ccw_suspend(struct ccw_device *cdev)
|
|
|
|
{
|
|
|
|
zfcp_ccw_offline_sync(cdev, ZFCP_STATUS_ADAPTER_SUSPENDED, "ccsusp1");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int zfcp_ccw_thaw(struct ccw_device *cdev)
|
|
|
|
{
|
|
|
|
/* trace records for thaw and final shutdown during suspend
|
|
|
|
can only be found in system dump until the end of suspend
|
|
|
|
but not after resume because it's based on the memory image
|
|
|
|
right after the very first suspend (freeze) callback */
|
|
|
|
zfcp_ccw_activate(cdev, 0, "ccthaw1");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int zfcp_ccw_resume(struct ccw_device *cdev)
|
|
|
|
{
|
|
|
|
zfcp_ccw_activate(cdev, ZFCP_STATUS_ADAPTER_SUSPENDED, "ccresu1");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-09-24 15:23:22 +07:00
|
|
|
struct ccw_driver zfcp_ccw_driver = {
|
2011-03-23 16:16:02 +07:00
|
|
|
.driver = {
|
|
|
|
.owner = THIS_MODULE,
|
|
|
|
.name = "zfcp",
|
|
|
|
},
|
2008-06-10 23:20:56 +07:00
|
|
|
.ids = zfcp_ccw_device_id,
|
|
|
|
.probe = zfcp_ccw_probe,
|
|
|
|
.remove = zfcp_ccw_remove,
|
|
|
|
.set_online = zfcp_ccw_set_online,
|
|
|
|
.set_offline = zfcp_ccw_set_offline,
|
|
|
|
.notify = zfcp_ccw_notify,
|
|
|
|
.shutdown = zfcp_ccw_shutdown,
|
[SCSI] zfcp: Do not wakeup while suspended
If the mapping of FCP device bus ID and corresponding subchannel
is modified while the Linux image is suspended, the resume of FCP
devices can fail. During resume, zfcp gets callbacks from cio regarding
the modified subchannels but they can be arbitrarily mixed with the
restore/resume callback. Since the cio callbacks would trigger
adapter recovery, zfcp could wakeup before the resume callback.
Therefore, ignore the cio callbacks regarding subchannels while
being suspended. We can safely do so, since zfcp does not deal itself
with subchannels. For problem determination purposes, we still trace the
ignored callback events.
The following kernel messages could be seen on resume:
kernel: <WWPN>: parent <FCP device bus ID> should not be sleeping
As part of adapter reopen recovery, zfcp performs auto port scanning
which can erroneously try to register new remote ports with
scsi_transport_fc and the device core code complains about the parent
(adapter) still sleeping.
kernel: zfcp.3dff9c: <FCP device bus ID>:\
Setting up the QDIO connection to the FCP adapter failed
<last kernel message repeated 3 more times>
kernel: zfcp.574d43: <FCP device bus ID>:\
ERP cannot recover an error on the FCP device
In such cases, the adapter gave up recovery and remained blocked along
with its child objects: remote ports and LUNs/scsi devices. Even the
adapter shutdown as part of giving up recovery failed because the ccw
device state remained disconnected. Later, the corresponding remote
ports ran into dev_loss_tmo. As a result, the LUNs were erroneously
not available again after resume.
Even a manually triggered adapter recovery (e.g. sysfs attribute
failed, or device offline/online via sysfs) could not recover the
adapter due to the remaining disconnected state of the corresponding
ccw device.
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org> #2.6.32+
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
2012-09-04 20:23:32 +07:00
|
|
|
.freeze = zfcp_ccw_suspend,
|
|
|
|
.thaw = zfcp_ccw_thaw,
|
|
|
|
.restore = zfcp_ccw_resume,
|
2008-06-10 23:20:56 +07:00
|
|
|
};
|