2016-07-08 13:37:08 +07:00
|
|
|
/*
|
|
|
|
* Copyright 2016 IBM Corporation.
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU General Public License
|
|
|
|
* as published by the Free Software Foundation; either version
|
|
|
|
* 2 of the License, or (at your option) any later version.
|
|
|
|
*/
|
|
|
|
#include <linux/types.h>
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/irq.h>
|
|
|
|
#include <linux/smp.h>
|
|
|
|
#include <linux/interrupt.h>
|
|
|
|
#include <linux/cpu.h>
|
|
|
|
#include <linux/of.h>
|
|
|
|
|
|
|
|
#include <asm/smp.h>
|
|
|
|
#include <asm/irq.h>
|
|
|
|
#include <asm/errno.h>
|
|
|
|
#include <asm/xics.h>
|
|
|
|
#include <asm/io.h>
|
|
|
|
#include <asm/opal.h>
|
2017-01-17 00:58:53 +07:00
|
|
|
#include <asm/kvm_ppc.h>
|
2016-07-08 13:37:08 +07:00
|
|
|
|
|
|
|
static void icp_opal_teardown_cpu(void)
|
|
|
|
{
|
2016-09-06 10:43:45 +07:00
|
|
|
int hw_cpu = hard_smp_processor_id();
|
2016-07-08 13:37:08 +07:00
|
|
|
|
|
|
|
/* Clear any pending IPI */
|
2016-09-06 10:43:45 +07:00
|
|
|
opal_int_set_mfrr(hw_cpu, 0xff);
|
2016-07-08 13:37:08 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static void icp_opal_flush_ipi(void)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* We take the ipi irq but and never return so we need to EOI the IPI,
|
|
|
|
* but want to leave our priority 0.
|
|
|
|
*
|
|
|
|
* Should we check all the other interrupts too?
|
|
|
|
* Should we be flagging idle loop instead?
|
|
|
|
* Or creating some task to be scheduled?
|
|
|
|
*/
|
2017-01-17 00:58:53 +07:00
|
|
|
if (opal_int_eoi((0x00 << 24) | XICS_IPI) > 0)
|
|
|
|
force_external_irq_replay();
|
|
|
|
}
|
|
|
|
|
|
|
|
static unsigned int icp_opal_get_xirr(void)
|
|
|
|
{
|
|
|
|
unsigned int kvm_xirr;
|
|
|
|
__be32 hw_xirr;
|
|
|
|
int64_t rc;
|
|
|
|
|
|
|
|
/* Handle an interrupt latched by KVM first */
|
|
|
|
kvm_xirr = kvmppc_get_xics_latch();
|
|
|
|
if (kvm_xirr)
|
|
|
|
return kvm_xirr;
|
|
|
|
|
|
|
|
/* Then ask OPAL */
|
|
|
|
rc = opal_int_get_xirr(&hw_xirr, false);
|
|
|
|
if (rc < 0)
|
|
|
|
return 0;
|
|
|
|
return be32_to_cpu(hw_xirr);
|
2016-07-08 13:37:08 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static unsigned int icp_opal_get_irq(void)
|
|
|
|
{
|
|
|
|
unsigned int xirr;
|
|
|
|
unsigned int vec;
|
|
|
|
unsigned int irq;
|
|
|
|
|
2017-01-17 00:58:53 +07:00
|
|
|
xirr = icp_opal_get_xirr();
|
2016-07-08 13:37:08 +07:00
|
|
|
vec = xirr & 0x00ffffff;
|
|
|
|
if (vec == XICS_IRQ_SPURIOUS)
|
2016-09-06 18:53:24 +07:00
|
|
|
return 0;
|
2016-07-08 13:37:08 +07:00
|
|
|
|
|
|
|
irq = irq_find_mapping(xics_host, vec);
|
2016-09-06 18:53:24 +07:00
|
|
|
if (likely(irq)) {
|
2016-07-08 13:37:08 +07:00
|
|
|
xics_push_cppr(vec);
|
|
|
|
return irq;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* We don't have a linux mapping, so have rtas mask it. */
|
|
|
|
xics_mask_unknown_vec(vec);
|
|
|
|
|
|
|
|
/* We might learn about it later, so EOI it */
|
2017-01-17 00:58:53 +07:00
|
|
|
if (opal_int_eoi(xirr) > 0)
|
|
|
|
force_external_irq_replay();
|
2016-07-08 13:37:08 +07:00
|
|
|
|
2016-09-06 18:53:24 +07:00
|
|
|
return 0;
|
2016-07-08 13:37:08 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static void icp_opal_set_cpu_priority(unsigned char cppr)
|
|
|
|
{
|
powerpc/xics: Work around limitations of OPAL XICS priority handling
The CPPR (Current Processor Priority Register) of a XICS interrupt
presentation controller contains a value N, such that only interrupts
with a priority "more favoured" than N will be received by the CPU,
where "more favoured" means "less than". So if the CPPR has the value 5
then only interrupts with a priority of 0-4 inclusive will be received.
In theory the CPPR can support a value of 0 to 255 inclusive.
In practice Linux only uses values of 0, 4, 5 and 0xff. Setting the CPPR
to 0 rejects all interrupts, setting it to 0xff allows all interrupts.
The values 4 and 5 are used to differentiate IPIs from external
interrupts. Setting the CPPR to 5 allows IPIs to be received but not
external interrupts.
The CPPR emulation in the OPAL XICS implementation only directly
supports priorities 0 and 0xff. All other priorities are considered
equivalent, and mapped to a single priority value internally. This means
when using icp-opal we can not allow IPIs but not externals.
This breaks Linux's use of priority values when a CPU is hot unplugged.
After migrating IRQs away from the CPU that is being offlined, we set
the priority to 5, meaning we still want the offline CPU to receive
IPIs. But the effect of the OPAL XICS emulation's use of a single
priority value is that all interrupts are rejected by the CPU. With the
CPU offline, and not receiving IPIs, we may not be able to wake it up to
bring it back online.
The first part of the fix is in icp_opal_set_cpu_priority(). CPPR values
of 0 to 4 inclusive will correctly cause all interrupts to be rejected,
so we pass those CPPR values through to OPAL. However if we are called
with a CPPR of 5 or greater, the caller is expecting to be able to allow
IPIs but not external interrupts. We know this doesn't work, so instead
of rejecting all interrupts we choose the opposite which is to allow all
interrupts. This is still not correct behaviour, but we know for the
only existing caller (xics_migrate_irqs_away()), that it is the better
option.
The other part of the fix is in xics_migrate_irqs_away(). Instead of
setting priority (CPPR) to 0, and then back to 5 before migrating IRQs,
we migrate the IRQs before setting the priority back to 5. This should
have no effect on an ICP backend with a working set_priority(), and on
icp-opal it means we will keep all interrupts blocked until after we've
finished doing the IRQ migration. Additionally we wait for 5ms after
doing the migration to make sure there are no IRQs in flight.
Fixes: d74361881f0d ("powerpc/xics: Add ICP OPAL backend")
Cc: stable@vger.kernel.org # v4.8+
Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
Reported-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Tested-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Signed-off-by: Balbir Singh <bsingharora@gmail.com>
[mpe: Rewrote comments and change log, change delay to 5ms]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
2017-03-03 07:58:44 +07:00
|
|
|
/*
|
|
|
|
* Here be dragons. The caller has asked to allow only IPI's and not
|
|
|
|
* external interrupts. But OPAL XIVE doesn't support that. So instead
|
|
|
|
* of allowing no interrupts allow all. That's still not right, but
|
|
|
|
* currently the only caller who does this is xics_migrate_irqs_away()
|
|
|
|
* and it works in that case.
|
|
|
|
*/
|
|
|
|
if (cppr >= DEFAULT_PRIORITY)
|
|
|
|
cppr = LOWEST_PRIORITY;
|
|
|
|
|
2016-07-08 13:37:08 +07:00
|
|
|
xics_set_base_cppr(cppr);
|
|
|
|
opal_int_set_cppr(cppr);
|
|
|
|
iosync();
|
|
|
|
}
|
|
|
|
|
|
|
|
static void icp_opal_eoi(struct irq_data *d)
|
|
|
|
{
|
|
|
|
unsigned int hw_irq = (unsigned int)irqd_to_hwirq(d);
|
|
|
|
int64_t rc;
|
|
|
|
|
|
|
|
iosync();
|
|
|
|
rc = opal_int_eoi((xics_pop_cppr() << 24) | hw_irq);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* EOI tells us whether there are more interrupts to fetch.
|
|
|
|
*
|
|
|
|
* Some HW implementations might not be able to send us another
|
|
|
|
* external interrupt in that case, so we force a replay.
|
|
|
|
*/
|
|
|
|
if (rc > 0)
|
|
|
|
force_external_irq_replay();
|
|
|
|
}
|
|
|
|
|
|
|
|
#ifdef CONFIG_SMP
|
|
|
|
|
2017-04-13 17:16:21 +07:00
|
|
|
static void icp_opal_cause_ipi(int cpu)
|
2016-07-08 13:37:08 +07:00
|
|
|
{
|
2016-09-06 10:43:45 +07:00
|
|
|
int hw_cpu = get_hard_smp_processor_id(cpu);
|
|
|
|
|
2017-02-07 07:35:36 +07:00
|
|
|
kvmppc_set_host_ipi(cpu, 1);
|
2016-09-06 10:43:45 +07:00
|
|
|
opal_int_set_mfrr(hw_cpu, IPI_PRIORITY);
|
2016-07-08 13:37:08 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static irqreturn_t icp_opal_ipi_action(int irq, void *dev_id)
|
|
|
|
{
|
2017-02-07 07:35:36 +07:00
|
|
|
int cpu = smp_processor_id();
|
2016-07-08 13:37:08 +07:00
|
|
|
|
2017-02-07 07:35:36 +07:00
|
|
|
kvmppc_set_host_ipi(cpu, 0);
|
|
|
|
opal_int_set_mfrr(get_hard_smp_processor_id(cpu), 0xff);
|
2016-07-08 13:37:08 +07:00
|
|
|
|
|
|
|
return smp_ipi_demux();
|
|
|
|
}
|
|
|
|
|
2017-02-07 07:35:31 +07:00
|
|
|
/*
|
|
|
|
* Called when an interrupt is received on an off-line CPU to
|
|
|
|
* clear the interrupt, so that the CPU can go back to nap mode.
|
|
|
|
*/
|
|
|
|
void icp_opal_flush_interrupt(void)
|
|
|
|
{
|
|
|
|
unsigned int xirr;
|
|
|
|
unsigned int vec;
|
|
|
|
|
|
|
|
do {
|
|
|
|
xirr = icp_opal_get_xirr();
|
|
|
|
vec = xirr & 0x00ffffff;
|
|
|
|
if (vec == XICS_IRQ_SPURIOUS)
|
|
|
|
break;
|
|
|
|
if (vec == XICS_IPI) {
|
|
|
|
/* Clear pending IPI */
|
|
|
|
int cpu = smp_processor_id();
|
|
|
|
kvmppc_set_host_ipi(cpu, 0);
|
|
|
|
opal_int_set_mfrr(get_hard_smp_processor_id(cpu), 0xff);
|
|
|
|
} else {
|
|
|
|
pr_err("XICS: hw interrupt 0x%x to offline cpu, "
|
|
|
|
"disabling\n", vec);
|
|
|
|
xics_mask_unknown_vec(vec);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* EOI the interrupt */
|
|
|
|
} while (opal_int_eoi(xirr) > 0);
|
|
|
|
}
|
|
|
|
|
2016-07-08 13:37:08 +07:00
|
|
|
#endif /* CONFIG_SMP */
|
|
|
|
|
|
|
|
static const struct icp_ops icp_opal_ops = {
|
|
|
|
.get_irq = icp_opal_get_irq,
|
|
|
|
.eoi = icp_opal_eoi,
|
|
|
|
.set_priority = icp_opal_set_cpu_priority,
|
|
|
|
.teardown_cpu = icp_opal_teardown_cpu,
|
|
|
|
.flush_ipi = icp_opal_flush_ipi,
|
|
|
|
#ifdef CONFIG_SMP
|
|
|
|
.ipi_action = icp_opal_ipi_action,
|
|
|
|
.cause_ipi = icp_opal_cause_ipi,
|
|
|
|
#endif
|
|
|
|
};
|
|
|
|
|
|
|
|
int icp_opal_init(void)
|
|
|
|
{
|
|
|
|
struct device_node *np;
|
|
|
|
|
|
|
|
np = of_find_compatible_node(NULL, NULL, "ibm,opal-intc");
|
|
|
|
if (!np)
|
|
|
|
return -ENODEV;
|
|
|
|
|
|
|
|
icp_ops = &icp_opal_ops;
|
|
|
|
|
|
|
|
printk("XICS: Using OPAL ICP fallbacks\n");
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|