2005-04-17 05:20:36 +07:00
|
|
|
/*
|
2005-05-21 01:33:25 +07:00
|
|
|
* w1_therm.c
|
2005-04-17 05:20:36 +07:00
|
|
|
*
|
2011-08-26 05:59:06 +07:00
|
|
|
* Copyright (c) 2004 Evgeniy Polyakov <zbr@ioremap.net>
|
2005-05-21 01:33:25 +07:00
|
|
|
*
|
2005-04-17 05:20:36 +07:00
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the therms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program; if not, write to the Free Software
|
|
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <asm/types.h>
|
|
|
|
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/moduleparam.h>
|
2006-10-18 12:47:25 +07:00
|
|
|
#include <linux/sched.h>
|
2005-04-17 05:20:36 +07:00
|
|
|
#include <linux/device.h>
|
|
|
|
#include <linux/types.h>
|
|
|
|
#include <linux/delay.h>
|
|
|
|
|
2005-12-06 17:38:28 +07:00
|
|
|
#include "../w1.h"
|
|
|
|
#include "../w1_int.h"
|
|
|
|
#include "../w1_family.h"
|
2005-04-17 05:20:36 +07:00
|
|
|
|
|
|
|
MODULE_LICENSE("GPL");
|
2011-08-26 05:59:06 +07:00
|
|
|
MODULE_AUTHOR("Evgeniy Polyakov <zbr@ioremap.net>");
|
2005-04-17 05:20:36 +07:00
|
|
|
MODULE_DESCRIPTION("Driver for 1-wire Dallas network protocol, temperature family.");
|
|
|
|
|
2008-10-16 12:04:43 +07:00
|
|
|
/* Allow the strong pullup to be disabled, but default to enabled.
|
|
|
|
* If it was disabled a parasite powered device might not get the require
|
|
|
|
* current to do a temperature conversion. If it is enabled parasite powered
|
|
|
|
* devices have a better chance of getting the current required.
|
|
|
|
*/
|
|
|
|
static int w1_strong_pullup = 1;
|
|
|
|
module_param_named(strong_pullup, w1_strong_pullup, int, 0);
|
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
static u8 bad_roms[][9] = {
|
2005-05-21 01:33:25 +07:00
|
|
|
{0xaa, 0x00, 0x4b, 0x46, 0xff, 0xff, 0x0c, 0x10, 0x87},
|
2005-04-17 05:20:36 +07:00
|
|
|
{}
|
|
|
|
};
|
|
|
|
|
2008-10-16 12:04:51 +07:00
|
|
|
static ssize_t w1_therm_read(struct device *device,
|
|
|
|
struct device_attribute *attr, char *buf);
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2008-10-16 12:04:51 +07:00
|
|
|
static struct device_attribute w1_therm_attr =
|
|
|
|
__ATTR(w1_slave, S_IRUGO, w1_therm_read, NULL);
|
2005-08-11 20:27:50 +07:00
|
|
|
|
|
|
|
static int w1_therm_add_slave(struct w1_slave *sl)
|
|
|
|
{
|
2008-10-16 12:04:51 +07:00
|
|
|
return device_create_file(&sl->dev, &w1_therm_attr);
|
2005-08-11 20:27:50 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static void w1_therm_remove_slave(struct w1_slave *sl)
|
|
|
|
{
|
2008-10-16 12:04:51 +07:00
|
|
|
device_remove_file(&sl->dev, &w1_therm_attr);
|
2005-08-11 20:27:50 +07:00
|
|
|
}
|
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
static struct w1_family_ops w1_therm_fops = {
|
2005-08-11 20:27:50 +07:00
|
|
|
.add_slave = w1_therm_add_slave,
|
|
|
|
.remove_slave = w1_therm_remove_slave,
|
2005-04-17 05:20:36 +07:00
|
|
|
};
|
|
|
|
|
2005-04-18 01:58:14 +07:00
|
|
|
static struct w1_family w1_therm_family_DS18S20 = {
|
|
|
|
.fid = W1_THERM_DS18S20,
|
|
|
|
.fops = &w1_therm_fops,
|
|
|
|
};
|
|
|
|
|
|
|
|
static struct w1_family w1_therm_family_DS18B20 = {
|
|
|
|
.fid = W1_THERM_DS18B20,
|
|
|
|
.fops = &w1_therm_fops,
|
|
|
|
};
|
2005-08-11 20:27:50 +07:00
|
|
|
|
2005-04-18 01:58:14 +07:00
|
|
|
static struct w1_family w1_therm_family_DS1822 = {
|
|
|
|
.fid = W1_THERM_DS1822,
|
|
|
|
.fops = &w1_therm_fops,
|
|
|
|
};
|
|
|
|
|
2011-07-27 06:08:55 +07:00
|
|
|
static struct w1_family w1_therm_family_DS28EA00 = {
|
|
|
|
.fid = W1_THERM_DS28EA00,
|
|
|
|
.fops = &w1_therm_fops,
|
|
|
|
};
|
|
|
|
|
2005-04-18 01:58:14 +07:00
|
|
|
struct w1_therm_family_converter
|
|
|
|
{
|
|
|
|
u8 broken;
|
|
|
|
u16 reserved;
|
|
|
|
struct w1_family *f;
|
|
|
|
int (*convert)(u8 rom[9]);
|
|
|
|
};
|
|
|
|
|
2008-02-06 16:38:09 +07:00
|
|
|
/* The return value is millidegrees Centigrade. */
|
2005-04-18 01:58:14 +07:00
|
|
|
static inline int w1_DS18B20_convert_temp(u8 rom[9]);
|
|
|
|
static inline int w1_DS18S20_convert_temp(u8 rom[9]);
|
|
|
|
|
|
|
|
static struct w1_therm_family_converter w1_therm_families[] = {
|
|
|
|
{
|
|
|
|
.f = &w1_therm_family_DS18S20,
|
|
|
|
.convert = w1_DS18S20_convert_temp
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.f = &w1_therm_family_DS1822,
|
|
|
|
.convert = w1_DS18B20_convert_temp
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.f = &w1_therm_family_DS18B20,
|
|
|
|
.convert = w1_DS18B20_convert_temp
|
|
|
|
},
|
2011-07-27 06:08:55 +07:00
|
|
|
{
|
|
|
|
.f = &w1_therm_family_DS28EA00,
|
|
|
|
.convert = w1_DS18B20_convert_temp
|
|
|
|
},
|
2005-04-18 01:58:14 +07:00
|
|
|
};
|
|
|
|
|
|
|
|
static inline int w1_DS18B20_convert_temp(u8 rom[9])
|
|
|
|
{
|
2010-04-24 00:17:53 +07:00
|
|
|
s16 t = le16_to_cpup((__le16 *)rom);
|
|
|
|
return t*1000/16;
|
2005-04-18 01:58:14 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static inline int w1_DS18S20_convert_temp(u8 rom[9])
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
|
|
|
int t, h;
|
2005-04-18 01:58:14 +07:00
|
|
|
|
|
|
|
if (!rom[7])
|
|
|
|
return 0;
|
2005-12-06 17:38:28 +07:00
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
if (rom[1] == 0)
|
|
|
|
t = ((s32)rom[0] >> 1)*1000;
|
|
|
|
else
|
|
|
|
t = 1000*(-1*(s32)(0x100-rom[0]) >> 1);
|
2005-12-06 17:38:28 +07:00
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
t -= 250;
|
|
|
|
h = 1000*((s32)rom[7] - (s32)rom[6]);
|
|
|
|
h /= (s32)rom[7];
|
|
|
|
t += h;
|
|
|
|
|
|
|
|
return t;
|
|
|
|
}
|
|
|
|
|
2005-04-18 01:58:14 +07:00
|
|
|
static inline int w1_convert_temp(u8 rom[9], u8 fid)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
2007-02-12 15:52:05 +07:00
|
|
|
for (i = 0; i < ARRAY_SIZE(w1_therm_families); ++i)
|
2005-05-21 01:50:33 +07:00
|
|
|
if (w1_therm_families[i].f->fid == fid)
|
2005-04-18 01:58:14 +07:00
|
|
|
return w1_therm_families[i].convert(rom);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
static int w1_therm_check_rom(u8 rom[9])
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i=0; i<sizeof(bad_roms)/9; ++i)
|
|
|
|
if (!memcmp(bad_roms[i], rom, 9))
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-10-16 12:04:51 +07:00
|
|
|
static ssize_t w1_therm_read(struct device *device,
|
|
|
|
struct device_attribute *attr, char *buf)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2008-10-16 12:04:51 +07:00
|
|
|
struct w1_slave *sl = dev_to_w1_slave(device);
|
2005-04-17 05:20:36 +07:00
|
|
|
struct w1_master *dev = sl->master;
|
2011-11-16 06:43:16 +07:00
|
|
|
u8 rom[9], crc, verdict, external_power;
|
2005-04-17 05:20:36 +07:00
|
|
|
int i, max_trying = 10;
|
2008-10-16 12:04:51 +07:00
|
|
|
ssize_t c = PAGE_SIZE;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2012-05-18 12:59:52 +07:00
|
|
|
i = mutex_lock_interruptible(&dev->bus_mutex);
|
2011-11-16 06:43:16 +07:00
|
|
|
if (i != 0)
|
|
|
|
return i;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
|
|
|
memset(rom, 0, sizeof(rom));
|
|
|
|
|
|
|
|
verdict = 0;
|
|
|
|
crc = 0;
|
|
|
|
|
|
|
|
while (max_trying--) {
|
2005-08-11 20:27:49 +07:00
|
|
|
if (!w1_reset_select_slave(sl)) {
|
2005-04-17 05:20:36 +07:00
|
|
|
int count = 0;
|
|
|
|
unsigned int tm = 750;
|
2011-11-16 06:43:16 +07:00
|
|
|
unsigned long sleep_rem;
|
|
|
|
|
|
|
|
w1_write_8(dev, W1_READ_PSUPPLY);
|
|
|
|
external_power = w1_read_8(dev);
|
|
|
|
|
|
|
|
if (w1_reset_select_slave(sl))
|
|
|
|
continue;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2008-10-16 12:04:43 +07:00
|
|
|
/* 750ms strong pullup (or delay) after the convert */
|
2011-11-16 06:43:16 +07:00
|
|
|
if (!external_power && w1_strong_pullup)
|
2008-10-16 12:04:43 +07:00
|
|
|
w1_next_pullup(dev, tm);
|
2011-11-16 06:43:16 +07:00
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
w1_write_8(dev, W1_CONVERT_TEMP);
|
2011-11-16 06:43:16 +07:00
|
|
|
|
|
|
|
if (external_power) {
|
2012-05-18 12:59:52 +07:00
|
|
|
mutex_unlock(&dev->bus_mutex);
|
2011-11-16 06:43:16 +07:00
|
|
|
|
|
|
|
sleep_rem = msleep_interruptible(tm);
|
|
|
|
if (sleep_rem != 0)
|
|
|
|
return -EINTR;
|
|
|
|
|
2012-05-18 12:59:52 +07:00
|
|
|
i = mutex_lock_interruptible(&dev->bus_mutex);
|
2011-11-16 06:43:16 +07:00
|
|
|
if (i != 0)
|
|
|
|
return i;
|
|
|
|
} else if (!w1_strong_pullup) {
|
|
|
|
sleep_rem = msleep_interruptible(tm);
|
|
|
|
if (sleep_rem != 0) {
|
2012-05-18 12:59:52 +07:00
|
|
|
mutex_unlock(&dev->bus_mutex);
|
2011-11-16 06:43:16 +07:00
|
|
|
return -EINTR;
|
|
|
|
}
|
|
|
|
}
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2005-08-11 20:27:49 +07:00
|
|
|
if (!w1_reset_select_slave(sl)) {
|
2005-05-21 01:33:25 +07:00
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
w1_write_8(dev, W1_READ_SCRATCHPAD);
|
|
|
|
if ((count = w1_read_block(dev, rom, 9)) != 9) {
|
2008-10-16 12:04:51 +07:00
|
|
|
dev_warn(device, "w1_read_block() "
|
|
|
|
"returned %u instead of 9.\n",
|
|
|
|
count);
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
crc = w1_calc_crc8(rom, 8);
|
|
|
|
|
W1: w1_therm.c is flagging 0C etc as invalid
The extra rom[0] check is flagging valid temperatures as invalid when
there is already a CRC data transmission check.
w1_therm_read_bin()
if (rom[8] == crc && rom[0])
verdict = 1;
Requiring rom[0] to be non-zero will flag as invalid temperature
conversions when the low byte is zero, specifically the temperatures 0C,
16C, 32C, 48C, -16C, -32C, and -48C.
The CRC check is produced on the device for the previous 8 bytes and is
required to ensure the data integrity in transmission. I don't see why the
extra check for rom[0] being non-zero is in there. Evgeniy Polyakov didn't
know either. Just for a check I unplugged the sensor, executed a
temperature conversion, and read the results. The read was all ff's, which
also failed the CRC, so it doesn't need to protect against a disconnected
sensor.
I have more extensive patches in the work, but these two trivial ones will
do for today. I would like to hear from people who use the ds2490 USB to
one wire dongle. 1 if you would be willing to test the patches as I
currently only have the one sensor on a short parisite powered wire, 2 if
there is any cheap sources for the ds2490.
Signed-off-by: David Fries <david@fries.net>
Acked-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-01-22 18:31:39 +07:00
|
|
|
if (rom[8] == crc)
|
2005-04-17 05:20:36 +07:00
|
|
|
verdict = 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!w1_therm_check_rom(rom))
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
for (i = 0; i < 9; ++i)
|
2008-10-16 12:04:51 +07:00
|
|
|
c -= snprintf(buf + PAGE_SIZE - c, c, "%02x ", rom[i]);
|
|
|
|
c -= snprintf(buf + PAGE_SIZE - c, c, ": crc=%02x %s\n",
|
2005-04-17 05:20:36 +07:00
|
|
|
crc, (verdict) ? "YES" : "NO");
|
|
|
|
if (verdict)
|
|
|
|
memcpy(sl->rom, rom, sizeof(sl->rom));
|
|
|
|
else
|
2008-10-16 12:04:51 +07:00
|
|
|
dev_warn(device, "18S20 doesn't respond to CONVERT_TEMP.\n");
|
2005-04-17 05:20:36 +07:00
|
|
|
|
|
|
|
for (i = 0; i < 9; ++i)
|
2008-10-16 12:04:51 +07:00
|
|
|
c -= snprintf(buf + PAGE_SIZE - c, c, "%02x ", sl->rom[i]);
|
2005-12-06 17:38:28 +07:00
|
|
|
|
2008-10-16 12:04:51 +07:00
|
|
|
c -= snprintf(buf + PAGE_SIZE - c, c, "t=%d\n",
|
|
|
|
w1_convert_temp(rom, sl->family->fid));
|
2012-05-18 12:59:52 +07:00
|
|
|
mutex_unlock(&dev->bus_mutex);
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2008-10-16 12:04:51 +07:00
|
|
|
return PAGE_SIZE - c;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static int __init w1_therm_init(void)
|
|
|
|
{
|
2005-04-18 01:58:14 +07:00
|
|
|
int err, i;
|
|
|
|
|
2007-02-12 15:52:05 +07:00
|
|
|
for (i = 0; i < ARRAY_SIZE(w1_therm_families); ++i) {
|
2005-04-18 01:58:14 +07:00
|
|
|
err = w1_register_family(w1_therm_families[i].f);
|
|
|
|
if (err)
|
|
|
|
w1_therm_families[i].broken = 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static void __exit w1_therm_fini(void)
|
|
|
|
{
|
2005-04-18 01:58:14 +07:00
|
|
|
int i;
|
|
|
|
|
2007-02-12 15:52:05 +07:00
|
|
|
for (i = 0; i < ARRAY_SIZE(w1_therm_families); ++i)
|
2005-04-18 01:58:14 +07:00
|
|
|
if (!w1_therm_families[i].broken)
|
|
|
|
w1_unregister_family(w1_therm_families[i].f);
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
module_init(w1_therm_init);
|
|
|
|
module_exit(w1_therm_fini);
|