2009-12-18 09:24:27 +07:00
|
|
|
/*
|
|
|
|
* Copyright (C) 2008 Red Hat, Inc., Eric Paris <eparis@redhat.com>
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation; either version 2, or (at your option)
|
|
|
|
* any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program; see the file COPYING. If not, write to
|
|
|
|
* the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/*
|
|
|
|
* fsnotify inode mark locking/lifetime/and refcnting
|
|
|
|
*
|
|
|
|
* REFCNT:
|
2013-07-09 05:59:46 +07:00
|
|
|
* The group->recnt and mark->refcnt tell how many "things" in the kernel
|
|
|
|
* currently are referencing the objects. Both kind of objects typically will
|
|
|
|
* live inside the kernel with a refcnt of 2, one for its creation and one for
|
|
|
|
* the reference a group and a mark hold to each other.
|
|
|
|
* If you are holding the appropriate locks, you can take a reference and the
|
|
|
|
* object itself is guaranteed to survive until the reference is dropped.
|
2009-12-18 09:24:27 +07:00
|
|
|
*
|
|
|
|
* LOCKING:
|
2013-07-09 05:59:46 +07:00
|
|
|
* There are 3 locks involved with fsnotify inode marks and they MUST be taken
|
|
|
|
* in order as follows:
|
2009-12-18 09:24:27 +07:00
|
|
|
*
|
2013-07-09 05:59:46 +07:00
|
|
|
* group->mark_mutex
|
2009-12-18 09:24:27 +07:00
|
|
|
* mark->lock
|
2017-02-01 14:19:43 +07:00
|
|
|
* mark->connector->lock
|
2009-12-18 09:24:27 +07:00
|
|
|
*
|
2013-07-09 05:59:46 +07:00
|
|
|
* group->mark_mutex protects the marks_list anchored inside a given group and
|
|
|
|
* each mark is hooked via the g_list. It also protects the groups private
|
|
|
|
* data (i.e group limits).
|
|
|
|
|
|
|
|
* mark->lock protects the marks attributes like its masks and flags.
|
|
|
|
* Furthermore it protects the access to a reference of the group that the mark
|
|
|
|
* is assigned to as well as the access to a reference of the inode/vfsmount
|
|
|
|
* that is being watched by the mark.
|
2009-12-18 09:24:27 +07:00
|
|
|
*
|
2017-02-01 14:19:43 +07:00
|
|
|
* mark->connector->lock protects the list of marks anchored inside an
|
|
|
|
* inode / vfsmount and each mark is hooked via the i_list.
|
2009-12-18 09:24:27 +07:00
|
|
|
*
|
2017-02-01 14:19:43 +07:00
|
|
|
* A list of notification marks relating to inode / mnt is contained in
|
|
|
|
* fsnotify_mark_connector. That structure is alive as long as there are any
|
2016-12-21 18:15:30 +07:00
|
|
|
* marks in the list and is also protected by fsnotify_mark_srcu. A mark gets
|
|
|
|
* detached from fsnotify_mark_connector when last reference to the mark is
|
|
|
|
* dropped. Thus having mark reference is enough to protect mark->connector
|
|
|
|
* pointer and to make sure fsnotify_mark_connector cannot disappear. Also
|
|
|
|
* because we remove mark from g_list before dropping mark reference associated
|
|
|
|
* with that, any mark found through g_list is guaranteed to have
|
|
|
|
* mark->connector set until we drop group->mark_mutex.
|
2009-12-18 09:24:27 +07:00
|
|
|
*
|
|
|
|
* LIFETIME:
|
|
|
|
* Inode marks survive between when they are added to an inode and when their
|
2016-12-16 16:53:32 +07:00
|
|
|
* refcnt==0. Marks are also protected by fsnotify_mark_srcu.
|
2009-12-18 09:24:27 +07:00
|
|
|
*
|
|
|
|
* The inode mark can be cleared for a number of different reasons including:
|
|
|
|
* - The inode is unlinked for the last time. (fsnotify_inode_remove)
|
|
|
|
* - The inode is being evicted from cache. (fsnotify_inode_delete)
|
|
|
|
* - The fs the inode is on is unmounted. (fsnotify_inode_delete/fsnotify_unmount_inodes)
|
|
|
|
* - Something explicitly requests that it be removed. (fsnotify_destroy_mark)
|
|
|
|
* - The fsnotify_group associated with the mark is going away and all such marks
|
2017-01-04 16:51:58 +07:00
|
|
|
* need to be cleaned up. (fsnotify_clear_marks_by_group)
|
2009-12-18 09:24:27 +07:00
|
|
|
*
|
|
|
|
* This has the very interesting property of being able to run concurrently with
|
|
|
|
* any (or all) other directions.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/fs.h>
|
|
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/kernel.h>
|
2010-07-28 21:18:38 +07:00
|
|
|
#include <linux/kthread.h>
|
2009-12-18 09:24:27 +07:00
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/mutex.h>
|
|
|
|
#include <linux/slab.h>
|
|
|
|
#include <linux/spinlock.h>
|
2010-07-28 21:18:38 +07:00
|
|
|
#include <linux/srcu.h>
|
2009-12-18 09:24:27 +07:00
|
|
|
|
2011-07-27 06:09:06 +07:00
|
|
|
#include <linux/atomic.h>
|
2009-12-18 09:24:27 +07:00
|
|
|
|
|
|
|
#include <linux/fsnotify_backend.h>
|
|
|
|
#include "fsnotify.h"
|
|
|
|
|
2016-02-18 04:11:21 +07:00
|
|
|
#define FSNOTIFY_REAPER_DELAY (1) /* 1 jiffy */
|
|
|
|
|
2010-07-28 21:18:38 +07:00
|
|
|
struct srcu_struct fsnotify_mark_srcu;
|
2017-03-14 18:31:02 +07:00
|
|
|
struct kmem_cache *fsnotify_mark_connector_cachep;
|
|
|
|
|
2016-02-18 04:11:18 +07:00
|
|
|
static DEFINE_SPINLOCK(destroy_lock);
|
|
|
|
static LIST_HEAD(destroy_list);
|
2017-02-01 15:21:58 +07:00
|
|
|
static struct fsnotify_mark_connector *connector_destroy_list;
|
2016-02-18 04:11:21 +07:00
|
|
|
|
2016-05-20 07:08:59 +07:00
|
|
|
static void fsnotify_mark_destroy_workfn(struct work_struct *work);
|
|
|
|
static DECLARE_DELAYED_WORK(reaper_work, fsnotify_mark_destroy_workfn);
|
2010-07-28 21:18:38 +07:00
|
|
|
|
2017-02-01 15:21:58 +07:00
|
|
|
static void fsnotify_connector_destroy_workfn(struct work_struct *work);
|
|
|
|
static DECLARE_WORK(connector_reaper_work, fsnotify_connector_destroy_workfn);
|
|
|
|
|
2009-12-18 09:24:27 +07:00
|
|
|
void fsnotify_get_mark(struct fsnotify_mark *mark)
|
|
|
|
{
|
2017-10-20 17:26:02 +07:00
|
|
|
WARN_ON_ONCE(!refcount_read(&mark->refcnt));
|
|
|
|
refcount_inc(&mark->refcnt);
|
2009-12-18 09:24:27 +07:00
|
|
|
}
|
|
|
|
|
2018-06-23 21:54:50 +07:00
|
|
|
static __u32 *fsnotify_conn_mask_p(struct fsnotify_mark_connector *conn)
|
|
|
|
{
|
|
|
|
if (conn->type == FSNOTIFY_OBJ_TYPE_INODE)
|
|
|
|
return &fsnotify_conn_inode(conn)->i_fsnotify_mask;
|
|
|
|
else if (conn->type == FSNOTIFY_OBJ_TYPE_VFSMOUNT)
|
|
|
|
return &fsnotify_conn_mount(conn)->mnt_fsnotify_mask;
|
2018-09-01 14:41:11 +07:00
|
|
|
else if (conn->type == FSNOTIFY_OBJ_TYPE_SB)
|
|
|
|
return &fsnotify_conn_sb(conn)->s_fsnotify_mask;
|
2018-06-23 21:54:50 +07:00
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
__u32 fsnotify_conn_mask(struct fsnotify_mark_connector *conn)
|
|
|
|
{
|
|
|
|
if (WARN_ON(!fsnotify_valid_obj_type(conn->type)))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
return *fsnotify_conn_mask_p(conn);
|
|
|
|
}
|
|
|
|
|
2017-03-15 15:16:27 +07:00
|
|
|
static void __fsnotify_recalc_mask(struct fsnotify_mark_connector *conn)
|
2014-12-13 07:58:36 +07:00
|
|
|
{
|
|
|
|
u32 new_mask = 0;
|
|
|
|
struct fsnotify_mark *mark;
|
|
|
|
|
2017-02-01 14:19:43 +07:00
|
|
|
assert_spin_locked(&conn->lock);
|
2018-08-20 18:55:45 +07:00
|
|
|
/* We can get detached connector here when inode is getting unlinked. */
|
|
|
|
if (!fsnotify_valid_obj_type(conn->type))
|
|
|
|
return;
|
2016-12-21 18:15:30 +07:00
|
|
|
hlist_for_each_entry(mark, &conn->list, obj_list) {
|
|
|
|
if (mark->flags & FSNOTIFY_MARK_FLAG_ATTACHED)
|
|
|
|
new_mask |= mark->mask;
|
|
|
|
}
|
2018-06-23 21:54:50 +07:00
|
|
|
*fsnotify_conn_mask_p(conn) = new_mask;
|
2017-03-15 15:16:27 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Calculate mask of events for a list of marks. The caller must make sure
|
2018-06-23 21:54:49 +07:00
|
|
|
* connector and connector->obj cannot disappear under us. Callers achieve
|
2016-12-21 18:15:30 +07:00
|
|
|
* this by holding a mark->lock or mark->group->mark_mutex for a mark on this
|
|
|
|
* list.
|
2017-03-15 15:16:27 +07:00
|
|
|
*/
|
|
|
|
void fsnotify_recalc_mask(struct fsnotify_mark_connector *conn)
|
|
|
|
{
|
|
|
|
if (!conn)
|
|
|
|
return;
|
|
|
|
|
2017-02-01 14:19:43 +07:00
|
|
|
spin_lock(&conn->lock);
|
2017-03-15 15:16:27 +07:00
|
|
|
__fsnotify_recalc_mask(conn);
|
2017-02-01 14:19:43 +07:00
|
|
|
spin_unlock(&conn->lock);
|
2018-04-21 06:10:49 +07:00
|
|
|
if (conn->type == FSNOTIFY_OBJ_TYPE_INODE)
|
2018-06-23 21:54:49 +07:00
|
|
|
__fsnotify_update_child_dentry_flags(
|
|
|
|
fsnotify_conn_inode(conn));
|
2014-12-13 07:58:36 +07:00
|
|
|
}
|
|
|
|
|
2017-02-01 15:21:58 +07:00
|
|
|
/* Free all connectors queued for freeing once SRCU period ends */
|
|
|
|
static void fsnotify_connector_destroy_workfn(struct work_struct *work)
|
|
|
|
{
|
|
|
|
struct fsnotify_mark_connector *conn, *free;
|
|
|
|
|
|
|
|
spin_lock(&destroy_lock);
|
|
|
|
conn = connector_destroy_list;
|
|
|
|
connector_destroy_list = NULL;
|
|
|
|
spin_unlock(&destroy_lock);
|
|
|
|
|
|
|
|
synchronize_srcu(&fsnotify_mark_srcu);
|
|
|
|
while (conn) {
|
|
|
|
free = conn;
|
|
|
|
conn = conn->destroy_next;
|
|
|
|
kmem_cache_free(fsnotify_mark_connector_cachep, free);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-10-17 18:07:05 +07:00
|
|
|
static void *fsnotify_detach_connector_from_object(
|
|
|
|
struct fsnotify_mark_connector *conn,
|
|
|
|
unsigned int *type)
|
2017-02-01 15:21:58 +07:00
|
|
|
{
|
|
|
|
struct inode *inode = NULL;
|
|
|
|
|
2018-10-17 18:07:05 +07:00
|
|
|
*type = conn->type;
|
2018-06-23 21:54:49 +07:00
|
|
|
if (conn->type == FSNOTIFY_OBJ_TYPE_DETACHED)
|
|
|
|
return NULL;
|
|
|
|
|
2018-04-21 06:10:49 +07:00
|
|
|
if (conn->type == FSNOTIFY_OBJ_TYPE_INODE) {
|
2018-06-23 21:54:49 +07:00
|
|
|
inode = fsnotify_conn_inode(conn);
|
2017-02-01 15:21:58 +07:00
|
|
|
inode->i_fsnotify_mask = 0;
|
2018-10-17 18:07:05 +07:00
|
|
|
atomic_long_inc(&inode->i_sb->s_fsnotify_inode_refs);
|
2018-04-21 06:10:49 +07:00
|
|
|
} else if (conn->type == FSNOTIFY_OBJ_TYPE_VFSMOUNT) {
|
2018-06-23 21:54:49 +07:00
|
|
|
fsnotify_conn_mount(conn)->mnt_fsnotify_mask = 0;
|
2018-09-01 14:41:11 +07:00
|
|
|
} else if (conn->type == FSNOTIFY_OBJ_TYPE_SB) {
|
|
|
|
fsnotify_conn_sb(conn)->s_fsnotify_mask = 0;
|
2017-02-01 15:21:58 +07:00
|
|
|
}
|
|
|
|
|
2018-06-23 21:54:49 +07:00
|
|
|
rcu_assign_pointer(*(conn->obj), NULL);
|
|
|
|
conn->obj = NULL;
|
|
|
|
conn->type = FSNOTIFY_OBJ_TYPE_DETACHED;
|
|
|
|
|
2017-02-01 15:21:58 +07:00
|
|
|
return inode;
|
|
|
|
}
|
|
|
|
|
2016-12-21 18:15:30 +07:00
|
|
|
static void fsnotify_final_mark_destroy(struct fsnotify_mark *mark)
|
|
|
|
{
|
2016-12-22 00:06:12 +07:00
|
|
|
struct fsnotify_group *group = mark->group;
|
|
|
|
|
|
|
|
if (WARN_ON_ONCE(!group))
|
|
|
|
return;
|
|
|
|
group->ops->free_mark(mark);
|
|
|
|
fsnotify_put_group(group);
|
2016-12-21 18:15:30 +07:00
|
|
|
}
|
|
|
|
|
2018-10-17 18:07:05 +07:00
|
|
|
/* Drop object reference originally held by a connector */
|
|
|
|
static void fsnotify_drop_object(unsigned int type, void *objp)
|
|
|
|
{
|
|
|
|
struct inode *inode;
|
|
|
|
struct super_block *sb;
|
|
|
|
|
|
|
|
if (!objp)
|
|
|
|
return;
|
|
|
|
/* Currently only inode references are passed to be dropped */
|
|
|
|
if (WARN_ON_ONCE(type != FSNOTIFY_OBJ_TYPE_INODE))
|
|
|
|
return;
|
|
|
|
inode = objp;
|
|
|
|
sb = inode->i_sb;
|
|
|
|
iput(inode);
|
|
|
|
if (atomic_long_dec_and_test(&sb->s_fsnotify_inode_refs))
|
|
|
|
wake_up_var(&sb->s_fsnotify_inode_refs);
|
|
|
|
}
|
|
|
|
|
2016-12-21 18:15:30 +07:00
|
|
|
void fsnotify_put_mark(struct fsnotify_mark *mark)
|
2017-03-15 15:48:11 +07:00
|
|
|
{
|
|
|
|
struct fsnotify_mark_connector *conn;
|
2018-10-17 18:07:05 +07:00
|
|
|
void *objp = NULL;
|
|
|
|
unsigned int type = FSNOTIFY_OBJ_TYPE_DETACHED;
|
2017-02-01 15:21:58 +07:00
|
|
|
bool free_conn = false;
|
2017-03-15 15:48:11 +07:00
|
|
|
|
2016-12-21 18:15:30 +07:00
|
|
|
/* Catch marks that were actually never attached to object */
|
|
|
|
if (!mark->connector) {
|
2017-10-20 17:26:02 +07:00
|
|
|
if (refcount_dec_and_test(&mark->refcnt))
|
2016-12-21 18:15:30 +07:00
|
|
|
fsnotify_final_mark_destroy(mark);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We have to be careful so that traversals of obj_list under lock can
|
|
|
|
* safely grab mark reference.
|
|
|
|
*/
|
2017-10-20 17:26:02 +07:00
|
|
|
if (!refcount_dec_and_lock(&mark->refcnt, &mark->connector->lock))
|
2016-12-21 18:15:30 +07:00
|
|
|
return;
|
|
|
|
|
2017-03-15 15:48:11 +07:00
|
|
|
conn = mark->connector;
|
|
|
|
hlist_del_init_rcu(&mark->obj_list);
|
|
|
|
if (hlist_empty(&conn->list)) {
|
2018-10-17 18:07:05 +07:00
|
|
|
objp = fsnotify_detach_connector_from_object(conn, &type);
|
2017-02-01 15:21:58 +07:00
|
|
|
free_conn = true;
|
|
|
|
} else {
|
|
|
|
__fsnotify_recalc_mask(conn);
|
2017-03-15 15:48:11 +07:00
|
|
|
}
|
|
|
|
mark->connector = NULL;
|
2017-02-01 14:19:43 +07:00
|
|
|
spin_unlock(&conn->lock);
|
2017-03-15 15:48:11 +07:00
|
|
|
|
2018-10-17 18:07:05 +07:00
|
|
|
fsnotify_drop_object(type, objp);
|
2016-12-21 18:15:30 +07:00
|
|
|
|
2017-02-01 15:21:58 +07:00
|
|
|
if (free_conn) {
|
|
|
|
spin_lock(&destroy_lock);
|
|
|
|
conn->destroy_next = connector_destroy_list;
|
|
|
|
connector_destroy_list = conn;
|
|
|
|
spin_unlock(&destroy_lock);
|
|
|
|
queue_work(system_unbound_wq, &connector_reaper_work);
|
|
|
|
}
|
2016-12-21 18:15:30 +07:00
|
|
|
/*
|
|
|
|
* Note that we didn't update flags telling whether inode cares about
|
|
|
|
* what's happening with children. We update these flags from
|
|
|
|
* __fsnotify_parent() lazily when next event happens on one of our
|
|
|
|
* children.
|
|
|
|
*/
|
|
|
|
spin_lock(&destroy_lock);
|
|
|
|
list_add(&mark->g_list, &destroy_list);
|
|
|
|
spin_unlock(&destroy_lock);
|
|
|
|
queue_delayed_work(system_unbound_wq, &reaper_work,
|
|
|
|
FSNOTIFY_REAPER_DELAY);
|
2017-03-15 15:48:11 +07:00
|
|
|
}
|
|
|
|
|
2017-10-31 03:14:55 +07:00
|
|
|
/*
|
|
|
|
* Get mark reference when we found the mark via lockless traversal of object
|
|
|
|
* list. Mark can be already removed from the list by now and on its way to be
|
|
|
|
* destroyed once SRCU period ends.
|
|
|
|
*
|
|
|
|
* Also pin the group so it doesn't disappear under us.
|
|
|
|
*/
|
|
|
|
static bool fsnotify_get_mark_safe(struct fsnotify_mark *mark)
|
2016-11-10 22:02:11 +07:00
|
|
|
{
|
2017-10-31 03:14:55 +07:00
|
|
|
if (!mark)
|
|
|
|
return true;
|
2016-11-10 22:02:11 +07:00
|
|
|
|
2017-10-20 17:26:02 +07:00
|
|
|
if (refcount_inc_not_zero(&mark->refcnt)) {
|
2017-10-31 03:14:56 +07:00
|
|
|
spin_lock(&mark->lock);
|
|
|
|
if (mark->flags & FSNOTIFY_MARK_FLAG_ATTACHED) {
|
|
|
|
/* mark is attached, group is still alive then */
|
|
|
|
atomic_inc(&mark->group->user_waits);
|
|
|
|
spin_unlock(&mark->lock);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
spin_unlock(&mark->lock);
|
|
|
|
fsnotify_put_mark(mark);
|
|
|
|
}
|
2017-10-31 03:14:55 +07:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Puts marks and wakes up group destruction if necessary.
|
|
|
|
*
|
|
|
|
* Pairs with fsnotify_get_mark_safe()
|
|
|
|
*/
|
|
|
|
static void fsnotify_put_mark_wake(struct fsnotify_mark *mark)
|
|
|
|
{
|
|
|
|
if (mark) {
|
|
|
|
struct fsnotify_group *group = mark->group;
|
|
|
|
|
|
|
|
fsnotify_put_mark(mark);
|
|
|
|
/*
|
|
|
|
* We abuse notification_waitq on group shutdown for waiting for
|
|
|
|
* all marks pinned when waiting for userspace.
|
|
|
|
*/
|
|
|
|
if (atomic_dec_and_test(&group->user_waits) && group->shutdown)
|
|
|
|
wake_up(&group->notification_waitq);
|
2016-11-10 22:02:11 +07:00
|
|
|
}
|
2017-10-31 03:14:55 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
bool fsnotify_prepare_user_wait(struct fsnotify_iter_info *iter_info)
|
|
|
|
{
|
2018-04-21 06:10:52 +07:00
|
|
|
int type;
|
|
|
|
|
|
|
|
fsnotify_foreach_obj_type(type) {
|
|
|
|
/* This can fail if mark is being removed */
|
|
|
|
if (!fsnotify_get_mark_safe(iter_info->marks[type]))
|
|
|
|
goto fail;
|
2016-11-10 22:02:11 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Now that both marks are pinned by refcount in the inode / vfsmount
|
|
|
|
* lists, we can drop SRCU lock, and safely resume the list iteration
|
|
|
|
* once userspace returns.
|
|
|
|
*/
|
|
|
|
srcu_read_unlock(&fsnotify_mark_srcu, iter_info->srcu_idx);
|
|
|
|
|
|
|
|
return true;
|
2018-04-21 06:10:52 +07:00
|
|
|
|
|
|
|
fail:
|
|
|
|
for (type--; type >= 0; type--)
|
|
|
|
fsnotify_put_mark_wake(iter_info->marks[type]);
|
|
|
|
return false;
|
2016-11-10 22:02:11 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
void fsnotify_finish_user_wait(struct fsnotify_iter_info *iter_info)
|
|
|
|
{
|
2018-04-21 06:10:52 +07:00
|
|
|
int type;
|
|
|
|
|
2016-11-10 22:02:11 +07:00
|
|
|
iter_info->srcu_idx = srcu_read_lock(&fsnotify_mark_srcu);
|
2018-04-21 06:10:52 +07:00
|
|
|
fsnotify_foreach_obj_type(type)
|
|
|
|
fsnotify_put_mark_wake(iter_info->marks[type]);
|
2016-11-10 22:02:11 +07:00
|
|
|
}
|
|
|
|
|
2009-12-18 09:24:27 +07:00
|
|
|
/*
|
2016-12-21 18:15:30 +07:00
|
|
|
* Mark mark as detached, remove it from group list. Mark still stays in object
|
|
|
|
* list until its last reference is dropped. Note that we rely on mark being
|
|
|
|
* removed from group list before corresponding reference to it is dropped. In
|
|
|
|
* particular we rely on mark->connector being valid while we hold
|
|
|
|
* group->mark_mutex if we found the mark through g_list.
|
2015-09-05 05:43:12 +07:00
|
|
|
*
|
2016-11-09 20:54:20 +07:00
|
|
|
* Must be called with group->mark_mutex held. The caller must either hold
|
|
|
|
* reference to the mark or be protected by fsnotify_mark_srcu.
|
2009-12-18 09:24:27 +07:00
|
|
|
*/
|
2015-09-05 05:43:12 +07:00
|
|
|
void fsnotify_detach_mark(struct fsnotify_mark *mark)
|
2009-12-18 09:24:27 +07:00
|
|
|
{
|
2015-09-05 05:43:12 +07:00
|
|
|
struct fsnotify_group *group = mark->group;
|
2009-12-18 09:24:27 +07:00
|
|
|
|
2016-11-09 20:54:20 +07:00
|
|
|
WARN_ON_ONCE(!mutex_is_locked(&group->mark_mutex));
|
|
|
|
WARN_ON_ONCE(!srcu_read_lock_held(&fsnotify_mark_srcu) &&
|
2017-10-20 17:26:02 +07:00
|
|
|
refcount_read(&mark->refcnt) < 1 +
|
2016-11-09 20:54:20 +07:00
|
|
|
!!(mark->flags & FSNOTIFY_MARK_FLAG_ATTACHED));
|
2011-06-14 22:29:52 +07:00
|
|
|
|
2011-06-14 22:29:48 +07:00
|
|
|
spin_lock(&mark->lock);
|
2010-07-28 21:18:38 +07:00
|
|
|
/* something else already called this function on this mark */
|
2015-09-05 05:43:12 +07:00
|
|
|
if (!(mark->flags & FSNOTIFY_MARK_FLAG_ATTACHED)) {
|
2009-12-18 09:24:27 +07:00
|
|
|
spin_unlock(&mark->lock);
|
2011-06-14 22:29:51 +07:00
|
|
|
return;
|
2009-12-18 09:24:27 +07:00
|
|
|
}
|
2015-09-05 05:43:12 +07:00
|
|
|
mark->flags &= ~FSNOTIFY_MARK_FLAG_ATTACHED;
|
2009-12-18 09:24:27 +07:00
|
|
|
list_del_init(&mark->g_list);
|
|
|
|
spin_unlock(&mark->lock);
|
2011-06-14 22:29:52 +07:00
|
|
|
|
2015-09-05 05:43:12 +07:00
|
|
|
atomic_dec(&group->num_marks);
|
2016-11-09 20:54:20 +07:00
|
|
|
|
|
|
|
/* Drop mark reference acquired in fsnotify_add_mark_locked() */
|
|
|
|
fsnotify_put_mark(mark);
|
2015-09-05 05:43:12 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2016-11-09 20:54:20 +07:00
|
|
|
* Free fsnotify mark. The mark is actually only marked as being freed. The
|
|
|
|
* freeing is actually happening only once last reference to the mark is
|
|
|
|
* dropped from a workqueue which first waits for srcu period end.
|
2016-05-20 07:08:59 +07:00
|
|
|
*
|
2016-11-09 20:54:20 +07:00
|
|
|
* Caller must have a reference to the mark or be protected by
|
|
|
|
* fsnotify_mark_srcu.
|
2015-09-05 05:43:12 +07:00
|
|
|
*/
|
2016-11-09 20:54:20 +07:00
|
|
|
void fsnotify_free_mark(struct fsnotify_mark *mark)
|
2015-09-05 05:43:12 +07:00
|
|
|
{
|
|
|
|
struct fsnotify_group *group = mark->group;
|
|
|
|
|
|
|
|
spin_lock(&mark->lock);
|
|
|
|
/* something else already called this function on this mark */
|
|
|
|
if (!(mark->flags & FSNOTIFY_MARK_FLAG_ALIVE)) {
|
|
|
|
spin_unlock(&mark->lock);
|
2016-11-09 20:54:20 +07:00
|
|
|
return;
|
2015-09-05 05:43:12 +07:00
|
|
|
}
|
|
|
|
mark->flags &= ~FSNOTIFY_MARK_FLAG_ALIVE;
|
|
|
|
spin_unlock(&mark->lock);
|
2009-12-18 09:24:27 +07:00
|
|
|
|
2015-07-22 06:06:53 +07:00
|
|
|
/*
|
|
|
|
* Some groups like to know that marks are being freed. This is a
|
|
|
|
* callback to the group function to let it know that this mark
|
|
|
|
* is being freed.
|
|
|
|
*/
|
|
|
|
if (group->ops->freeing_mark)
|
|
|
|
group->ops->freeing_mark(mark, group);
|
2011-06-14 22:29:52 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
void fsnotify_destroy_mark(struct fsnotify_mark *mark,
|
|
|
|
struct fsnotify_group *group)
|
|
|
|
{
|
fsnotify: change locking order
On Mon, Aug 01, 2011 at 04:38:22PM -0400, Eric Paris wrote:
>
> I finally built and tested a v3.0 kernel with these patches (I know I'm
> SOOOOOO far behind). Not what I hoped for:
>
> > [ 150.937798] VFS: Busy inodes after unmount of tmpfs. Self-destruct in 5 seconds. Have a nice day...
> > [ 150.945290] BUG: unable to handle kernel NULL pointer dereference at 0000000000000070
> > [ 150.946012] IP: [<ffffffff810ffd58>] shmem_free_inode+0x18/0x50
> > [ 150.946012] PGD 2bf9e067 PUD 2bf9f067 PMD 0
> > [ 150.946012] Oops: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC
> > [ 150.946012] CPU 0
> > [ 150.946012] Modules linked in: nfs lockd fscache auth_rpcgss nfs_acl sunrpc ip6t_REJECT nf_conntrack_ipv6 nf_defrag_ipv6 ip6table_filter ip6_tables ext4 jbd2 crc16 joydev ata_piix i2c_piix4 pcspkr uinput ipv6 autofs4 usbhid [last unloaded: scsi_wait_scan]
> > [ 150.946012]
> > [ 150.946012] Pid: 2764, comm: syscall_thrash Not tainted 3.0.0+ #1 Red Hat KVM
> > [ 150.946012] RIP: 0010:[<ffffffff810ffd58>] [<ffffffff810ffd58>] shmem_free_inode+0x18/0x50
> > [ 150.946012] RSP: 0018:ffff88002c2e5df8 EFLAGS: 00010282
> > [ 150.946012] RAX: 000000004e370d9f RBX: 0000000000000000 RCX: ffff88003a029438
> > [ 150.946012] RDX: 0000000033630a5f RSI: 0000000000000000 RDI: ffff88003491c240
> > [ 150.946012] RBP: ffff88002c2e5e08 R08: 0000000000000000 R09: 0000000000000000
> > [ 150.946012] R10: 0000000000000000 R11: 0000000000000000 R12: ffff88003a029428
> > [ 150.946012] R13: ffff88003a029428 R14: ffff88003a029428 R15: ffff88003499a610
> > [ 150.946012] FS: 00007f5a05420700(0000) GS:ffff88003f600000(0000) knlGS:0000000000000000
> > [ 150.946012] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> > [ 150.946012] CR2: 0000000000000070 CR3: 000000002a662000 CR4: 00000000000006f0
> > [ 150.946012] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> > [ 150.946012] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> > [ 150.946012] Process syscall_thrash (pid: 2764, threadinfo ffff88002c2e4000, task ffff88002bfbc760)
> > [ 150.946012] Stack:
> > [ 150.946012] ffff88003a029438 ffff88003a029428 ffff88002c2e5e38 ffffffff81102f76
> > [ 150.946012] ffff88003a029438 ffff88003a029598 ffffffff8160f9c0 ffff88002c221250
> > [ 150.946012] ffff88002c2e5e68 ffffffff8115e9be ffff88002c2e5e68 ffff88003a029438
> > [ 150.946012] Call Trace:
> > [ 150.946012] [<ffffffff81102f76>] shmem_evict_inode+0x76/0x130
> > [ 150.946012] [<ffffffff8115e9be>] evict+0x7e/0x170
> > [ 150.946012] [<ffffffff8115ee40>] iput_final+0xd0/0x190
> > [ 150.946012] [<ffffffff8115ef33>] iput+0x33/0x40
> > [ 150.946012] [<ffffffff81180205>] fsnotify_destroy_mark_locked+0x145/0x160
> > [ 150.946012] [<ffffffff81180316>] fsnotify_destroy_mark+0x36/0x50
> > [ 150.946012] [<ffffffff81181937>] sys_inotify_rm_watch+0x77/0xd0
> > [ 150.946012] [<ffffffff815aca52>] system_call_fastpath+0x16/0x1b
> > [ 150.946012] Code: 67 4a 00 b8 e4 ff ff ff eb aa 66 0f 1f 84 00 00 00 00 00 55 48 89 e5 48 83 ec 10 48 89 1c 24 4c 89 64 24 08 48 8b 9f 40 05 00 00
> > [ 150.946012] 83 7b 70 00 74 1c 4c 8d a3 80 00 00 00 4c 89 e7 e8 d2 5d 4a
> > [ 150.946012] RIP [<ffffffff810ffd58>] shmem_free_inode+0x18/0x50
> > [ 150.946012] RSP <ffff88002c2e5df8>
> > [ 150.946012] CR2: 0000000000000070
>
> Looks at aweful lot like the problem from:
> http://www.spinics.net/lists/linux-fsdevel/msg46101.html
>
I tried to reproduce this bug with your test program, but without success.
However, if I understand correctly, this occurs since we dont hold any locks when
we call iput() in mark_destroy(), right?
With the patches you tested, iput() is also not called within any lock, since the
groups mark_mutex is released temporarily before iput() is called. This is, since
the original codes behaviour is similar.
However since we now have a mutex as the biggest lock, we can do what you
suggested (http://www.spinics.net/lists/linux-fsdevel/msg46107.html) and
call iput() with the mutex held to avoid the race.
The patch below implements this. It uses nested locking to avoid deadlock in case
we do the final iput() on an inode which still holds marks and thus would take
the mutex again when calling fsnotify_inode_delete() in destroy_inode().
Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Signed-off-by: Eric Paris <eparis@redhat.com>
2011-08-12 06:13:31 +07:00
|
|
|
mutex_lock_nested(&group->mark_mutex, SINGLE_DEPTH_NESTING);
|
2015-09-05 05:43:12 +07:00
|
|
|
fsnotify_detach_mark(mark);
|
2011-06-14 22:29:52 +07:00
|
|
|
mutex_unlock(&group->mark_mutex);
|
2015-09-05 05:43:12 +07:00
|
|
|
fsnotify_free_mark(mark);
|
2009-12-18 09:24:27 +07:00
|
|
|
}
|
|
|
|
|
2014-11-14 06:19:33 +07:00
|
|
|
/*
|
|
|
|
* Sorting function for lists of fsnotify marks.
|
|
|
|
*
|
|
|
|
* Fanotify supports different notification classes (reflected as priority of
|
|
|
|
* notification group). Events shall be passed to notification groups in
|
|
|
|
* decreasing priority order. To achieve this marks in notification lists for
|
|
|
|
* inodes and vfsmounts are sorted so that priorities of corresponding groups
|
|
|
|
* are descending.
|
|
|
|
*
|
|
|
|
* Furthermore correct handling of the ignore mask requires processing inode
|
|
|
|
* and vfsmount marks of each group together. Using the group address as
|
|
|
|
* further sort criterion provides a unique sorting order and thus we can
|
|
|
|
* merge inode and vfsmount lists of marks in linear time and find groups
|
|
|
|
* present in both lists.
|
|
|
|
*
|
|
|
|
* A return value of 1 signifies that b has priority over a.
|
|
|
|
* A return value of 0 signifies that the two marks have to be handled together.
|
|
|
|
* A return value of -1 signifies that a has priority over b.
|
|
|
|
*/
|
|
|
|
int fsnotify_compare_groups(struct fsnotify_group *a, struct fsnotify_group *b)
|
|
|
|
{
|
|
|
|
if (a == b)
|
|
|
|
return 0;
|
|
|
|
if (!a)
|
|
|
|
return 1;
|
|
|
|
if (!b)
|
|
|
|
return -1;
|
|
|
|
if (a->priority < b->priority)
|
|
|
|
return 1;
|
|
|
|
if (a->priority > b->priority)
|
|
|
|
return -1;
|
|
|
|
if (a < b)
|
|
|
|
return 1;
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2018-06-23 21:54:47 +07:00
|
|
|
static int fsnotify_attach_connector_to_object(fsnotify_connp_t *connp,
|
2018-06-23 21:54:48 +07:00
|
|
|
unsigned int type)
|
2017-03-14 18:31:02 +07:00
|
|
|
{
|
2018-06-23 21:54:48 +07:00
|
|
|
struct inode *inode = NULL;
|
2017-03-14 18:31:02 +07:00
|
|
|
struct fsnotify_mark_connector *conn;
|
|
|
|
|
2017-03-14 22:11:23 +07:00
|
|
|
conn = kmem_cache_alloc(fsnotify_mark_connector_cachep, GFP_KERNEL);
|
2017-03-14 18:31:02 +07:00
|
|
|
if (!conn)
|
|
|
|
return -ENOMEM;
|
2017-02-01 14:19:43 +07:00
|
|
|
spin_lock_init(&conn->lock);
|
2017-03-14 18:31:02 +07:00
|
|
|
INIT_HLIST_HEAD(&conn->list);
|
2018-06-23 21:54:48 +07:00
|
|
|
conn->type = type;
|
2018-06-23 21:54:49 +07:00
|
|
|
conn->obj = connp;
|
2018-06-23 21:54:48 +07:00
|
|
|
if (conn->type == FSNOTIFY_OBJ_TYPE_INODE)
|
2018-06-23 21:54:49 +07:00
|
|
|
inode = igrab(fsnotify_conn_inode(conn));
|
2017-03-14 18:31:02 +07:00
|
|
|
/*
|
2017-02-01 14:19:43 +07:00
|
|
|
* cmpxchg() provides the barrier so that readers of *connp can see
|
|
|
|
* only initialized structure
|
2017-03-14 18:31:02 +07:00
|
|
|
*/
|
2017-02-01 14:19:43 +07:00
|
|
|
if (cmpxchg(connp, NULL, conn)) {
|
|
|
|
/* Someone else created list structure for us */
|
2017-02-01 15:21:58 +07:00
|
|
|
if (inode)
|
|
|
|
iput(inode);
|
2017-03-14 22:11:23 +07:00
|
|
|
kmem_cache_free(fsnotify_mark_connector_cachep, conn);
|
2017-02-01 14:19:43 +07:00
|
|
|
}
|
2017-03-14 18:31:02 +07:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-02-01 15:21:58 +07:00
|
|
|
/*
|
|
|
|
* Get mark connector, make sure it is alive and return with its lock held.
|
|
|
|
* This is for users that get connector pointer from inode or mount. Users that
|
|
|
|
* hold reference to a mark on the list may directly lock connector->lock as
|
|
|
|
* they are sure list cannot go away under them.
|
|
|
|
*/
|
|
|
|
static struct fsnotify_mark_connector *fsnotify_grab_connector(
|
2018-06-23 21:54:47 +07:00
|
|
|
fsnotify_connp_t *connp)
|
2017-02-01 15:21:58 +07:00
|
|
|
{
|
|
|
|
struct fsnotify_mark_connector *conn;
|
|
|
|
int idx;
|
|
|
|
|
|
|
|
idx = srcu_read_lock(&fsnotify_mark_srcu);
|
|
|
|
conn = srcu_dereference(*connp, &fsnotify_mark_srcu);
|
|
|
|
if (!conn)
|
|
|
|
goto out;
|
|
|
|
spin_lock(&conn->lock);
|
2018-04-21 06:10:49 +07:00
|
|
|
if (conn->type == FSNOTIFY_OBJ_TYPE_DETACHED) {
|
2017-02-01 15:21:58 +07:00
|
|
|
spin_unlock(&conn->lock);
|
|
|
|
srcu_read_unlock(&fsnotify_mark_srcu, idx);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
out:
|
|
|
|
srcu_read_unlock(&fsnotify_mark_srcu, idx);
|
|
|
|
return conn;
|
|
|
|
}
|
|
|
|
|
2017-03-14 18:31:02 +07:00
|
|
|
/*
|
|
|
|
* Add mark into proper place in given list of marks. These marks may be used
|
|
|
|
* for the fsnotify backend to determine which event types should be delivered
|
|
|
|
* to which group and for which inodes. These marks are ordered according to
|
|
|
|
* priority, highest number first, and then by the group's location in memory.
|
|
|
|
*/
|
2017-03-14 22:11:23 +07:00
|
|
|
static int fsnotify_add_mark_list(struct fsnotify_mark *mark,
|
2018-06-23 21:54:48 +07:00
|
|
|
fsnotify_connp_t *connp, unsigned int type,
|
2017-03-14 22:11:23 +07:00
|
|
|
int allow_dups)
|
2014-12-13 07:58:36 +07:00
|
|
|
{
|
|
|
|
struct fsnotify_mark *lmark, *last = NULL;
|
2017-03-14 18:31:02 +07:00
|
|
|
struct fsnotify_mark_connector *conn;
|
2014-12-13 07:58:36 +07:00
|
|
|
int cmp;
|
2017-03-14 22:11:23 +07:00
|
|
|
int err = 0;
|
|
|
|
|
2018-06-23 21:54:48 +07:00
|
|
|
if (WARN_ON(!fsnotify_valid_obj_type(type)))
|
2017-03-14 22:11:23 +07:00
|
|
|
return -EINVAL;
|
2017-02-01 15:21:58 +07:00
|
|
|
restart:
|
|
|
|
spin_lock(&mark->lock);
|
|
|
|
conn = fsnotify_grab_connector(connp);
|
|
|
|
if (!conn) {
|
|
|
|
spin_unlock(&mark->lock);
|
2018-06-23 21:54:48 +07:00
|
|
|
err = fsnotify_attach_connector_to_object(connp, type);
|
2017-03-14 18:31:02 +07:00
|
|
|
if (err)
|
|
|
|
return err;
|
2017-02-01 15:21:58 +07:00
|
|
|
goto restart;
|
2017-03-14 18:31:02 +07:00
|
|
|
}
|
2014-12-13 07:58:36 +07:00
|
|
|
|
|
|
|
/* is mark the first mark? */
|
2017-03-14 18:31:02 +07:00
|
|
|
if (hlist_empty(&conn->list)) {
|
|
|
|
hlist_add_head_rcu(&mark->obj_list, &conn->list);
|
2017-03-14 20:29:35 +07:00
|
|
|
goto added;
|
2014-12-13 07:58:36 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
/* should mark be in the middle of the current list? */
|
2017-03-14 18:31:02 +07:00
|
|
|
hlist_for_each_entry(lmark, &conn->list, obj_list) {
|
2014-12-13 07:58:36 +07:00
|
|
|
last = lmark;
|
|
|
|
|
2016-12-21 18:15:30 +07:00
|
|
|
if ((lmark->group == mark->group) &&
|
|
|
|
(lmark->flags & FSNOTIFY_MARK_FLAG_ATTACHED) &&
|
|
|
|
!allow_dups) {
|
2017-03-14 22:11:23 +07:00
|
|
|
err = -EEXIST;
|
|
|
|
goto out_err;
|
|
|
|
}
|
2014-12-13 07:58:36 +07:00
|
|
|
|
|
|
|
cmp = fsnotify_compare_groups(lmark->group, mark->group);
|
|
|
|
if (cmp >= 0) {
|
|
|
|
hlist_add_before_rcu(&mark->obj_list, &lmark->obj_list);
|
2017-03-14 20:29:35 +07:00
|
|
|
goto added;
|
2014-12-13 07:58:36 +07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
BUG_ON(last == NULL);
|
|
|
|
/* mark should be the last entry. last is the current last entry */
|
|
|
|
hlist_add_behind_rcu(&mark->obj_list, &last->obj_list);
|
2017-03-14 20:29:35 +07:00
|
|
|
added:
|
|
|
|
mark->connector = conn;
|
2017-03-14 22:11:23 +07:00
|
|
|
out_err:
|
2017-02-01 14:19:43 +07:00
|
|
|
spin_unlock(&conn->lock);
|
2017-03-14 22:11:23 +07:00
|
|
|
spin_unlock(&mark->lock);
|
|
|
|
return err;
|
2014-12-13 07:58:36 +07:00
|
|
|
}
|
|
|
|
|
2009-12-18 09:24:27 +07:00
|
|
|
/*
|
|
|
|
* Attach an initialized mark to a given group and fs object.
|
|
|
|
* These marks may be used for the fsnotify backend to determine which
|
|
|
|
* event types should be delivered to which group.
|
|
|
|
*/
|
2018-06-23 21:54:48 +07:00
|
|
|
int fsnotify_add_mark_locked(struct fsnotify_mark *mark,
|
|
|
|
fsnotify_connp_t *connp, unsigned int type,
|
|
|
|
int allow_dups)
|
2009-12-18 09:24:27 +07:00
|
|
|
{
|
2016-12-22 00:32:48 +07:00
|
|
|
struct fsnotify_group *group = mark->group;
|
2009-12-18 09:24:27 +07:00
|
|
|
int ret = 0;
|
|
|
|
|
2011-06-14 22:29:52 +07:00
|
|
|
BUG_ON(!mutex_is_locked(&group->mark_mutex));
|
2009-12-18 09:24:27 +07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* LOCKING ORDER!!!!
|
2011-06-14 22:29:50 +07:00
|
|
|
* group->mark_mutex
|
2011-06-14 22:29:48 +07:00
|
|
|
* mark->lock
|
2017-02-01 14:19:43 +07:00
|
|
|
* mark->connector->lock
|
2009-12-18 09:24:27 +07:00
|
|
|
*/
|
2011-06-14 22:29:48 +07:00
|
|
|
spin_lock(&mark->lock);
|
2015-09-05 05:43:12 +07:00
|
|
|
mark->flags |= FSNOTIFY_MARK_FLAG_ALIVE | FSNOTIFY_MARK_FLAG_ATTACHED;
|
2010-07-28 21:18:38 +07:00
|
|
|
|
2009-12-18 09:24:27 +07:00
|
|
|
list_add(&mark->g_list, &group->marks_list);
|
|
|
|
atomic_inc(&group->num_marks);
|
2016-12-21 18:15:30 +07:00
|
|
|
fsnotify_get_mark(mark); /* for g_list */
|
2009-12-18 09:24:27 +07:00
|
|
|
spin_unlock(&mark->lock);
|
|
|
|
|
2018-06-23 21:54:48 +07:00
|
|
|
ret = fsnotify_add_mark_list(mark, connp, type, allow_dups);
|
2017-03-14 22:11:23 +07:00
|
|
|
if (ret)
|
|
|
|
goto err;
|
|
|
|
|
2017-03-15 15:16:27 +07:00
|
|
|
if (mark->mask)
|
|
|
|
fsnotify_recalc_mask(mark->connector);
|
2009-12-18 09:24:27 +07:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
err:
|
2017-10-31 16:09:25 +07:00
|
|
|
spin_lock(&mark->lock);
|
2016-11-09 20:54:20 +07:00
|
|
|
mark->flags &= ~(FSNOTIFY_MARK_FLAG_ALIVE |
|
|
|
|
FSNOTIFY_MARK_FLAG_ATTACHED);
|
2009-12-18 09:24:27 +07:00
|
|
|
list_del_init(&mark->g_list);
|
2017-10-31 16:09:25 +07:00
|
|
|
spin_unlock(&mark->lock);
|
2009-12-18 09:24:27 +07:00
|
|
|
atomic_dec(&group->num_marks);
|
|
|
|
|
2016-11-09 20:54:20 +07:00
|
|
|
fsnotify_put_mark(mark);
|
2009-12-18 09:24:27 +07:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2018-06-23 21:54:48 +07:00
|
|
|
int fsnotify_add_mark(struct fsnotify_mark *mark, fsnotify_connp_t *connp,
|
|
|
|
unsigned int type, int allow_dups)
|
2011-06-14 22:29:52 +07:00
|
|
|
{
|
|
|
|
int ret;
|
2016-12-22 00:32:48 +07:00
|
|
|
struct fsnotify_group *group = mark->group;
|
|
|
|
|
2011-06-14 22:29:52 +07:00
|
|
|
mutex_lock(&group->mark_mutex);
|
2018-06-23 21:54:48 +07:00
|
|
|
ret = fsnotify_add_mark_locked(mark, connp, type, allow_dups);
|
2011-06-14 22:29:52 +07:00
|
|
|
mutex_unlock(&group->mark_mutex);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2014-12-13 07:58:36 +07:00
|
|
|
/*
|
|
|
|
* Given a list of marks, find the mark associated with given group. If found
|
|
|
|
* take a reference to that mark and return it, else return NULL.
|
|
|
|
*/
|
2018-06-23 21:54:47 +07:00
|
|
|
struct fsnotify_mark *fsnotify_find_mark(fsnotify_connp_t *connp,
|
|
|
|
struct fsnotify_group *group)
|
2014-12-13 07:58:36 +07:00
|
|
|
{
|
2017-02-01 15:21:58 +07:00
|
|
|
struct fsnotify_mark_connector *conn;
|
2014-12-13 07:58:36 +07:00
|
|
|
struct fsnotify_mark *mark;
|
|
|
|
|
2017-02-01 15:21:58 +07:00
|
|
|
conn = fsnotify_grab_connector(connp);
|
2017-03-14 18:31:02 +07:00
|
|
|
if (!conn)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
hlist_for_each_entry(mark, &conn->list, obj_list) {
|
2016-12-21 18:15:30 +07:00
|
|
|
if (mark->group == group &&
|
|
|
|
(mark->flags & FSNOTIFY_MARK_FLAG_ATTACHED)) {
|
2014-12-13 07:58:36 +07:00
|
|
|
fsnotify_get_mark(mark);
|
2017-02-01 14:19:43 +07:00
|
|
|
spin_unlock(&conn->lock);
|
2014-12-13 07:58:36 +07:00
|
|
|
return mark;
|
|
|
|
}
|
|
|
|
}
|
2017-02-01 14:19:43 +07:00
|
|
|
spin_unlock(&conn->lock);
|
2014-12-13 07:58:36 +07:00
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2018-04-21 06:10:49 +07:00
|
|
|
/* Clear any marks in a group with given type mask */
|
2017-01-04 16:33:18 +07:00
|
|
|
void fsnotify_clear_marks_by_group(struct fsnotify_group *group,
|
2018-04-21 06:10:49 +07:00
|
|
|
unsigned int type_mask)
|
2009-12-18 09:24:27 +07:00
|
|
|
{
|
|
|
|
struct fsnotify_mark *lmark, *mark;
|
2015-08-07 05:46:42 +07:00
|
|
|
LIST_HEAD(to_free);
|
2017-01-04 16:51:58 +07:00
|
|
|
struct list_head *head = &to_free;
|
2009-12-18 09:24:27 +07:00
|
|
|
|
2017-01-04 16:51:58 +07:00
|
|
|
/* Skip selection step if we want to clear all marks. */
|
2018-04-21 06:10:49 +07:00
|
|
|
if (type_mask == FSNOTIFY_OBJ_ALL_TYPES_MASK) {
|
2017-01-04 16:51:58 +07:00
|
|
|
head = &group->marks_list;
|
|
|
|
goto clear;
|
|
|
|
}
|
2015-08-07 05:46:42 +07:00
|
|
|
/*
|
|
|
|
* We have to be really careful here. Anytime we drop mark_mutex, e.g.
|
|
|
|
* fsnotify_clear_marks_by_inode() can come and free marks. Even in our
|
|
|
|
* to_free list so we have to use mark_mutex even when accessing that
|
|
|
|
* list. And freeing mark requires us to drop mark_mutex. So we can
|
|
|
|
* reliably free only the first mark in the list. That's why we first
|
|
|
|
* move marks to free to to_free list in one go and then free marks in
|
|
|
|
* to_free list one by one.
|
|
|
|
*/
|
fsnotify: change locking order
On Mon, Aug 01, 2011 at 04:38:22PM -0400, Eric Paris wrote:
>
> I finally built and tested a v3.0 kernel with these patches (I know I'm
> SOOOOOO far behind). Not what I hoped for:
>
> > [ 150.937798] VFS: Busy inodes after unmount of tmpfs. Self-destruct in 5 seconds. Have a nice day...
> > [ 150.945290] BUG: unable to handle kernel NULL pointer dereference at 0000000000000070
> > [ 150.946012] IP: [<ffffffff810ffd58>] shmem_free_inode+0x18/0x50
> > [ 150.946012] PGD 2bf9e067 PUD 2bf9f067 PMD 0
> > [ 150.946012] Oops: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC
> > [ 150.946012] CPU 0
> > [ 150.946012] Modules linked in: nfs lockd fscache auth_rpcgss nfs_acl sunrpc ip6t_REJECT nf_conntrack_ipv6 nf_defrag_ipv6 ip6table_filter ip6_tables ext4 jbd2 crc16 joydev ata_piix i2c_piix4 pcspkr uinput ipv6 autofs4 usbhid [last unloaded: scsi_wait_scan]
> > [ 150.946012]
> > [ 150.946012] Pid: 2764, comm: syscall_thrash Not tainted 3.0.0+ #1 Red Hat KVM
> > [ 150.946012] RIP: 0010:[<ffffffff810ffd58>] [<ffffffff810ffd58>] shmem_free_inode+0x18/0x50
> > [ 150.946012] RSP: 0018:ffff88002c2e5df8 EFLAGS: 00010282
> > [ 150.946012] RAX: 000000004e370d9f RBX: 0000000000000000 RCX: ffff88003a029438
> > [ 150.946012] RDX: 0000000033630a5f RSI: 0000000000000000 RDI: ffff88003491c240
> > [ 150.946012] RBP: ffff88002c2e5e08 R08: 0000000000000000 R09: 0000000000000000
> > [ 150.946012] R10: 0000000000000000 R11: 0000000000000000 R12: ffff88003a029428
> > [ 150.946012] R13: ffff88003a029428 R14: ffff88003a029428 R15: ffff88003499a610
> > [ 150.946012] FS: 00007f5a05420700(0000) GS:ffff88003f600000(0000) knlGS:0000000000000000
> > [ 150.946012] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> > [ 150.946012] CR2: 0000000000000070 CR3: 000000002a662000 CR4: 00000000000006f0
> > [ 150.946012] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> > [ 150.946012] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> > [ 150.946012] Process syscall_thrash (pid: 2764, threadinfo ffff88002c2e4000, task ffff88002bfbc760)
> > [ 150.946012] Stack:
> > [ 150.946012] ffff88003a029438 ffff88003a029428 ffff88002c2e5e38 ffffffff81102f76
> > [ 150.946012] ffff88003a029438 ffff88003a029598 ffffffff8160f9c0 ffff88002c221250
> > [ 150.946012] ffff88002c2e5e68 ffffffff8115e9be ffff88002c2e5e68 ffff88003a029438
> > [ 150.946012] Call Trace:
> > [ 150.946012] [<ffffffff81102f76>] shmem_evict_inode+0x76/0x130
> > [ 150.946012] [<ffffffff8115e9be>] evict+0x7e/0x170
> > [ 150.946012] [<ffffffff8115ee40>] iput_final+0xd0/0x190
> > [ 150.946012] [<ffffffff8115ef33>] iput+0x33/0x40
> > [ 150.946012] [<ffffffff81180205>] fsnotify_destroy_mark_locked+0x145/0x160
> > [ 150.946012] [<ffffffff81180316>] fsnotify_destroy_mark+0x36/0x50
> > [ 150.946012] [<ffffffff81181937>] sys_inotify_rm_watch+0x77/0xd0
> > [ 150.946012] [<ffffffff815aca52>] system_call_fastpath+0x16/0x1b
> > [ 150.946012] Code: 67 4a 00 b8 e4 ff ff ff eb aa 66 0f 1f 84 00 00 00 00 00 55 48 89 e5 48 83 ec 10 48 89 1c 24 4c 89 64 24 08 48 8b 9f 40 05 00 00
> > [ 150.946012] 83 7b 70 00 74 1c 4c 8d a3 80 00 00 00 4c 89 e7 e8 d2 5d 4a
> > [ 150.946012] RIP [<ffffffff810ffd58>] shmem_free_inode+0x18/0x50
> > [ 150.946012] RSP <ffff88002c2e5df8>
> > [ 150.946012] CR2: 0000000000000070
>
> Looks at aweful lot like the problem from:
> http://www.spinics.net/lists/linux-fsdevel/msg46101.html
>
I tried to reproduce this bug with your test program, but without success.
However, if I understand correctly, this occurs since we dont hold any locks when
we call iput() in mark_destroy(), right?
With the patches you tested, iput() is also not called within any lock, since the
groups mark_mutex is released temporarily before iput() is called. This is, since
the original codes behaviour is similar.
However since we now have a mutex as the biggest lock, we can do what you
suggested (http://www.spinics.net/lists/linux-fsdevel/msg46107.html) and
call iput() with the mutex held to avoid the race.
The patch below implements this. It uses nested locking to avoid deadlock in case
we do the final iput() on an inode which still holds marks and thus would take
the mutex again when calling fsnotify_inode_delete() in destroy_inode().
Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Signed-off-by: Eric Paris <eparis@redhat.com>
2011-08-12 06:13:31 +07:00
|
|
|
mutex_lock_nested(&group->mark_mutex, SINGLE_DEPTH_NESTING);
|
2009-12-18 09:24:27 +07:00
|
|
|
list_for_each_entry_safe(mark, lmark, &group->marks_list, g_list) {
|
2018-04-21 06:10:49 +07:00
|
|
|
if ((1U << mark->connector->type) & type_mask)
|
2015-08-07 05:46:42 +07:00
|
|
|
list_move(&mark->g_list, &to_free);
|
2009-12-18 09:24:27 +07:00
|
|
|
}
|
2011-06-14 22:29:50 +07:00
|
|
|
mutex_unlock(&group->mark_mutex);
|
2015-08-07 05:46:42 +07:00
|
|
|
|
2017-01-04 16:51:58 +07:00
|
|
|
clear:
|
2015-08-07 05:46:42 +07:00
|
|
|
while (1) {
|
|
|
|
mutex_lock_nested(&group->mark_mutex, SINGLE_DEPTH_NESTING);
|
2017-01-04 16:51:58 +07:00
|
|
|
if (list_empty(head)) {
|
2015-08-07 05:46:42 +07:00
|
|
|
mutex_unlock(&group->mark_mutex);
|
|
|
|
break;
|
|
|
|
}
|
2017-01-04 16:51:58 +07:00
|
|
|
mark = list_first_entry(head, struct fsnotify_mark, g_list);
|
2015-08-07 05:46:42 +07:00
|
|
|
fsnotify_get_mark(mark);
|
2015-09-05 05:43:12 +07:00
|
|
|
fsnotify_detach_mark(mark);
|
2015-08-07 05:46:42 +07:00
|
|
|
mutex_unlock(&group->mark_mutex);
|
2015-09-05 05:43:12 +07:00
|
|
|
fsnotify_free_mark(mark);
|
2015-08-07 05:46:42 +07:00
|
|
|
fsnotify_put_mark(mark);
|
|
|
|
}
|
2009-12-18 09:24:27 +07:00
|
|
|
}
|
|
|
|
|
2018-06-23 21:54:47 +07:00
|
|
|
/* Destroy all marks attached to an object via connector */
|
|
|
|
void fsnotify_destroy_marks(fsnotify_connp_t *connp)
|
2017-02-01 15:23:48 +07:00
|
|
|
{
|
2017-02-01 15:21:58 +07:00
|
|
|
struct fsnotify_mark_connector *conn;
|
2016-12-21 18:15:30 +07:00
|
|
|
struct fsnotify_mark *mark, *old_mark = NULL;
|
2018-10-17 18:07:05 +07:00
|
|
|
void *objp;
|
|
|
|
unsigned int type;
|
2017-02-01 15:23:48 +07:00
|
|
|
|
2016-12-21 18:15:30 +07:00
|
|
|
conn = fsnotify_grab_connector(connp);
|
|
|
|
if (!conn)
|
|
|
|
return;
|
|
|
|
/*
|
|
|
|
* We have to be careful since we can race with e.g.
|
|
|
|
* fsnotify_clear_marks_by_group() and once we drop the conn->lock, the
|
|
|
|
* list can get modified. However we are holding mark reference and
|
|
|
|
* thus our mark cannot be removed from obj_list so we can continue
|
|
|
|
* iteration after regaining conn->lock.
|
|
|
|
*/
|
|
|
|
hlist_for_each_entry(mark, &conn->list, obj_list) {
|
2017-02-01 15:23:48 +07:00
|
|
|
fsnotify_get_mark(mark);
|
2017-02-01 14:19:43 +07:00
|
|
|
spin_unlock(&conn->lock);
|
2016-12-21 18:15:30 +07:00
|
|
|
if (old_mark)
|
|
|
|
fsnotify_put_mark(old_mark);
|
|
|
|
old_mark = mark;
|
2017-02-01 15:23:48 +07:00
|
|
|
fsnotify_destroy_mark(mark, mark->group);
|
2016-12-21 18:15:30 +07:00
|
|
|
spin_lock(&conn->lock);
|
2017-02-01 15:23:48 +07:00
|
|
|
}
|
2016-12-21 18:15:30 +07:00
|
|
|
/*
|
|
|
|
* Detach list from object now so that we don't pin inode until all
|
|
|
|
* mark references get dropped. It would lead to strange results such
|
|
|
|
* as delaying inode deletion or blocking unmount.
|
|
|
|
*/
|
2018-10-17 18:07:05 +07:00
|
|
|
objp = fsnotify_detach_connector_from_object(conn, &type);
|
2016-12-21 18:15:30 +07:00
|
|
|
spin_unlock(&conn->lock);
|
|
|
|
if (old_mark)
|
|
|
|
fsnotify_put_mark(old_mark);
|
2018-10-17 18:07:05 +07:00
|
|
|
fsnotify_drop_object(type, objp);
|
2017-02-01 15:23:48 +07:00
|
|
|
}
|
|
|
|
|
2009-12-18 09:24:27 +07:00
|
|
|
/*
|
|
|
|
* Nothing fancy, just initialize lists and locks and counters.
|
|
|
|
*/
|
|
|
|
void fsnotify_init_mark(struct fsnotify_mark *mark,
|
2016-12-22 00:06:12 +07:00
|
|
|
struct fsnotify_group *group)
|
2009-12-18 09:24:27 +07:00
|
|
|
{
|
2009-12-18 09:24:27 +07:00
|
|
|
memset(mark, 0, sizeof(*mark));
|
2009-12-18 09:24:27 +07:00
|
|
|
spin_lock_init(&mark->lock);
|
2017-10-20 17:26:02 +07:00
|
|
|
refcount_set(&mark->refcnt, 1);
|
2016-12-22 00:32:48 +07:00
|
|
|
fsnotify_get_group(group);
|
|
|
|
mark->group = group;
|
2009-12-18 09:24:27 +07:00
|
|
|
}
|
2016-02-18 04:11:18 +07:00
|
|
|
|
2016-05-20 07:08:59 +07:00
|
|
|
/*
|
|
|
|
* Destroy all marks in destroy_list, waits for SRCU period to finish before
|
|
|
|
* actually freeing marks.
|
|
|
|
*/
|
2016-12-21 20:48:18 +07:00
|
|
|
static void fsnotify_mark_destroy_workfn(struct work_struct *work)
|
2016-02-18 04:11:18 +07:00
|
|
|
{
|
|
|
|
struct fsnotify_mark *mark, *next;
|
|
|
|
struct list_head private_destroy_list;
|
|
|
|
|
2016-02-18 04:11:21 +07:00
|
|
|
spin_lock(&destroy_lock);
|
|
|
|
/* exchange the list head */
|
|
|
|
list_replace_init(&destroy_list, &private_destroy_list);
|
|
|
|
spin_unlock(&destroy_lock);
|
2016-02-18 04:11:18 +07:00
|
|
|
|
2016-02-18 04:11:21 +07:00
|
|
|
synchronize_srcu(&fsnotify_mark_srcu);
|
2016-02-18 04:11:18 +07:00
|
|
|
|
2016-02-18 04:11:21 +07:00
|
|
|
list_for_each_entry_safe(mark, next, &private_destroy_list, g_list) {
|
|
|
|
list_del_init(&mark->g_list);
|
2016-12-21 18:15:30 +07:00
|
|
|
fsnotify_final_mark_destroy(mark);
|
2016-02-18 04:11:18 +07:00
|
|
|
}
|
|
|
|
}
|
2016-05-20 07:08:59 +07:00
|
|
|
|
2016-12-21 20:48:18 +07:00
|
|
|
/* Wait for all marks queued for destruction to be actually destroyed */
|
|
|
|
void fsnotify_wait_marks_destroyed(void)
|
2016-05-20 07:08:59 +07:00
|
|
|
{
|
2016-12-21 20:48:18 +07:00
|
|
|
flush_delayed_work(&reaper_work);
|
2016-05-20 07:08:59 +07:00
|
|
|
}
|