2018-01-27 03:22:04 +07:00
|
|
|
// SPDX-License-Identifier: GPL-2.0+
|
2005-04-17 05:20:36 +07:00
|
|
|
/*
|
2013-11-15 01:28:18 +07:00
|
|
|
* RPA Virtual I/O device functions
|
2005-04-17 05:20:36 +07:00
|
|
|
* Copyright (C) 2004 Linda Xie <lxie@us.ibm.com>
|
|
|
|
*
|
|
|
|
* All rights reserved.
|
|
|
|
*
|
|
|
|
* Send feedback to <lxie@us.ibm.com>
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/sysfs.h>
|
|
|
|
#include <linux/pci.h>
|
2005-10-31 06:03:48 +07:00
|
|
|
#include <linux/string.h>
|
|
|
|
#include <linux/slab.h>
|
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
#include <asm/rtas.h>
|
|
|
|
#include "rpaphp.h"
|
|
|
|
|
|
|
|
/* free up the memory used by a slot */
|
|
|
|
void dealloc_slot_struct(struct slot *slot)
|
|
|
|
{
|
2008-10-21 06:41:43 +07:00
|
|
|
kfree(slot->name);
|
2005-04-17 05:20:36 +07:00
|
|
|
kfree(slot->hotplug_slot);
|
|
|
|
kfree(slot);
|
|
|
|
}
|
|
|
|
|
2007-04-14 05:34:10 +07:00
|
|
|
struct slot *alloc_slot_struct(struct device_node *dn,
|
2015-12-28 04:21:11 +07:00
|
|
|
int drc_index, char *drc_name, int power_domain)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
|
|
|
struct slot *slot;
|
2013-11-15 01:28:18 +07:00
|
|
|
|
2006-02-28 21:34:49 +07:00
|
|
|
slot = kzalloc(sizeof(struct slot), GFP_KERNEL);
|
2005-04-17 05:20:36 +07:00
|
|
|
if (!slot)
|
|
|
|
goto error_nomem;
|
2006-02-28 21:34:49 +07:00
|
|
|
slot->hotplug_slot = kzalloc(sizeof(struct hotplug_slot), GFP_KERNEL);
|
2005-04-17 05:20:36 +07:00
|
|
|
if (!slot->hotplug_slot)
|
2013-11-15 01:28:18 +07:00
|
|
|
goto error_slot;
|
2008-10-21 06:41:43 +07:00
|
|
|
slot->name = kstrdup(drc_name, GFP_KERNEL);
|
|
|
|
if (!slot->name)
|
PCI: hotplug: Drop hotplug_slot_info
Ever since the PCI hotplug core was introduced in 2002, drivers had to
allocate and register a struct hotplug_slot_info for every slot:
https://git.kernel.org/tglx/history/c/a8a2069f432c
Apparently the idea was that drivers furnish the hotplug core with an
up-to-date card presence status, power status, latch status and
attention indicator status as well as notify the hotplug core of changes
thereof. However only 4 out of 12 hotplug drivers bother to notify the
hotplug core with pci_hp_change_slot_info() and the hotplug core never
made any use of the information: There is just a single macro in
pci_hotplug_core.c, GET_STATUS(), which uses the hotplug_slot_info if
the driver lacks the corresponding callback in hotplug_slot_ops. The
macro is called when the user reads the attribute via sysfs.
Now, if the callback isn't defined, the attribute isn't exposed in sysfs
in the first place (see e.g. has_power_file()). There are only two
situations when the hotplug_slot_info would actually be accessed:
* If the driver defines ->enable_slot or ->disable_slot but not
->get_power_status.
* If the driver defines ->set_attention_status but not
->get_attention_status.
There is no driver doing the former and just a single driver doing the
latter, namely pnv_php.c. Amend it with a ->get_attention_status
callback. With that, the hotplug_slot_info becomes completely unused by
the PCI hotplug core. But a few drivers use it internally as a cache:
cpcihp uses it to cache the latch_status and adapter_status.
cpqhp uses it to cache the adapter_status.
pnv_php and rpaphp use it to cache the attention_status.
shpchp uses it to cache all four values.
Amend these drivers to cache the information in their private slot
struct. shpchp's slot struct already contains members to cache the
power_status and adapter_status, so additional members are only needed
for the other two values. In the case of cpqphp, the cached value is
only accessed in a single place, so instead of caching it, read the
current value from the hardware.
Caution: acpiphp, cpci, cpqhp, shpchp, asus-wmi and eeepc-laptop
populate the hotplug_slot_info with initial values on probe. That code
is herewith removed. There is a theoretical chance that the code has
side effects without which the driver fails to function, e.g. if the
ACPI method to read the adapter status needs to be executed at least
once on probe. That seems unlikely to me, still maintainers should
review the changes carefully for this possibility.
Rafael adds: "I'm not aware of any case in which it will break anything,
[...] but if that happens, it may be necessary to add the execution of
the control methods in question directly to the initialization part."
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com> # drivers/pci/hotplug/rpa*
Acked-by: Sebastian Ott <sebott@linux.ibm.com> # drivers/pci/hotplug/s390*
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> # drivers/platform/x86
Cc: Len Brown <lenb@kernel.org>
Cc: Scott Murray <scott@spiteful.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Oliver OHalloran <oliveroh@au1.ibm.com>
Cc: Gavin Shan <gwshan@linux.vnet.ibm.com>
Cc: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Cc: Corentin Chary <corentin.chary@gmail.com>
Cc: Darren Hart <dvhart@infradead.org>
2018-09-08 14:59:01 +07:00
|
|
|
goto error_hpslot;
|
2005-04-17 05:20:36 +07:00
|
|
|
slot->dn = dn;
|
|
|
|
slot->index = drc_index;
|
|
|
|
slot->power_domain = power_domain;
|
|
|
|
slot->hotplug_slot->private = slot;
|
|
|
|
slot->hotplug_slot->ops = &rpaphp_hotplug_slot_ops;
|
2013-11-15 01:28:18 +07:00
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
return (slot);
|
|
|
|
|
|
|
|
error_hpslot:
|
|
|
|
kfree(slot->hotplug_slot);
|
|
|
|
error_slot:
|
|
|
|
kfree(slot);
|
|
|
|
error_nomem:
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int is_registered(struct slot *slot)
|
|
|
|
{
|
2007-04-14 05:34:10 +07:00
|
|
|
struct slot *tmp_slot;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
|
|
|
list_for_each_entry(tmp_slot, &rpaphp_slot_head, rpaphp_slot_list) {
|
|
|
|
if (!strcmp(tmp_slot->name, slot->name))
|
|
|
|
return 1;
|
2013-11-15 01:28:18 +07:00
|
|
|
}
|
2005-04-17 05:20:36 +07:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2006-01-13 07:31:01 +07:00
|
|
|
int rpaphp_deregister_slot(struct slot *slot)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
|
|
|
int retval = 0;
|
|
|
|
struct hotplug_slot *php_slot = slot->hotplug_slot;
|
|
|
|
|
|
|
|
dbg("%s - Entry: deregistering slot=%s\n",
|
2008-03-04 10:09:46 +07:00
|
|
|
__func__, slot->name);
|
2005-04-17 05:20:36 +07:00
|
|
|
|
|
|
|
list_del(&slot->rpaphp_slot_list);
|
PCI: hotplug: Demidlayer registration with the core
When a hotplug driver calls pci_hp_register(), all steps necessary for
registration are carried out in one go, including creation of a kobject
and addition to sysfs. That's a problem for pciehp once it's converted
to enable/disable the slot exclusively from the IRQ thread: The thread
needs to be spawned after creation of the kobject (because it uses the
kobject's name), but before addition to sysfs (because it will handle
enable/disable requests submitted via sysfs).
pci_hp_deregister() does offer a ->release callback that's invoked
after deletion from sysfs and before destruction of the kobject. But
because pci_hp_register() doesn't offer a counterpart, hotplug drivers'
->probe and ->remove code becomes asymmetric, which is error prone
as recently discovered use-after-free bugs in pciehp's ->remove hook
have shown.
In a sense, this appears to be a case of the midlayer antipattern:
"The core thesis of the "midlayer mistake" is that midlayers are
bad and should not exist. That common functionality which it is
so tempting to put in a midlayer should instead be provided as
library routines which can [be] used, augmented, or ignored by
each bottom level driver independently. Thus every subsystem
that supports multiple implementations (or drivers) should
provide a very thin top layer which calls directly into the
bottom layer drivers, and a rich library of support code that
eases the implementation of those drivers. This library is
available to, but not forced upon, those drivers."
-- Neil Brown (2009), https://lwn.net/Articles/336262/
The presence of midlayer traits in the PCI hotplug core might be ascribed
to its age: When it was introduced in February 2002, the blessings of a
library approach might not have been well known:
https://git.kernel.org/tglx/history/c/a8a2069f432c
For comparison, the driver core does offer split functions for creating
a kobject (device_initialize()) and addition to sysfs (device_add()) as
an alternative to carrying out everything at once (device_register()).
This was introduced in October 2002:
https://git.kernel.org/tglx/history/c/8b290eb19962
The odd ->release callback in the PCI hotplug core was added in 2003:
https://git.kernel.org/tglx/history/c/69f8d663b595
Clearly, a library approach would not force every hotplug driver to
implement a ->release callback, but rather allow the driver to remove
the sysfs files, release its data structures and finally destroy the
kobject. Alternatively, a driver may choose to remove everything with
pci_hp_deregister(), then release its data structures.
To this end, offer drivers pci_hp_initialize() and pci_hp_add() as a
split-up version of pci_hp_register(). Likewise, offer pci_hp_del()
and pci_hp_destroy() as a split-up version of pci_hp_deregister().
Eliminate the ->release callback and move its code into each driver's
teardown routine.
Declare pci_hp_deregister() void, in keeping with the usual kernel
pattern that enablement can fail, but disablement cannot. It only
returned an error if the caller passed in a NULL pointer or a slot which
has never or is no longer registered or is sharing its name with another
slot. Those would be bugs, so WARN about them. Few hotplug drivers
actually checked the return value and those that did only printed a
useless error message to dmesg. Remove that.
For most drivers the conversion was straightforward since it doesn't
matter whether the code in the ->release callback is executed before or
after destruction of the kobject. But in the case of ibmphp, it was
unclear to me whether setting slot_cur->ctrl and slot_cur->bus_on to
NULL needs to happen before the kobject is destroyed, so I erred on
the side of caution and ensured that the order stays the same. Another
nontrivial case is pnv_php, I've found the list and kref logic difficult
to understand, however my impression was that it is safe to delete the
list element and drop the references until after the kobject is
destroyed.
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> # drivers/platform/x86
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Cc: Scott Murray <scott@spiteful.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Gavin Shan <gwshan@linux.vnet.ibm.com>
Cc: Sebastian Ott <sebott@linux.vnet.ibm.com>
Cc: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Cc: Corentin Chary <corentin.chary@gmail.com>
Cc: Darren Hart <dvhart@infradead.org>
Cc: Andy Shevchenko <andy@infradead.org>
2018-07-20 05:27:43 +07:00
|
|
|
pci_hp_deregister(php_slot);
|
|
|
|
dealloc_slot_struct(slot);
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2008-03-04 10:09:46 +07:00
|
|
|
dbg("%s - Exit: rc[%d]\n", __func__, retval);
|
2005-04-17 05:20:36 +07:00
|
|
|
return retval;
|
|
|
|
}
|
2006-02-02 07:21:09 +07:00
|
|
|
EXPORT_SYMBOL_GPL(rpaphp_deregister_slot);
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2006-01-13 07:31:01 +07:00
|
|
|
int rpaphp_register_slot(struct slot *slot)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2006-12-02 07:31:27 +07:00
|
|
|
struct hotplug_slot *php_slot = slot->hotplug_slot;
|
2016-07-12 05:16:27 +07:00
|
|
|
struct device_node *child;
|
|
|
|
u32 my_index;
|
2005-04-17 05:20:36 +07:00
|
|
|
int retval;
|
2016-07-12 05:16:27 +07:00
|
|
|
int slotno = -1;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2017-07-19 04:43:21 +07:00
|
|
|
dbg("%s registering slot:path[%pOF] index[%x], name[%s] pdomain[%x] type[%d]\n",
|
|
|
|
__func__, slot->dn, slot->index, slot->name,
|
2005-04-17 05:20:36 +07:00
|
|
|
slot->power_domain, slot->type);
|
2006-12-02 07:31:27 +07:00
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
/* should not try to register the same slot twice */
|
2006-12-02 07:31:27 +07:00
|
|
|
if (is_registered(slot)) {
|
2006-01-13 07:31:01 +07:00
|
|
|
err("rpaphp_register_slot: slot[%s] is already registered\n", slot->name);
|
2007-04-14 05:34:11 +07:00
|
|
|
return -EAGAIN;
|
2013-11-15 01:28:18 +07:00
|
|
|
}
|
2006-12-02 07:31:27 +07:00
|
|
|
|
2016-07-12 05:16:27 +07:00
|
|
|
for_each_child_of_node(slot->dn, child) {
|
|
|
|
retval = of_property_read_u32(child, "ibm,my-drc-index", &my_index);
|
|
|
|
if (my_index == slot->index) {
|
|
|
|
slotno = PCI_SLOT(PCI_DN(child)->devfn);
|
|
|
|
of_node_put(child);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-10-21 06:40:42 +07:00
|
|
|
retval = pci_hp_register(php_slot, slot->bus, slotno, slot->name);
|
2005-04-17 05:20:36 +07:00
|
|
|
if (retval) {
|
|
|
|
err("pci_hp_register failed with error %d\n", retval);
|
2007-04-14 05:34:11 +07:00
|
|
|
return retval;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
2006-12-02 07:31:27 +07:00
|
|
|
/* add slot to our internal list */
|
2005-04-17 05:20:36 +07:00
|
|
|
list_add(&slot->rpaphp_slot_list, &rpaphp_slot_head);
|
2007-11-26 14:51:37 +07:00
|
|
|
info("Slot [%s] registered\n", slot->name);
|
2005-04-17 05:20:36 +07:00
|
|
|
return 0;
|
|
|
|
}
|