2005-04-17 05:20:36 +07:00
|
|
|
/*
|
|
|
|
* acpi_container.c - ACPI Generic Container Driver
|
|
|
|
* ($Revision: )
|
|
|
|
*
|
|
|
|
* Copyright (C) 2004 Anil S Keshavamurthy (anil.s.keshavamurthy@intel.com)
|
|
|
|
* Copyright (C) 2004 Keiichiro Tokunaga (tokunaga.keiich@jp.fujitsu.com)
|
|
|
|
* Copyright (C) 2004 Motoyuki Ito (motoyuki@soft.fujitsu.com)
|
|
|
|
* Copyright (C) 2004 Intel Corp.
|
|
|
|
* Copyright (C) 2004 FUJITSU LIMITED
|
|
|
|
*
|
|
|
|
* ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or (at
|
|
|
|
* your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful, but
|
|
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License along
|
|
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
|
|
* 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
|
|
|
|
*
|
|
|
|
* ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/init.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 15:04:11 +07:00
|
|
|
#include <linux/slab.h>
|
2005-04-17 05:20:36 +07:00
|
|
|
#include <linux/types.h>
|
|
|
|
#include <linux/acpi.h>
|
|
|
|
#include <acpi/acpi_bus.h>
|
|
|
|
#include <acpi/acpi_drivers.h>
|
|
|
|
|
2009-07-29 03:45:54 +07:00
|
|
|
#define PREFIX "ACPI: "
|
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
#define _COMPONENT ACPI_CONTAINER_COMPONENT
|
2007-02-13 10:42:12 +07:00
|
|
|
ACPI_MODULE_NAME("container");
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2007-07-23 19:44:41 +07:00
|
|
|
static const struct acpi_device_id container_device_ids[] = {
|
|
|
|
{"ACPI0004", 0},
|
|
|
|
{"PNP0A05", 0},
|
|
|
|
{"PNP0A06", 0},
|
|
|
|
{"", 0},
|
|
|
|
};
|
|
|
|
|
2013-02-09 05:52:39 +07:00
|
|
|
static int container_device_attach(struct acpi_device *device,
|
|
|
|
const struct acpi_device_id *not_used)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* FIXME: This is necessary, so that acpi_eject_store() doesn't return
|
|
|
|
* -ENODEV for containers.
|
|
|
|
*/
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct acpi_scan_handler container_device_handler = {
|
2007-07-23 19:44:41 +07:00
|
|
|
.ids = container_device_ids,
|
2013-02-09 05:52:39 +07:00
|
|
|
.attach = container_device_attach,
|
2005-04-17 05:20:36 +07:00
|
|
|
};
|
|
|
|
|
2005-08-05 11:44:28 +07:00
|
|
|
static int is_device_present(acpi_handle handle)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2005-08-05 11:44:28 +07:00
|
|
|
acpi_handle temp;
|
|
|
|
acpi_status status;
|
2008-10-10 13:22:59 +07:00
|
|
|
unsigned long long sta;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
|
|
|
|
|
|
|
status = acpi_get_handle(handle, "_STA", &temp);
|
|
|
|
if (ACPI_FAILURE(status))
|
2007-04-26 01:17:39 +07:00
|
|
|
return 1; /* _STA not found, assume device present */
|
2005-04-17 05:20:36 +07:00
|
|
|
|
|
|
|
status = acpi_evaluate_integer(handle, "_STA", NULL, &sta);
|
|
|
|
if (ACPI_FAILURE(status))
|
2006-06-27 11:41:40 +07:00
|
|
|
return 0; /* Firmware error */
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2007-04-26 01:17:39 +07:00
|
|
|
return ((sta & ACPI_STA_DEVICE_PRESENT) == ACPI_STA_DEVICE_PRESENT);
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
2005-08-05 11:44:28 +07:00
|
|
|
static void container_notify_cb(acpi_handle handle, u32 type, void *context)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2005-08-05 11:44:28 +07:00
|
|
|
struct acpi_device *device = NULL;
|
2005-04-17 05:20:36 +07:00
|
|
|
int result;
|
|
|
|
int present;
|
|
|
|
acpi_status status;
|
2012-05-24 09:25:23 +07:00
|
|
|
u32 ost_code = ACPI_OST_SC_NON_SPECIFIC_FAILURE; /* default */
|
2005-08-05 11:44:28 +07:00
|
|
|
|
ACPI / hotplug: Fix concurrency issues and memory leaks
This changeset is aimed at fixing a few different but related
problems in the ACPI hotplug infrastructure.
First of all, since notify handlers may be run in parallel with
acpi_bus_scan(), acpi_bus_trim() and acpi_bus_hot_remove_device()
and some of them are installed for ACPI handles that have no struct
acpi_device objects attached (i.e. before those objects are created),
those notify handlers have to take acpi_scan_lock to prevent races
from taking place (e.g. a struct acpi_device is found to be present
for the given ACPI handle, but right after that it is removed by
acpi_bus_trim() running in parallel to the given notify handler).
Moreover, since some of them call acpi_bus_scan() and
acpi_bus_trim(), this leads to the conclusion that acpi_scan_lock
should be acquired by the callers of these two funtions rather by
these functions themselves.
For these reasons, make all notify handlers that can handle device
addition and eject events take acpi_scan_lock and remove the
acpi_scan_lock locking from acpi_bus_scan() and acpi_bus_trim().
Accordingly, update all of their users to make sure that they
are always called under acpi_scan_lock.
Furthermore, since eject operations are carried out asynchronously
with respect to the notify events that trigger them, with the help
of acpi_bus_hot_remove_device(), even if notify handlers take the
ACPI scan lock, it still is possible that, for example,
acpi_bus_trim() will run between acpi_bus_hot_remove_device() and
the notify handler that scheduled its execution and that
acpi_bus_trim() will remove the device node passed to
acpi_bus_hot_remove_device() for ejection. In that case, the struct
acpi_device object obtained by acpi_bus_hot_remove_device() will be
invalid and not-so-funny things will ensue. To protect agaist that,
make the users of acpi_bus_hot_remove_device() run get_device() on
ACPI device node objects that are about to be passed to it and make
acpi_bus_hot_remove_device() run put_device() on them and check if
their ACPI handles are not NULL (make acpi_device_unregister() clear
the device nodes' ACPI handles for that check to work).
Finally, observe that acpi_os_hotplug_execute() actually can fail,
in which case its caller ought to free memory allocated for the
context object to prevent leaks from happening. It also needs to
run put_device() on the device node that it ran get_device() on
previously in that case. Modify the code accordingly.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Yinghai Lu <yinghai@kernel.org>
2013-02-13 20:36:47 +07:00
|
|
|
acpi_scan_lock_acquire();
|
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
switch (type) {
|
|
|
|
case ACPI_NOTIFY_BUS_CHECK:
|
|
|
|
/* Fall through */
|
|
|
|
case ACPI_NOTIFY_DEVICE_CHECK:
|
2012-11-21 06:42:29 +07:00
|
|
|
pr_debug("Container driver received %s event\n",
|
2005-08-05 11:44:28 +07:00
|
|
|
(type == ACPI_NOTIFY_BUS_CHECK) ?
|
|
|
|
"ACPI_NOTIFY_BUS_CHECK" : "ACPI_NOTIFY_DEVICE_CHECK");
|
2012-05-24 09:25:23 +07:00
|
|
|
|
|
|
|
present = is_device_present(handle);
|
2005-04-17 05:20:36 +07:00
|
|
|
status = acpi_bus_get_device(handle, &device);
|
2012-05-24 09:25:23 +07:00
|
|
|
if (!present) {
|
2005-04-17 05:20:36 +07:00
|
|
|
if (ACPI_SUCCESS(status)) {
|
|
|
|
/* device exist and this is a remove request */
|
2012-05-24 09:25:23 +07:00
|
|
|
device->flags.eject_pending = 1;
|
2006-12-07 19:56:38 +07:00
|
|
|
kobject_uevent(&device->dev.kobj, KOBJ_OFFLINE);
|
ACPI / hotplug: Fix concurrency issues and memory leaks
This changeset is aimed at fixing a few different but related
problems in the ACPI hotplug infrastructure.
First of all, since notify handlers may be run in parallel with
acpi_bus_scan(), acpi_bus_trim() and acpi_bus_hot_remove_device()
and some of them are installed for ACPI handles that have no struct
acpi_device objects attached (i.e. before those objects are created),
those notify handlers have to take acpi_scan_lock to prevent races
from taking place (e.g. a struct acpi_device is found to be present
for the given ACPI handle, but right after that it is removed by
acpi_bus_trim() running in parallel to the given notify handler).
Moreover, since some of them call acpi_bus_scan() and
acpi_bus_trim(), this leads to the conclusion that acpi_scan_lock
should be acquired by the callers of these two funtions rather by
these functions themselves.
For these reasons, make all notify handlers that can handle device
addition and eject events take acpi_scan_lock and remove the
acpi_scan_lock locking from acpi_bus_scan() and acpi_bus_trim().
Accordingly, update all of their users to make sure that they
are always called under acpi_scan_lock.
Furthermore, since eject operations are carried out asynchronously
with respect to the notify events that trigger them, with the help
of acpi_bus_hot_remove_device(), even if notify handlers take the
ACPI scan lock, it still is possible that, for example,
acpi_bus_trim() will run between acpi_bus_hot_remove_device() and
the notify handler that scheduled its execution and that
acpi_bus_trim() will remove the device node passed to
acpi_bus_hot_remove_device() for ejection. In that case, the struct
acpi_device object obtained by acpi_bus_hot_remove_device() will be
invalid and not-so-funny things will ensue. To protect agaist that,
make the users of acpi_bus_hot_remove_device() run get_device() on
ACPI device node objects that are about to be passed to it and make
acpi_bus_hot_remove_device() run put_device() on them and check if
their ACPI handles are not NULL (make acpi_device_unregister() clear
the device nodes' ACPI handles for that check to work).
Finally, observe that acpi_os_hotplug_execute() actually can fail,
in which case its caller ought to free memory allocated for the
context object to prevent leaks from happening. It also needs to
run put_device() on the device node that it ran get_device() on
previously in that case. Modify the code accordingly.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Yinghai Lu <yinghai@kernel.org>
2013-02-13 20:36:47 +07:00
|
|
|
goto out;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
2012-05-24 09:25:23 +07:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!ACPI_FAILURE(status) || device)
|
|
|
|
break;
|
|
|
|
|
2013-01-19 07:27:35 +07:00
|
|
|
result = acpi_bus_scan(handle);
|
2012-05-24 09:25:23 +07:00
|
|
|
if (result) {
|
2012-11-21 06:42:29 +07:00
|
|
|
acpi_handle_warn(handle, "Failed to add container\n");
|
2012-05-24 09:25:23 +07:00
|
|
|
break;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
2012-12-21 06:36:49 +07:00
|
|
|
result = acpi_bus_get_device(handle, &device);
|
|
|
|
if (result) {
|
|
|
|
acpi_handle_warn(handle, "Missing device object\n");
|
|
|
|
break;
|
|
|
|
}
|
2012-05-24 09:25:23 +07:00
|
|
|
|
|
|
|
kobject_uevent(&device->dev.kobj, KOBJ_ONLINE);
|
|
|
|
ost_code = ACPI_OST_SC_SUCCESS;
|
2005-04-17 05:20:36 +07:00
|
|
|
break;
|
2012-05-24 09:25:23 +07:00
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
case ACPI_NOTIFY_EJECT_REQUEST:
|
|
|
|
if (!acpi_bus_get_device(handle, &device) && device) {
|
2012-05-24 09:25:23 +07:00
|
|
|
device->flags.eject_pending = 1;
|
2006-12-07 19:56:38 +07:00
|
|
|
kobject_uevent(&device->dev.kobj, KOBJ_OFFLINE);
|
ACPI / hotplug: Fix concurrency issues and memory leaks
This changeset is aimed at fixing a few different but related
problems in the ACPI hotplug infrastructure.
First of all, since notify handlers may be run in parallel with
acpi_bus_scan(), acpi_bus_trim() and acpi_bus_hot_remove_device()
and some of them are installed for ACPI handles that have no struct
acpi_device objects attached (i.e. before those objects are created),
those notify handlers have to take acpi_scan_lock to prevent races
from taking place (e.g. a struct acpi_device is found to be present
for the given ACPI handle, but right after that it is removed by
acpi_bus_trim() running in parallel to the given notify handler).
Moreover, since some of them call acpi_bus_scan() and
acpi_bus_trim(), this leads to the conclusion that acpi_scan_lock
should be acquired by the callers of these two funtions rather by
these functions themselves.
For these reasons, make all notify handlers that can handle device
addition and eject events take acpi_scan_lock and remove the
acpi_scan_lock locking from acpi_bus_scan() and acpi_bus_trim().
Accordingly, update all of their users to make sure that they
are always called under acpi_scan_lock.
Furthermore, since eject operations are carried out asynchronously
with respect to the notify events that trigger them, with the help
of acpi_bus_hot_remove_device(), even if notify handlers take the
ACPI scan lock, it still is possible that, for example,
acpi_bus_trim() will run between acpi_bus_hot_remove_device() and
the notify handler that scheduled its execution and that
acpi_bus_trim() will remove the device node passed to
acpi_bus_hot_remove_device() for ejection. In that case, the struct
acpi_device object obtained by acpi_bus_hot_remove_device() will be
invalid and not-so-funny things will ensue. To protect agaist that,
make the users of acpi_bus_hot_remove_device() run get_device() on
ACPI device node objects that are about to be passed to it and make
acpi_bus_hot_remove_device() run put_device() on them and check if
their ACPI handles are not NULL (make acpi_device_unregister() clear
the device nodes' ACPI handles for that check to work).
Finally, observe that acpi_os_hotplug_execute() actually can fail,
in which case its caller ought to free memory allocated for the
context object to prevent leaks from happening. It also needs to
run put_device() on the device node that it ran get_device() on
previously in that case. Modify the code accordingly.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Yinghai Lu <yinghai@kernel.org>
2013-02-13 20:36:47 +07:00
|
|
|
goto out;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
break;
|
2012-05-24 09:25:23 +07:00
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
default:
|
2012-05-24 09:25:23 +07:00
|
|
|
/* non-hotplug event; possibly handled by other handler */
|
ACPI / hotplug: Fix concurrency issues and memory leaks
This changeset is aimed at fixing a few different but related
problems in the ACPI hotplug infrastructure.
First of all, since notify handlers may be run in parallel with
acpi_bus_scan(), acpi_bus_trim() and acpi_bus_hot_remove_device()
and some of them are installed for ACPI handles that have no struct
acpi_device objects attached (i.e. before those objects are created),
those notify handlers have to take acpi_scan_lock to prevent races
from taking place (e.g. a struct acpi_device is found to be present
for the given ACPI handle, but right after that it is removed by
acpi_bus_trim() running in parallel to the given notify handler).
Moreover, since some of them call acpi_bus_scan() and
acpi_bus_trim(), this leads to the conclusion that acpi_scan_lock
should be acquired by the callers of these two funtions rather by
these functions themselves.
For these reasons, make all notify handlers that can handle device
addition and eject events take acpi_scan_lock and remove the
acpi_scan_lock locking from acpi_bus_scan() and acpi_bus_trim().
Accordingly, update all of their users to make sure that they
are always called under acpi_scan_lock.
Furthermore, since eject operations are carried out asynchronously
with respect to the notify events that trigger them, with the help
of acpi_bus_hot_remove_device(), even if notify handlers take the
ACPI scan lock, it still is possible that, for example,
acpi_bus_trim() will run between acpi_bus_hot_remove_device() and
the notify handler that scheduled its execution and that
acpi_bus_trim() will remove the device node passed to
acpi_bus_hot_remove_device() for ejection. In that case, the struct
acpi_device object obtained by acpi_bus_hot_remove_device() will be
invalid and not-so-funny things will ensue. To protect agaist that,
make the users of acpi_bus_hot_remove_device() run get_device() on
ACPI device node objects that are about to be passed to it and make
acpi_bus_hot_remove_device() run put_device() on them and check if
their ACPI handles are not NULL (make acpi_device_unregister() clear
the device nodes' ACPI handles for that check to work).
Finally, observe that acpi_os_hotplug_execute() actually can fail,
in which case its caller ought to free memory allocated for the
context object to prevent leaks from happening. It also needs to
run put_device() on the device node that it ran get_device() on
previously in that case. Modify the code accordingly.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Yinghai Lu <yinghai@kernel.org>
2013-02-13 20:36:47 +07:00
|
|
|
goto out;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
2012-05-24 09:25:23 +07:00
|
|
|
|
|
|
|
/* Inform firmware that the hotplug operation has completed */
|
|
|
|
(void) acpi_evaluate_hotplug_ost(handle, type, ost_code, NULL);
|
ACPI / hotplug: Fix concurrency issues and memory leaks
This changeset is aimed at fixing a few different but related
problems in the ACPI hotplug infrastructure.
First of all, since notify handlers may be run in parallel with
acpi_bus_scan(), acpi_bus_trim() and acpi_bus_hot_remove_device()
and some of them are installed for ACPI handles that have no struct
acpi_device objects attached (i.e. before those objects are created),
those notify handlers have to take acpi_scan_lock to prevent races
from taking place (e.g. a struct acpi_device is found to be present
for the given ACPI handle, but right after that it is removed by
acpi_bus_trim() running in parallel to the given notify handler).
Moreover, since some of them call acpi_bus_scan() and
acpi_bus_trim(), this leads to the conclusion that acpi_scan_lock
should be acquired by the callers of these two funtions rather by
these functions themselves.
For these reasons, make all notify handlers that can handle device
addition and eject events take acpi_scan_lock and remove the
acpi_scan_lock locking from acpi_bus_scan() and acpi_bus_trim().
Accordingly, update all of their users to make sure that they
are always called under acpi_scan_lock.
Furthermore, since eject operations are carried out asynchronously
with respect to the notify events that trigger them, with the help
of acpi_bus_hot_remove_device(), even if notify handlers take the
ACPI scan lock, it still is possible that, for example,
acpi_bus_trim() will run between acpi_bus_hot_remove_device() and
the notify handler that scheduled its execution and that
acpi_bus_trim() will remove the device node passed to
acpi_bus_hot_remove_device() for ejection. In that case, the struct
acpi_device object obtained by acpi_bus_hot_remove_device() will be
invalid and not-so-funny things will ensue. To protect agaist that,
make the users of acpi_bus_hot_remove_device() run get_device() on
ACPI device node objects that are about to be passed to it and make
acpi_bus_hot_remove_device() run put_device() on them and check if
their ACPI handles are not NULL (make acpi_device_unregister() clear
the device nodes' ACPI handles for that check to work).
Finally, observe that acpi_os_hotplug_execute() actually can fail,
in which case its caller ought to free memory allocated for the
context object to prevent leaks from happening. It also needs to
run put_device() on the device node that it ran get_device() on
previously in that case. Modify the code accordingly.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Yinghai Lu <yinghai@kernel.org>
2013-02-13 20:36:47 +07:00
|
|
|
|
|
|
|
out:
|
|
|
|
acpi_scan_lock_release();
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
2013-02-09 05:52:39 +07:00
|
|
|
static bool is_container(acpi_handle handle)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2005-08-05 11:44:28 +07:00
|
|
|
struct acpi_device_info *info;
|
2013-02-09 05:52:39 +07:00
|
|
|
bool ret = false;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2013-02-09 05:52:39 +07:00
|
|
|
if (ACPI_FAILURE(acpi_get_object_info(handle, &info)))
|
|
|
|
return false;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2013-02-09 05:52:39 +07:00
|
|
|
if (info->valid & ACPI_VALID_HID) {
|
|
|
|
const struct acpi_device_id *id;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2013-02-09 05:52:39 +07:00
|
|
|
for (id = container_device_ids; id->id[0]; id++) {
|
|
|
|
ret = !strcmp((char *)id->id, info->hardware_id.string);
|
|
|
|
if (ret)
|
|
|
|
break;
|
|
|
|
}
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
2009-06-29 12:39:29 +07:00
|
|
|
kfree(info);
|
2013-02-09 05:52:39 +07:00
|
|
|
return ret;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
2013-02-09 05:52:39 +07:00
|
|
|
static acpi_status acpi_container_register_notify_handler(acpi_handle handle,
|
|
|
|
u32 lvl, void *ctxt,
|
|
|
|
void **retv)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2013-02-09 05:52:39 +07:00
|
|
|
if (is_container(handle))
|
|
|
|
acpi_install_notify_handler(handle, ACPI_SYSTEM_NOTIFY,
|
|
|
|
container_notify_cb, NULL);
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2013-02-09 05:52:39 +07:00
|
|
|
return AE_OK;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
2013-02-09 05:52:39 +07:00
|
|
|
void __init acpi_container_init(void)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2013-02-09 05:52:39 +07:00
|
|
|
acpi_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT, ACPI_UINT32_MAX,
|
|
|
|
acpi_container_register_notify_handler, NULL,
|
|
|
|
NULL, NULL);
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2013-02-09 05:52:39 +07:00
|
|
|
acpi_scan_add_handler(&container_device_handler);
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|