2005-04-17 05:20:36 +07:00
|
|
|
/*
|
|
|
|
* This file is subject to the terms and conditions of the GNU General Public
|
|
|
|
* License. See the file "COPYING" in the main directory of this archive
|
|
|
|
* for more details.
|
|
|
|
*
|
|
|
|
* Copyright (C) 1992 Ross Biro
|
|
|
|
* Copyright (C) Linus Torvalds
|
|
|
|
* Copyright (C) 1994, 95, 96, 97, 98, 2000 Ralf Baechle
|
|
|
|
* Copyright (C) 1996 David S. Miller
|
|
|
|
* Kevin D. Kissell, kevink@mips.com and Carsten Langgaard, carstenl@mips.com
|
|
|
|
* Copyright (C) 1999 MIPS Technologies, Inc.
|
|
|
|
* Copyright (C) 2000 Ulf Carlsson
|
|
|
|
*
|
|
|
|
* At this time Linux/MIPS64 only supports syscall tracing, even for 32-bit
|
|
|
|
* binaries.
|
|
|
|
*/
|
|
|
|
#include <linux/compiler.h>
|
2013-05-29 06:07:19 +07:00
|
|
|
#include <linux/context_tracking.h>
|
2012-08-02 19:44:11 +07:00
|
|
|
#include <linux/elf.h>
|
2005-04-17 05:20:36 +07:00
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/sched.h>
|
2017-02-09 00:51:37 +07:00
|
|
|
#include <linux/sched/task_stack.h>
|
2005-04-17 05:20:36 +07:00
|
|
|
#include <linux/mm.h>
|
|
|
|
#include <linux/errno.h>
|
|
|
|
#include <linux/ptrace.h>
|
2012-08-02 19:44:11 +07:00
|
|
|
#include <linux/regset.h>
|
2005-04-17 05:20:36 +07:00
|
|
|
#include <linux/smp.h>
|
|
|
|
#include <linux/security.h>
|
2015-07-30 03:44:53 +07:00
|
|
|
#include <linux/stddef.h>
|
2012-07-18 00:43:58 +07:00
|
|
|
#include <linux/tracehook.h>
|
2007-07-25 22:19:33 +07:00
|
|
|
#include <linux/audit.h>
|
|
|
|
#include <linux/seccomp.h>
|
2013-09-07 01:24:48 +07:00
|
|
|
#include <linux/ftrace.h>
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2005-05-19 19:08:04 +07:00
|
|
|
#include <asm/byteorder.h>
|
2005-04-17 05:20:36 +07:00
|
|
|
#include <asm/cpu.h>
|
2015-04-04 05:27:48 +07:00
|
|
|
#include <asm/cpu-info.h>
|
2005-05-31 18:49:19 +07:00
|
|
|
#include <asm/dsp.h>
|
2005-04-17 05:20:36 +07:00
|
|
|
#include <asm/fpu.h>
|
|
|
|
#include <asm/mipsregs.h>
|
2005-10-06 23:39:32 +07:00
|
|
|
#include <asm/mipsmtregs.h>
|
2005-04-17 05:20:36 +07:00
|
|
|
#include <asm/pgtable.h>
|
|
|
|
#include <asm/page.h>
|
2018-05-16 05:34:28 +07:00
|
|
|
#include <asm/processor.h>
|
2012-09-27 01:16:47 +07:00
|
|
|
#include <asm/syscall.h>
|
2016-12-25 02:46:01 +07:00
|
|
|
#include <linux/uaccess.h>
|
2005-04-17 05:20:36 +07:00
|
|
|
#include <asm/bootinfo.h>
|
2005-09-29 05:11:15 +07:00
|
|
|
#include <asm/reg.h>
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2013-09-07 01:24:48 +07:00
|
|
|
#define CREATE_TRACE_POINTS
|
|
|
|
#include <trace/events/syscalls.h>
|
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
/*
|
|
|
|
* Called by kernel/ptrace.c when detaching..
|
|
|
|
*
|
|
|
|
* Make sure single step bits etc are not set.
|
|
|
|
*/
|
|
|
|
void ptrace_disable(struct task_struct *child)
|
|
|
|
{
|
2008-09-23 14:11:26 +07:00
|
|
|
/* Don't load the watchpoint registers for the ex-child. */
|
|
|
|
clear_tsk_thread_flag(child, TIF_LOAD_WATCH);
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
2005-09-29 05:11:15 +07:00
|
|
|
/*
|
2013-01-22 18:59:30 +07:00
|
|
|
* Read a general register set. We always use the 64-bit format, even
|
2005-09-29 05:11:15 +07:00
|
|
|
* for 32-bit kernels and for 32-bit processes on a 64-bit kernel.
|
|
|
|
* Registers are sign extended to fill the available space.
|
|
|
|
*/
|
2014-07-23 20:40:13 +07:00
|
|
|
int ptrace_getregs(struct task_struct *child, struct user_pt_regs __user *data)
|
2005-09-29 05:11:15 +07:00
|
|
|
{
|
|
|
|
struct pt_regs *regs;
|
|
|
|
int i;
|
|
|
|
|
Remove 'type' argument from access_ok() function
Nobody has actually used the type (VERIFY_READ vs VERIFY_WRITE) argument
of the user address range verification function since we got rid of the
old racy i386-only code to walk page tables by hand.
It existed because the original 80386 would not honor the write protect
bit when in kernel mode, so you had to do COW by hand before doing any
user access. But we haven't supported that in a long time, and these
days the 'type' argument is a purely historical artifact.
A discussion about extending 'user_access_begin()' to do the range
checking resulted this patch, because there is no way we're going to
move the old VERIFY_xyz interface to that model. And it's best done at
the end of the merge window when I've done most of my merges, so let's
just get this done once and for all.
This patch was mostly done with a sed-script, with manual fix-ups for
the cases that weren't of the trivial 'access_ok(VERIFY_xyz' form.
There were a couple of notable cases:
- csky still had the old "verify_area()" name as an alias.
- the iter_iov code had magical hardcoded knowledge of the actual
values of VERIFY_{READ,WRITE} (not that they mattered, since nothing
really used it)
- microblaze used the type argument for a debug printout
but other than those oddities this should be a total no-op patch.
I tried to fix up all architectures, did fairly extensive grepping for
access_ok() uses, and the changes are trivial, but I may have missed
something. Any missed conversion should be trivially fixable, though.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2019-01-04 09:57:57 +07:00
|
|
|
if (!access_ok(data, 38 * 8))
|
2005-09-29 05:11:15 +07:00
|
|
|
return -EIO;
|
|
|
|
|
2006-01-12 16:06:07 +07:00
|
|
|
regs = task_pt_regs(child);
|
2005-09-29 05:11:15 +07:00
|
|
|
|
|
|
|
for (i = 0; i < 32; i++)
|
2014-07-23 20:40:13 +07:00
|
|
|
__put_user((long)regs->regs[i], (__s64 __user *)&data->regs[i]);
|
|
|
|
__put_user((long)regs->lo, (__s64 __user *)&data->lo);
|
|
|
|
__put_user((long)regs->hi, (__s64 __user *)&data->hi);
|
|
|
|
__put_user((long)regs->cp0_epc, (__s64 __user *)&data->cp0_epc);
|
|
|
|
__put_user((long)regs->cp0_badvaddr, (__s64 __user *)&data->cp0_badvaddr);
|
|
|
|
__put_user((long)regs->cp0_status, (__s64 __user *)&data->cp0_status);
|
|
|
|
__put_user((long)regs->cp0_cause, (__s64 __user *)&data->cp0_cause);
|
2005-09-29 05:11:15 +07:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Write a general register set. As for PTRACE_GETREGS, we always use
|
|
|
|
* the 64-bit format. On a 32-bit kernel only the lower order half
|
|
|
|
* (according to endianness) will be used.
|
|
|
|
*/
|
2014-07-23 20:40:13 +07:00
|
|
|
int ptrace_setregs(struct task_struct *child, struct user_pt_regs __user *data)
|
2005-09-29 05:11:15 +07:00
|
|
|
{
|
|
|
|
struct pt_regs *regs;
|
|
|
|
int i;
|
|
|
|
|
Remove 'type' argument from access_ok() function
Nobody has actually used the type (VERIFY_READ vs VERIFY_WRITE) argument
of the user address range verification function since we got rid of the
old racy i386-only code to walk page tables by hand.
It existed because the original 80386 would not honor the write protect
bit when in kernel mode, so you had to do COW by hand before doing any
user access. But we haven't supported that in a long time, and these
days the 'type' argument is a purely historical artifact.
A discussion about extending 'user_access_begin()' to do the range
checking resulted this patch, because there is no way we're going to
move the old VERIFY_xyz interface to that model. And it's best done at
the end of the merge window when I've done most of my merges, so let's
just get this done once and for all.
This patch was mostly done with a sed-script, with manual fix-ups for
the cases that weren't of the trivial 'access_ok(VERIFY_xyz' form.
There were a couple of notable cases:
- csky still had the old "verify_area()" name as an alias.
- the iter_iov code had magical hardcoded knowledge of the actual
values of VERIFY_{READ,WRITE} (not that they mattered, since nothing
really used it)
- microblaze used the type argument for a debug printout
but other than those oddities this should be a total no-op patch.
I tried to fix up all architectures, did fairly extensive grepping for
access_ok() uses, and the changes are trivial, but I may have missed
something. Any missed conversion should be trivially fixable, though.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2019-01-04 09:57:57 +07:00
|
|
|
if (!access_ok(data, 38 * 8))
|
2005-09-29 05:11:15 +07:00
|
|
|
return -EIO;
|
|
|
|
|
2006-01-12 16:06:07 +07:00
|
|
|
regs = task_pt_regs(child);
|
2005-09-29 05:11:15 +07:00
|
|
|
|
|
|
|
for (i = 0; i < 32; i++)
|
2014-07-23 20:40:13 +07:00
|
|
|
__get_user(regs->regs[i], (__s64 __user *)&data->regs[i]);
|
|
|
|
__get_user(regs->lo, (__s64 __user *)&data->lo);
|
|
|
|
__get_user(regs->hi, (__s64 __user *)&data->hi);
|
|
|
|
__get_user(regs->cp0_epc, (__s64 __user *)&data->cp0_epc);
|
2005-09-29 05:11:15 +07:00
|
|
|
|
|
|
|
/* badvaddr, status, and cause may not be written. */
|
|
|
|
|
2017-08-12 03:56:52 +07:00
|
|
|
/* System call number may have been changed */
|
|
|
|
mips_syscall_update_nr(child, regs);
|
|
|
|
|
2005-09-29 05:11:15 +07:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-09-23 14:11:26 +07:00
|
|
|
int ptrace_get_watch_regs(struct task_struct *child,
|
|
|
|
struct pt_watch_regs __user *addr)
|
|
|
|
{
|
|
|
|
enum pt_watch_style style;
|
|
|
|
int i;
|
|
|
|
|
2014-05-01 18:51:19 +07:00
|
|
|
if (!cpu_has_watch || boot_cpu_data.watch_reg_use_cnt == 0)
|
2008-09-23 14:11:26 +07:00
|
|
|
return -EIO;
|
Remove 'type' argument from access_ok() function
Nobody has actually used the type (VERIFY_READ vs VERIFY_WRITE) argument
of the user address range verification function since we got rid of the
old racy i386-only code to walk page tables by hand.
It existed because the original 80386 would not honor the write protect
bit when in kernel mode, so you had to do COW by hand before doing any
user access. But we haven't supported that in a long time, and these
days the 'type' argument is a purely historical artifact.
A discussion about extending 'user_access_begin()' to do the range
checking resulted this patch, because there is no way we're going to
move the old VERIFY_xyz interface to that model. And it's best done at
the end of the merge window when I've done most of my merges, so let's
just get this done once and for all.
This patch was mostly done with a sed-script, with manual fix-ups for
the cases that weren't of the trivial 'access_ok(VERIFY_xyz' form.
There were a couple of notable cases:
- csky still had the old "verify_area()" name as an alias.
- the iter_iov code had magical hardcoded knowledge of the actual
values of VERIFY_{READ,WRITE} (not that they mattered, since nothing
really used it)
- microblaze used the type argument for a debug printout
but other than those oddities this should be a total no-op patch.
I tried to fix up all architectures, did fairly extensive grepping for
access_ok() uses, and the changes are trivial, but I may have missed
something. Any missed conversion should be trivially fixable, though.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2019-01-04 09:57:57 +07:00
|
|
|
if (!access_ok(addr, sizeof(struct pt_watch_regs)))
|
2008-09-23 14:11:26 +07:00
|
|
|
return -EIO;
|
|
|
|
|
|
|
|
#ifdef CONFIG_32BIT
|
|
|
|
style = pt_watch_style_mips32;
|
|
|
|
#define WATCH_STYLE mips32
|
|
|
|
#else
|
|
|
|
style = pt_watch_style_mips64;
|
|
|
|
#define WATCH_STYLE mips64
|
|
|
|
#endif
|
|
|
|
|
|
|
|
__put_user(style, &addr->style);
|
2014-05-01 18:51:19 +07:00
|
|
|
__put_user(boot_cpu_data.watch_reg_use_cnt,
|
2008-09-23 14:11:26 +07:00
|
|
|
&addr->WATCH_STYLE.num_valid);
|
2014-05-01 18:51:19 +07:00
|
|
|
for (i = 0; i < boot_cpu_data.watch_reg_use_cnt; i++) {
|
2008-09-23 14:11:26 +07:00
|
|
|
__put_user(child->thread.watch.mips3264.watchlo[i],
|
|
|
|
&addr->WATCH_STYLE.watchlo[i]);
|
2016-03-02 05:19:39 +07:00
|
|
|
__put_user(child->thread.watch.mips3264.watchhi[i] &
|
|
|
|
(MIPS_WATCHHI_MASK | MIPS_WATCHHI_IRW),
|
2008-09-23 14:11:26 +07:00
|
|
|
&addr->WATCH_STYLE.watchhi[i]);
|
2014-05-01 18:51:19 +07:00
|
|
|
__put_user(boot_cpu_data.watch_reg_masks[i],
|
2008-09-23 14:11:26 +07:00
|
|
|
&addr->WATCH_STYLE.watch_masks[i]);
|
|
|
|
}
|
|
|
|
for (; i < 8; i++) {
|
|
|
|
__put_user(0, &addr->WATCH_STYLE.watchlo[i]);
|
|
|
|
__put_user(0, &addr->WATCH_STYLE.watchhi[i]);
|
|
|
|
__put_user(0, &addr->WATCH_STYLE.watch_masks[i]);
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
int ptrace_set_watch_regs(struct task_struct *child,
|
|
|
|
struct pt_watch_regs __user *addr)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
int watch_active = 0;
|
|
|
|
unsigned long lt[NUM_WATCH_REGS];
|
|
|
|
u16 ht[NUM_WATCH_REGS];
|
|
|
|
|
2014-05-01 18:51:19 +07:00
|
|
|
if (!cpu_has_watch || boot_cpu_data.watch_reg_use_cnt == 0)
|
2008-09-23 14:11:26 +07:00
|
|
|
return -EIO;
|
Remove 'type' argument from access_ok() function
Nobody has actually used the type (VERIFY_READ vs VERIFY_WRITE) argument
of the user address range verification function since we got rid of the
old racy i386-only code to walk page tables by hand.
It existed because the original 80386 would not honor the write protect
bit when in kernel mode, so you had to do COW by hand before doing any
user access. But we haven't supported that in a long time, and these
days the 'type' argument is a purely historical artifact.
A discussion about extending 'user_access_begin()' to do the range
checking resulted this patch, because there is no way we're going to
move the old VERIFY_xyz interface to that model. And it's best done at
the end of the merge window when I've done most of my merges, so let's
just get this done once and for all.
This patch was mostly done with a sed-script, with manual fix-ups for
the cases that weren't of the trivial 'access_ok(VERIFY_xyz' form.
There were a couple of notable cases:
- csky still had the old "verify_area()" name as an alias.
- the iter_iov code had magical hardcoded knowledge of the actual
values of VERIFY_{READ,WRITE} (not that they mattered, since nothing
really used it)
- microblaze used the type argument for a debug printout
but other than those oddities this should be a total no-op patch.
I tried to fix up all architectures, did fairly extensive grepping for
access_ok() uses, and the changes are trivial, but I may have missed
something. Any missed conversion should be trivially fixable, though.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2019-01-04 09:57:57 +07:00
|
|
|
if (!access_ok(addr, sizeof(struct pt_watch_regs)))
|
2008-09-23 14:11:26 +07:00
|
|
|
return -EIO;
|
|
|
|
/* Check the values. */
|
2014-05-01 18:51:19 +07:00
|
|
|
for (i = 0; i < boot_cpu_data.watch_reg_use_cnt; i++) {
|
2008-09-23 14:11:26 +07:00
|
|
|
__get_user(lt[i], &addr->WATCH_STYLE.watchlo[i]);
|
|
|
|
#ifdef CONFIG_32BIT
|
|
|
|
if (lt[i] & __UA_LIMIT)
|
|
|
|
return -EINVAL;
|
|
|
|
#else
|
|
|
|
if (test_tsk_thread_flag(child, TIF_32BIT_ADDR)) {
|
|
|
|
if (lt[i] & 0xffffffff80000000UL)
|
|
|
|
return -EINVAL;
|
|
|
|
} else {
|
|
|
|
if (lt[i] & __UA_LIMIT)
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
__get_user(ht[i], &addr->WATCH_STYLE.watchhi[i]);
|
2016-03-02 05:19:39 +07:00
|
|
|
if (ht[i] & ~MIPS_WATCHHI_MASK)
|
2008-09-23 14:11:26 +07:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
/* Install them. */
|
2014-05-01 18:51:19 +07:00
|
|
|
for (i = 0; i < boot_cpu_data.watch_reg_use_cnt; i++) {
|
2016-03-02 05:19:39 +07:00
|
|
|
if (lt[i] & MIPS_WATCHLO_IRW)
|
2008-09-23 14:11:26 +07:00
|
|
|
watch_active = 1;
|
|
|
|
child->thread.watch.mips3264.watchlo[i] = lt[i];
|
|
|
|
/* Set the G bit. */
|
|
|
|
child->thread.watch.mips3264.watchhi[i] = ht[i];
|
|
|
|
}
|
|
|
|
|
|
|
|
if (watch_active)
|
|
|
|
set_tsk_thread_flag(child, TIF_LOAD_WATCH);
|
|
|
|
else
|
|
|
|
clear_tsk_thread_flag(child, TIF_LOAD_WATCH);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2012-08-02 19:44:11 +07:00
|
|
|
/* regset get/set implementations */
|
|
|
|
|
2014-07-23 20:40:09 +07:00
|
|
|
#if defined(CONFIG_32BIT) || defined(CONFIG_MIPS32_O32)
|
|
|
|
|
|
|
|
static int gpr32_get(struct task_struct *target,
|
|
|
|
const struct user_regset *regset,
|
|
|
|
unsigned int pos, unsigned int count,
|
|
|
|
void *kbuf, void __user *ubuf)
|
2012-08-02 19:44:11 +07:00
|
|
|
{
|
|
|
|
struct pt_regs *regs = task_pt_regs(target);
|
2014-07-23 20:40:09 +07:00
|
|
|
u32 uregs[ELF_NGREG] = {};
|
2012-08-02 19:44:11 +07:00
|
|
|
|
2016-11-21 17:23:38 +07:00
|
|
|
mips_dump_regs32(uregs, regs);
|
2014-07-23 20:40:09 +07:00
|
|
|
return user_regset_copyout(&pos, &count, &kbuf, &ubuf, uregs, 0,
|
|
|
|
sizeof(uregs));
|
2012-08-02 19:44:11 +07:00
|
|
|
}
|
|
|
|
|
2014-07-23 20:40:09 +07:00
|
|
|
static int gpr32_set(struct task_struct *target,
|
|
|
|
const struct user_regset *regset,
|
|
|
|
unsigned int pos, unsigned int count,
|
|
|
|
const void *kbuf, const void __user *ubuf)
|
2012-08-02 19:44:11 +07:00
|
|
|
{
|
2014-07-23 20:40:09 +07:00
|
|
|
struct pt_regs *regs = task_pt_regs(target);
|
|
|
|
u32 uregs[ELF_NGREG];
|
|
|
|
unsigned start, num_regs, i;
|
|
|
|
int err;
|
|
|
|
|
|
|
|
start = pos / sizeof(u32);
|
|
|
|
num_regs = count / sizeof(u32);
|
|
|
|
|
|
|
|
if (start + num_regs > ELF_NGREG)
|
|
|
|
return -EIO;
|
|
|
|
|
|
|
|
err = user_regset_copyin(&pos, &count, &kbuf, &ubuf, uregs, 0,
|
|
|
|
sizeof(uregs));
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
|
|
|
for (i = start; i < num_regs; i++) {
|
|
|
|
/*
|
|
|
|
* Cast all values to signed here so that if this is a 64-bit
|
|
|
|
* kernel, the supplied 32-bit values will be sign extended.
|
|
|
|
*/
|
|
|
|
switch (i) {
|
|
|
|
case MIPS32_EF_R1 ... MIPS32_EF_R25:
|
|
|
|
/* k0/k1 are ignored. */
|
|
|
|
case MIPS32_EF_R28 ... MIPS32_EF_R31:
|
|
|
|
regs->regs[i - MIPS32_EF_R0] = (s32)uregs[i];
|
|
|
|
break;
|
|
|
|
case MIPS32_EF_LO:
|
|
|
|
regs->lo = (s32)uregs[i];
|
|
|
|
break;
|
|
|
|
case MIPS32_EF_HI:
|
|
|
|
regs->hi = (s32)uregs[i];
|
|
|
|
break;
|
|
|
|
case MIPS32_EF_CP0_EPC:
|
|
|
|
regs->cp0_epc = (s32)uregs[i];
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-08-12 03:56:52 +07:00
|
|
|
/* System call number may have been changed */
|
|
|
|
mips_syscall_update_nr(target, regs);
|
|
|
|
|
2014-07-23 20:40:09 +07:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif /* CONFIG_32BIT || CONFIG_MIPS32_O32 */
|
|
|
|
|
|
|
|
#ifdef CONFIG_64BIT
|
|
|
|
|
|
|
|
static int gpr64_get(struct task_struct *target,
|
|
|
|
const struct user_regset *regset,
|
|
|
|
unsigned int pos, unsigned int count,
|
|
|
|
void *kbuf, void __user *ubuf)
|
|
|
|
{
|
|
|
|
struct pt_regs *regs = task_pt_regs(target);
|
|
|
|
u64 uregs[ELF_NGREG] = {};
|
|
|
|
|
2016-11-21 17:23:38 +07:00
|
|
|
mips_dump_regs64(uregs, regs);
|
2014-07-23 20:40:09 +07:00
|
|
|
return user_regset_copyout(&pos, &count, &kbuf, &ubuf, uregs, 0,
|
|
|
|
sizeof(uregs));
|
|
|
|
}
|
2012-08-02 19:44:11 +07:00
|
|
|
|
2014-07-23 20:40:09 +07:00
|
|
|
static int gpr64_set(struct task_struct *target,
|
|
|
|
const struct user_regset *regset,
|
|
|
|
unsigned int pos, unsigned int count,
|
|
|
|
const void *kbuf, const void __user *ubuf)
|
|
|
|
{
|
|
|
|
struct pt_regs *regs = task_pt_regs(target);
|
|
|
|
u64 uregs[ELF_NGREG];
|
|
|
|
unsigned start, num_regs, i;
|
|
|
|
int err;
|
|
|
|
|
|
|
|
start = pos / sizeof(u64);
|
|
|
|
num_regs = count / sizeof(u64);
|
|
|
|
|
|
|
|
if (start + num_regs > ELF_NGREG)
|
|
|
|
return -EIO;
|
2012-08-02 19:44:11 +07:00
|
|
|
|
2014-07-23 20:40:09 +07:00
|
|
|
err = user_regset_copyin(&pos, &count, &kbuf, &ubuf, uregs, 0,
|
|
|
|
sizeof(uregs));
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
|
|
|
for (i = start; i < num_regs; i++) {
|
|
|
|
switch (i) {
|
|
|
|
case MIPS64_EF_R1 ... MIPS64_EF_R25:
|
|
|
|
/* k0/k1 are ignored. */
|
|
|
|
case MIPS64_EF_R28 ... MIPS64_EF_R31:
|
|
|
|
regs->regs[i - MIPS64_EF_R0] = uregs[i];
|
|
|
|
break;
|
|
|
|
case MIPS64_EF_LO:
|
|
|
|
regs->lo = uregs[i];
|
|
|
|
break;
|
|
|
|
case MIPS64_EF_HI:
|
|
|
|
regs->hi = uregs[i];
|
|
|
|
break;
|
|
|
|
case MIPS64_EF_CP0_EPC:
|
|
|
|
regs->cp0_epc = uregs[i];
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2012-08-02 19:44:11 +07:00
|
|
|
|
2017-08-12 03:56:52 +07:00
|
|
|
/* System call number may have been changed */
|
|
|
|
mips_syscall_update_nr(target, regs);
|
|
|
|
|
2012-08-02 19:44:11 +07:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2014-07-23 20:40:09 +07:00
|
|
|
#endif /* CONFIG_64BIT */
|
|
|
|
|
2018-11-08 06:14:07 +07:00
|
|
|
|
|
|
|
#ifdef CONFIG_MIPS_FP_SUPPORT
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Poke at FCSR according to its mask. Set the Cause bits even
|
|
|
|
* if a corresponding Enable bit is set. This will be noticed at
|
|
|
|
* the time the thread is switched to and SIGFPE thrown accordingly.
|
|
|
|
*/
|
|
|
|
static void ptrace_setfcr31(struct task_struct *child, u32 value)
|
|
|
|
{
|
|
|
|
u32 fcr31;
|
|
|
|
u32 mask;
|
|
|
|
|
|
|
|
fcr31 = child->thread.fpu.fcr31;
|
|
|
|
mask = boot_cpu_data.fpu_msk31;
|
|
|
|
child->thread.fpu.fcr31 = (value & ~mask) | (fcr31 & mask);
|
|
|
|
}
|
|
|
|
|
|
|
|
int ptrace_getfpregs(struct task_struct *child, __u32 __user *data)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
Remove 'type' argument from access_ok() function
Nobody has actually used the type (VERIFY_READ vs VERIFY_WRITE) argument
of the user address range verification function since we got rid of the
old racy i386-only code to walk page tables by hand.
It existed because the original 80386 would not honor the write protect
bit when in kernel mode, so you had to do COW by hand before doing any
user access. But we haven't supported that in a long time, and these
days the 'type' argument is a purely historical artifact.
A discussion about extending 'user_access_begin()' to do the range
checking resulted this patch, because there is no way we're going to
move the old VERIFY_xyz interface to that model. And it's best done at
the end of the merge window when I've done most of my merges, so let's
just get this done once and for all.
This patch was mostly done with a sed-script, with manual fix-ups for
the cases that weren't of the trivial 'access_ok(VERIFY_xyz' form.
There were a couple of notable cases:
- csky still had the old "verify_area()" name as an alias.
- the iter_iov code had magical hardcoded knowledge of the actual
values of VERIFY_{READ,WRITE} (not that they mattered, since nothing
really used it)
- microblaze used the type argument for a debug printout
but other than those oddities this should be a total no-op patch.
I tried to fix up all architectures, did fairly extensive grepping for
access_ok() uses, and the changes are trivial, but I may have missed
something. Any missed conversion should be trivially fixable, though.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2019-01-04 09:57:57 +07:00
|
|
|
if (!access_ok(data, 33 * 8))
|
2018-11-08 06:14:07 +07:00
|
|
|
return -EIO;
|
|
|
|
|
|
|
|
if (tsk_used_math(child)) {
|
|
|
|
union fpureg *fregs = get_fpu_regs(child);
|
|
|
|
for (i = 0; i < 32; i++)
|
|
|
|
__put_user(get_fpr64(&fregs[i], 0),
|
|
|
|
i + (__u64 __user *)data);
|
|
|
|
} else {
|
|
|
|
for (i = 0; i < 32; i++)
|
|
|
|
__put_user((__u64) -1, i + (__u64 __user *) data);
|
|
|
|
}
|
|
|
|
|
|
|
|
__put_user(child->thread.fpu.fcr31, data + 64);
|
|
|
|
__put_user(boot_cpu_data.fpu_id, data + 65);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
int ptrace_setfpregs(struct task_struct *child, __u32 __user *data)
|
|
|
|
{
|
|
|
|
union fpureg *fregs;
|
|
|
|
u64 fpr_val;
|
|
|
|
u32 value;
|
|
|
|
int i;
|
|
|
|
|
Remove 'type' argument from access_ok() function
Nobody has actually used the type (VERIFY_READ vs VERIFY_WRITE) argument
of the user address range verification function since we got rid of the
old racy i386-only code to walk page tables by hand.
It existed because the original 80386 would not honor the write protect
bit when in kernel mode, so you had to do COW by hand before doing any
user access. But we haven't supported that in a long time, and these
days the 'type' argument is a purely historical artifact.
A discussion about extending 'user_access_begin()' to do the range
checking resulted this patch, because there is no way we're going to
move the old VERIFY_xyz interface to that model. And it's best done at
the end of the merge window when I've done most of my merges, so let's
just get this done once and for all.
This patch was mostly done with a sed-script, with manual fix-ups for
the cases that weren't of the trivial 'access_ok(VERIFY_xyz' form.
There were a couple of notable cases:
- csky still had the old "verify_area()" name as an alias.
- the iter_iov code had magical hardcoded knowledge of the actual
values of VERIFY_{READ,WRITE} (not that they mattered, since nothing
really used it)
- microblaze used the type argument for a debug printout
but other than those oddities this should be a total no-op patch.
I tried to fix up all architectures, did fairly extensive grepping for
access_ok() uses, and the changes are trivial, but I may have missed
something. Any missed conversion should be trivially fixable, though.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2019-01-04 09:57:57 +07:00
|
|
|
if (!access_ok(data, 33 * 8))
|
2018-11-08 06:14:07 +07:00
|
|
|
return -EIO;
|
|
|
|
|
|
|
|
init_fp_ctx(child);
|
|
|
|
fregs = get_fpu_regs(child);
|
|
|
|
|
|
|
|
for (i = 0; i < 32; i++) {
|
|
|
|
__get_user(fpr_val, i + (__u64 __user *)data);
|
|
|
|
set_fpr64(&fregs[i], 0, fpr_val);
|
|
|
|
}
|
|
|
|
|
|
|
|
__get_user(value, data + 64);
|
|
|
|
ptrace_setfcr31(child, value);
|
|
|
|
|
|
|
|
/* FIR may not be written. */
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-12-12 05:51:35 +07:00
|
|
|
/*
|
|
|
|
* Copy the floating-point context to the supplied NT_PRFPREG buffer,
|
|
|
|
* !CONFIG_CPU_HAS_MSA variant. FP context's general register slots
|
MIPS: Fix an FCSR access API regression with NT_PRFPREG and MSA
Fix a commit 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for
FP regset") public API regression, then activated by commit 1db1af84d6df
("MIPS: Basic MSA context switching support"), that caused the FCSR
register not to be read or written for CONFIG_CPU_HAS_MSA kernel
configurations (regardless of actual presence or absence of the MSA
feature in a given processor) with ptrace(2) PTRACE_GETREGSET and
PTRACE_SETREGSET requests nor recorded in core dumps.
This is because with !CONFIG_CPU_HAS_MSA configurations the whole of
`elf_fpregset_t' array is bulk-copied as it is, which includes the FCSR
in one half of the last, 33rd slot, whereas with CONFIG_CPU_HAS_MSA
configurations array elements are copied individually, and then only the
leading 32 FGR slots while the remaining slot is ignored.
Correct the code then such that only FGR slots are copied in the
respective !MSA and MSA helpers an then the FCSR slot is handled
separately in common code. Use `ptrace_setfcr31' to update the FCSR
too, so that the read-only mask is respected.
Retrieving a correct value of FCSR is important in debugging not only
for the human to be able to get the right interpretation of the
situation, but for correct operation of GDB as well. This is because
the condition code bits in FSCR are used by GDB to determine the
location to place a breakpoint at when single-stepping through an FPU
branch instruction. If such a breakpoint is placed incorrectly (i.e.
with the condition reversed), then it will be missed, likely causing the
debuggee to run away from the control of GDB and consequently breaking
the process of investigation.
Fortunately GDB continues using the older PTRACE_GETFPREGS ptrace(2)
request which is unaffected, so the regression only really hits with
post-mortem debug sessions using a core dump file, in which case
execution, and consequently single-stepping through branches is not
possible. Of course core files created by buggy kernels out there will
have the value of FCSR recorded clobbered, but such core files cannot be
corrected and the person using them simply will have to be aware that
the value of FCSR retrieved is not reliable.
Which also means we can likely get away without defining a replacement
API which would ensure a correct value of FSCR to be retrieved, or none
at all.
This is based on previous work by Alex Smith, extensively rewritten.
Signed-off-by: Alex Smith <alex@alex-smith.me.uk>
Signed-off-by: James Hogan <james.hogan@mips.com>
Signed-off-by: Maciej W. Rozycki <macro@mips.com>
Fixes: 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for FP regset")
Cc: Paul Burton <Paul.Burton@mips.com>
Cc: Dave Martin <Dave.Martin@arm.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org # v3.15+
Patchwork: https://patchwork.linux-mips.org/patch/17928/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
2017-12-12 05:54:33 +07:00
|
|
|
* correspond 1:1 to buffer slots. Only general registers are copied.
|
2017-12-12 05:51:35 +07:00
|
|
|
*/
|
|
|
|
static int fpr_get_fpa(struct task_struct *target,
|
|
|
|
unsigned int *pos, unsigned int *count,
|
|
|
|
void **kbuf, void __user **ubuf)
|
2012-08-02 19:44:11 +07:00
|
|
|
{
|
2017-12-12 05:51:35 +07:00
|
|
|
return user_regset_copyout(pos, count, kbuf, ubuf,
|
|
|
|
&target->thread.fpu,
|
MIPS: Fix an FCSR access API regression with NT_PRFPREG and MSA
Fix a commit 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for
FP regset") public API regression, then activated by commit 1db1af84d6df
("MIPS: Basic MSA context switching support"), that caused the FCSR
register not to be read or written for CONFIG_CPU_HAS_MSA kernel
configurations (regardless of actual presence or absence of the MSA
feature in a given processor) with ptrace(2) PTRACE_GETREGSET and
PTRACE_SETREGSET requests nor recorded in core dumps.
This is because with !CONFIG_CPU_HAS_MSA configurations the whole of
`elf_fpregset_t' array is bulk-copied as it is, which includes the FCSR
in one half of the last, 33rd slot, whereas with CONFIG_CPU_HAS_MSA
configurations array elements are copied individually, and then only the
leading 32 FGR slots while the remaining slot is ignored.
Correct the code then such that only FGR slots are copied in the
respective !MSA and MSA helpers an then the FCSR slot is handled
separately in common code. Use `ptrace_setfcr31' to update the FCSR
too, so that the read-only mask is respected.
Retrieving a correct value of FCSR is important in debugging not only
for the human to be able to get the right interpretation of the
situation, but for correct operation of GDB as well. This is because
the condition code bits in FSCR are used by GDB to determine the
location to place a breakpoint at when single-stepping through an FPU
branch instruction. If such a breakpoint is placed incorrectly (i.e.
with the condition reversed), then it will be missed, likely causing the
debuggee to run away from the control of GDB and consequently breaking
the process of investigation.
Fortunately GDB continues using the older PTRACE_GETFPREGS ptrace(2)
request which is unaffected, so the regression only really hits with
post-mortem debug sessions using a core dump file, in which case
execution, and consequently single-stepping through branches is not
possible. Of course core files created by buggy kernels out there will
have the value of FCSR recorded clobbered, but such core files cannot be
corrected and the person using them simply will have to be aware that
the value of FCSR retrieved is not reliable.
Which also means we can likely get away without defining a replacement
API which would ensure a correct value of FSCR to be retrieved, or none
at all.
This is based on previous work by Alex Smith, extensively rewritten.
Signed-off-by: Alex Smith <alex@alex-smith.me.uk>
Signed-off-by: James Hogan <james.hogan@mips.com>
Signed-off-by: Maciej W. Rozycki <macro@mips.com>
Fixes: 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for FP regset")
Cc: Paul Burton <Paul.Burton@mips.com>
Cc: Dave Martin <Dave.Martin@arm.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org # v3.15+
Patchwork: https://patchwork.linux-mips.org/patch/17928/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
2017-12-12 05:54:33 +07:00
|
|
|
0, NUM_FPU_REGS * sizeof(elf_fpreg_t));
|
2017-12-12 05:51:35 +07:00
|
|
|
}
|
2014-01-27 22:23:07 +07:00
|
|
|
|
2017-12-12 05:51:35 +07:00
|
|
|
/*
|
|
|
|
* Copy the floating-point context to the supplied NT_PRFPREG buffer,
|
|
|
|
* CONFIG_CPU_HAS_MSA variant. Only lower 64 bits of FP context's
|
MIPS: Fix an FCSR access API regression with NT_PRFPREG and MSA
Fix a commit 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for
FP regset") public API regression, then activated by commit 1db1af84d6df
("MIPS: Basic MSA context switching support"), that caused the FCSR
register not to be read or written for CONFIG_CPU_HAS_MSA kernel
configurations (regardless of actual presence or absence of the MSA
feature in a given processor) with ptrace(2) PTRACE_GETREGSET and
PTRACE_SETREGSET requests nor recorded in core dumps.
This is because with !CONFIG_CPU_HAS_MSA configurations the whole of
`elf_fpregset_t' array is bulk-copied as it is, which includes the FCSR
in one half of the last, 33rd slot, whereas with CONFIG_CPU_HAS_MSA
configurations array elements are copied individually, and then only the
leading 32 FGR slots while the remaining slot is ignored.
Correct the code then such that only FGR slots are copied in the
respective !MSA and MSA helpers an then the FCSR slot is handled
separately in common code. Use `ptrace_setfcr31' to update the FCSR
too, so that the read-only mask is respected.
Retrieving a correct value of FCSR is important in debugging not only
for the human to be able to get the right interpretation of the
situation, but for correct operation of GDB as well. This is because
the condition code bits in FSCR are used by GDB to determine the
location to place a breakpoint at when single-stepping through an FPU
branch instruction. If such a breakpoint is placed incorrectly (i.e.
with the condition reversed), then it will be missed, likely causing the
debuggee to run away from the control of GDB and consequently breaking
the process of investigation.
Fortunately GDB continues using the older PTRACE_GETFPREGS ptrace(2)
request which is unaffected, so the regression only really hits with
post-mortem debug sessions using a core dump file, in which case
execution, and consequently single-stepping through branches is not
possible. Of course core files created by buggy kernels out there will
have the value of FCSR recorded clobbered, but such core files cannot be
corrected and the person using them simply will have to be aware that
the value of FCSR retrieved is not reliable.
Which also means we can likely get away without defining a replacement
API which would ensure a correct value of FSCR to be retrieved, or none
at all.
This is based on previous work by Alex Smith, extensively rewritten.
Signed-off-by: Alex Smith <alex@alex-smith.me.uk>
Signed-off-by: James Hogan <james.hogan@mips.com>
Signed-off-by: Maciej W. Rozycki <macro@mips.com>
Fixes: 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for FP regset")
Cc: Paul Burton <Paul.Burton@mips.com>
Cc: Dave Martin <Dave.Martin@arm.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org # v3.15+
Patchwork: https://patchwork.linux-mips.org/patch/17928/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
2017-12-12 05:54:33 +07:00
|
|
|
* general register slots are copied to buffer slots. Only general
|
|
|
|
* registers are copied.
|
2017-12-12 05:51:35 +07:00
|
|
|
*/
|
|
|
|
static int fpr_get_msa(struct task_struct *target,
|
|
|
|
unsigned int *pos, unsigned int *count,
|
|
|
|
void **kbuf, void __user **ubuf)
|
|
|
|
{
|
|
|
|
unsigned int i;
|
|
|
|
u64 fpr_val;
|
|
|
|
int err;
|
2014-01-27 22:23:07 +07:00
|
|
|
|
2017-12-12 05:55:40 +07:00
|
|
|
BUILD_BUG_ON(sizeof(fpr_val) != sizeof(elf_fpreg_t));
|
2014-01-27 22:23:07 +07:00
|
|
|
for (i = 0; i < NUM_FPU_REGS; i++) {
|
|
|
|
fpr_val = get_fpr64(&target->thread.fpu.fpr[i], 0);
|
2017-12-12 05:51:35 +07:00
|
|
|
err = user_regset_copyout(pos, count, kbuf, ubuf,
|
2014-01-27 22:23:07 +07:00
|
|
|
&fpr_val, i * sizeof(elf_fpreg_t),
|
|
|
|
(i + 1) * sizeof(elf_fpreg_t));
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
2012-08-02 19:44:11 +07:00
|
|
|
}
|
|
|
|
|
MIPS: Fix an FCSR access API regression with NT_PRFPREG and MSA
Fix a commit 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for
FP regset") public API regression, then activated by commit 1db1af84d6df
("MIPS: Basic MSA context switching support"), that caused the FCSR
register not to be read or written for CONFIG_CPU_HAS_MSA kernel
configurations (regardless of actual presence or absence of the MSA
feature in a given processor) with ptrace(2) PTRACE_GETREGSET and
PTRACE_SETREGSET requests nor recorded in core dumps.
This is because with !CONFIG_CPU_HAS_MSA configurations the whole of
`elf_fpregset_t' array is bulk-copied as it is, which includes the FCSR
in one half of the last, 33rd slot, whereas with CONFIG_CPU_HAS_MSA
configurations array elements are copied individually, and then only the
leading 32 FGR slots while the remaining slot is ignored.
Correct the code then such that only FGR slots are copied in the
respective !MSA and MSA helpers an then the FCSR slot is handled
separately in common code. Use `ptrace_setfcr31' to update the FCSR
too, so that the read-only mask is respected.
Retrieving a correct value of FCSR is important in debugging not only
for the human to be able to get the right interpretation of the
situation, but for correct operation of GDB as well. This is because
the condition code bits in FSCR are used by GDB to determine the
location to place a breakpoint at when single-stepping through an FPU
branch instruction. If such a breakpoint is placed incorrectly (i.e.
with the condition reversed), then it will be missed, likely causing the
debuggee to run away from the control of GDB and consequently breaking
the process of investigation.
Fortunately GDB continues using the older PTRACE_GETFPREGS ptrace(2)
request which is unaffected, so the regression only really hits with
post-mortem debug sessions using a core dump file, in which case
execution, and consequently single-stepping through branches is not
possible. Of course core files created by buggy kernels out there will
have the value of FCSR recorded clobbered, but such core files cannot be
corrected and the person using them simply will have to be aware that
the value of FCSR retrieved is not reliable.
Which also means we can likely get away without defining a replacement
API which would ensure a correct value of FSCR to be retrieved, or none
at all.
This is based on previous work by Alex Smith, extensively rewritten.
Signed-off-by: Alex Smith <alex@alex-smith.me.uk>
Signed-off-by: James Hogan <james.hogan@mips.com>
Signed-off-by: Maciej W. Rozycki <macro@mips.com>
Fixes: 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for FP regset")
Cc: Paul Burton <Paul.Burton@mips.com>
Cc: Dave Martin <Dave.Martin@arm.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org # v3.15+
Patchwork: https://patchwork.linux-mips.org/patch/17928/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
2017-12-12 05:54:33 +07:00
|
|
|
/*
|
|
|
|
* Copy the floating-point context to the supplied NT_PRFPREG buffer.
|
|
|
|
* Choose the appropriate helper for general registers, and then copy
|
2018-04-30 21:56:47 +07:00
|
|
|
* the FCSR and FIR registers separately.
|
MIPS: Fix an FCSR access API regression with NT_PRFPREG and MSA
Fix a commit 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for
FP regset") public API regression, then activated by commit 1db1af84d6df
("MIPS: Basic MSA context switching support"), that caused the FCSR
register not to be read or written for CONFIG_CPU_HAS_MSA kernel
configurations (regardless of actual presence or absence of the MSA
feature in a given processor) with ptrace(2) PTRACE_GETREGSET and
PTRACE_SETREGSET requests nor recorded in core dumps.
This is because with !CONFIG_CPU_HAS_MSA configurations the whole of
`elf_fpregset_t' array is bulk-copied as it is, which includes the FCSR
in one half of the last, 33rd slot, whereas with CONFIG_CPU_HAS_MSA
configurations array elements are copied individually, and then only the
leading 32 FGR slots while the remaining slot is ignored.
Correct the code then such that only FGR slots are copied in the
respective !MSA and MSA helpers an then the FCSR slot is handled
separately in common code. Use `ptrace_setfcr31' to update the FCSR
too, so that the read-only mask is respected.
Retrieving a correct value of FCSR is important in debugging not only
for the human to be able to get the right interpretation of the
situation, but for correct operation of GDB as well. This is because
the condition code bits in FSCR are used by GDB to determine the
location to place a breakpoint at when single-stepping through an FPU
branch instruction. If such a breakpoint is placed incorrectly (i.e.
with the condition reversed), then it will be missed, likely causing the
debuggee to run away from the control of GDB and consequently breaking
the process of investigation.
Fortunately GDB continues using the older PTRACE_GETFPREGS ptrace(2)
request which is unaffected, so the regression only really hits with
post-mortem debug sessions using a core dump file, in which case
execution, and consequently single-stepping through branches is not
possible. Of course core files created by buggy kernels out there will
have the value of FCSR recorded clobbered, but such core files cannot be
corrected and the person using them simply will have to be aware that
the value of FCSR retrieved is not reliable.
Which also means we can likely get away without defining a replacement
API which would ensure a correct value of FSCR to be retrieved, or none
at all.
This is based on previous work by Alex Smith, extensively rewritten.
Signed-off-by: Alex Smith <alex@alex-smith.me.uk>
Signed-off-by: James Hogan <james.hogan@mips.com>
Signed-off-by: Maciej W. Rozycki <macro@mips.com>
Fixes: 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for FP regset")
Cc: Paul Burton <Paul.Burton@mips.com>
Cc: Dave Martin <Dave.Martin@arm.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org # v3.15+
Patchwork: https://patchwork.linux-mips.org/patch/17928/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
2017-12-12 05:54:33 +07:00
|
|
|
*/
|
2017-12-12 05:51:35 +07:00
|
|
|
static int fpr_get(struct task_struct *target,
|
2012-08-02 19:44:11 +07:00
|
|
|
const struct user_regset *regset,
|
|
|
|
unsigned int pos, unsigned int count,
|
2017-12-12 05:51:35 +07:00
|
|
|
void *kbuf, void __user *ubuf)
|
2012-08-02 19:44:11 +07:00
|
|
|
{
|
MIPS: Fix an FCSR access API regression with NT_PRFPREG and MSA
Fix a commit 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for
FP regset") public API regression, then activated by commit 1db1af84d6df
("MIPS: Basic MSA context switching support"), that caused the FCSR
register not to be read or written for CONFIG_CPU_HAS_MSA kernel
configurations (regardless of actual presence or absence of the MSA
feature in a given processor) with ptrace(2) PTRACE_GETREGSET and
PTRACE_SETREGSET requests nor recorded in core dumps.
This is because with !CONFIG_CPU_HAS_MSA configurations the whole of
`elf_fpregset_t' array is bulk-copied as it is, which includes the FCSR
in one half of the last, 33rd slot, whereas with CONFIG_CPU_HAS_MSA
configurations array elements are copied individually, and then only the
leading 32 FGR slots while the remaining slot is ignored.
Correct the code then such that only FGR slots are copied in the
respective !MSA and MSA helpers an then the FCSR slot is handled
separately in common code. Use `ptrace_setfcr31' to update the FCSR
too, so that the read-only mask is respected.
Retrieving a correct value of FCSR is important in debugging not only
for the human to be able to get the right interpretation of the
situation, but for correct operation of GDB as well. This is because
the condition code bits in FSCR are used by GDB to determine the
location to place a breakpoint at when single-stepping through an FPU
branch instruction. If such a breakpoint is placed incorrectly (i.e.
with the condition reversed), then it will be missed, likely causing the
debuggee to run away from the control of GDB and consequently breaking
the process of investigation.
Fortunately GDB continues using the older PTRACE_GETFPREGS ptrace(2)
request which is unaffected, so the regression only really hits with
post-mortem debug sessions using a core dump file, in which case
execution, and consequently single-stepping through branches is not
possible. Of course core files created by buggy kernels out there will
have the value of FCSR recorded clobbered, but such core files cannot be
corrected and the person using them simply will have to be aware that
the value of FCSR retrieved is not reliable.
Which also means we can likely get away without defining a replacement
API which would ensure a correct value of FSCR to be retrieved, or none
at all.
This is based on previous work by Alex Smith, extensively rewritten.
Signed-off-by: Alex Smith <alex@alex-smith.me.uk>
Signed-off-by: James Hogan <james.hogan@mips.com>
Signed-off-by: Maciej W. Rozycki <macro@mips.com>
Fixes: 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for FP regset")
Cc: Paul Burton <Paul.Burton@mips.com>
Cc: Dave Martin <Dave.Martin@arm.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org # v3.15+
Patchwork: https://patchwork.linux-mips.org/patch/17928/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
2017-12-12 05:54:33 +07:00
|
|
|
const int fcr31_pos = NUM_FPU_REGS * sizeof(elf_fpreg_t);
|
2018-04-30 21:56:47 +07:00
|
|
|
const int fir_pos = fcr31_pos + sizeof(u32);
|
2014-01-27 22:23:07 +07:00
|
|
|
int err;
|
|
|
|
|
2017-12-12 05:51:35 +07:00
|
|
|
if (sizeof(target->thread.fpu.fpr[0]) == sizeof(elf_fpreg_t))
|
|
|
|
err = fpr_get_fpa(target, &pos, &count, &kbuf, &ubuf);
|
|
|
|
else
|
|
|
|
err = fpr_get_msa(target, &pos, &count, &kbuf, &ubuf);
|
MIPS: Fix an FCSR access API regression with NT_PRFPREG and MSA
Fix a commit 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for
FP regset") public API regression, then activated by commit 1db1af84d6df
("MIPS: Basic MSA context switching support"), that caused the FCSR
register not to be read or written for CONFIG_CPU_HAS_MSA kernel
configurations (regardless of actual presence or absence of the MSA
feature in a given processor) with ptrace(2) PTRACE_GETREGSET and
PTRACE_SETREGSET requests nor recorded in core dumps.
This is because with !CONFIG_CPU_HAS_MSA configurations the whole of
`elf_fpregset_t' array is bulk-copied as it is, which includes the FCSR
in one half of the last, 33rd slot, whereas with CONFIG_CPU_HAS_MSA
configurations array elements are copied individually, and then only the
leading 32 FGR slots while the remaining slot is ignored.
Correct the code then such that only FGR slots are copied in the
respective !MSA and MSA helpers an then the FCSR slot is handled
separately in common code. Use `ptrace_setfcr31' to update the FCSR
too, so that the read-only mask is respected.
Retrieving a correct value of FCSR is important in debugging not only
for the human to be able to get the right interpretation of the
situation, but for correct operation of GDB as well. This is because
the condition code bits in FSCR are used by GDB to determine the
location to place a breakpoint at when single-stepping through an FPU
branch instruction. If such a breakpoint is placed incorrectly (i.e.
with the condition reversed), then it will be missed, likely causing the
debuggee to run away from the control of GDB and consequently breaking
the process of investigation.
Fortunately GDB continues using the older PTRACE_GETFPREGS ptrace(2)
request which is unaffected, so the regression only really hits with
post-mortem debug sessions using a core dump file, in which case
execution, and consequently single-stepping through branches is not
possible. Of course core files created by buggy kernels out there will
have the value of FCSR recorded clobbered, but such core files cannot be
corrected and the person using them simply will have to be aware that
the value of FCSR retrieved is not reliable.
Which also means we can likely get away without defining a replacement
API which would ensure a correct value of FSCR to be retrieved, or none
at all.
This is based on previous work by Alex Smith, extensively rewritten.
Signed-off-by: Alex Smith <alex@alex-smith.me.uk>
Signed-off-by: James Hogan <james.hogan@mips.com>
Signed-off-by: Maciej W. Rozycki <macro@mips.com>
Fixes: 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for FP regset")
Cc: Paul Burton <Paul.Burton@mips.com>
Cc: Dave Martin <Dave.Martin@arm.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org # v3.15+
Patchwork: https://patchwork.linux-mips.org/patch/17928/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
2017-12-12 05:54:33 +07:00
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
|
|
|
err = user_regset_copyout(&pos, &count, &kbuf, &ubuf,
|
|
|
|
&target->thread.fpu.fcr31,
|
|
|
|
fcr31_pos, fcr31_pos + sizeof(u32));
|
2018-04-30 21:56:47 +07:00
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
|
|
|
err = user_regset_copyout(&pos, &count, &kbuf, &ubuf,
|
|
|
|
&boot_cpu_data.fpu_id,
|
|
|
|
fir_pos, fir_pos + sizeof(u32));
|
2017-12-12 05:51:35 +07:00
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|
2015-01-30 19:09:36 +07:00
|
|
|
|
2017-12-12 05:51:35 +07:00
|
|
|
/*
|
|
|
|
* Copy the supplied NT_PRFPREG buffer to the floating-point context,
|
|
|
|
* !CONFIG_CPU_HAS_MSA variant. Buffer slots correspond 1:1 to FP
|
MIPS: Fix an FCSR access API regression with NT_PRFPREG and MSA
Fix a commit 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for
FP regset") public API regression, then activated by commit 1db1af84d6df
("MIPS: Basic MSA context switching support"), that caused the FCSR
register not to be read or written for CONFIG_CPU_HAS_MSA kernel
configurations (regardless of actual presence or absence of the MSA
feature in a given processor) with ptrace(2) PTRACE_GETREGSET and
PTRACE_SETREGSET requests nor recorded in core dumps.
This is because with !CONFIG_CPU_HAS_MSA configurations the whole of
`elf_fpregset_t' array is bulk-copied as it is, which includes the FCSR
in one half of the last, 33rd slot, whereas with CONFIG_CPU_HAS_MSA
configurations array elements are copied individually, and then only the
leading 32 FGR slots while the remaining slot is ignored.
Correct the code then such that only FGR slots are copied in the
respective !MSA and MSA helpers an then the FCSR slot is handled
separately in common code. Use `ptrace_setfcr31' to update the FCSR
too, so that the read-only mask is respected.
Retrieving a correct value of FCSR is important in debugging not only
for the human to be able to get the right interpretation of the
situation, but for correct operation of GDB as well. This is because
the condition code bits in FSCR are used by GDB to determine the
location to place a breakpoint at when single-stepping through an FPU
branch instruction. If such a breakpoint is placed incorrectly (i.e.
with the condition reversed), then it will be missed, likely causing the
debuggee to run away from the control of GDB and consequently breaking
the process of investigation.
Fortunately GDB continues using the older PTRACE_GETFPREGS ptrace(2)
request which is unaffected, so the regression only really hits with
post-mortem debug sessions using a core dump file, in which case
execution, and consequently single-stepping through branches is not
possible. Of course core files created by buggy kernels out there will
have the value of FCSR recorded clobbered, but such core files cannot be
corrected and the person using them simply will have to be aware that
the value of FCSR retrieved is not reliable.
Which also means we can likely get away without defining a replacement
API which would ensure a correct value of FSCR to be retrieved, or none
at all.
This is based on previous work by Alex Smith, extensively rewritten.
Signed-off-by: Alex Smith <alex@alex-smith.me.uk>
Signed-off-by: James Hogan <james.hogan@mips.com>
Signed-off-by: Maciej W. Rozycki <macro@mips.com>
Fixes: 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for FP regset")
Cc: Paul Burton <Paul.Burton@mips.com>
Cc: Dave Martin <Dave.Martin@arm.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org # v3.15+
Patchwork: https://patchwork.linux-mips.org/patch/17928/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
2017-12-12 05:54:33 +07:00
|
|
|
* context's general register slots. Only general registers are copied.
|
2017-12-12 05:51:35 +07:00
|
|
|
*/
|
|
|
|
static int fpr_set_fpa(struct task_struct *target,
|
|
|
|
unsigned int *pos, unsigned int *count,
|
|
|
|
const void **kbuf, const void __user **ubuf)
|
|
|
|
{
|
|
|
|
return user_regset_copyin(pos, count, kbuf, ubuf,
|
|
|
|
&target->thread.fpu,
|
MIPS: Fix an FCSR access API regression with NT_PRFPREG and MSA
Fix a commit 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for
FP regset") public API regression, then activated by commit 1db1af84d6df
("MIPS: Basic MSA context switching support"), that caused the FCSR
register not to be read or written for CONFIG_CPU_HAS_MSA kernel
configurations (regardless of actual presence or absence of the MSA
feature in a given processor) with ptrace(2) PTRACE_GETREGSET and
PTRACE_SETREGSET requests nor recorded in core dumps.
This is because with !CONFIG_CPU_HAS_MSA configurations the whole of
`elf_fpregset_t' array is bulk-copied as it is, which includes the FCSR
in one half of the last, 33rd slot, whereas with CONFIG_CPU_HAS_MSA
configurations array elements are copied individually, and then only the
leading 32 FGR slots while the remaining slot is ignored.
Correct the code then such that only FGR slots are copied in the
respective !MSA and MSA helpers an then the FCSR slot is handled
separately in common code. Use `ptrace_setfcr31' to update the FCSR
too, so that the read-only mask is respected.
Retrieving a correct value of FCSR is important in debugging not only
for the human to be able to get the right interpretation of the
situation, but for correct operation of GDB as well. This is because
the condition code bits in FSCR are used by GDB to determine the
location to place a breakpoint at when single-stepping through an FPU
branch instruction. If such a breakpoint is placed incorrectly (i.e.
with the condition reversed), then it will be missed, likely causing the
debuggee to run away from the control of GDB and consequently breaking
the process of investigation.
Fortunately GDB continues using the older PTRACE_GETFPREGS ptrace(2)
request which is unaffected, so the regression only really hits with
post-mortem debug sessions using a core dump file, in which case
execution, and consequently single-stepping through branches is not
possible. Of course core files created by buggy kernels out there will
have the value of FCSR recorded clobbered, but such core files cannot be
corrected and the person using them simply will have to be aware that
the value of FCSR retrieved is not reliable.
Which also means we can likely get away without defining a replacement
API which would ensure a correct value of FSCR to be retrieved, or none
at all.
This is based on previous work by Alex Smith, extensively rewritten.
Signed-off-by: Alex Smith <alex@alex-smith.me.uk>
Signed-off-by: James Hogan <james.hogan@mips.com>
Signed-off-by: Maciej W. Rozycki <macro@mips.com>
Fixes: 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for FP regset")
Cc: Paul Burton <Paul.Burton@mips.com>
Cc: Dave Martin <Dave.Martin@arm.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org # v3.15+
Patchwork: https://patchwork.linux-mips.org/patch/17928/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
2017-12-12 05:54:33 +07:00
|
|
|
0, NUM_FPU_REGS * sizeof(elf_fpreg_t));
|
2017-12-12 05:51:35 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Copy the supplied NT_PRFPREG buffer to the floating-point context,
|
|
|
|
* CONFIG_CPU_HAS_MSA variant. Buffer slots are copied to lower 64
|
MIPS: Fix an FCSR access API regression with NT_PRFPREG and MSA
Fix a commit 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for
FP regset") public API regression, then activated by commit 1db1af84d6df
("MIPS: Basic MSA context switching support"), that caused the FCSR
register not to be read or written for CONFIG_CPU_HAS_MSA kernel
configurations (regardless of actual presence or absence of the MSA
feature in a given processor) with ptrace(2) PTRACE_GETREGSET and
PTRACE_SETREGSET requests nor recorded in core dumps.
This is because with !CONFIG_CPU_HAS_MSA configurations the whole of
`elf_fpregset_t' array is bulk-copied as it is, which includes the FCSR
in one half of the last, 33rd slot, whereas with CONFIG_CPU_HAS_MSA
configurations array elements are copied individually, and then only the
leading 32 FGR slots while the remaining slot is ignored.
Correct the code then such that only FGR slots are copied in the
respective !MSA and MSA helpers an then the FCSR slot is handled
separately in common code. Use `ptrace_setfcr31' to update the FCSR
too, so that the read-only mask is respected.
Retrieving a correct value of FCSR is important in debugging not only
for the human to be able to get the right interpretation of the
situation, but for correct operation of GDB as well. This is because
the condition code bits in FSCR are used by GDB to determine the
location to place a breakpoint at when single-stepping through an FPU
branch instruction. If such a breakpoint is placed incorrectly (i.e.
with the condition reversed), then it will be missed, likely causing the
debuggee to run away from the control of GDB and consequently breaking
the process of investigation.
Fortunately GDB continues using the older PTRACE_GETFPREGS ptrace(2)
request which is unaffected, so the regression only really hits with
post-mortem debug sessions using a core dump file, in which case
execution, and consequently single-stepping through branches is not
possible. Of course core files created by buggy kernels out there will
have the value of FCSR recorded clobbered, but such core files cannot be
corrected and the person using them simply will have to be aware that
the value of FCSR retrieved is not reliable.
Which also means we can likely get away without defining a replacement
API which would ensure a correct value of FSCR to be retrieved, or none
at all.
This is based on previous work by Alex Smith, extensively rewritten.
Signed-off-by: Alex Smith <alex@alex-smith.me.uk>
Signed-off-by: James Hogan <james.hogan@mips.com>
Signed-off-by: Maciej W. Rozycki <macro@mips.com>
Fixes: 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for FP regset")
Cc: Paul Burton <Paul.Burton@mips.com>
Cc: Dave Martin <Dave.Martin@arm.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org # v3.15+
Patchwork: https://patchwork.linux-mips.org/patch/17928/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
2017-12-12 05:54:33 +07:00
|
|
|
* bits only of FP context's general register slots. Only general
|
|
|
|
* registers are copied.
|
2017-12-12 05:51:35 +07:00
|
|
|
*/
|
|
|
|
static int fpr_set_msa(struct task_struct *target,
|
|
|
|
unsigned int *pos, unsigned int *count,
|
|
|
|
const void **kbuf, const void __user **ubuf)
|
|
|
|
{
|
|
|
|
unsigned int i;
|
|
|
|
u64 fpr_val;
|
|
|
|
int err;
|
2014-01-27 22:23:07 +07:00
|
|
|
|
2017-03-27 21:10:58 +07:00
|
|
|
BUILD_BUG_ON(sizeof(fpr_val) != sizeof(elf_fpreg_t));
|
2017-12-12 05:53:14 +07:00
|
|
|
for (i = 0; i < NUM_FPU_REGS && *count > 0; i++) {
|
2017-12-12 05:51:35 +07:00
|
|
|
err = user_regset_copyin(pos, count, kbuf, ubuf,
|
2014-01-27 22:23:07 +07:00
|
|
|
&fpr_val, i * sizeof(elf_fpreg_t),
|
|
|
|
(i + 1) * sizeof(elf_fpreg_t));
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
set_fpr64(&target->thread.fpu.fpr[i], 0, fpr_val);
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
2012-08-02 19:44:11 +07:00
|
|
|
}
|
|
|
|
|
2017-12-12 05:52:15 +07:00
|
|
|
/*
|
|
|
|
* Copy the supplied NT_PRFPREG buffer to the floating-point context.
|
MIPS: Fix an FCSR access API regression with NT_PRFPREG and MSA
Fix a commit 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for
FP regset") public API regression, then activated by commit 1db1af84d6df
("MIPS: Basic MSA context switching support"), that caused the FCSR
register not to be read or written for CONFIG_CPU_HAS_MSA kernel
configurations (regardless of actual presence or absence of the MSA
feature in a given processor) with ptrace(2) PTRACE_GETREGSET and
PTRACE_SETREGSET requests nor recorded in core dumps.
This is because with !CONFIG_CPU_HAS_MSA configurations the whole of
`elf_fpregset_t' array is bulk-copied as it is, which includes the FCSR
in one half of the last, 33rd slot, whereas with CONFIG_CPU_HAS_MSA
configurations array elements are copied individually, and then only the
leading 32 FGR slots while the remaining slot is ignored.
Correct the code then such that only FGR slots are copied in the
respective !MSA and MSA helpers an then the FCSR slot is handled
separately in common code. Use `ptrace_setfcr31' to update the FCSR
too, so that the read-only mask is respected.
Retrieving a correct value of FCSR is important in debugging not only
for the human to be able to get the right interpretation of the
situation, but for correct operation of GDB as well. This is because
the condition code bits in FSCR are used by GDB to determine the
location to place a breakpoint at when single-stepping through an FPU
branch instruction. If such a breakpoint is placed incorrectly (i.e.
with the condition reversed), then it will be missed, likely causing the
debuggee to run away from the control of GDB and consequently breaking
the process of investigation.
Fortunately GDB continues using the older PTRACE_GETFPREGS ptrace(2)
request which is unaffected, so the regression only really hits with
post-mortem debug sessions using a core dump file, in which case
execution, and consequently single-stepping through branches is not
possible. Of course core files created by buggy kernels out there will
have the value of FCSR recorded clobbered, but such core files cannot be
corrected and the person using them simply will have to be aware that
the value of FCSR retrieved is not reliable.
Which also means we can likely get away without defining a replacement
API which would ensure a correct value of FSCR to be retrieved, or none
at all.
This is based on previous work by Alex Smith, extensively rewritten.
Signed-off-by: Alex Smith <alex@alex-smith.me.uk>
Signed-off-by: James Hogan <james.hogan@mips.com>
Signed-off-by: Maciej W. Rozycki <macro@mips.com>
Fixes: 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for FP regset")
Cc: Paul Burton <Paul.Burton@mips.com>
Cc: Dave Martin <Dave.Martin@arm.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org # v3.15+
Patchwork: https://patchwork.linux-mips.org/patch/17928/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
2017-12-12 05:54:33 +07:00
|
|
|
* Choose the appropriate helper for general registers, and then copy
|
2018-04-30 21:56:47 +07:00
|
|
|
* the FCSR register separately. Ignore the incoming FIR register
|
|
|
|
* contents though, as the register is read-only.
|
2017-12-12 05:52:15 +07:00
|
|
|
*
|
|
|
|
* We optimize for the case where `count % sizeof(elf_fpreg_t) == 0',
|
|
|
|
* which is supposed to have been guaranteed by the kernel before
|
|
|
|
* calling us, e.g. in `ptrace_regset'. We enforce that requirement,
|
|
|
|
* so that we can safely avoid preinitializing temporaries for
|
|
|
|
* partial register writes.
|
|
|
|
*/
|
2017-12-12 05:51:35 +07:00
|
|
|
static int fpr_set(struct task_struct *target,
|
|
|
|
const struct user_regset *regset,
|
|
|
|
unsigned int pos, unsigned int count,
|
|
|
|
const void *kbuf, const void __user *ubuf)
|
|
|
|
{
|
MIPS: Fix an FCSR access API regression with NT_PRFPREG and MSA
Fix a commit 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for
FP regset") public API regression, then activated by commit 1db1af84d6df
("MIPS: Basic MSA context switching support"), that caused the FCSR
register not to be read or written for CONFIG_CPU_HAS_MSA kernel
configurations (regardless of actual presence or absence of the MSA
feature in a given processor) with ptrace(2) PTRACE_GETREGSET and
PTRACE_SETREGSET requests nor recorded in core dumps.
This is because with !CONFIG_CPU_HAS_MSA configurations the whole of
`elf_fpregset_t' array is bulk-copied as it is, which includes the FCSR
in one half of the last, 33rd slot, whereas with CONFIG_CPU_HAS_MSA
configurations array elements are copied individually, and then only the
leading 32 FGR slots while the remaining slot is ignored.
Correct the code then such that only FGR slots are copied in the
respective !MSA and MSA helpers an then the FCSR slot is handled
separately in common code. Use `ptrace_setfcr31' to update the FCSR
too, so that the read-only mask is respected.
Retrieving a correct value of FCSR is important in debugging not only
for the human to be able to get the right interpretation of the
situation, but for correct operation of GDB as well. This is because
the condition code bits in FSCR are used by GDB to determine the
location to place a breakpoint at when single-stepping through an FPU
branch instruction. If such a breakpoint is placed incorrectly (i.e.
with the condition reversed), then it will be missed, likely causing the
debuggee to run away from the control of GDB and consequently breaking
the process of investigation.
Fortunately GDB continues using the older PTRACE_GETFPREGS ptrace(2)
request which is unaffected, so the regression only really hits with
post-mortem debug sessions using a core dump file, in which case
execution, and consequently single-stepping through branches is not
possible. Of course core files created by buggy kernels out there will
have the value of FCSR recorded clobbered, but such core files cannot be
corrected and the person using them simply will have to be aware that
the value of FCSR retrieved is not reliable.
Which also means we can likely get away without defining a replacement
API which would ensure a correct value of FSCR to be retrieved, or none
at all.
This is based on previous work by Alex Smith, extensively rewritten.
Signed-off-by: Alex Smith <alex@alex-smith.me.uk>
Signed-off-by: James Hogan <james.hogan@mips.com>
Signed-off-by: Maciej W. Rozycki <macro@mips.com>
Fixes: 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for FP regset")
Cc: Paul Burton <Paul.Burton@mips.com>
Cc: Dave Martin <Dave.Martin@arm.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org # v3.15+
Patchwork: https://patchwork.linux-mips.org/patch/17928/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
2017-12-12 05:54:33 +07:00
|
|
|
const int fcr31_pos = NUM_FPU_REGS * sizeof(elf_fpreg_t);
|
2018-04-30 21:56:47 +07:00
|
|
|
const int fir_pos = fcr31_pos + sizeof(u32);
|
MIPS: Fix an FCSR access API regression with NT_PRFPREG and MSA
Fix a commit 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for
FP regset") public API regression, then activated by commit 1db1af84d6df
("MIPS: Basic MSA context switching support"), that caused the FCSR
register not to be read or written for CONFIG_CPU_HAS_MSA kernel
configurations (regardless of actual presence or absence of the MSA
feature in a given processor) with ptrace(2) PTRACE_GETREGSET and
PTRACE_SETREGSET requests nor recorded in core dumps.
This is because with !CONFIG_CPU_HAS_MSA configurations the whole of
`elf_fpregset_t' array is bulk-copied as it is, which includes the FCSR
in one half of the last, 33rd slot, whereas with CONFIG_CPU_HAS_MSA
configurations array elements are copied individually, and then only the
leading 32 FGR slots while the remaining slot is ignored.
Correct the code then such that only FGR slots are copied in the
respective !MSA and MSA helpers an then the FCSR slot is handled
separately in common code. Use `ptrace_setfcr31' to update the FCSR
too, so that the read-only mask is respected.
Retrieving a correct value of FCSR is important in debugging not only
for the human to be able to get the right interpretation of the
situation, but for correct operation of GDB as well. This is because
the condition code bits in FSCR are used by GDB to determine the
location to place a breakpoint at when single-stepping through an FPU
branch instruction. If such a breakpoint is placed incorrectly (i.e.
with the condition reversed), then it will be missed, likely causing the
debuggee to run away from the control of GDB and consequently breaking
the process of investigation.
Fortunately GDB continues using the older PTRACE_GETFPREGS ptrace(2)
request which is unaffected, so the regression only really hits with
post-mortem debug sessions using a core dump file, in which case
execution, and consequently single-stepping through branches is not
possible. Of course core files created by buggy kernels out there will
have the value of FCSR recorded clobbered, but such core files cannot be
corrected and the person using them simply will have to be aware that
the value of FCSR retrieved is not reliable.
Which also means we can likely get away without defining a replacement
API which would ensure a correct value of FSCR to be retrieved, or none
at all.
This is based on previous work by Alex Smith, extensively rewritten.
Signed-off-by: Alex Smith <alex@alex-smith.me.uk>
Signed-off-by: James Hogan <james.hogan@mips.com>
Signed-off-by: Maciej W. Rozycki <macro@mips.com>
Fixes: 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for FP regset")
Cc: Paul Burton <Paul.Burton@mips.com>
Cc: Dave Martin <Dave.Martin@arm.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org # v3.15+
Patchwork: https://patchwork.linux-mips.org/patch/17928/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
2017-12-12 05:54:33 +07:00
|
|
|
u32 fcr31;
|
2017-12-12 05:51:35 +07:00
|
|
|
int err;
|
|
|
|
|
2017-12-12 05:52:15 +07:00
|
|
|
BUG_ON(count % sizeof(elf_fpreg_t));
|
|
|
|
|
2017-12-12 05:56:54 +07:00
|
|
|
if (pos + count > sizeof(elf_fpregset_t))
|
|
|
|
return -EIO;
|
|
|
|
|
2017-12-12 05:51:35 +07:00
|
|
|
init_fp_ctx(target);
|
|
|
|
|
|
|
|
if (sizeof(target->thread.fpu.fpr[0]) == sizeof(elf_fpreg_t))
|
|
|
|
err = fpr_set_fpa(target, &pos, &count, &kbuf, &ubuf);
|
|
|
|
else
|
|
|
|
err = fpr_set_msa(target, &pos, &count, &kbuf, &ubuf);
|
MIPS: Fix an FCSR access API regression with NT_PRFPREG and MSA
Fix a commit 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for
FP regset") public API regression, then activated by commit 1db1af84d6df
("MIPS: Basic MSA context switching support"), that caused the FCSR
register not to be read or written for CONFIG_CPU_HAS_MSA kernel
configurations (regardless of actual presence or absence of the MSA
feature in a given processor) with ptrace(2) PTRACE_GETREGSET and
PTRACE_SETREGSET requests nor recorded in core dumps.
This is because with !CONFIG_CPU_HAS_MSA configurations the whole of
`elf_fpregset_t' array is bulk-copied as it is, which includes the FCSR
in one half of the last, 33rd slot, whereas with CONFIG_CPU_HAS_MSA
configurations array elements are copied individually, and then only the
leading 32 FGR slots while the remaining slot is ignored.
Correct the code then such that only FGR slots are copied in the
respective !MSA and MSA helpers an then the FCSR slot is handled
separately in common code. Use `ptrace_setfcr31' to update the FCSR
too, so that the read-only mask is respected.
Retrieving a correct value of FCSR is important in debugging not only
for the human to be able to get the right interpretation of the
situation, but for correct operation of GDB as well. This is because
the condition code bits in FSCR are used by GDB to determine the
location to place a breakpoint at when single-stepping through an FPU
branch instruction. If such a breakpoint is placed incorrectly (i.e.
with the condition reversed), then it will be missed, likely causing the
debuggee to run away from the control of GDB and consequently breaking
the process of investigation.
Fortunately GDB continues using the older PTRACE_GETFPREGS ptrace(2)
request which is unaffected, so the regression only really hits with
post-mortem debug sessions using a core dump file, in which case
execution, and consequently single-stepping through branches is not
possible. Of course core files created by buggy kernels out there will
have the value of FCSR recorded clobbered, but such core files cannot be
corrected and the person using them simply will have to be aware that
the value of FCSR retrieved is not reliable.
Which also means we can likely get away without defining a replacement
API which would ensure a correct value of FSCR to be retrieved, or none
at all.
This is based on previous work by Alex Smith, extensively rewritten.
Signed-off-by: Alex Smith <alex@alex-smith.me.uk>
Signed-off-by: James Hogan <james.hogan@mips.com>
Signed-off-by: Maciej W. Rozycki <macro@mips.com>
Fixes: 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for FP regset")
Cc: Paul Burton <Paul.Burton@mips.com>
Cc: Dave Martin <Dave.Martin@arm.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org # v3.15+
Patchwork: https://patchwork.linux-mips.org/patch/17928/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
2017-12-12 05:54:33 +07:00
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
|
|
|
if (count > 0) {
|
|
|
|
err = user_regset_copyin(&pos, &count, &kbuf, &ubuf,
|
|
|
|
&fcr31,
|
|
|
|
fcr31_pos, fcr31_pos + sizeof(u32));
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
|
|
|
ptrace_setfcr31(target, fcr31);
|
|
|
|
}
|
2017-12-12 05:51:35 +07:00
|
|
|
|
2018-04-30 21:56:47 +07:00
|
|
|
if (count > 0)
|
|
|
|
err = user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf,
|
|
|
|
fir_pos,
|
|
|
|
fir_pos + sizeof(u32));
|
|
|
|
|
2017-12-12 05:51:35 +07:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2018-11-08 06:14:07 +07:00
|
|
|
/* Copy the FP mode setting to the supplied NT_MIPS_FP_MODE buffer. */
|
|
|
|
static int fp_mode_get(struct task_struct *target,
|
|
|
|
const struct user_regset *regset,
|
|
|
|
unsigned int pos, unsigned int count,
|
|
|
|
void *kbuf, void __user *ubuf)
|
|
|
|
{
|
|
|
|
int fp_mode;
|
|
|
|
|
|
|
|
fp_mode = mips_get_process_fp_mode(target);
|
|
|
|
return user_regset_copyout(&pos, &count, &kbuf, &ubuf, &fp_mode, 0,
|
|
|
|
sizeof(fp_mode));
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Copy the supplied NT_MIPS_FP_MODE buffer to the FP mode setting.
|
|
|
|
*
|
|
|
|
* We optimize for the case where `count % sizeof(int) == 0', which
|
|
|
|
* is supposed to have been guaranteed by the kernel before calling
|
|
|
|
* us, e.g. in `ptrace_regset'. We enforce that requirement, so
|
|
|
|
* that we can safely avoid preinitializing temporaries for partial
|
|
|
|
* mode writes.
|
|
|
|
*/
|
|
|
|
static int fp_mode_set(struct task_struct *target,
|
|
|
|
const struct user_regset *regset,
|
|
|
|
unsigned int pos, unsigned int count,
|
|
|
|
const void *kbuf, const void __user *ubuf)
|
|
|
|
{
|
|
|
|
int fp_mode;
|
|
|
|
int err;
|
|
|
|
|
|
|
|
BUG_ON(count % sizeof(int));
|
|
|
|
|
|
|
|
if (pos + count > sizeof(fp_mode))
|
|
|
|
return -EIO;
|
|
|
|
|
|
|
|
err = user_regset_copyin(&pos, &count, &kbuf, &ubuf, &fp_mode, 0,
|
|
|
|
sizeof(fp_mode));
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
|
|
|
if (count > 0)
|
|
|
|
err = mips_set_process_fp_mode(target, fp_mode);
|
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif /* CONFIG_MIPS_FP_SUPPORT */
|
|
|
|
|
2018-11-21 03:41:05 +07:00
|
|
|
#ifdef CONFIG_CPU_HAS_MSA
|
|
|
|
|
|
|
|
struct msa_control_regs {
|
|
|
|
unsigned int fir;
|
|
|
|
unsigned int fcsr;
|
|
|
|
unsigned int msair;
|
|
|
|
unsigned int msacsr;
|
|
|
|
};
|
|
|
|
|
|
|
|
static int copy_pad_fprs(struct task_struct *target,
|
|
|
|
const struct user_regset *regset,
|
|
|
|
unsigned int *ppos, unsigned int *pcount,
|
|
|
|
void **pkbuf, void __user **pubuf,
|
|
|
|
unsigned int live_sz)
|
|
|
|
{
|
|
|
|
int i, j, start, start_pad, err;
|
|
|
|
unsigned long long fill = ~0ull;
|
|
|
|
unsigned int cp_sz, pad_sz;
|
|
|
|
|
|
|
|
cp_sz = min(regset->size, live_sz);
|
|
|
|
pad_sz = regset->size - cp_sz;
|
|
|
|
WARN_ON(pad_sz % sizeof(fill));
|
|
|
|
|
|
|
|
i = start = err = 0;
|
|
|
|
for (; i < NUM_FPU_REGS; i++, start += regset->size) {
|
|
|
|
err |= user_regset_copyout(ppos, pcount, pkbuf, pubuf,
|
|
|
|
&target->thread.fpu.fpr[i],
|
|
|
|
start, start + cp_sz);
|
|
|
|
|
|
|
|
start_pad = start + cp_sz;
|
|
|
|
for (j = 0; j < (pad_sz / sizeof(fill)); j++) {
|
|
|
|
err |= user_regset_copyout(ppos, pcount, pkbuf, pubuf,
|
|
|
|
&fill, start_pad,
|
|
|
|
start_pad + sizeof(fill));
|
|
|
|
start_pad += sizeof(fill);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int msa_get(struct task_struct *target,
|
|
|
|
const struct user_regset *regset,
|
|
|
|
unsigned int pos, unsigned int count,
|
|
|
|
void *kbuf, void __user *ubuf)
|
|
|
|
{
|
|
|
|
const unsigned int wr_size = NUM_FPU_REGS * regset->size;
|
|
|
|
const struct msa_control_regs ctrl_regs = {
|
|
|
|
.fir = boot_cpu_data.fpu_id,
|
|
|
|
.fcsr = target->thread.fpu.fcr31,
|
|
|
|
.msair = boot_cpu_data.msa_id,
|
|
|
|
.msacsr = target->thread.fpu.msacsr,
|
|
|
|
};
|
|
|
|
int err;
|
|
|
|
|
|
|
|
if (!tsk_used_math(target)) {
|
|
|
|
/* The task hasn't used FP or MSA, fill with 0xff */
|
|
|
|
err = copy_pad_fprs(target, regset, &pos, &count,
|
|
|
|
&kbuf, &ubuf, 0);
|
|
|
|
} else if (!test_tsk_thread_flag(target, TIF_MSA_CTX_LIVE)) {
|
|
|
|
/* Copy scalar FP context, fill the rest with 0xff */
|
|
|
|
err = copy_pad_fprs(target, regset, &pos, &count,
|
|
|
|
&kbuf, &ubuf, 8);
|
|
|
|
} else if (sizeof(target->thread.fpu.fpr[0]) == regset->size) {
|
|
|
|
/* Trivially copy the vector registers */
|
|
|
|
err = user_regset_copyout(&pos, &count, &kbuf, &ubuf,
|
|
|
|
&target->thread.fpu.fpr,
|
|
|
|
0, wr_size);
|
|
|
|
} else {
|
|
|
|
/* Copy as much context as possible, fill the rest with 0xff */
|
|
|
|
err = copy_pad_fprs(target, regset, &pos, &count,
|
|
|
|
&kbuf, &ubuf,
|
|
|
|
sizeof(target->thread.fpu.fpr[0]));
|
|
|
|
}
|
|
|
|
|
|
|
|
err |= user_regset_copyout(&pos, &count, &kbuf, &ubuf,
|
|
|
|
&ctrl_regs, wr_size,
|
|
|
|
wr_size + sizeof(ctrl_regs));
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int msa_set(struct task_struct *target,
|
|
|
|
const struct user_regset *regset,
|
|
|
|
unsigned int pos, unsigned int count,
|
|
|
|
const void *kbuf, const void __user *ubuf)
|
|
|
|
{
|
|
|
|
const unsigned int wr_size = NUM_FPU_REGS * regset->size;
|
|
|
|
struct msa_control_regs ctrl_regs;
|
|
|
|
unsigned int cp_sz;
|
|
|
|
int i, err, start;
|
|
|
|
|
|
|
|
init_fp_ctx(target);
|
|
|
|
|
|
|
|
if (sizeof(target->thread.fpu.fpr[0]) == regset->size) {
|
|
|
|
/* Trivially copy the vector registers */
|
|
|
|
err = user_regset_copyin(&pos, &count, &kbuf, &ubuf,
|
|
|
|
&target->thread.fpu.fpr,
|
|
|
|
0, wr_size);
|
|
|
|
} else {
|
|
|
|
/* Copy as much context as possible */
|
|
|
|
cp_sz = min_t(unsigned int, regset->size,
|
|
|
|
sizeof(target->thread.fpu.fpr[0]));
|
|
|
|
|
|
|
|
i = start = err = 0;
|
|
|
|
for (; i < NUM_FPU_REGS; i++, start += regset->size) {
|
|
|
|
err |= user_regset_copyin(&pos, &count, &kbuf, &ubuf,
|
|
|
|
&target->thread.fpu.fpr[i],
|
|
|
|
start, start + cp_sz);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!err)
|
|
|
|
err = user_regset_copyin(&pos, &count, &kbuf, &ubuf, &ctrl_regs,
|
|
|
|
wr_size, wr_size + sizeof(ctrl_regs));
|
|
|
|
if (!err) {
|
|
|
|
target->thread.fpu.fcr31 = ctrl_regs.fcsr & ~FPU_CSR_ALL_X;
|
|
|
|
target->thread.fpu.msacsr = ctrl_regs.msacsr & ~MSA_CSR_CAUSEF;
|
|
|
|
}
|
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif /* CONFIG_CPU_HAS_MSA */
|
|
|
|
|
2018-05-16 05:34:28 +07:00
|
|
|
#if defined(CONFIG_32BIT) || defined(CONFIG_MIPS32_O32)
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Copy the DSP context to the supplied 32-bit NT_MIPS_DSP buffer.
|
|
|
|
*/
|
|
|
|
static int dsp32_get(struct task_struct *target,
|
|
|
|
const struct user_regset *regset,
|
|
|
|
unsigned int pos, unsigned int count,
|
|
|
|
void *kbuf, void __user *ubuf)
|
|
|
|
{
|
|
|
|
unsigned int start, num_regs, i;
|
|
|
|
u32 dspregs[NUM_DSP_REGS + 1];
|
|
|
|
|
|
|
|
BUG_ON(count % sizeof(u32));
|
|
|
|
|
|
|
|
if (!cpu_has_dsp)
|
|
|
|
return -EIO;
|
|
|
|
|
|
|
|
start = pos / sizeof(u32);
|
|
|
|
num_regs = count / sizeof(u32);
|
|
|
|
|
|
|
|
if (start + num_regs > NUM_DSP_REGS + 1)
|
|
|
|
return -EIO;
|
|
|
|
|
|
|
|
for (i = start; i < num_regs; i++)
|
|
|
|
switch (i) {
|
|
|
|
case 0 ... NUM_DSP_REGS - 1:
|
|
|
|
dspregs[i] = target->thread.dsp.dspr[i];
|
|
|
|
break;
|
|
|
|
case NUM_DSP_REGS:
|
|
|
|
dspregs[i] = target->thread.dsp.dspcontrol;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
return user_regset_copyout(&pos, &count, &kbuf, &ubuf, dspregs, 0,
|
|
|
|
sizeof(dspregs));
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Copy the supplied 32-bit NT_MIPS_DSP buffer to the DSP context.
|
|
|
|
*/
|
|
|
|
static int dsp32_set(struct task_struct *target,
|
|
|
|
const struct user_regset *regset,
|
|
|
|
unsigned int pos, unsigned int count,
|
|
|
|
const void *kbuf, const void __user *ubuf)
|
|
|
|
{
|
|
|
|
unsigned int start, num_regs, i;
|
|
|
|
u32 dspregs[NUM_DSP_REGS + 1];
|
|
|
|
int err;
|
|
|
|
|
|
|
|
BUG_ON(count % sizeof(u32));
|
|
|
|
|
|
|
|
if (!cpu_has_dsp)
|
|
|
|
return -EIO;
|
|
|
|
|
|
|
|
start = pos / sizeof(u32);
|
|
|
|
num_regs = count / sizeof(u32);
|
|
|
|
|
|
|
|
if (start + num_regs > NUM_DSP_REGS + 1)
|
|
|
|
return -EIO;
|
|
|
|
|
|
|
|
err = user_regset_copyin(&pos, &count, &kbuf, &ubuf, dspregs, 0,
|
|
|
|
sizeof(dspregs));
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
|
|
|
for (i = start; i < num_regs; i++)
|
|
|
|
switch (i) {
|
|
|
|
case 0 ... NUM_DSP_REGS - 1:
|
|
|
|
target->thread.dsp.dspr[i] = (s32)dspregs[i];
|
|
|
|
break;
|
|
|
|
case NUM_DSP_REGS:
|
|
|
|
target->thread.dsp.dspcontrol = (s32)dspregs[i];
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif /* CONFIG_32BIT || CONFIG_MIPS32_O32 */
|
|
|
|
|
|
|
|
#ifdef CONFIG_64BIT
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Copy the DSP context to the supplied 64-bit NT_MIPS_DSP buffer.
|
|
|
|
*/
|
|
|
|
static int dsp64_get(struct task_struct *target,
|
|
|
|
const struct user_regset *regset,
|
|
|
|
unsigned int pos, unsigned int count,
|
|
|
|
void *kbuf, void __user *ubuf)
|
|
|
|
{
|
|
|
|
unsigned int start, num_regs, i;
|
|
|
|
u64 dspregs[NUM_DSP_REGS + 1];
|
|
|
|
|
|
|
|
BUG_ON(count % sizeof(u64));
|
|
|
|
|
|
|
|
if (!cpu_has_dsp)
|
|
|
|
return -EIO;
|
|
|
|
|
|
|
|
start = pos / sizeof(u64);
|
|
|
|
num_regs = count / sizeof(u64);
|
|
|
|
|
|
|
|
if (start + num_regs > NUM_DSP_REGS + 1)
|
|
|
|
return -EIO;
|
|
|
|
|
|
|
|
for (i = start; i < num_regs; i++)
|
|
|
|
switch (i) {
|
|
|
|
case 0 ... NUM_DSP_REGS - 1:
|
|
|
|
dspregs[i] = target->thread.dsp.dspr[i];
|
|
|
|
break;
|
|
|
|
case NUM_DSP_REGS:
|
|
|
|
dspregs[i] = target->thread.dsp.dspcontrol;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
return user_regset_copyout(&pos, &count, &kbuf, &ubuf, dspregs, 0,
|
|
|
|
sizeof(dspregs));
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Copy the supplied 64-bit NT_MIPS_DSP buffer to the DSP context.
|
|
|
|
*/
|
|
|
|
static int dsp64_set(struct task_struct *target,
|
|
|
|
const struct user_regset *regset,
|
|
|
|
unsigned int pos, unsigned int count,
|
|
|
|
const void *kbuf, const void __user *ubuf)
|
|
|
|
{
|
|
|
|
unsigned int start, num_regs, i;
|
|
|
|
u64 dspregs[NUM_DSP_REGS + 1];
|
|
|
|
int err;
|
|
|
|
|
|
|
|
BUG_ON(count % sizeof(u64));
|
|
|
|
|
|
|
|
if (!cpu_has_dsp)
|
|
|
|
return -EIO;
|
|
|
|
|
|
|
|
start = pos / sizeof(u64);
|
|
|
|
num_regs = count / sizeof(u64);
|
|
|
|
|
|
|
|
if (start + num_regs > NUM_DSP_REGS + 1)
|
|
|
|
return -EIO;
|
|
|
|
|
|
|
|
err = user_regset_copyin(&pos, &count, &kbuf, &ubuf, dspregs, 0,
|
|
|
|
sizeof(dspregs));
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
|
|
|
for (i = start; i < num_regs; i++)
|
|
|
|
switch (i) {
|
|
|
|
case 0 ... NUM_DSP_REGS - 1:
|
|
|
|
target->thread.dsp.dspr[i] = dspregs[i];
|
|
|
|
break;
|
|
|
|
case NUM_DSP_REGS:
|
|
|
|
target->thread.dsp.dspcontrol = dspregs[i];
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif /* CONFIG_64BIT */
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Determine whether the DSP context is present.
|
|
|
|
*/
|
|
|
|
static int dsp_active(struct task_struct *target,
|
|
|
|
const struct user_regset *regset)
|
|
|
|
{
|
|
|
|
return cpu_has_dsp ? NUM_DSP_REGS + 1 : -ENODEV;
|
|
|
|
}
|
|
|
|
|
2012-08-02 19:44:11 +07:00
|
|
|
enum mips_regset {
|
|
|
|
REGSET_GPR,
|
2018-05-16 05:34:28 +07:00
|
|
|
REGSET_DSP,
|
2018-11-08 06:14:07 +07:00
|
|
|
#ifdef CONFIG_MIPS_FP_SUPPORT
|
|
|
|
REGSET_FPR,
|
2018-05-16 05:40:18 +07:00
|
|
|
REGSET_FP_MODE,
|
2018-11-08 06:14:07 +07:00
|
|
|
#endif
|
2018-11-21 03:41:05 +07:00
|
|
|
#ifdef CONFIG_CPU_HAS_MSA
|
|
|
|
REGSET_MSA,
|
|
|
|
#endif
|
2012-08-02 19:44:11 +07:00
|
|
|
};
|
|
|
|
|
2015-07-30 03:44:53 +07:00
|
|
|
struct pt_regs_offset {
|
|
|
|
const char *name;
|
|
|
|
int offset;
|
|
|
|
};
|
|
|
|
|
|
|
|
#define REG_OFFSET_NAME(reg, r) { \
|
|
|
|
.name = #reg, \
|
|
|
|
.offset = offsetof(struct pt_regs, r) \
|
|
|
|
}
|
|
|
|
|
|
|
|
#define REG_OFFSET_END { \
|
|
|
|
.name = NULL, \
|
|
|
|
.offset = 0 \
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct pt_regs_offset regoffset_table[] = {
|
|
|
|
REG_OFFSET_NAME(r0, regs[0]),
|
|
|
|
REG_OFFSET_NAME(r1, regs[1]),
|
|
|
|
REG_OFFSET_NAME(r2, regs[2]),
|
|
|
|
REG_OFFSET_NAME(r3, regs[3]),
|
|
|
|
REG_OFFSET_NAME(r4, regs[4]),
|
|
|
|
REG_OFFSET_NAME(r5, regs[5]),
|
|
|
|
REG_OFFSET_NAME(r6, regs[6]),
|
|
|
|
REG_OFFSET_NAME(r7, regs[7]),
|
|
|
|
REG_OFFSET_NAME(r8, regs[8]),
|
|
|
|
REG_OFFSET_NAME(r9, regs[9]),
|
|
|
|
REG_OFFSET_NAME(r10, regs[10]),
|
|
|
|
REG_OFFSET_NAME(r11, regs[11]),
|
|
|
|
REG_OFFSET_NAME(r12, regs[12]),
|
|
|
|
REG_OFFSET_NAME(r13, regs[13]),
|
|
|
|
REG_OFFSET_NAME(r14, regs[14]),
|
|
|
|
REG_OFFSET_NAME(r15, regs[15]),
|
|
|
|
REG_OFFSET_NAME(r16, regs[16]),
|
|
|
|
REG_OFFSET_NAME(r17, regs[17]),
|
|
|
|
REG_OFFSET_NAME(r18, regs[18]),
|
|
|
|
REG_OFFSET_NAME(r19, regs[19]),
|
|
|
|
REG_OFFSET_NAME(r20, regs[20]),
|
|
|
|
REG_OFFSET_NAME(r21, regs[21]),
|
|
|
|
REG_OFFSET_NAME(r22, regs[22]),
|
|
|
|
REG_OFFSET_NAME(r23, regs[23]),
|
|
|
|
REG_OFFSET_NAME(r24, regs[24]),
|
|
|
|
REG_OFFSET_NAME(r25, regs[25]),
|
|
|
|
REG_OFFSET_NAME(r26, regs[26]),
|
|
|
|
REG_OFFSET_NAME(r27, regs[27]),
|
|
|
|
REG_OFFSET_NAME(r28, regs[28]),
|
|
|
|
REG_OFFSET_NAME(r29, regs[29]),
|
|
|
|
REG_OFFSET_NAME(r30, regs[30]),
|
|
|
|
REG_OFFSET_NAME(r31, regs[31]),
|
|
|
|
REG_OFFSET_NAME(c0_status, cp0_status),
|
|
|
|
REG_OFFSET_NAME(hi, hi),
|
|
|
|
REG_OFFSET_NAME(lo, lo),
|
|
|
|
#ifdef CONFIG_CPU_HAS_SMARTMIPS
|
|
|
|
REG_OFFSET_NAME(acx, acx),
|
|
|
|
#endif
|
|
|
|
REG_OFFSET_NAME(c0_badvaddr, cp0_badvaddr),
|
|
|
|
REG_OFFSET_NAME(c0_cause, cp0_cause),
|
|
|
|
REG_OFFSET_NAME(c0_epc, cp0_epc),
|
|
|
|
#ifdef CONFIG_CPU_CAVIUM_OCTEON
|
|
|
|
REG_OFFSET_NAME(mpl0, mpl[0]),
|
|
|
|
REG_OFFSET_NAME(mpl1, mpl[1]),
|
|
|
|
REG_OFFSET_NAME(mpl2, mpl[2]),
|
|
|
|
REG_OFFSET_NAME(mtp0, mtp[0]),
|
|
|
|
REG_OFFSET_NAME(mtp1, mtp[1]),
|
|
|
|
REG_OFFSET_NAME(mtp2, mtp[2]),
|
|
|
|
#endif
|
|
|
|
REG_OFFSET_END,
|
|
|
|
};
|
|
|
|
|
|
|
|
/**
|
|
|
|
* regs_query_register_offset() - query register offset from its name
|
|
|
|
* @name: the name of a register
|
|
|
|
*
|
|
|
|
* regs_query_register_offset() returns the offset of a register in struct
|
|
|
|
* pt_regs from its name. If the name is invalid, this returns -EINVAL;
|
|
|
|
*/
|
|
|
|
int regs_query_register_offset(const char *name)
|
|
|
|
{
|
|
|
|
const struct pt_regs_offset *roff;
|
|
|
|
for (roff = regoffset_table; roff->name != NULL; roff++)
|
|
|
|
if (!strcmp(roff->name, name))
|
|
|
|
return roff->offset;
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2014-07-23 20:40:09 +07:00
|
|
|
#if defined(CONFIG_32BIT) || defined(CONFIG_MIPS32_O32)
|
|
|
|
|
2012-08-02 19:44:11 +07:00
|
|
|
static const struct user_regset mips_regsets[] = {
|
|
|
|
[REGSET_GPR] = {
|
|
|
|
.core_note_type = NT_PRSTATUS,
|
|
|
|
.n = ELF_NGREG,
|
|
|
|
.size = sizeof(unsigned int),
|
|
|
|
.align = sizeof(unsigned int),
|
2014-07-23 20:40:09 +07:00
|
|
|
.get = gpr32_get,
|
|
|
|
.set = gpr32_set,
|
2012-08-02 19:44:11 +07:00
|
|
|
},
|
2018-05-16 05:34:28 +07:00
|
|
|
[REGSET_DSP] = {
|
|
|
|
.core_note_type = NT_MIPS_DSP,
|
|
|
|
.n = NUM_DSP_REGS + 1,
|
|
|
|
.size = sizeof(u32),
|
|
|
|
.align = sizeof(u32),
|
|
|
|
.get = dsp32_get,
|
|
|
|
.set = dsp32_set,
|
|
|
|
.active = dsp_active,
|
|
|
|
},
|
2018-11-08 06:14:07 +07:00
|
|
|
#ifdef CONFIG_MIPS_FP_SUPPORT
|
|
|
|
[REGSET_FPR] = {
|
|
|
|
.core_note_type = NT_PRFPREG,
|
|
|
|
.n = ELF_NFPREG,
|
|
|
|
.size = sizeof(elf_fpreg_t),
|
|
|
|
.align = sizeof(elf_fpreg_t),
|
|
|
|
.get = fpr_get,
|
|
|
|
.set = fpr_set,
|
|
|
|
},
|
2018-05-16 05:40:18 +07:00
|
|
|
[REGSET_FP_MODE] = {
|
|
|
|
.core_note_type = NT_MIPS_FP_MODE,
|
|
|
|
.n = 1,
|
|
|
|
.size = sizeof(int),
|
|
|
|
.align = sizeof(int),
|
|
|
|
.get = fp_mode_get,
|
|
|
|
.set = fp_mode_set,
|
|
|
|
},
|
2018-11-08 06:14:07 +07:00
|
|
|
#endif
|
2018-11-21 03:41:05 +07:00
|
|
|
#ifdef CONFIG_CPU_HAS_MSA
|
|
|
|
[REGSET_MSA] = {
|
|
|
|
.core_note_type = NT_MIPS_MSA,
|
|
|
|
.n = NUM_FPU_REGS + 1,
|
|
|
|
.size = 16,
|
|
|
|
.align = 16,
|
|
|
|
.get = msa_get,
|
|
|
|
.set = msa_set,
|
|
|
|
},
|
|
|
|
#endif
|
2012-08-02 19:44:11 +07:00
|
|
|
};
|
|
|
|
|
|
|
|
static const struct user_regset_view user_mips_view = {
|
|
|
|
.name = "mips",
|
|
|
|
.e_machine = ELF_ARCH,
|
|
|
|
.ei_osabi = ELF_OSABI,
|
|
|
|
.regsets = mips_regsets,
|
|
|
|
.n = ARRAY_SIZE(mips_regsets),
|
|
|
|
};
|
|
|
|
|
2014-07-23 20:40:09 +07:00
|
|
|
#endif /* CONFIG_32BIT || CONFIG_MIPS32_O32 */
|
|
|
|
|
|
|
|
#ifdef CONFIG_64BIT
|
|
|
|
|
2012-08-02 19:44:11 +07:00
|
|
|
static const struct user_regset mips64_regsets[] = {
|
|
|
|
[REGSET_GPR] = {
|
|
|
|
.core_note_type = NT_PRSTATUS,
|
|
|
|
.n = ELF_NGREG,
|
|
|
|
.size = sizeof(unsigned long),
|
|
|
|
.align = sizeof(unsigned long),
|
2014-07-23 20:40:09 +07:00
|
|
|
.get = gpr64_get,
|
|
|
|
.set = gpr64_set,
|
2012-08-02 19:44:11 +07:00
|
|
|
},
|
2018-05-16 05:34:28 +07:00
|
|
|
[REGSET_DSP] = {
|
|
|
|
.core_note_type = NT_MIPS_DSP,
|
|
|
|
.n = NUM_DSP_REGS + 1,
|
|
|
|
.size = sizeof(u64),
|
|
|
|
.align = sizeof(u64),
|
|
|
|
.get = dsp64_get,
|
|
|
|
.set = dsp64_set,
|
|
|
|
.active = dsp_active,
|
|
|
|
},
|
2018-11-08 06:14:07 +07:00
|
|
|
#ifdef CONFIG_MIPS_FP_SUPPORT
|
2018-05-16 05:40:18 +07:00
|
|
|
[REGSET_FP_MODE] = {
|
|
|
|
.core_note_type = NT_MIPS_FP_MODE,
|
|
|
|
.n = 1,
|
|
|
|
.size = sizeof(int),
|
|
|
|
.align = sizeof(int),
|
|
|
|
.get = fp_mode_get,
|
|
|
|
.set = fp_mode_set,
|
|
|
|
},
|
2018-11-08 06:14:07 +07:00
|
|
|
[REGSET_FPR] = {
|
|
|
|
.core_note_type = NT_PRFPREG,
|
|
|
|
.n = ELF_NFPREG,
|
|
|
|
.size = sizeof(elf_fpreg_t),
|
|
|
|
.align = sizeof(elf_fpreg_t),
|
|
|
|
.get = fpr_get,
|
|
|
|
.set = fpr_set,
|
|
|
|
},
|
|
|
|
#endif
|
2018-11-21 03:41:05 +07:00
|
|
|
#ifdef CONFIG_CPU_HAS_MSA
|
|
|
|
[REGSET_MSA] = {
|
|
|
|
.core_note_type = NT_MIPS_MSA,
|
|
|
|
.n = NUM_FPU_REGS + 1,
|
|
|
|
.size = 16,
|
|
|
|
.align = 16,
|
|
|
|
.get = msa_get,
|
|
|
|
.set = msa_set,
|
|
|
|
},
|
|
|
|
#endif
|
2012-08-02 19:44:11 +07:00
|
|
|
};
|
|
|
|
|
|
|
|
static const struct user_regset_view user_mips64_view = {
|
2014-07-23 20:40:09 +07:00
|
|
|
.name = "mips64",
|
2012-08-02 19:44:11 +07:00
|
|
|
.e_machine = ELF_ARCH,
|
|
|
|
.ei_osabi = ELF_OSABI,
|
|
|
|
.regsets = mips64_regsets,
|
2014-07-23 20:40:09 +07:00
|
|
|
.n = ARRAY_SIZE(mips64_regsets),
|
2012-08-02 19:44:11 +07:00
|
|
|
};
|
|
|
|
|
MIPS: Fix an n32 core file generation regset support regression
Fix a commit 7aeb753b5353 ("MIPS: Implement task_user_regset_view.")
regression, then activated by commit 6a9c001b7ec3 ("MIPS: Switch ELF
core dumper to use regsets.)", that caused n32 processes to dump o32
core files by failing to set the EF_MIPS_ABI2 flag in the ELF core file
header's `e_flags' member:
$ file tls-core
tls-core: ELF 32-bit MSB executable, MIPS, N32 MIPS64 rel2 version 1 (SYSV), [...]
$ ./tls-core
Aborted (core dumped)
$ file core
core: ELF 32-bit MSB core file MIPS, MIPS-I version 1 (SYSV), SVR4-style
$
Previously the flag was set as the result of a:
statement placed in arch/mips/kernel/binfmt_elfn32.c, however in the
regset case, i.e. when CORE_DUMP_USE_REGSET is set, ELF_CORE_EFLAGS is
no longer used by `fill_note_info' in fs/binfmt_elf.c, and instead the
`->e_flags' member of the regset view chosen is. We have the views
defined in arch/mips/kernel/ptrace.c, however only an o32 and an n64
one, and the latter is used for n32 as well. Consequently an o32 core
file is incorrectly dumped from n32 processes (the ELF32 vs ELF64 class
is chosen elsewhere, and the 32-bit one is correctly selected for n32).
Correct the issue then by defining an n32 regset view and using it as
appropriate. Issue discovered in GDB testing.
Fixes: 7aeb753b5353 ("MIPS: Implement task_user_regset_view.")
Signed-off-by: Maciej W. Rozycki <macro@mips.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Djordje Todorovic <djordje.todorovic@rt-rk.com>
Cc: linux-mips@linux-mips.org
Cc: <stable@vger.kernel.org> # 3.13+
Patchwork: https://patchwork.linux-mips.org/patch/17617/
Signed-off-by: James Hogan <jhogan@kernel.org>
2017-11-08 02:09:20 +07:00
|
|
|
#ifdef CONFIG_MIPS32_N32
|
|
|
|
|
|
|
|
static const struct user_regset_view user_mipsn32_view = {
|
|
|
|
.name = "mipsn32",
|
|
|
|
.e_flags = EF_MIPS_ABI2,
|
|
|
|
.e_machine = ELF_ARCH,
|
|
|
|
.ei_osabi = ELF_OSABI,
|
|
|
|
.regsets = mips64_regsets,
|
|
|
|
.n = ARRAY_SIZE(mips64_regsets),
|
|
|
|
};
|
|
|
|
|
|
|
|
#endif /* CONFIG_MIPS32_N32 */
|
|
|
|
|
2014-07-23 20:40:09 +07:00
|
|
|
#endif /* CONFIG_64BIT */
|
|
|
|
|
2012-08-02 19:44:11 +07:00
|
|
|
const struct user_regset_view *task_user_regset_view(struct task_struct *task)
|
|
|
|
{
|
|
|
|
#ifdef CONFIG_32BIT
|
|
|
|
return &user_mips_view;
|
2014-07-23 20:40:09 +07:00
|
|
|
#else
|
2012-08-02 19:44:11 +07:00
|
|
|
#ifdef CONFIG_MIPS32_O32
|
2014-07-23 20:40:09 +07:00
|
|
|
if (test_tsk_thread_flag(task, TIF_32BIT_REGS))
|
|
|
|
return &user_mips_view;
|
MIPS: Fix an n32 core file generation regset support regression
Fix a commit 7aeb753b5353 ("MIPS: Implement task_user_regset_view.")
regression, then activated by commit 6a9c001b7ec3 ("MIPS: Switch ELF
core dumper to use regsets.)", that caused n32 processes to dump o32
core files by failing to set the EF_MIPS_ABI2 flag in the ELF core file
header's `e_flags' member:
$ file tls-core
tls-core: ELF 32-bit MSB executable, MIPS, N32 MIPS64 rel2 version 1 (SYSV), [...]
$ ./tls-core
Aborted (core dumped)
$ file core
core: ELF 32-bit MSB core file MIPS, MIPS-I version 1 (SYSV), SVR4-style
$
Previously the flag was set as the result of a:
statement placed in arch/mips/kernel/binfmt_elfn32.c, however in the
regset case, i.e. when CORE_DUMP_USE_REGSET is set, ELF_CORE_EFLAGS is
no longer used by `fill_note_info' in fs/binfmt_elf.c, and instead the
`->e_flags' member of the regset view chosen is. We have the views
defined in arch/mips/kernel/ptrace.c, however only an o32 and an n64
one, and the latter is used for n32 as well. Consequently an o32 core
file is incorrectly dumped from n32 processes (the ELF32 vs ELF64 class
is chosen elsewhere, and the 32-bit one is correctly selected for n32).
Correct the issue then by defining an n32 regset view and using it as
appropriate. Issue discovered in GDB testing.
Fixes: 7aeb753b5353 ("MIPS: Implement task_user_regset_view.")
Signed-off-by: Maciej W. Rozycki <macro@mips.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Djordje Todorovic <djordje.todorovic@rt-rk.com>
Cc: linux-mips@linux-mips.org
Cc: <stable@vger.kernel.org> # 3.13+
Patchwork: https://patchwork.linux-mips.org/patch/17617/
Signed-off-by: James Hogan <jhogan@kernel.org>
2017-11-08 02:09:20 +07:00
|
|
|
#endif
|
|
|
|
#ifdef CONFIG_MIPS32_N32
|
|
|
|
if (test_tsk_thread_flag(task, TIF_32BIT_ADDR))
|
|
|
|
return &user_mipsn32_view;
|
2012-08-02 19:44:11 +07:00
|
|
|
#endif
|
|
|
|
return &user_mips64_view;
|
2014-07-23 20:40:09 +07:00
|
|
|
#endif
|
2012-08-02 19:44:11 +07:00
|
|
|
}
|
|
|
|
|
2010-10-28 05:33:47 +07:00
|
|
|
long arch_ptrace(struct task_struct *child, long request,
|
|
|
|
unsigned long addr, unsigned long data)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
|
|
|
int ret;
|
2010-10-28 05:33:58 +07:00
|
|
|
void __user *addrp = (void __user *) addr;
|
|
|
|
void __user *datavp = (void __user *) data;
|
|
|
|
unsigned long __user *datalp = (void __user *) data;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
|
|
|
switch (request) {
|
|
|
|
/* when I and D space are separate, these will need to be fixed. */
|
|
|
|
case PTRACE_PEEKTEXT: /* read word at location addr. */
|
2007-07-17 18:03:43 +07:00
|
|
|
case PTRACE_PEEKDATA:
|
|
|
|
ret = generic_ptrace_peekdata(child, addr, data);
|
2005-04-17 05:20:36 +07:00
|
|
|
break;
|
|
|
|
|
|
|
|
/* Read the word at location addr in the USER area. */
|
|
|
|
case PTRACE_PEEKUSR: {
|
|
|
|
struct pt_regs *regs;
|
|
|
|
unsigned long tmp = 0;
|
|
|
|
|
2006-01-12 16:06:07 +07:00
|
|
|
regs = task_pt_regs(child);
|
2005-04-17 05:20:36 +07:00
|
|
|
ret = 0; /* Default return value. */
|
|
|
|
|
|
|
|
switch (addr) {
|
|
|
|
case 0 ... 31:
|
|
|
|
tmp = regs->regs[addr];
|
|
|
|
break;
|
2018-11-08 06:14:07 +07:00
|
|
|
#ifdef CONFIG_MIPS_FP_SUPPORT
|
|
|
|
case FPR_BASE ... FPR_BASE + 31: {
|
|
|
|
union fpureg *fregs;
|
|
|
|
|
2013-11-22 20:12:07 +07:00
|
|
|
if (!tsk_used_math(child)) {
|
|
|
|
/* FP not yet used */
|
|
|
|
tmp = -1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
fregs = get_fpu_regs(child);
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2005-09-04 05:56:16 +07:00
|
|
|
#ifdef CONFIG_32BIT
|
2018-05-14 22:49:43 +07:00
|
|
|
if (test_tsk_thread_flag(child, TIF_32BIT_FPREGS)) {
|
2005-04-17 05:20:36 +07:00
|
|
|
/*
|
|
|
|
* The odd registers are actually the high
|
|
|
|
* order bits of the values stored in the even
|
2018-05-16 05:03:09 +07:00
|
|
|
* registers.
|
2005-04-17 05:20:36 +07:00
|
|
|
*/
|
2014-02-13 18:26:41 +07:00
|
|
|
tmp = get_fpr32(&fregs[(addr & ~1) - FPR_BASE],
|
|
|
|
addr & 1);
|
2013-11-22 20:12:07 +07:00
|
|
|
break;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
2013-11-22 20:12:07 +07:00
|
|
|
#endif
|
2018-05-16 22:39:58 +07:00
|
|
|
tmp = get_fpr64(&fregs[addr - FPR_BASE], 0);
|
2005-04-17 05:20:36 +07:00
|
|
|
break;
|
2018-11-08 06:14:07 +07:00
|
|
|
}
|
|
|
|
case FPC_CSR:
|
|
|
|
tmp = child->thread.fpu.fcr31;
|
|
|
|
break;
|
|
|
|
case FPC_EIR:
|
|
|
|
/* implementation / version register */
|
|
|
|
tmp = boot_cpu_data.fpu_id;
|
|
|
|
break;
|
|
|
|
#endif
|
2005-04-17 05:20:36 +07:00
|
|
|
case PC:
|
|
|
|
tmp = regs->cp0_epc;
|
|
|
|
break;
|
|
|
|
case CAUSE:
|
|
|
|
tmp = regs->cp0_cause;
|
|
|
|
break;
|
|
|
|
case BADVADDR:
|
|
|
|
tmp = regs->cp0_badvaddr;
|
|
|
|
break;
|
|
|
|
case MMHI:
|
|
|
|
tmp = regs->hi;
|
|
|
|
break;
|
|
|
|
case MMLO:
|
|
|
|
tmp = regs->lo;
|
|
|
|
break;
|
2007-02-02 23:41:47 +07:00
|
|
|
#ifdef CONFIG_CPU_HAS_SMARTMIPS
|
|
|
|
case ACX:
|
|
|
|
tmp = regs->acx;
|
|
|
|
break;
|
|
|
|
#endif
|
2005-06-30 16:42:00 +07:00
|
|
|
case DSP_BASE ... DSP_BASE + 5: {
|
|
|
|
dspreg_t *dregs;
|
|
|
|
|
2005-05-31 18:49:19 +07:00
|
|
|
if (!cpu_has_dsp) {
|
|
|
|
tmp = 0;
|
|
|
|
ret = -EIO;
|
2005-11-07 15:59:47 +07:00
|
|
|
goto out;
|
2005-05-31 18:49:19 +07:00
|
|
|
}
|
2005-12-05 20:47:25 +07:00
|
|
|
dregs = __get_dsp_regs(child);
|
2018-05-16 05:33:26 +07:00
|
|
|
tmp = dregs[addr - DSP_BASE];
|
2005-05-31 18:49:19 +07:00
|
|
|
break;
|
2005-06-30 16:42:00 +07:00
|
|
|
}
|
2005-05-31 18:49:19 +07:00
|
|
|
case DSP_CONTROL:
|
|
|
|
if (!cpu_has_dsp) {
|
|
|
|
tmp = 0;
|
|
|
|
ret = -EIO;
|
2005-11-07 15:59:47 +07:00
|
|
|
goto out;
|
2005-05-31 18:49:19 +07:00
|
|
|
}
|
|
|
|
tmp = child->thread.dsp.dspcontrol;
|
|
|
|
break;
|
2005-04-17 05:20:36 +07:00
|
|
|
default:
|
|
|
|
tmp = 0;
|
|
|
|
ret = -EIO;
|
2005-11-07 15:59:47 +07:00
|
|
|
goto out;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
2010-10-28 05:33:58 +07:00
|
|
|
ret = put_user(tmp, datalp);
|
2005-04-17 05:20:36 +07:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* when I and D space are separate, this will have to be fixed. */
|
|
|
|
case PTRACE_POKETEXT: /* write the word at location addr. */
|
|
|
|
case PTRACE_POKEDATA:
|
2007-07-17 18:03:44 +07:00
|
|
|
ret = generic_ptrace_pokedata(child, addr, data);
|
2005-04-17 05:20:36 +07:00
|
|
|
break;
|
|
|
|
|
|
|
|
case PTRACE_POKEUSR: {
|
|
|
|
struct pt_regs *regs;
|
|
|
|
ret = 0;
|
2006-01-12 16:06:07 +07:00
|
|
|
regs = task_pt_regs(child);
|
2005-04-17 05:20:36 +07:00
|
|
|
|
|
|
|
switch (addr) {
|
|
|
|
case 0 ... 31:
|
|
|
|
regs->regs[addr] = data;
|
2017-08-12 03:56:52 +07:00
|
|
|
/* System call number may have been changed */
|
|
|
|
if (addr == 2)
|
|
|
|
mips_syscall_update_nr(child, regs);
|
|
|
|
else if (addr == 4 &&
|
|
|
|
mips_syscall_is_indirect(child, regs))
|
|
|
|
mips_syscall_update_nr(child, regs);
|
2005-04-17 05:20:36 +07:00
|
|
|
break;
|
2018-11-08 06:14:07 +07:00
|
|
|
#ifdef CONFIG_MIPS_FP_SUPPORT
|
2005-04-17 05:20:36 +07:00
|
|
|
case FPR_BASE ... FPR_BASE + 31: {
|
2014-02-13 18:26:41 +07:00
|
|
|
union fpureg *fregs = get_fpu_regs(child);
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2015-01-30 19:09:36 +07:00
|
|
|
init_fp_ctx(child);
|
2005-09-04 05:56:16 +07:00
|
|
|
#ifdef CONFIG_32BIT
|
2018-05-14 22:49:43 +07:00
|
|
|
if (test_tsk_thread_flag(child, TIF_32BIT_FPREGS)) {
|
2013-11-22 20:12:07 +07:00
|
|
|
/*
|
|
|
|
* The odd registers are actually the high
|
|
|
|
* order bits of the values stored in the even
|
2018-05-16 05:03:09 +07:00
|
|
|
* registers.
|
2013-11-22 20:12:07 +07:00
|
|
|
*/
|
2014-02-13 18:26:41 +07:00
|
|
|
set_fpr32(&fregs[(addr & ~1) - FPR_BASE],
|
|
|
|
addr & 1, data);
|
2013-11-22 20:12:07 +07:00
|
|
|
break;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
#endif
|
2014-02-13 18:26:41 +07:00
|
|
|
set_fpr64(&fregs[addr - FPR_BASE], 0, data);
|
2005-04-17 05:20:36 +07:00
|
|
|
break;
|
|
|
|
}
|
2018-11-08 06:14:07 +07:00
|
|
|
case FPC_CSR:
|
|
|
|
init_fp_ctx(child);
|
|
|
|
ptrace_setfcr31(child, data);
|
|
|
|
break;
|
|
|
|
#endif
|
2005-04-17 05:20:36 +07:00
|
|
|
case PC:
|
|
|
|
regs->cp0_epc = data;
|
|
|
|
break;
|
|
|
|
case MMHI:
|
|
|
|
regs->hi = data;
|
|
|
|
break;
|
|
|
|
case MMLO:
|
|
|
|
regs->lo = data;
|
|
|
|
break;
|
2007-02-02 23:41:47 +07:00
|
|
|
#ifdef CONFIG_CPU_HAS_SMARTMIPS
|
|
|
|
case ACX:
|
|
|
|
regs->acx = data;
|
|
|
|
break;
|
|
|
|
#endif
|
2005-06-30 16:42:00 +07:00
|
|
|
case DSP_BASE ... DSP_BASE + 5: {
|
|
|
|
dspreg_t *dregs;
|
|
|
|
|
2005-05-31 18:49:19 +07:00
|
|
|
if (!cpu_has_dsp) {
|
|
|
|
ret = -EIO;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2005-06-30 16:42:00 +07:00
|
|
|
dregs = __get_dsp_regs(child);
|
2005-05-31 18:49:19 +07:00
|
|
|
dregs[addr - DSP_BASE] = data;
|
|
|
|
break;
|
2005-06-30 16:42:00 +07:00
|
|
|
}
|
2005-05-31 18:49:19 +07:00
|
|
|
case DSP_CONTROL:
|
|
|
|
if (!cpu_has_dsp) {
|
|
|
|
ret = -EIO;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
child->thread.dsp.dspcontrol = data;
|
|
|
|
break;
|
2005-04-17 05:20:36 +07:00
|
|
|
default:
|
|
|
|
/* The rest are not allowed. */
|
|
|
|
ret = -EIO;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2005-09-29 05:11:15 +07:00
|
|
|
case PTRACE_GETREGS:
|
2010-10-28 05:33:58 +07:00
|
|
|
ret = ptrace_getregs(child, datavp);
|
2005-09-29 05:11:15 +07:00
|
|
|
break;
|
|
|
|
|
|
|
|
case PTRACE_SETREGS:
|
2010-10-28 05:33:58 +07:00
|
|
|
ret = ptrace_setregs(child, datavp);
|
2005-09-29 05:11:15 +07:00
|
|
|
break;
|
|
|
|
|
2018-11-08 06:14:07 +07:00
|
|
|
#ifdef CONFIG_MIPS_FP_SUPPORT
|
2005-09-29 05:11:15 +07:00
|
|
|
case PTRACE_GETFPREGS:
|
2010-10-28 05:33:58 +07:00
|
|
|
ret = ptrace_getfpregs(child, datavp);
|
2005-09-29 05:11:15 +07:00
|
|
|
break;
|
|
|
|
|
|
|
|
case PTRACE_SETFPREGS:
|
2010-10-28 05:33:58 +07:00
|
|
|
ret = ptrace_setfpregs(child, datavp);
|
2005-09-29 05:11:15 +07:00
|
|
|
break;
|
2018-11-08 06:14:07 +07:00
|
|
|
#endif
|
2005-04-14 00:43:59 +07:00
|
|
|
case PTRACE_GET_THREAD_AREA:
|
2010-10-28 05:33:58 +07:00
|
|
|
ret = put_user(task_thread_info(child)->tp_value, datalp);
|
2005-04-14 00:43:59 +07:00
|
|
|
break;
|
|
|
|
|
2008-09-23 14:11:26 +07:00
|
|
|
case PTRACE_GET_WATCH_REGS:
|
2010-10-28 05:33:58 +07:00
|
|
|
ret = ptrace_get_watch_regs(child, addrp);
|
2008-09-23 14:11:26 +07:00
|
|
|
break;
|
|
|
|
|
|
|
|
case PTRACE_SET_WATCH_REGS:
|
2010-10-28 05:33:58 +07:00
|
|
|
ret = ptrace_set_watch_regs(child, addrp);
|
2008-09-23 14:11:26 +07:00
|
|
|
break;
|
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
default:
|
|
|
|
ret = ptrace_request(child, request, addr, data);
|
|
|
|
break;
|
|
|
|
}
|
2005-11-07 15:59:47 +07:00
|
|
|
out:
|
2005-04-17 05:20:36 +07:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Notification of system call entry/exit
|
|
|
|
* - triggered by current->work.syscall_trace
|
|
|
|
*/
|
2014-01-22 21:40:03 +07:00
|
|
|
asmlinkage long syscall_trace_enter(struct pt_regs *regs, long syscall)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2013-05-29 06:07:19 +07:00
|
|
|
user_exit();
|
|
|
|
|
2015-02-03 23:08:17 +07:00
|
|
|
current_thread_info()->syscall = syscall;
|
|
|
|
|
2017-08-12 03:56:51 +07:00
|
|
|
if (test_thread_flag(TIF_SYSCALL_TRACE)) {
|
|
|
|
if (tracehook_report_syscall_entry(regs))
|
|
|
|
return -1;
|
|
|
|
syscall = current_thread_info()->syscall;
|
|
|
|
}
|
2016-06-03 02:33:44 +07:00
|
|
|
|
2017-06-14 05:28:47 +07:00
|
|
|
#ifdef CONFIG_SECCOMP
|
|
|
|
if (unlikely(test_thread_flag(TIF_SECCOMP))) {
|
|
|
|
int ret, i;
|
|
|
|
struct seccomp_data sd;
|
2017-08-12 03:56:50 +07:00
|
|
|
unsigned long args[6];
|
2017-06-14 05:28:47 +07:00
|
|
|
|
|
|
|
sd.nr = syscall;
|
2019-03-18 06:30:18 +07:00
|
|
|
sd.arch = syscall_get_arch(current);
|
2016-11-08 04:26:37 +07:00
|
|
|
syscall_get_arguments(current, regs, args);
|
2017-08-12 03:56:50 +07:00
|
|
|
for (i = 0; i < 6; i++)
|
|
|
|
sd.args[i] = args[i];
|
2017-06-14 05:28:47 +07:00
|
|
|
sd.instruction_pointer = KSTK_EIP(current);
|
|
|
|
|
|
|
|
ret = __secure_computing(&sd);
|
|
|
|
if (ret == -1)
|
|
|
|
return ret;
|
2017-08-12 03:56:51 +07:00
|
|
|
syscall = current_thread_info()->syscall;
|
2017-06-14 05:28:47 +07:00
|
|
|
}
|
|
|
|
#endif
|
2007-07-25 22:19:33 +07:00
|
|
|
|
2013-09-07 01:24:48 +07:00
|
|
|
if (unlikely(test_thread_flag(TIF_SYSCALL_TRACEPOINT)))
|
|
|
|
trace_sys_enter(regs, regs->regs[2]);
|
|
|
|
|
2014-03-12 00:29:28 +07:00
|
|
|
audit_syscall_entry(syscall, regs->regs[4], regs->regs[5],
|
2012-01-04 02:23:06 +07:00
|
|
|
regs->regs[6], regs->regs[7]);
|
2017-06-29 16:12:36 +07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Negative syscall numbers are mistaken for rejected syscalls, but
|
|
|
|
* won't have had the return value set appropriately, so we do so now.
|
|
|
|
*/
|
|
|
|
if (syscall < 0)
|
|
|
|
syscall_set_return_value(current, regs, -ENOSYS, 0);
|
2014-01-22 21:40:01 +07:00
|
|
|
return syscall;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
2011-05-19 15:21:29 +07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Notification of system call entry/exit
|
|
|
|
* - triggered by current->work.syscall_trace
|
|
|
|
*/
|
|
|
|
asmlinkage void syscall_trace_leave(struct pt_regs *regs)
|
|
|
|
{
|
2013-05-29 06:07:19 +07:00
|
|
|
/*
|
|
|
|
* We may come here right after calling schedule_user()
|
|
|
|
* or do_notify_resume(), in which case we can be in RCU
|
|
|
|
* user mode.
|
|
|
|
*/
|
|
|
|
user_exit();
|
|
|
|
|
2012-01-04 02:23:06 +07:00
|
|
|
audit_syscall_exit(regs);
|
2011-05-19 15:21:29 +07:00
|
|
|
|
2013-09-07 01:24:48 +07:00
|
|
|
if (unlikely(test_thread_flag(TIF_SYSCALL_TRACEPOINT)))
|
2017-06-29 16:12:34 +07:00
|
|
|
trace_sys_exit(regs, regs_return_value(regs));
|
2013-09-07 01:24:48 +07:00
|
|
|
|
2012-07-18 00:43:58 +07:00
|
|
|
if (test_thread_flag(TIF_SYSCALL_TRACE))
|
|
|
|
tracehook_report_syscall_exit(regs, 0);
|
2013-05-29 06:07:19 +07:00
|
|
|
|
|
|
|
user_enter();
|
2011-05-19 15:21:29 +07:00
|
|
|
}
|