2013-09-12 04:25:43 +07:00
|
|
|
/* Copyright (c) 2013 Coraid, Inc. See COPYING for GPL terms. */
|
2005-04-17 05:20:36 +07:00
|
|
|
/*
|
|
|
|
* aoeblk.c
|
|
|
|
* block device routines
|
|
|
|
*/
|
|
|
|
|
2010-10-28 19:15:26 +07:00
|
|
|
#include <linux/kernel.h>
|
2005-04-17 05:20:36 +07:00
|
|
|
#include <linux/hdreg.h>
|
2018-10-12 23:03:14 +07:00
|
|
|
#include <linux/blk-mq.h>
|
2007-12-11 06:49:13 +07:00
|
|
|
#include <linux/backing-dev.h>
|
2005-04-17 05:20:36 +07:00
|
|
|
#include <linux/fs.h>
|
|
|
|
#include <linux/ioctl.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 15:04:11 +07:00
|
|
|
#include <linux/slab.h>
|
2010-10-28 19:15:26 +07:00
|
|
|
#include <linux/ratelimit.h>
|
2005-04-17 05:20:36 +07:00
|
|
|
#include <linux/genhd.h>
|
|
|
|
#include <linux/netdevice.h>
|
2010-06-02 19:28:52 +07:00
|
|
|
#include <linux/mutex.h>
|
2011-05-27 03:00:52 +07:00
|
|
|
#include <linux/export.h>
|
2012-12-18 07:03:32 +07:00
|
|
|
#include <linux/moduleparam.h>
|
2013-09-12 04:25:39 +07:00
|
|
|
#include <linux/debugfs.h>
|
2012-12-18 07:03:42 +07:00
|
|
|
#include <scsi/sg.h>
|
2005-04-17 05:20:36 +07:00
|
|
|
#include "aoe.h"
|
|
|
|
|
2010-06-02 19:28:52 +07:00
|
|
|
static DEFINE_MUTEX(aoeblk_mutex);
|
2006-12-07 11:33:20 +07:00
|
|
|
static struct kmem_cache *buf_pool_cache;
|
2013-09-12 04:25:39 +07:00
|
|
|
static struct dentry *aoe_debugfs_dir;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2012-12-18 07:03:32 +07:00
|
|
|
/* GPFS needs a larger value than the default. */
|
|
|
|
static int aoe_maxsectors;
|
|
|
|
module_param(aoe_maxsectors, int, 0644);
|
|
|
|
MODULE_PARM_DESC(aoe_maxsectors,
|
|
|
|
"When nonzero, set the maximum number of sectors per I/O request");
|
|
|
|
|
2007-05-22 03:08:01 +07:00
|
|
|
static ssize_t aoedisk_show_state(struct device *dev,
|
|
|
|
struct device_attribute *attr, char *page)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2007-05-22 03:08:01 +07:00
|
|
|
struct gendisk *disk = dev_to_disk(dev);
|
2005-04-17 05:20:36 +07:00
|
|
|
struct aoedev *d = disk->private_data;
|
|
|
|
|
|
|
|
return snprintf(page, PAGE_SIZE,
|
|
|
|
"%s%s\n",
|
|
|
|
(d->flags & DEVFL_UP) ? "up" : "down",
|
aoe: handle multiple network paths to AoE device
A remote AoE device is something can process ATA commands and is identified by
an AoE shelf number and an AoE slot number. Such a device might have more
than one network interface, and it might be reachable by more than one local
network interface. This patch tracks the available network paths available to
each AoE device, allowing them to be used more efficiently.
Andrew Morton asked about the call to msleep_interruptible in the revalidate
function. Yes, if a signal is pending, then msleep_interruptible will not
return 0. That means we will not loop but will call aoenet_xmit with a NULL
skb, which is a noop. If the system is too low on memory or the aoe driver is
too low on frames, then the user can hit control-C to interrupt the attempt to
do a revalidate. I have added a comment to the code summarizing that.
Andrew Morton asked whether the allocation performed inside addtgt could use a
more relaxed allocation like GFP_KERNEL, but addtgt is called when the aoedev
lock has been locked with spin_lock_irqsave. It would be nice to allocate the
memory under fewer restrictions, but targets are only added when the device is
being discovered, and if the target can't be added right now, we can try again
in a minute when then next AoE config query broadcast goes out.
Andrew Morton pointed out that the "too many targets" message could be printed
for failing GFP_ATOMIC allocations. The last patch in this series makes the
messages more specific.
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 19:20:00 +07:00
|
|
|
(d->flags & DEVFL_KICKME) ? ",kickme" :
|
2006-01-20 01:46:19 +07:00
|
|
|
(d->nopen && !(d->flags & DEVFL_UP)) ? ",closewait" : "");
|
|
|
|
/* I'd rather see nopen exported so we can ditch closewait */
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
2007-05-22 03:08:01 +07:00
|
|
|
static ssize_t aoedisk_show_mac(struct device *dev,
|
|
|
|
struct device_attribute *attr, char *page)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2007-05-22 03:08:01 +07:00
|
|
|
struct gendisk *disk = dev_to_disk(dev);
|
2005-04-17 05:20:36 +07:00
|
|
|
struct aoedev *d = disk->private_data;
|
aoe: handle multiple network paths to AoE device
A remote AoE device is something can process ATA commands and is identified by
an AoE shelf number and an AoE slot number. Such a device might have more
than one network interface, and it might be reachable by more than one local
network interface. This patch tracks the available network paths available to
each AoE device, allowing them to be used more efficiently.
Andrew Morton asked about the call to msleep_interruptible in the revalidate
function. Yes, if a signal is pending, then msleep_interruptible will not
return 0. That means we will not loop but will call aoenet_xmit with a NULL
skb, which is a noop. If the system is too low on memory or the aoe driver is
too low on frames, then the user can hit control-C to interrupt the attempt to
do a revalidate. I have added a comment to the code summarizing that.
Andrew Morton asked whether the allocation performed inside addtgt could use a
more relaxed allocation like GFP_KERNEL, but addtgt is called when the aoedev
lock has been locked with spin_lock_irqsave. It would be nice to allocate the
memory under fewer restrictions, but targets are only added when the device is
being discovered, and if the target can't be added right now, we can try again
in a minute when then next AoE config query broadcast goes out.
Andrew Morton pointed out that the "too many targets" message could be printed
for failing GFP_ATOMIC allocations. The last patch in this series makes the
messages more specific.
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 19:20:00 +07:00
|
|
|
struct aoetgt *t = d->targets[0];
|
2005-04-17 05:20:36 +07:00
|
|
|
|
aoe: handle multiple network paths to AoE device
A remote AoE device is something can process ATA commands and is identified by
an AoE shelf number and an AoE slot number. Such a device might have more
than one network interface, and it might be reachable by more than one local
network interface. This patch tracks the available network paths available to
each AoE device, allowing them to be used more efficiently.
Andrew Morton asked about the call to msleep_interruptible in the revalidate
function. Yes, if a signal is pending, then msleep_interruptible will not
return 0. That means we will not loop but will call aoenet_xmit with a NULL
skb, which is a noop. If the system is too low on memory or the aoe driver is
too low on frames, then the user can hit control-C to interrupt the attempt to
do a revalidate. I have added a comment to the code summarizing that.
Andrew Morton asked whether the allocation performed inside addtgt could use a
more relaxed allocation like GFP_KERNEL, but addtgt is called when the aoedev
lock has been locked with spin_lock_irqsave. It would be nice to allocate the
memory under fewer restrictions, but targets are only added when the device is
being discovered, and if the target can't be added right now, we can try again
in a minute when then next AoE config query broadcast goes out.
Andrew Morton pointed out that the "too many targets" message could be printed
for failing GFP_ATOMIC allocations. The last patch in this series makes the
messages more specific.
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 19:20:00 +07:00
|
|
|
if (t == NULL)
|
|
|
|
return snprintf(page, PAGE_SIZE, "none\n");
|
2008-11-25 15:40:37 +07:00
|
|
|
return snprintf(page, PAGE_SIZE, "%pm\n", t->addr);
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
2007-05-22 03:08:01 +07:00
|
|
|
static ssize_t aoedisk_show_netif(struct device *dev,
|
|
|
|
struct device_attribute *attr, char *page)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2007-05-22 03:08:01 +07:00
|
|
|
struct gendisk *disk = dev_to_disk(dev);
|
2005-04-17 05:20:36 +07:00
|
|
|
struct aoedev *d = disk->private_data;
|
aoe: handle multiple network paths to AoE device
A remote AoE device is something can process ATA commands and is identified by
an AoE shelf number and an AoE slot number. Such a device might have more
than one network interface, and it might be reachable by more than one local
network interface. This patch tracks the available network paths available to
each AoE device, allowing them to be used more efficiently.
Andrew Morton asked about the call to msleep_interruptible in the revalidate
function. Yes, if a signal is pending, then msleep_interruptible will not
return 0. That means we will not loop but will call aoenet_xmit with a NULL
skb, which is a noop. If the system is too low on memory or the aoe driver is
too low on frames, then the user can hit control-C to interrupt the attempt to
do a revalidate. I have added a comment to the code summarizing that.
Andrew Morton asked whether the allocation performed inside addtgt could use a
more relaxed allocation like GFP_KERNEL, but addtgt is called when the aoedev
lock has been locked with spin_lock_irqsave. It would be nice to allocate the
memory under fewer restrictions, but targets are only added when the device is
being discovered, and if the target can't be added right now, we can try again
in a minute when then next AoE config query broadcast goes out.
Andrew Morton pointed out that the "too many targets" message could be printed
for failing GFP_ATOMIC allocations. The last patch in this series makes the
messages more specific.
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 19:20:00 +07:00
|
|
|
struct net_device *nds[8], **nd, **nnd, **ne;
|
|
|
|
struct aoetgt **t, **te;
|
|
|
|
struct aoeif *ifp, *e;
|
|
|
|
char *p;
|
|
|
|
|
|
|
|
memset(nds, 0, sizeof nds);
|
|
|
|
nd = nds;
|
|
|
|
ne = nd + ARRAY_SIZE(nds);
|
|
|
|
t = d->targets;
|
2012-12-18 07:04:11 +07:00
|
|
|
te = t + d->ntargets;
|
aoe: handle multiple network paths to AoE device
A remote AoE device is something can process ATA commands and is identified by
an AoE shelf number and an AoE slot number. Such a device might have more
than one network interface, and it might be reachable by more than one local
network interface. This patch tracks the available network paths available to
each AoE device, allowing them to be used more efficiently.
Andrew Morton asked about the call to msleep_interruptible in the revalidate
function. Yes, if a signal is pending, then msleep_interruptible will not
return 0. That means we will not loop but will call aoenet_xmit with a NULL
skb, which is a noop. If the system is too low on memory or the aoe driver is
too low on frames, then the user can hit control-C to interrupt the attempt to
do a revalidate. I have added a comment to the code summarizing that.
Andrew Morton asked whether the allocation performed inside addtgt could use a
more relaxed allocation like GFP_KERNEL, but addtgt is called when the aoedev
lock has been locked with spin_lock_irqsave. It would be nice to allocate the
memory under fewer restrictions, but targets are only added when the device is
being discovered, and if the target can't be added right now, we can try again
in a minute when then next AoE config query broadcast goes out.
Andrew Morton pointed out that the "too many targets" message could be printed
for failing GFP_ATOMIC allocations. The last patch in this series makes the
messages more specific.
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 19:20:00 +07:00
|
|
|
for (; t < te && *t; t++) {
|
|
|
|
ifp = (*t)->ifs;
|
|
|
|
e = ifp + NAOEIFS;
|
|
|
|
for (; ifp < e && ifp->nd; ifp++) {
|
|
|
|
for (nnd = nds; nnd < nd; nnd++)
|
|
|
|
if (*nnd == ifp->nd)
|
|
|
|
break;
|
|
|
|
if (nnd == nd && nd != ne)
|
|
|
|
*nd++ = ifp->nd;
|
|
|
|
}
|
|
|
|
}
|
2005-04-17 05:20:36 +07:00
|
|
|
|
aoe: handle multiple network paths to AoE device
A remote AoE device is something can process ATA commands and is identified by
an AoE shelf number and an AoE slot number. Such a device might have more
than one network interface, and it might be reachable by more than one local
network interface. This patch tracks the available network paths available to
each AoE device, allowing them to be used more efficiently.
Andrew Morton asked about the call to msleep_interruptible in the revalidate
function. Yes, if a signal is pending, then msleep_interruptible will not
return 0. That means we will not loop but will call aoenet_xmit with a NULL
skb, which is a noop. If the system is too low on memory or the aoe driver is
too low on frames, then the user can hit control-C to interrupt the attempt to
do a revalidate. I have added a comment to the code summarizing that.
Andrew Morton asked whether the allocation performed inside addtgt could use a
more relaxed allocation like GFP_KERNEL, but addtgt is called when the aoedev
lock has been locked with spin_lock_irqsave. It would be nice to allocate the
memory under fewer restrictions, but targets are only added when the device is
being discovered, and if the target can't be added right now, we can try again
in a minute when then next AoE config query broadcast goes out.
Andrew Morton pointed out that the "too many targets" message could be printed
for failing GFP_ATOMIC allocations. The last patch in this series makes the
messages more specific.
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 19:20:00 +07:00
|
|
|
ne = nd;
|
|
|
|
nd = nds;
|
|
|
|
if (*nd == NULL)
|
|
|
|
return snprintf(page, PAGE_SIZE, "none\n");
|
|
|
|
for (p = page; nd < ne; nd++)
|
|
|
|
p += snprintf(p, PAGE_SIZE - (p-page), "%s%s",
|
|
|
|
p == page ? "" : ",", (*nd)->name);
|
|
|
|
p += snprintf(p, PAGE_SIZE - (p-page), "\n");
|
|
|
|
return p-page;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
2005-04-29 21:24:25 +07:00
|
|
|
/* firmware version */
|
2007-05-22 03:08:01 +07:00
|
|
|
static ssize_t aoedisk_show_fwver(struct device *dev,
|
|
|
|
struct device_attribute *attr, char *page)
|
2005-04-29 21:24:25 +07:00
|
|
|
{
|
2007-05-22 03:08:01 +07:00
|
|
|
struct gendisk *disk = dev_to_disk(dev);
|
2005-04-29 21:24:25 +07:00
|
|
|
struct aoedev *d = disk->private_data;
|
|
|
|
|
|
|
|
return snprintf(page, PAGE_SIZE, "0x%04x\n", (unsigned int) d->fw_ver);
|
|
|
|
}
|
2012-12-18 07:03:34 +07:00
|
|
|
static ssize_t aoedisk_show_payload(struct device *dev,
|
|
|
|
struct device_attribute *attr, char *page)
|
|
|
|
{
|
|
|
|
struct gendisk *disk = dev_to_disk(dev);
|
|
|
|
struct aoedev *d = disk->private_data;
|
|
|
|
|
|
|
|
return snprintf(page, PAGE_SIZE, "%lu\n", d->maxbcnt);
|
|
|
|
}
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2013-09-12 04:25:41 +07:00
|
|
|
static int aoedisk_debugfs_show(struct seq_file *s, void *ignored)
|
|
|
|
{
|
|
|
|
struct aoedev *d;
|
2013-09-12 04:25:42 +07:00
|
|
|
struct aoetgt **t, **te;
|
|
|
|
struct aoeif *ifp, *ife;
|
2013-09-12 04:25:41 +07:00
|
|
|
unsigned long flags;
|
2013-09-12 04:25:42 +07:00
|
|
|
char c;
|
2013-09-12 04:25:41 +07:00
|
|
|
|
|
|
|
d = s->private;
|
2013-09-12 04:25:42 +07:00
|
|
|
seq_printf(s, "rttavg: %d rttdev: %d\n",
|
|
|
|
d->rttavg >> RTTSCALE,
|
|
|
|
d->rttdev >> RTTDSCALE);
|
|
|
|
seq_printf(s, "nskbpool: %d\n", skb_queue_len(&d->skbpool));
|
|
|
|
seq_printf(s, "kicked: %ld\n", d->kicked);
|
|
|
|
seq_printf(s, "maxbcnt: %ld\n", d->maxbcnt);
|
|
|
|
seq_printf(s, "ref: %ld\n", d->ref);
|
|
|
|
|
2013-09-12 04:25:41 +07:00
|
|
|
spin_lock_irqsave(&d->lock, flags);
|
2013-09-12 04:25:42 +07:00
|
|
|
t = d->targets;
|
|
|
|
te = t + d->ntargets;
|
|
|
|
for (; t < te && *t; t++) {
|
|
|
|
c = '\t';
|
|
|
|
seq_printf(s, "falloc: %ld\n", (*t)->falloc);
|
|
|
|
seq_printf(s, "ffree: %p\n",
|
|
|
|
list_empty(&(*t)->ffree) ? NULL : (*t)->ffree.next);
|
|
|
|
seq_printf(s, "%pm:%d:%d:%d\n", (*t)->addr, (*t)->nout,
|
|
|
|
(*t)->maxout, (*t)->nframes);
|
|
|
|
seq_printf(s, "\tssthresh:%d\n", (*t)->ssthresh);
|
|
|
|
seq_printf(s, "\ttaint:%d\n", (*t)->taint);
|
|
|
|
seq_printf(s, "\tr:%d\n", (*t)->rpkts);
|
|
|
|
seq_printf(s, "\tw:%d\n", (*t)->wpkts);
|
|
|
|
ifp = (*t)->ifs;
|
|
|
|
ife = ifp + ARRAY_SIZE((*t)->ifs);
|
|
|
|
for (; ifp->nd && ifp < ife; ifp++) {
|
|
|
|
seq_printf(s, "%c%s", c, ifp->nd->name);
|
|
|
|
c = ',';
|
|
|
|
}
|
|
|
|
seq_puts(s, "\n");
|
|
|
|
}
|
2013-09-12 04:25:41 +07:00
|
|
|
spin_unlock_irqrestore(&d->lock, flags);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int aoe_debugfs_open(struct inode *inode, struct file *file)
|
|
|
|
{
|
|
|
|
return single_open(file, aoedisk_debugfs_show, inode->i_private);
|
|
|
|
}
|
|
|
|
|
2018-05-25 02:38:59 +07:00
|
|
|
static DEVICE_ATTR(state, 0444, aoedisk_show_state, NULL);
|
|
|
|
static DEVICE_ATTR(mac, 0444, aoedisk_show_mac, NULL);
|
|
|
|
static DEVICE_ATTR(netif, 0444, aoedisk_show_netif, NULL);
|
2007-05-22 03:08:01 +07:00
|
|
|
static struct device_attribute dev_attr_firmware_version = {
|
2018-05-25 02:38:59 +07:00
|
|
|
.attr = { .name = "firmware-version", .mode = 0444 },
|
2007-05-22 03:08:01 +07:00
|
|
|
.show = aoedisk_show_fwver,
|
2005-04-29 21:24:25 +07:00
|
|
|
};
|
2018-05-25 02:38:59 +07:00
|
|
|
static DEVICE_ATTR(payload, 0444, aoedisk_show_payload, NULL);
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2002-04-10 02:14:34 +07:00
|
|
|
static struct attribute *aoe_attrs[] = {
|
2007-05-22 03:08:01 +07:00
|
|
|
&dev_attr_state.attr,
|
|
|
|
&dev_attr_mac.attr,
|
|
|
|
&dev_attr_netif.attr,
|
|
|
|
&dev_attr_firmware_version.attr,
|
2012-12-18 07:03:34 +07:00
|
|
|
&dev_attr_payload.attr,
|
2007-05-22 03:08:01 +07:00
|
|
|
NULL,
|
2002-04-10 02:14:34 +07:00
|
|
|
};
|
|
|
|
|
2018-09-28 13:17:21 +07:00
|
|
|
static const struct attribute_group aoe_attr_group = {
|
2002-04-10 02:14:34 +07:00
|
|
|
.attrs = aoe_attrs,
|
|
|
|
};
|
|
|
|
|
2018-09-28 13:17:21 +07:00
|
|
|
static const struct attribute_group *aoe_attr_groups[] = {
|
|
|
|
&aoe_attr_group,
|
|
|
|
NULL,
|
|
|
|
};
|
|
|
|
|
2013-09-12 04:25:41 +07:00
|
|
|
static const struct file_operations aoe_debugfs_fops = {
|
|
|
|
.open = aoe_debugfs_open,
|
|
|
|
.read = seq_read,
|
|
|
|
.llseek = seq_lseek,
|
|
|
|
.release = single_release,
|
|
|
|
};
|
2013-09-12 04:25:40 +07:00
|
|
|
|
|
|
|
static void
|
|
|
|
aoedisk_add_debugfs(struct aoedev *d)
|
|
|
|
{
|
|
|
|
char *p;
|
|
|
|
|
|
|
|
if (aoe_debugfs_dir == NULL)
|
|
|
|
return;
|
|
|
|
p = strchr(d->gd->disk_name, '/');
|
|
|
|
if (p == NULL)
|
|
|
|
p = d->gd->disk_name;
|
|
|
|
else
|
|
|
|
p++;
|
|
|
|
BUG_ON(*p == '\0');
|
2019-06-04 02:47:54 +07:00
|
|
|
d->debugfs = debugfs_create_file(p, 0444, aoe_debugfs_dir, d,
|
|
|
|
&aoe_debugfs_fops);
|
2013-09-12 04:25:40 +07:00
|
|
|
}
|
|
|
|
void
|
|
|
|
aoedisk_rm_debugfs(struct aoedev *d)
|
|
|
|
{
|
|
|
|
debugfs_remove(d->debugfs);
|
|
|
|
d->debugfs = NULL;
|
|
|
|
}
|
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
static int
|
2008-03-02 21:23:18 +07:00
|
|
|
aoeblk_open(struct block_device *bdev, fmode_t mode)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2008-03-02 21:23:18 +07:00
|
|
|
struct aoedev *d = bdev->bd_disk->private_data;
|
2005-04-17 05:20:36 +07:00
|
|
|
ulong flags;
|
|
|
|
|
aoe: avoid races between device destruction and discovery
This change avoids a race that could result in a NULL pointer derference
following a WARNing from kobject_add_internal, "don't try to register
things with the same name in the same directory."
The problem was found with a test that forgets and discovers an
aoe device in a loop:
while test ! -r /tmp/stop; do
aoe-flush -a
aoe-discover
done
The race was between aoedev_flush taking aoedevs out of the devlist,
allowing a new discovery of the same AoE target to take place before the
driver gets around to calling sysfs_remove_group. Fixing that one
revealed another race between do_open and add_disk, and this patch avoids
that, too.
The fix required some care, because for flushing (forgetting) an aoedev,
some of the steps must be performed under lock and some must be able to
sleep. Also, for discovering a new aoedev, some steps might sleep.
The check for a bad aoedev pointer remains from a time when about half of
this patch was done, and it was possible for the
bdev->bd_disk->private_data to become corrupted. The check should be
removed eventually, but it is not expected to add significant overhead,
occurring in the aoeblk_open routine.
Signed-off-by: Ed Cashin <ecashin@coraid.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2012-12-18 07:04:09 +07:00
|
|
|
if (!virt_addr_valid(d)) {
|
|
|
|
pr_crit("aoe: invalid device pointer in %s\n",
|
|
|
|
__func__);
|
|
|
|
WARN_ON(1);
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
if (!(d->flags & DEVFL_UP) || d->flags & DEVFL_TKILL)
|
|
|
|
return -ENODEV;
|
|
|
|
|
2010-06-02 19:28:52 +07:00
|
|
|
mutex_lock(&aoeblk_mutex);
|
2005-04-17 05:20:36 +07:00
|
|
|
spin_lock_irqsave(&d->lock, flags);
|
aoe: avoid races between device destruction and discovery
This change avoids a race that could result in a NULL pointer derference
following a WARNing from kobject_add_internal, "don't try to register
things with the same name in the same directory."
The problem was found with a test that forgets and discovers an
aoe device in a loop:
while test ! -r /tmp/stop; do
aoe-flush -a
aoe-discover
done
The race was between aoedev_flush taking aoedevs out of the devlist,
allowing a new discovery of the same AoE target to take place before the
driver gets around to calling sysfs_remove_group. Fixing that one
revealed another race between do_open and add_disk, and this patch avoids
that, too.
The fix required some care, because for flushing (forgetting) an aoedev,
some of the steps must be performed under lock and some must be able to
sleep. Also, for discovering a new aoedev, some steps might sleep.
The check for a bad aoedev pointer remains from a time when about half of
this patch was done, and it was possible for the
bdev->bd_disk->private_data to become corrupted. The check should be
removed eventually, but it is not expected to add significant overhead,
occurring in the aoeblk_open routine.
Signed-off-by: Ed Cashin <ecashin@coraid.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2012-12-18 07:04:09 +07:00
|
|
|
if (d->flags & DEVFL_UP && !(d->flags & DEVFL_TKILL)) {
|
2005-04-17 05:20:36 +07:00
|
|
|
d->nopen++;
|
|
|
|
spin_unlock_irqrestore(&d->lock, flags);
|
2010-06-02 19:28:52 +07:00
|
|
|
mutex_unlock(&aoeblk_mutex);
|
2005-04-17 05:20:36 +07:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
spin_unlock_irqrestore(&d->lock, flags);
|
2010-06-02 19:28:52 +07:00
|
|
|
mutex_unlock(&aoeblk_mutex);
|
2005-04-17 05:20:36 +07:00
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
2013-05-06 08:52:57 +07:00
|
|
|
static void
|
2008-03-02 21:23:18 +07:00
|
|
|
aoeblk_release(struct gendisk *disk, fmode_t mode)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2008-03-02 21:23:18 +07:00
|
|
|
struct aoedev *d = disk->private_data;
|
2005-04-17 05:20:36 +07:00
|
|
|
ulong flags;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&d->lock, flags);
|
|
|
|
|
2006-01-20 01:46:27 +07:00
|
|
|
if (--d->nopen == 0) {
|
2005-04-17 05:20:36 +07:00
|
|
|
spin_unlock_irqrestore(&d->lock, flags);
|
|
|
|
aoecmd_cfg(d->aoemajor, d->aoeminor);
|
2013-05-06 08:52:57 +07:00
|
|
|
return;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
spin_unlock_irqrestore(&d->lock, flags);
|
|
|
|
}
|
|
|
|
|
2018-10-12 23:03:14 +07:00
|
|
|
static blk_status_t aoeblk_queue_rq(struct blk_mq_hw_ctx *hctx,
|
|
|
|
const struct blk_mq_queue_data *bd)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2018-10-12 23:03:14 +07:00
|
|
|
struct aoedev *d = hctx->queue->queuedata;
|
|
|
|
|
|
|
|
spin_lock_irq(&d->lock);
|
2005-04-17 05:20:36 +07:00
|
|
|
|
|
|
|
if ((d->flags & DEVFL_UP) == 0) {
|
2010-10-28 19:15:26 +07:00
|
|
|
pr_info_ratelimited("aoe: device %ld.%d is not up\n",
|
2006-09-21 01:36:51 +07:00
|
|
|
d->aoemajor, d->aoeminor);
|
2018-10-12 23:03:14 +07:00
|
|
|
spin_unlock_irq(&d->lock);
|
|
|
|
blk_mq_start_request(bd->rq);
|
|
|
|
return BLK_STS_IOERR;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
2018-10-12 23:03:14 +07:00
|
|
|
|
|
|
|
list_add_tail(&bd->rq->queuelist, &d->rq_list);
|
2006-01-20 01:46:19 +07:00
|
|
|
aoecmd_work(d);
|
2018-10-12 23:03:14 +07:00
|
|
|
spin_unlock_irq(&d->lock);
|
|
|
|
return BLK_STS_OK;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
2006-01-08 16:02:50 +07:00
|
|
|
aoeblk_getgeo(struct block_device *bdev, struct hd_geometry *geo)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2006-01-08 16:02:50 +07:00
|
|
|
struct aoedev *d = bdev->bd_disk->private_data;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
|
|
|
if ((d->flags & DEVFL_UP) == 0) {
|
2006-09-21 01:36:51 +07:00
|
|
|
printk(KERN_ERR "aoe: disk not up\n");
|
2005-04-17 05:20:36 +07:00
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
2006-01-08 16:02:50 +07:00
|
|
|
geo->cylinders = d->geo.cylinders;
|
|
|
|
geo->heads = d->geo.heads;
|
|
|
|
geo->sectors = d->geo.sectors;
|
|
|
|
return 0;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
2012-12-18 07:03:42 +07:00
|
|
|
static int
|
|
|
|
aoeblk_ioctl(struct block_device *bdev, fmode_t mode, uint cmd, ulong arg)
|
|
|
|
{
|
|
|
|
struct aoedev *d;
|
|
|
|
|
|
|
|
if (!arg)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
d = bdev->bd_disk->private_data;
|
|
|
|
if ((d->flags & DEVFL_UP) == 0) {
|
|
|
|
pr_err("aoe: disk not up\n");
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (cmd == HDIO_GET_IDENTITY) {
|
|
|
|
if (!copy_to_user((void __user *) arg, &d->ident,
|
|
|
|
sizeof(d->ident)))
|
|
|
|
return 0;
|
|
|
|
return -EFAULT;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* udev calls scsi_id, which uses SG_IO, resulting in noise */
|
|
|
|
if (cmd != SG_IO)
|
|
|
|
pr_info("aoe: unknown ioctl 0x%x\n", cmd);
|
|
|
|
|
|
|
|
return -ENOTTY;
|
|
|
|
}
|
|
|
|
|
2009-09-22 07:01:13 +07:00
|
|
|
static const struct block_device_operations aoe_bdops = {
|
2008-03-02 21:23:18 +07:00
|
|
|
.open = aoeblk_open,
|
|
|
|
.release = aoeblk_release,
|
2012-12-18 07:03:42 +07:00
|
|
|
.ioctl = aoeblk_ioctl,
|
2006-01-08 16:02:50 +07:00
|
|
|
.getgeo = aoeblk_getgeo,
|
2005-04-17 05:20:36 +07:00
|
|
|
.owner = THIS_MODULE,
|
|
|
|
};
|
|
|
|
|
2018-10-12 23:03:14 +07:00
|
|
|
static const struct blk_mq_ops aoeblk_mq_ops = {
|
|
|
|
.queue_rq = aoeblk_queue_rq,
|
|
|
|
};
|
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
/* alloc_disk and add_disk can sleep */
|
|
|
|
void
|
|
|
|
aoeblk_gdalloc(void *vp)
|
|
|
|
{
|
|
|
|
struct aoedev *d = vp;
|
|
|
|
struct gendisk *gd;
|
2012-10-05 07:16:23 +07:00
|
|
|
mempool_t *mp;
|
|
|
|
struct request_queue *q;
|
2018-10-12 23:03:14 +07:00
|
|
|
struct blk_mq_tag_set *set;
|
2012-10-05 07:16:23 +07:00
|
|
|
enum { KB = 1024, MB = KB * KB, READ_AHEAD = 2 * MB, };
|
2005-04-17 05:20:36 +07:00
|
|
|
ulong flags;
|
aoe: avoid races between device destruction and discovery
This change avoids a race that could result in a NULL pointer derference
following a WARNing from kobject_add_internal, "don't try to register
things with the same name in the same directory."
The problem was found with a test that forgets and discovers an
aoe device in a loop:
while test ! -r /tmp/stop; do
aoe-flush -a
aoe-discover
done
The race was between aoedev_flush taking aoedevs out of the devlist,
allowing a new discovery of the same AoE target to take place before the
driver gets around to calling sysfs_remove_group. Fixing that one
revealed another race between do_open and add_disk, and this patch avoids
that, too.
The fix required some care, because for flushing (forgetting) an aoedev,
some of the steps must be performed under lock and some must be able to
sleep. Also, for discovering a new aoedev, some steps might sleep.
The check for a bad aoedev pointer remains from a time when about half of
this patch was done, and it was possible for the
bdev->bd_disk->private_data to become corrupted. The check should be
removed eventually, but it is not expected to add significant overhead,
occurring in the aoeblk_open routine.
Signed-off-by: Ed Cashin <ecashin@coraid.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2012-12-18 07:04:09 +07:00
|
|
|
int late = 0;
|
2018-10-12 23:03:14 +07:00
|
|
|
int err;
|
aoe: avoid races between device destruction and discovery
This change avoids a race that could result in a NULL pointer derference
following a WARNing from kobject_add_internal, "don't try to register
things with the same name in the same directory."
The problem was found with a test that forgets and discovers an
aoe device in a loop:
while test ! -r /tmp/stop; do
aoe-flush -a
aoe-discover
done
The race was between aoedev_flush taking aoedevs out of the devlist,
allowing a new discovery of the same AoE target to take place before the
driver gets around to calling sysfs_remove_group. Fixing that one
revealed another race between do_open and add_disk, and this patch avoids
that, too.
The fix required some care, because for flushing (forgetting) an aoedev,
some of the steps must be performed under lock and some must be able to
sleep. Also, for discovering a new aoedev, some steps might sleep.
The check for a bad aoedev pointer remains from a time when about half of
this patch was done, and it was possible for the
bdev->bd_disk->private_data to become corrupted. The check should be
removed eventually, but it is not expected to add significant overhead,
occurring in the aoeblk_open routine.
Signed-off-by: Ed Cashin <ecashin@coraid.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2012-12-18 07:04:09 +07:00
|
|
|
|
|
|
|
spin_lock_irqsave(&d->lock, flags);
|
|
|
|
if (d->flags & DEVFL_GDALLOC
|
|
|
|
&& !(d->flags & DEVFL_TKILL)
|
|
|
|
&& !(d->flags & DEVFL_GD_NOW))
|
|
|
|
d->flags |= DEVFL_GD_NOW;
|
|
|
|
else
|
|
|
|
late = 1;
|
|
|
|
spin_unlock_irqrestore(&d->lock, flags);
|
|
|
|
if (late)
|
|
|
|
return;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
|
|
|
gd = alloc_disk(AOE_PARTITIONS);
|
|
|
|
if (gd == NULL) {
|
2012-10-05 07:16:23 +07:00
|
|
|
pr_err("aoe: cannot allocate disk structure for %ld.%d\n",
|
2006-09-21 01:36:49 +07:00
|
|
|
d->aoemajor, d->aoeminor);
|
2007-12-11 06:49:13 +07:00
|
|
|
goto err;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
2012-10-05 07:16:23 +07:00
|
|
|
mp = mempool_create(MIN_BUFS, mempool_alloc_slab, mempool_free_slab,
|
|
|
|
buf_pool_cache);
|
|
|
|
if (mp == NULL) {
|
2008-02-08 19:20:08 +07:00
|
|
|
printk(KERN_ERR "aoe: cannot allocate bufpool for %ld.%d\n",
|
2006-09-21 01:36:49 +07:00
|
|
|
d->aoemajor, d->aoeminor);
|
2007-12-11 06:49:13 +07:00
|
|
|
goto err_disk;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
2018-10-12 23:03:14 +07:00
|
|
|
|
|
|
|
set = &d->tag_set;
|
|
|
|
set->ops = &aoeblk_mq_ops;
|
2018-11-10 15:30:47 +07:00
|
|
|
set->cmd_size = sizeof(struct aoe_req);
|
2018-10-12 23:03:14 +07:00
|
|
|
set->nr_hw_queues = 1;
|
|
|
|
set->queue_depth = 128;
|
|
|
|
set->numa_node = NUMA_NO_NODE;
|
|
|
|
set->flags = BLK_MQ_F_SHOULD_MERGE;
|
|
|
|
err = blk_mq_alloc_tag_set(set);
|
|
|
|
if (err) {
|
|
|
|
pr_err("aoe: cannot allocate tag set for %ld.%d\n",
|
|
|
|
d->aoemajor, d->aoeminor);
|
|
|
|
goto err_mempool;
|
|
|
|
}
|
|
|
|
|
|
|
|
q = blk_mq_init_queue(set);
|
|
|
|
if (IS_ERR(q)) {
|
2012-10-05 07:16:23 +07:00
|
|
|
pr_err("aoe: cannot allocate block queue for %ld.%d\n",
|
|
|
|
d->aoemajor, d->aoeminor);
|
2018-10-12 23:03:14 +07:00
|
|
|
blk_mq_free_tag_set(set);
|
2012-12-18 07:03:58 +07:00
|
|
|
goto err_mempool;
|
2012-10-05 07:16:23 +07:00
|
|
|
}
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2007-12-11 06:49:13 +07:00
|
|
|
spin_lock_irqsave(&d->lock, flags);
|
aoe: avoid races between device destruction and discovery
This change avoids a race that could result in a NULL pointer derference
following a WARNing from kobject_add_internal, "don't try to register
things with the same name in the same directory."
The problem was found with a test that forgets and discovers an
aoe device in a loop:
while test ! -r /tmp/stop; do
aoe-flush -a
aoe-discover
done
The race was between aoedev_flush taking aoedevs out of the devlist,
allowing a new discovery of the same AoE target to take place before the
driver gets around to calling sysfs_remove_group. Fixing that one
revealed another race between do_open and add_disk, and this patch avoids
that, too.
The fix required some care, because for flushing (forgetting) an aoedev,
some of the steps must be performed under lock and some must be able to
sleep. Also, for discovering a new aoedev, some steps might sleep.
The check for a bad aoedev pointer remains from a time when about half of
this patch was done, and it was possible for the
bdev->bd_disk->private_data to become corrupted. The check should be
removed eventually, but it is not expected to add significant overhead,
occurring in the aoeblk_open routine.
Signed-off-by: Ed Cashin <ecashin@coraid.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2012-12-18 07:04:09 +07:00
|
|
|
WARN_ON(!(d->flags & DEVFL_GD_NOW));
|
|
|
|
WARN_ON(!(d->flags & DEVFL_GDALLOC));
|
|
|
|
WARN_ON(d->flags & DEVFL_TKILL);
|
|
|
|
WARN_ON(d->gd);
|
|
|
|
WARN_ON(d->flags & DEVFL_UP);
|
2015-08-14 01:57:56 +07:00
|
|
|
blk_queue_max_hw_sectors(q, BLK_DEF_MAX_SECTORS);
|
2017-02-02 21:56:50 +07:00
|
|
|
q->backing_dev_info->name = "aoe";
|
|
|
|
q->backing_dev_info->ra_pages = READ_AHEAD / PAGE_SIZE;
|
2012-10-05 07:16:23 +07:00
|
|
|
d->bufpool = mp;
|
|
|
|
d->blkq = gd->queue = q;
|
|
|
|
q->queuedata = d;
|
|
|
|
d->gd = gd;
|
2012-12-18 07:03:32 +07:00
|
|
|
if (aoe_maxsectors)
|
|
|
|
blk_queue_max_hw_sectors(q, aoe_maxsectors);
|
2005-04-17 05:20:36 +07:00
|
|
|
gd->major = AOE_MAJOR;
|
2012-10-05 07:16:40 +07:00
|
|
|
gd->first_minor = d->sysminor;
|
2005-04-17 05:20:36 +07:00
|
|
|
gd->fops = &aoe_bdops;
|
|
|
|
gd->private_data = d;
|
2008-08-25 17:56:07 +07:00
|
|
|
set_capacity(gd, d->ssize);
|
aoe: handle multiple network paths to AoE device
A remote AoE device is something can process ATA commands and is identified by
an AoE shelf number and an AoE slot number. Such a device might have more
than one network interface, and it might be reachable by more than one local
network interface. This patch tracks the available network paths available to
each AoE device, allowing them to be used more efficiently.
Andrew Morton asked about the call to msleep_interruptible in the revalidate
function. Yes, if a signal is pending, then msleep_interruptible will not
return 0. That means we will not loop but will call aoenet_xmit with a NULL
skb, which is a noop. If the system is too low on memory or the aoe driver is
too low on frames, then the user can hit control-C to interrupt the attempt to
do a revalidate. I have added a comment to the code summarizing that.
Andrew Morton asked whether the allocation performed inside addtgt could use a
more relaxed allocation like GFP_KERNEL, but addtgt is called when the aoedev
lock has been locked with spin_lock_irqsave. It would be nice to allocate the
memory under fewer restrictions, but targets are only added when the device is
being discovered, and if the target can't be added right now, we can try again
in a minute when then next AoE config query broadcast goes out.
Andrew Morton pointed out that the "too many targets" message could be printed
for failing GFP_ATOMIC allocations. The last patch in this series makes the
messages more specific.
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 19:20:00 +07:00
|
|
|
snprintf(gd->disk_name, sizeof gd->disk_name, "etherd/e%ld.%d",
|
2005-04-17 05:20:36 +07:00
|
|
|
d->aoemajor, d->aoeminor);
|
|
|
|
|
2006-01-20 01:46:19 +07:00
|
|
|
d->flags &= ~DEVFL_GDALLOC;
|
2005-04-17 05:20:36 +07:00
|
|
|
d->flags |= DEVFL_UP;
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(&d->lock, flags);
|
|
|
|
|
2018-09-28 13:17:21 +07:00
|
|
|
device_add_disk(NULL, gd, aoe_attr_groups);
|
2013-09-12 04:25:40 +07:00
|
|
|
aoedisk_add_debugfs(d);
|
aoe: avoid races between device destruction and discovery
This change avoids a race that could result in a NULL pointer derference
following a WARNing from kobject_add_internal, "don't try to register
things with the same name in the same directory."
The problem was found with a test that forgets and discovers an
aoe device in a loop:
while test ! -r /tmp/stop; do
aoe-flush -a
aoe-discover
done
The race was between aoedev_flush taking aoedevs out of the devlist,
allowing a new discovery of the same AoE target to take place before the
driver gets around to calling sysfs_remove_group. Fixing that one
revealed another race between do_open and add_disk, and this patch avoids
that, too.
The fix required some care, because for flushing (forgetting) an aoedev,
some of the steps must be performed under lock and some must be able to
sleep. Also, for discovering a new aoedev, some steps might sleep.
The check for a bad aoedev pointer remains from a time when about half of
this patch was done, and it was possible for the
bdev->bd_disk->private_data to become corrupted. The check should be
removed eventually, but it is not expected to add significant overhead,
occurring in the aoeblk_open routine.
Signed-off-by: Ed Cashin <ecashin@coraid.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2012-12-18 07:04:09 +07:00
|
|
|
|
|
|
|
spin_lock_irqsave(&d->lock, flags);
|
|
|
|
WARN_ON(!(d->flags & DEVFL_GD_NOW));
|
|
|
|
d->flags &= ~DEVFL_GD_NOW;
|
|
|
|
spin_unlock_irqrestore(&d->lock, flags);
|
2007-12-11 06:49:13 +07:00
|
|
|
return;
|
|
|
|
|
|
|
|
err_mempool:
|
2012-12-18 07:03:58 +07:00
|
|
|
mempool_destroy(mp);
|
2007-12-11 06:49:13 +07:00
|
|
|
err_disk:
|
|
|
|
put_disk(gd);
|
|
|
|
err:
|
|
|
|
spin_lock_irqsave(&d->lock, flags);
|
aoe: avoid races between device destruction and discovery
This change avoids a race that could result in a NULL pointer derference
following a WARNing from kobject_add_internal, "don't try to register
things with the same name in the same directory."
The problem was found with a test that forgets and discovers an
aoe device in a loop:
while test ! -r /tmp/stop; do
aoe-flush -a
aoe-discover
done
The race was between aoedev_flush taking aoedevs out of the devlist,
allowing a new discovery of the same AoE target to take place before the
driver gets around to calling sysfs_remove_group. Fixing that one
revealed another race between do_open and add_disk, and this patch avoids
that, too.
The fix required some care, because for flushing (forgetting) an aoedev,
some of the steps must be performed under lock and some must be able to
sleep. Also, for discovering a new aoedev, some steps might sleep.
The check for a bad aoedev pointer remains from a time when about half of
this patch was done, and it was possible for the
bdev->bd_disk->private_data to become corrupted. The check should be
removed eventually, but it is not expected to add significant overhead,
occurring in the aoeblk_open routine.
Signed-off-by: Ed Cashin <ecashin@coraid.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2012-12-18 07:04:09 +07:00
|
|
|
d->flags &= ~DEVFL_GD_NOW;
|
|
|
|
schedule_work(&d->work);
|
2007-12-11 06:49:13 +07:00
|
|
|
spin_unlock_irqrestore(&d->lock, flags);
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
aoeblk_exit(void)
|
|
|
|
{
|
2013-09-12 04:25:39 +07:00
|
|
|
debugfs_remove_recursive(aoe_debugfs_dir);
|
|
|
|
aoe_debugfs_dir = NULL;
|
2005-04-17 05:20:36 +07:00
|
|
|
kmem_cache_destroy(buf_pool_cache);
|
|
|
|
}
|
|
|
|
|
|
|
|
int __init
|
|
|
|
aoeblk_init(void)
|
|
|
|
{
|
2007-07-20 08:11:58 +07:00
|
|
|
buf_pool_cache = kmem_cache_create("aoe_bufs",
|
2005-04-17 05:20:36 +07:00
|
|
|
sizeof(struct buf),
|
2007-07-20 08:11:58 +07:00
|
|
|
0, 0, NULL);
|
2005-04-17 05:20:36 +07:00
|
|
|
if (buf_pool_cache == NULL)
|
|
|
|
return -ENOMEM;
|
2013-09-12 04:25:39 +07:00
|
|
|
aoe_debugfs_dir = debugfs_create_dir("aoe", NULL);
|
2005-04-17 05:20:36 +07:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|