2019-05-19 20:51:34 +07:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
2012-12-20 18:37:32 +07:00
|
|
|
/*
|
|
|
|
|
* CPU hotplug support for CSR Marco dual-core SMP SoCs
|
|
|
|
|
*
|
|
|
|
|
* Copyright (c) 2012 Cambridge Silicon Radio Limited, a CSR plc group company.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
|
#include <linux/errno.h>
|
|
|
|
|
#include <linux/smp.h>
|
|
|
|
|
|
|
|
|
|
#include <asm/smp_plat.h>
|
ARM: smp: remove arch-provided "pen_release"
Consolidating the "pen_release" stuff amongst the various SoC
implementations gives credence to having a CPU holding pen for
secondary CPUs. However, this is far from the truth.
Many SoC implementations cargo-cult copied various bits of the pen
release implementation from the initial Realview/Versatile Express
implementation without understanding what it was or why it existed.
The reason it existed is because these are _development_ platforms,
and some board firmware is unable to individually control the
startup of secondary CPUs. Moreover, they do not have a way to
power down or reset secondary CPUs for hot-unplug. Hence, the
pen_release implementation was designed for ARM Ltd's development
platforms to provide a working implementation, even though it is
very far from what is required.
It was decided a while back to reduce the duplication by consolidating
the "pen_release" variable, but this only made the situation worse -
we have ended up with several implementations that read this variable
but do not write it - again, showing the cargo-cult mentality at work,
lack of proper review of new code, and in some cases a lack of testing.
While it would be preferable to remove pen_release entirely from the
kernel, this is not possible without help from the SoC maintainers,
which seems to be lacking. However, I want to remove pen_release from
arch code to remove the credence that having it gives.
This patch removes pen_release from the arch code entirely, adding
private per-SoC definitions for it instead, and explicitly stating
that write_pen_release() is cargo-cult copied and should not be
copied any further. Rename write_pen_release() in a similar fashion
as well.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
2018-12-13 21:02:48 +07:00
|
|
|
#include "common.h"
|
2012-12-20 18:37:32 +07:00
|
|
|
|
|
|
|
|
static inline void platform_do_lowpower(unsigned int cpu)
|
|
|
|
|
{
|
|
|
|
|
/* we put the platform to just WFI */
|
|
|
|
|
for (;;) {
|
|
|
|
|
__asm__ __volatile__("dsb\n\t" "wfi\n\t"
|
|
|
|
|
: : : "memory");
|
ARM: smp: remove arch-provided "pen_release"
Consolidating the "pen_release" stuff amongst the various SoC
implementations gives credence to having a CPU holding pen for
secondary CPUs. However, this is far from the truth.
Many SoC implementations cargo-cult copied various bits of the pen
release implementation from the initial Realview/Versatile Express
implementation without understanding what it was or why it existed.
The reason it existed is because these are _development_ platforms,
and some board firmware is unable to individually control the
startup of secondary CPUs. Moreover, they do not have a way to
power down or reset secondary CPUs for hot-unplug. Hence, the
pen_release implementation was designed for ARM Ltd's development
platforms to provide a working implementation, even though it is
very far from what is required.
It was decided a while back to reduce the duplication by consolidating
the "pen_release" variable, but this only made the situation worse -
we have ended up with several implementations that read this variable
but do not write it - again, showing the cargo-cult mentality at work,
lack of proper review of new code, and in some cases a lack of testing.
While it would be preferable to remove pen_release entirely from the
kernel, this is not possible without help from the SoC maintainers,
which seems to be lacking. However, I want to remove pen_release from
arch code to remove the credence that having it gives.
This patch removes pen_release from the arch code entirely, adding
private per-SoC definitions for it instead, and explicitly stating
that write_pen_release() is cargo-cult copied and should not be
copied any further. Rename write_pen_release() in a similar fashion
as well.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
2018-12-13 21:02:48 +07:00
|
|
|
if (prima2_pen_release == cpu_logical_map(cpu)) {
|
2012-12-20 18:37:32 +07:00
|
|
|
/*
|
|
|
|
|
* OK, proper wakeup, we're done
|
|
|
|
|
*/
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* platform-specific code to shutdown a CPU
|
|
|
|
|
*
|
|
|
|
|
* Called with IRQs disabled
|
|
|
|
|
*/
|
2015-10-20 03:05:33 +07:00
|
|
|
void sirfsoc_cpu_die(unsigned int cpu)
|
2012-12-20 18:37:32 +07:00
|
|
|
{
|
|
|
|
|
platform_do_lowpower(cpu);
|
|
|
|
|
}
|