2006-10-20 13:28:16 +07:00
|
|
|
|
|
|
|
#include <linux/wait.h>
|
|
|
|
#include <linux/backing-dev.h>
|
2009-09-09 14:08:54 +07:00
|
|
|
#include <linux/kthread.h>
|
|
|
|
#include <linux/freezer.h>
|
2006-10-20 13:28:16 +07:00
|
|
|
#include <linux/fs.h>
|
2009-03-17 15:35:06 +07:00
|
|
|
#include <linux/pagemap.h>
|
2009-09-09 14:08:54 +07:00
|
|
|
#include <linux/mm.h>
|
2006-10-20 13:28:16 +07:00
|
|
|
#include <linux/sched.h>
|
|
|
|
#include <linux/module.h>
|
2008-04-30 14:54:32 +07:00
|
|
|
#include <linux/writeback.h>
|
|
|
|
#include <linux/device.h>
|
2010-07-07 10:24:06 +07:00
|
|
|
#include <trace/events/writeback.h>
|
2008-04-30 14:54:32 +07:00
|
|
|
|
2010-04-22 16:37:01 +07:00
|
|
|
static atomic_long_t bdi_seq = ATOMIC_LONG_INIT(0);
|
|
|
|
|
2009-03-17 15:35:06 +07:00
|
|
|
struct backing_dev_info default_backing_dev_info = {
|
2009-06-12 19:45:52 +07:00
|
|
|
.name = "default",
|
2009-03-17 15:35:06 +07:00
|
|
|
.ra_pages = VM_MAX_READAHEAD * 1024 / PAGE_CACHE_SIZE,
|
|
|
|
.state = 0,
|
|
|
|
.capabilities = BDI_CAP_MAP_COPY,
|
|
|
|
};
|
|
|
|
EXPORT_SYMBOL_GPL(default_backing_dev_info);
|
2008-04-30 14:54:32 +07:00
|
|
|
|
2010-04-25 13:54:42 +07:00
|
|
|
struct backing_dev_info noop_backing_dev_info = {
|
|
|
|
.name = "noop",
|
2010-09-21 16:48:55 +07:00
|
|
|
.capabilities = BDI_CAP_NO_ACCT_AND_WRITEBACK,
|
2010-04-25 13:54:42 +07:00
|
|
|
};
|
|
|
|
EXPORT_SYMBOL_GPL(noop_backing_dev_info);
|
|
|
|
|
2008-04-30 14:54:32 +07:00
|
|
|
static struct class *bdi_class;
|
2009-09-14 18:12:40 +07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* bdi_lock protects updates to bdi_list and bdi_pending_list, as well as
|
|
|
|
* reader side protection for bdi_pending_list. bdi_list has RCU reader side
|
|
|
|
* locking.
|
|
|
|
*/
|
2009-09-09 14:08:54 +07:00
|
|
|
DEFINE_SPINLOCK(bdi_lock);
|
2009-09-02 14:19:46 +07:00
|
|
|
LIST_HEAD(bdi_list);
|
2009-09-09 14:08:54 +07:00
|
|
|
LIST_HEAD(bdi_pending_list);
|
|
|
|
|
|
|
|
static struct task_struct *sync_supers_tsk;
|
|
|
|
static struct timer_list sync_supers_timer;
|
|
|
|
|
|
|
|
static int bdi_sync_supers(void *);
|
|
|
|
static void sync_supers_timer_fn(unsigned long);
|
|
|
|
|
2011-04-22 07:19:44 +07:00
|
|
|
void bdi_lock_two(struct bdi_writeback *wb1, struct bdi_writeback *wb2)
|
|
|
|
{
|
|
|
|
if (wb1 < wb2) {
|
|
|
|
spin_lock(&wb1->list_lock);
|
|
|
|
spin_lock_nested(&wb2->list_lock, 1);
|
|
|
|
} else {
|
|
|
|
spin_lock(&wb2->list_lock);
|
|
|
|
spin_lock_nested(&wb1->list_lock, 1);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-04-30 14:54:36 +07:00
|
|
|
#ifdef CONFIG_DEBUG_FS
|
|
|
|
#include <linux/debugfs.h>
|
|
|
|
#include <linux/seq_file.h>
|
|
|
|
|
|
|
|
static struct dentry *bdi_debug_root;
|
|
|
|
|
|
|
|
static void bdi_debug_init(void)
|
|
|
|
{
|
|
|
|
bdi_debug_root = debugfs_create_dir("bdi", NULL);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int bdi_debug_stats_show(struct seq_file *m, void *v)
|
|
|
|
{
|
|
|
|
struct backing_dev_info *bdi = m->private;
|
2010-06-20 04:08:06 +07:00
|
|
|
struct bdi_writeback *wb = &bdi->wb;
|
2009-01-07 05:39:29 +07:00
|
|
|
unsigned long background_thresh;
|
|
|
|
unsigned long dirty_thresh;
|
|
|
|
unsigned long bdi_thresh;
|
2011-05-21 02:23:37 +07:00
|
|
|
unsigned long nr_dirty, nr_io, nr_more_io;
|
2009-05-25 14:08:21 +07:00
|
|
|
struct inode *inode;
|
|
|
|
|
2011-05-21 02:23:37 +07:00
|
|
|
nr_dirty = nr_io = nr_more_io = 0;
|
2011-04-22 07:19:44 +07:00
|
|
|
spin_lock(&wb->list_lock);
|
2010-10-21 07:49:30 +07:00
|
|
|
list_for_each_entry(inode, &wb->b_dirty, i_wb_list)
|
2010-06-20 04:08:06 +07:00
|
|
|
nr_dirty++;
|
2010-10-21 07:49:30 +07:00
|
|
|
list_for_each_entry(inode, &wb->b_io, i_wb_list)
|
2010-06-20 04:08:06 +07:00
|
|
|
nr_io++;
|
2010-10-21 07:49:30 +07:00
|
|
|
list_for_each_entry(inode, &wb->b_more_io, i_wb_list)
|
2010-06-20 04:08:06 +07:00
|
|
|
nr_more_io++;
|
2011-04-22 07:19:44 +07:00
|
|
|
spin_unlock(&wb->list_lock);
|
2008-04-30 14:54:36 +07:00
|
|
|
|
2010-08-12 04:17:39 +07:00
|
|
|
global_dirty_limits(&background_thresh, &dirty_thresh);
|
|
|
|
bdi_thresh = bdi_dirty_limit(bdi, dirty_thresh);
|
2008-04-30 14:54:36 +07:00
|
|
|
|
|
|
|
#define K(x) ((x) << (PAGE_SHIFT - 10))
|
|
|
|
seq_printf(m,
|
2010-08-30 00:28:45 +07:00
|
|
|
"BdiWriteback: %10lu kB\n"
|
|
|
|
"BdiReclaimable: %10lu kB\n"
|
|
|
|
"BdiDirtyThresh: %10lu kB\n"
|
|
|
|
"DirtyThresh: %10lu kB\n"
|
|
|
|
"BackgroundThresh: %10lu kB\n"
|
2011-01-23 23:07:47 +07:00
|
|
|
"BdiDirtied: %10lu kB\n"
|
2010-08-30 00:28:45 +07:00
|
|
|
"BdiWritten: %10lu kB\n"
|
|
|
|
"BdiWriteBandwidth: %10lu kBps\n"
|
|
|
|
"b_dirty: %10lu\n"
|
|
|
|
"b_io: %10lu\n"
|
|
|
|
"b_more_io: %10lu\n"
|
|
|
|
"bdi_list: %10u\n"
|
|
|
|
"state: %10lx\n",
|
2008-04-30 14:54:36 +07:00
|
|
|
(unsigned long) K(bdi_stat(bdi, BDI_WRITEBACK)),
|
|
|
|
(unsigned long) K(bdi_stat(bdi, BDI_RECLAIMABLE)),
|
2010-12-09 11:44:24 +07:00
|
|
|
K(bdi_thresh),
|
|
|
|
K(dirty_thresh),
|
|
|
|
K(background_thresh),
|
2011-01-23 23:07:47 +07:00
|
|
|
(unsigned long) K(bdi_stat(bdi, BDI_DIRTIED)),
|
2010-12-09 11:44:24 +07:00
|
|
|
(unsigned long) K(bdi_stat(bdi, BDI_WRITTEN)),
|
2010-08-30 00:28:45 +07:00
|
|
|
(unsigned long) K(bdi->write_bandwidth),
|
2010-12-09 11:44:24 +07:00
|
|
|
nr_dirty,
|
|
|
|
nr_io,
|
|
|
|
nr_more_io,
|
2010-06-20 04:08:06 +07:00
|
|
|
!list_empty(&bdi->bdi_list), bdi->state);
|
2008-04-30 14:54:36 +07:00
|
|
|
#undef K
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int bdi_debug_stats_open(struct inode *inode, struct file *file)
|
|
|
|
{
|
|
|
|
return single_open(file, bdi_debug_stats_show, inode->i_private);
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct file_operations bdi_debug_stats_fops = {
|
|
|
|
.open = bdi_debug_stats_open,
|
|
|
|
.read = seq_read,
|
|
|
|
.llseek = seq_lseek,
|
|
|
|
.release = single_release,
|
|
|
|
};
|
|
|
|
|
|
|
|
static void bdi_debug_register(struct backing_dev_info *bdi, const char *name)
|
|
|
|
{
|
|
|
|
bdi->debug_dir = debugfs_create_dir(name, bdi_debug_root);
|
|
|
|
bdi->debug_stats = debugfs_create_file("stats", 0444, bdi->debug_dir,
|
|
|
|
bdi, &bdi_debug_stats_fops);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void bdi_debug_unregister(struct backing_dev_info *bdi)
|
|
|
|
{
|
|
|
|
debugfs_remove(bdi->debug_stats);
|
|
|
|
debugfs_remove(bdi->debug_dir);
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
static inline void bdi_debug_init(void)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
static inline void bdi_debug_register(struct backing_dev_info *bdi,
|
|
|
|
const char *name)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
static inline void bdi_debug_unregister(struct backing_dev_info *bdi)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2008-04-30 14:54:32 +07:00
|
|
|
static ssize_t read_ahead_kb_store(struct device *dev,
|
|
|
|
struct device_attribute *attr,
|
|
|
|
const char *buf, size_t count)
|
|
|
|
{
|
|
|
|
struct backing_dev_info *bdi = dev_get_drvdata(dev);
|
|
|
|
char *end;
|
|
|
|
unsigned long read_ahead_kb;
|
|
|
|
ssize_t ret = -EINVAL;
|
|
|
|
|
|
|
|
read_ahead_kb = simple_strtoul(buf, &end, 10);
|
|
|
|
if (*buf && (end[0] == '\0' || (end[0] == '\n' && end[1] == '\0'))) {
|
|
|
|
bdi->ra_pages = read_ahead_kb >> (PAGE_SHIFT - 10);
|
|
|
|
ret = count;
|
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
#define K(pages) ((pages) << (PAGE_SHIFT - 10))
|
|
|
|
|
|
|
|
#define BDI_SHOW(name, expr) \
|
|
|
|
static ssize_t name##_show(struct device *dev, \
|
|
|
|
struct device_attribute *attr, char *page) \
|
|
|
|
{ \
|
|
|
|
struct backing_dev_info *bdi = dev_get_drvdata(dev); \
|
|
|
|
\
|
|
|
|
return snprintf(page, PAGE_SIZE-1, "%lld\n", (long long)expr); \
|
|
|
|
}
|
|
|
|
|
|
|
|
BDI_SHOW(read_ahead_kb, K(bdi->ra_pages))
|
|
|
|
|
2008-04-30 14:54:35 +07:00
|
|
|
static ssize_t min_ratio_store(struct device *dev,
|
|
|
|
struct device_attribute *attr, const char *buf, size_t count)
|
|
|
|
{
|
|
|
|
struct backing_dev_info *bdi = dev_get_drvdata(dev);
|
|
|
|
char *end;
|
|
|
|
unsigned int ratio;
|
|
|
|
ssize_t ret = -EINVAL;
|
|
|
|
|
|
|
|
ratio = simple_strtoul(buf, &end, 10);
|
|
|
|
if (*buf && (end[0] == '\0' || (end[0] == '\n' && end[1] == '\0'))) {
|
|
|
|
ret = bdi_set_min_ratio(bdi, ratio);
|
|
|
|
if (!ret)
|
|
|
|
ret = count;
|
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
BDI_SHOW(min_ratio, bdi->min_ratio)
|
|
|
|
|
2008-04-30 14:54:36 +07:00
|
|
|
static ssize_t max_ratio_store(struct device *dev,
|
|
|
|
struct device_attribute *attr, const char *buf, size_t count)
|
|
|
|
{
|
|
|
|
struct backing_dev_info *bdi = dev_get_drvdata(dev);
|
|
|
|
char *end;
|
|
|
|
unsigned int ratio;
|
|
|
|
ssize_t ret = -EINVAL;
|
|
|
|
|
|
|
|
ratio = simple_strtoul(buf, &end, 10);
|
|
|
|
if (*buf && (end[0] == '\0' || (end[0] == '\n' && end[1] == '\0'))) {
|
|
|
|
ret = bdi_set_max_ratio(bdi, ratio);
|
|
|
|
if (!ret)
|
|
|
|
ret = count;
|
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
BDI_SHOW(max_ratio, bdi->max_ratio)
|
|
|
|
|
2008-04-30 14:54:32 +07:00
|
|
|
#define __ATTR_RW(attr) __ATTR(attr, 0644, attr##_show, attr##_store)
|
|
|
|
|
|
|
|
static struct device_attribute bdi_dev_attrs[] = {
|
|
|
|
__ATTR_RW(read_ahead_kb),
|
2008-04-30 14:54:35 +07:00
|
|
|
__ATTR_RW(min_ratio),
|
2008-04-30 14:54:36 +07:00
|
|
|
__ATTR_RW(max_ratio),
|
2008-04-30 14:54:32 +07:00
|
|
|
__ATTR_NULL,
|
|
|
|
};
|
|
|
|
|
|
|
|
static __init int bdi_class_init(void)
|
|
|
|
{
|
|
|
|
bdi_class = class_create(THIS_MODULE, "bdi");
|
2010-04-02 14:46:55 +07:00
|
|
|
if (IS_ERR(bdi_class))
|
|
|
|
return PTR_ERR(bdi_class);
|
|
|
|
|
2008-04-30 14:54:32 +07:00
|
|
|
bdi_class->dev_attrs = bdi_dev_attrs;
|
2008-04-30 14:54:36 +07:00
|
|
|
bdi_debug_init();
|
2008-04-30 14:54:32 +07:00
|
|
|
return 0;
|
|
|
|
}
|
2008-04-30 14:54:36 +07:00
|
|
|
postcore_initcall(bdi_class_init);
|
2008-04-30 14:54:32 +07:00
|
|
|
|
2009-03-17 15:35:06 +07:00
|
|
|
static int __init default_bdi_init(void)
|
|
|
|
{
|
|
|
|
int err;
|
|
|
|
|
2009-09-09 14:08:54 +07:00
|
|
|
sync_supers_tsk = kthread_run(bdi_sync_supers, NULL, "sync_supers");
|
|
|
|
BUG_ON(IS_ERR(sync_supers_tsk));
|
|
|
|
|
|
|
|
setup_timer(&sync_supers_timer, sync_supers_timer_fn, 0);
|
2010-05-22 01:00:35 +07:00
|
|
|
bdi_arm_supers_timer();
|
2009-09-09 14:08:54 +07:00
|
|
|
|
2009-03-17 15:35:06 +07:00
|
|
|
err = bdi_init(&default_backing_dev_info);
|
|
|
|
if (!err)
|
|
|
|
bdi_register(&default_backing_dev_info, NULL, "default");
|
2010-09-21 16:48:55 +07:00
|
|
|
err = bdi_init(&noop_backing_dev_info);
|
2009-03-17 15:35:06 +07:00
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
subsys_initcall(default_bdi_init);
|
|
|
|
|
2009-09-09 14:08:54 +07:00
|
|
|
int bdi_has_dirty_io(struct backing_dev_info *bdi)
|
|
|
|
{
|
|
|
|
return wb_has_dirty_io(&bdi->wb);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2010-07-25 18:29:11 +07:00
|
|
|
* kupdated() used to do this. We cannot do it from the bdi_forker_thread()
|
2009-09-09 14:08:54 +07:00
|
|
|
* or we risk deadlocking on ->s_umount. The longer term solution would be
|
|
|
|
* to implement sync_supers_bdi() or similar and simply do it from the
|
2010-07-25 18:29:11 +07:00
|
|
|
* bdi writeback thread individually.
|
2009-09-09 14:08:54 +07:00
|
|
|
*/
|
|
|
|
static int bdi_sync_supers(void *unused)
|
|
|
|
{
|
|
|
|
set_user_nice(current, 0);
|
|
|
|
|
|
|
|
while (!kthread_should_stop()) {
|
|
|
|
set_current_state(TASK_INTERRUPTIBLE);
|
|
|
|
schedule();
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Do this periodically, like kupdated() did before.
|
|
|
|
*/
|
|
|
|
sync_supers();
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-05-22 01:00:35 +07:00
|
|
|
void bdi_arm_supers_timer(void)
|
2009-09-09 14:08:54 +07:00
|
|
|
{
|
|
|
|
unsigned long next;
|
|
|
|
|
2010-05-22 01:00:35 +07:00
|
|
|
if (!dirty_writeback_interval)
|
|
|
|
return;
|
|
|
|
|
2009-09-09 14:08:54 +07:00
|
|
|
next = msecs_to_jiffies(dirty_writeback_interval * 10) + jiffies;
|
|
|
|
mod_timer(&sync_supers_timer, round_jiffies_up(next));
|
|
|
|
}
|
|
|
|
|
|
|
|
static void sync_supers_timer_fn(unsigned long unused)
|
|
|
|
{
|
|
|
|
wake_up_process(sync_supers_tsk);
|
2010-05-22 01:00:35 +07:00
|
|
|
bdi_arm_supers_timer();
|
2009-09-09 14:08:54 +07:00
|
|
|
}
|
|
|
|
|
2010-07-25 18:29:22 +07:00
|
|
|
static void wakeup_timer_fn(unsigned long data)
|
|
|
|
{
|
|
|
|
struct backing_dev_info *bdi = (struct backing_dev_info *)data;
|
|
|
|
|
|
|
|
spin_lock_bh(&bdi->wb_lock);
|
|
|
|
if (bdi->wb.task) {
|
2010-07-25 18:29:24 +07:00
|
|
|
trace_writeback_wake_thread(bdi);
|
2010-07-25 18:29:22 +07:00
|
|
|
wake_up_process(bdi->wb.task);
|
2012-01-30 01:17:33 +07:00
|
|
|
} else if (bdi->dev) {
|
2010-07-25 18:29:22 +07:00
|
|
|
/*
|
|
|
|
* When bdi tasks are inactive for long time, they are killed.
|
|
|
|
* In this case we have to wake-up the forker thread which
|
|
|
|
* should create and run the bdi thread.
|
|
|
|
*/
|
2010-07-25 18:29:24 +07:00
|
|
|
trace_writeback_wake_forker_thread(bdi);
|
2010-07-25 18:29:22 +07:00
|
|
|
wake_up_process(default_backing_dev_info.wb.task);
|
|
|
|
}
|
|
|
|
spin_unlock_bh(&bdi->wb_lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This function is used when the first inode for this bdi is marked dirty. It
|
|
|
|
* wakes-up the corresponding bdi thread which should then take care of the
|
|
|
|
* periodic background write-out of dirty inodes. Since the write-out would
|
|
|
|
* starts only 'dirty_writeback_interval' centisecs from now anyway, we just
|
|
|
|
* set up a timer which wakes the bdi thread up later.
|
|
|
|
*
|
|
|
|
* Note, we wouldn't bother setting up the timer, but this function is on the
|
|
|
|
* fast-path (used by '__mark_inode_dirty()'), so we save few context switches
|
|
|
|
* by delaying the wake-up.
|
|
|
|
*/
|
|
|
|
void bdi_wakeup_thread_delayed(struct backing_dev_info *bdi)
|
|
|
|
{
|
|
|
|
unsigned long timeout;
|
|
|
|
|
|
|
|
timeout = msecs_to_jiffies(dirty_writeback_interval * 10);
|
|
|
|
mod_timer(&bdi->wb.wakeup_timer, jiffies + timeout);
|
|
|
|
}
|
|
|
|
|
writeback: move bdi threads exiting logic to the forker thread
Currently, bdi threads can decide to exit if there were no useful activities
for 5 minutes. However, this causes nasty races: we can easily oops in the
'bdi_queue_work()' if the bdi thread decides to exit while we are waking it up.
And even if we do not oops, but the bdi tread exits immediately after we wake
it up, we'd lose the wake-up event and have an unnecessary delay (up to 5 secs)
in the bdi work processing.
This patch makes the forker thread to be the central place which not only
creates bdi threads, but also kills them if they were inactive long enough.
This better design-wise.
Another reason why this change was done is to prepare for the further changes
which will prevent the bdi threads from waking up every 5 sec and wasting
power. Indeed, when the task does not wake up periodically anymore, it won't be
able to exit either.
This patch also moves the the 'wake_up_bit()' call from the bdi thread to the
forker thread as well. So now the forker thread sets the BDI_pending bit, then
forks the task or kills it, then clears the bit and wakes up the waiting
process.
The only process which may wain on the bit is 'bdi_wb_shutdown()'. This
function was changed as well - now it first removes the bdi from the
'bdi_list', then waits on the 'BDI_pending' bit. Once it wakes up, it is
guaranteed that the forker thread won't race with it, because the bdi is not
visible. Note, the forker thread sets the 'BDI_pending' bit under the
'bdi->wb_lock' which is essential for proper serialization.
And additionally, when we change 'bdi->wb.task', we now take the
'bdi->work_lock', to make sure that we do not lose wake-ups which we otherwise
would when raced with, say, 'bdi_queue_work()'.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:20 +07:00
|
|
|
/*
|
|
|
|
* Calculate the longest interval (jiffies) bdi threads are allowed to be
|
|
|
|
* inactive.
|
|
|
|
*/
|
|
|
|
static unsigned long bdi_longest_inactive(void)
|
|
|
|
{
|
|
|
|
unsigned long interval;
|
|
|
|
|
|
|
|
interval = msecs_to_jiffies(dirty_writeback_interval * 10);
|
|
|
|
return max(5UL * 60 * HZ, interval);
|
|
|
|
}
|
|
|
|
|
2011-09-03 06:04:09 +07:00
|
|
|
/*
|
|
|
|
* Clear pending bit and wakeup anybody waiting for flusher thread creation or
|
|
|
|
* shutdown
|
|
|
|
*/
|
|
|
|
static void bdi_clear_pending(struct backing_dev_info *bdi)
|
|
|
|
{
|
|
|
|
clear_bit(BDI_pending, &bdi->state);
|
|
|
|
smp_mb__after_clear_bit();
|
|
|
|
wake_up_bit(&bdi->state, BDI_pending);
|
|
|
|
}
|
|
|
|
|
2010-07-25 18:29:11 +07:00
|
|
|
static int bdi_forker_thread(void *ptr)
|
2009-09-09 14:08:54 +07:00
|
|
|
{
|
|
|
|
struct bdi_writeback *me = ptr;
|
|
|
|
|
2010-10-27 04:22:45 +07:00
|
|
|
current->flags |= PF_SWAPWRITE;
|
2010-06-20 04:08:06 +07:00
|
|
|
set_freezable();
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Our parent may run at a different priority, just set us to normal
|
|
|
|
*/
|
|
|
|
set_user_nice(current, 0);
|
2009-09-09 14:08:54 +07:00
|
|
|
|
|
|
|
for (;;) {
|
writeback: move bdi threads exiting logic to the forker thread
Currently, bdi threads can decide to exit if there were no useful activities
for 5 minutes. However, this causes nasty races: we can easily oops in the
'bdi_queue_work()' if the bdi thread decides to exit while we are waking it up.
And even if we do not oops, but the bdi tread exits immediately after we wake
it up, we'd lose the wake-up event and have an unnecessary delay (up to 5 secs)
in the bdi work processing.
This patch makes the forker thread to be the central place which not only
creates bdi threads, but also kills them if they were inactive long enough.
This better design-wise.
Another reason why this change was done is to prepare for the further changes
which will prevent the bdi threads from waking up every 5 sec and wasting
power. Indeed, when the task does not wake up periodically anymore, it won't be
able to exit either.
This patch also moves the the 'wake_up_bit()' call from the bdi thread to the
forker thread as well. So now the forker thread sets the BDI_pending bit, then
forks the task or kills it, then clears the bit and wakes up the waiting
process.
The only process which may wain on the bit is 'bdi_wb_shutdown()'. This
function was changed as well - now it first removes the bdi from the
'bdi_list', then waits on the 'BDI_pending' bit. Once it wakes up, it is
guaranteed that the forker thread won't race with it, because the bdi is not
visible. Note, the forker thread sets the 'BDI_pending' bit under the
'bdi->wb_lock' which is essential for proper serialization.
And additionally, when we change 'bdi->wb.task', we now take the
'bdi->work_lock', to make sure that we do not lose wake-ups which we otherwise
would when raced with, say, 'bdi_queue_work()'.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:20 +07:00
|
|
|
struct task_struct *task = NULL;
|
writeback: do not remove bdi from bdi_list
The forker thread removes bdis from 'bdi_list' before forking the bdi thread.
But this is wrong for at least 2 reasons.
Reason #1: if we temporary remove a bdi from the list, we may miss works which
would otherwise be given to us.
Reason #2: this is racy; indeed, 'bdi_wb_shutdown()' expects that bdis are
always in the 'bdi_list' (see 'bdi_remove_from_list()'), and when
it races with the forker thread, it can shut down the bdi thread
at the same time as the forker creates it.
This patch makes sure the forker thread never removes bdis from 'bdi_list'
(which was suggested by Christoph Hellwig).
In order to make sure that we do not race with 'bdi_wb_shutdown()', we have to
hold the 'bdi_lock' while walking the 'bdi_list' and setting the 'BDI_pending'
flag.
NOTE! The error path is interesting. Currently, when we fail to create a bdi
thread, we move the bdi to the tail of 'bdi_list'. But if we never remove the
bdi from the list, we cannot move it to the tail either, because then we can
mess up the RCU readers which walk the list. And also, we'll have the race
described above in "Reason #2".
But I not think that adding to the tail is any important so I just do not do
that.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:17 +07:00
|
|
|
struct backing_dev_info *bdi;
|
2010-07-25 18:29:19 +07:00
|
|
|
enum {
|
|
|
|
NO_ACTION, /* Nothing to do */
|
|
|
|
FORK_THREAD, /* Fork bdi thread */
|
writeback: move bdi threads exiting logic to the forker thread
Currently, bdi threads can decide to exit if there were no useful activities
for 5 minutes. However, this causes nasty races: we can easily oops in the
'bdi_queue_work()' if the bdi thread decides to exit while we are waking it up.
And even if we do not oops, but the bdi tread exits immediately after we wake
it up, we'd lose the wake-up event and have an unnecessary delay (up to 5 secs)
in the bdi work processing.
This patch makes the forker thread to be the central place which not only
creates bdi threads, but also kills them if they were inactive long enough.
This better design-wise.
Another reason why this change was done is to prepare for the further changes
which will prevent the bdi threads from waking up every 5 sec and wasting
power. Indeed, when the task does not wake up periodically anymore, it won't be
able to exit either.
This patch also moves the the 'wake_up_bit()' call from the bdi thread to the
forker thread as well. So now the forker thread sets the BDI_pending bit, then
forks the task or kills it, then clears the bit and wakes up the waiting
process.
The only process which may wain on the bit is 'bdi_wb_shutdown()'. This
function was changed as well - now it first removes the bdi from the
'bdi_list', then waits on the 'BDI_pending' bit. Once it wakes up, it is
guaranteed that the forker thread won't race with it, because the bdi is not
visible. Note, the forker thread sets the 'BDI_pending' bit under the
'bdi->wb_lock' which is essential for proper serialization.
And additionally, when we change 'bdi->wb.task', we now take the
'bdi->work_lock', to make sure that we do not lose wake-ups which we otherwise
would when raced with, say, 'bdi_queue_work()'.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:20 +07:00
|
|
|
KILL_THREAD, /* Kill inactive bdi thread */
|
2010-07-25 18:29:19 +07:00
|
|
|
} action = NO_ACTION;
|
2009-09-09 14:08:54 +07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Temporary measure, we want to make sure we don't see
|
|
|
|
* dirty data on the default backing_dev_info
|
|
|
|
*/
|
2010-07-25 18:29:22 +07:00
|
|
|
if (wb_has_dirty_io(me) || !list_empty(&me->bdi->work_list)) {
|
|
|
|
del_timer(&me->wakeup_timer);
|
2009-09-09 14:08:54 +07:00
|
|
|
wb_do_writeback(me, 0);
|
2010-07-25 18:29:22 +07:00
|
|
|
}
|
2009-09-09 14:08:54 +07:00
|
|
|
|
2009-09-14 18:12:40 +07:00
|
|
|
spin_lock_bh(&bdi_lock);
|
2011-09-03 06:04:10 +07:00
|
|
|
/*
|
|
|
|
* In the following loop we are going to check whether we have
|
|
|
|
* some work to do without any synchronization with tasks
|
2011-11-01 07:08:54 +07:00
|
|
|
* waking us up to do work for them. Set the task state here
|
|
|
|
* so that we don't miss wakeups after verifying conditions.
|
2011-09-03 06:04:10 +07:00
|
|
|
*/
|
2010-07-25 18:29:13 +07:00
|
|
|
set_current_state(TASK_INTERRUPTIBLE);
|
2009-09-09 14:08:54 +07:00
|
|
|
|
writeback: do not remove bdi from bdi_list
The forker thread removes bdis from 'bdi_list' before forking the bdi thread.
But this is wrong for at least 2 reasons.
Reason #1: if we temporary remove a bdi from the list, we may miss works which
would otherwise be given to us.
Reason #2: this is racy; indeed, 'bdi_wb_shutdown()' expects that bdis are
always in the 'bdi_list' (see 'bdi_remove_from_list()'), and when
it races with the forker thread, it can shut down the bdi thread
at the same time as the forker creates it.
This patch makes sure the forker thread never removes bdis from 'bdi_list'
(which was suggested by Christoph Hellwig).
In order to make sure that we do not race with 'bdi_wb_shutdown()', we have to
hold the 'bdi_lock' while walking the 'bdi_list' and setting the 'BDI_pending'
flag.
NOTE! The error path is interesting. Currently, when we fail to create a bdi
thread, we move the bdi to the tail of 'bdi_list'. But if we never remove the
bdi from the list, we cannot move it to the tail either, because then we can
mess up the RCU readers which walk the list. And also, we'll have the race
described above in "Reason #2".
But I not think that adding to the tail is any important so I just do not do
that.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:17 +07:00
|
|
|
list_for_each_entry(bdi, &bdi_list, bdi_list) {
|
2010-07-25 18:29:19 +07:00
|
|
|
bool have_dirty_io;
|
|
|
|
|
|
|
|
if (!bdi_cap_writeback_dirty(bdi) ||
|
|
|
|
bdi_cap_flush_forker(bdi))
|
2009-09-09 14:08:54 +07:00
|
|
|
continue;
|
|
|
|
|
writeback: simplify bdi code a little
This patch simplifies bdi code a little by removing the 'pending_list' which is
redundant. Indeed, currently the forker thread ('bdi_forker_thread()') is
working like this:
1. In a loop, fetch all bdi's which have works but have no writeback thread and
move them to the 'pending_list'.
2. If the list is empty, sleep for 5 sec.
3. Otherwise, take one bdi from the list, fork the writeback thread for this
bdi, and repeat the loop.
IOW, it first moves everything to the 'pending_list', then process only one
element, and so on. This patch simplifies the algorithm, which is now as
follows.
1. Find the first bdi which has a work and remove it from the global list of
bdi's (bdi_list).
2. If there was not such bdi, sleep 5 sec.
3. Fork the writeback thread for this bdi and repeat the loop.
IOW, now we find the first bdi to process, process it, and so on. This is
simpler and involves less lists.
The bonus now is that we can get rid of a couple of functions, as well as
remove complications which involve 'rcu_call()' and 'bdi->rcu_head'.
This patch also makes sure we use 'list_add_tail_rcu()', instead of plain
'list_add_tail()', but this piece of code is going to be removed in the next
patch anyway.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:16 +07:00
|
|
|
WARN(!test_bit(BDI_registered, &bdi->state),
|
|
|
|
"bdi %p/%s is not registered!\n", bdi, bdi->name);
|
|
|
|
|
2010-07-25 18:29:19 +07:00
|
|
|
have_dirty_io = !list_empty(&bdi->work_list) ||
|
|
|
|
wb_has_dirty_io(&bdi->wb);
|
writeback: do not remove bdi from bdi_list
The forker thread removes bdis from 'bdi_list' before forking the bdi thread.
But this is wrong for at least 2 reasons.
Reason #1: if we temporary remove a bdi from the list, we may miss works which
would otherwise be given to us.
Reason #2: this is racy; indeed, 'bdi_wb_shutdown()' expects that bdis are
always in the 'bdi_list' (see 'bdi_remove_from_list()'), and when
it races with the forker thread, it can shut down the bdi thread
at the same time as the forker creates it.
This patch makes sure the forker thread never removes bdis from 'bdi_list'
(which was suggested by Christoph Hellwig).
In order to make sure that we do not race with 'bdi_wb_shutdown()', we have to
hold the 'bdi_lock' while walking the 'bdi_list' and setting the 'BDI_pending'
flag.
NOTE! The error path is interesting. Currently, when we fail to create a bdi
thread, we move the bdi to the tail of 'bdi_list'. But if we never remove the
bdi from the list, we cannot move it to the tail either, because then we can
mess up the RCU readers which walk the list. And also, we'll have the race
described above in "Reason #2".
But I not think that adding to the tail is any important so I just do not do
that.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:17 +07:00
|
|
|
|
|
|
|
/*
|
2010-07-25 18:29:19 +07:00
|
|
|
* If the bdi has work to do, but the thread does not
|
|
|
|
* exist - create it.
|
writeback: do not remove bdi from bdi_list
The forker thread removes bdis from 'bdi_list' before forking the bdi thread.
But this is wrong for at least 2 reasons.
Reason #1: if we temporary remove a bdi from the list, we may miss works which
would otherwise be given to us.
Reason #2: this is racy; indeed, 'bdi_wb_shutdown()' expects that bdis are
always in the 'bdi_list' (see 'bdi_remove_from_list()'), and when
it races with the forker thread, it can shut down the bdi thread
at the same time as the forker creates it.
This patch makes sure the forker thread never removes bdis from 'bdi_list'
(which was suggested by Christoph Hellwig).
In order to make sure that we do not race with 'bdi_wb_shutdown()', we have to
hold the 'bdi_lock' while walking the 'bdi_list' and setting the 'BDI_pending'
flag.
NOTE! The error path is interesting. Currently, when we fail to create a bdi
thread, we move the bdi to the tail of 'bdi_list'. But if we never remove the
bdi from the list, we cannot move it to the tail either, because then we can
mess up the RCU readers which walk the list. And also, we'll have the race
described above in "Reason #2".
But I not think that adding to the tail is any important so I just do not do
that.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:17 +07:00
|
|
|
*/
|
2010-07-25 18:29:19 +07:00
|
|
|
if (!bdi->wb.task && have_dirty_io) {
|
|
|
|
/*
|
|
|
|
* Set the pending bit - if someone will try to
|
|
|
|
* unregister this bdi - it'll wait on this bit.
|
|
|
|
*/
|
|
|
|
set_bit(BDI_pending, &bdi->state);
|
|
|
|
action = FORK_THREAD;
|
|
|
|
break;
|
|
|
|
}
|
writeback: move bdi threads exiting logic to the forker thread
Currently, bdi threads can decide to exit if there were no useful activities
for 5 minutes. However, this causes nasty races: we can easily oops in the
'bdi_queue_work()' if the bdi thread decides to exit while we are waking it up.
And even if we do not oops, but the bdi tread exits immediately after we wake
it up, we'd lose the wake-up event and have an unnecessary delay (up to 5 secs)
in the bdi work processing.
This patch makes the forker thread to be the central place which not only
creates bdi threads, but also kills them if they were inactive long enough.
This better design-wise.
Another reason why this change was done is to prepare for the further changes
which will prevent the bdi threads from waking up every 5 sec and wasting
power. Indeed, when the task does not wake up periodically anymore, it won't be
able to exit either.
This patch also moves the the 'wake_up_bit()' call from the bdi thread to the
forker thread as well. So now the forker thread sets the BDI_pending bit, then
forks the task or kills it, then clears the bit and wakes up the waiting
process.
The only process which may wain on the bit is 'bdi_wb_shutdown()'. This
function was changed as well - now it first removes the bdi from the
'bdi_list', then waits on the 'BDI_pending' bit. Once it wakes up, it is
guaranteed that the forker thread won't race with it, because the bdi is not
visible. Note, the forker thread sets the 'BDI_pending' bit under the
'bdi->wb_lock' which is essential for proper serialization.
And additionally, when we change 'bdi->wb.task', we now take the
'bdi->work_lock', to make sure that we do not lose wake-ups which we otherwise
would when raced with, say, 'bdi_queue_work()'.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:20 +07:00
|
|
|
|
2010-08-04 18:34:31 +07:00
|
|
|
spin_lock(&bdi->wb_lock);
|
|
|
|
|
writeback: move bdi threads exiting logic to the forker thread
Currently, bdi threads can decide to exit if there were no useful activities
for 5 minutes. However, this causes nasty races: we can easily oops in the
'bdi_queue_work()' if the bdi thread decides to exit while we are waking it up.
And even if we do not oops, but the bdi tread exits immediately after we wake
it up, we'd lose the wake-up event and have an unnecessary delay (up to 5 secs)
in the bdi work processing.
This patch makes the forker thread to be the central place which not only
creates bdi threads, but also kills them if they were inactive long enough.
This better design-wise.
Another reason why this change was done is to prepare for the further changes
which will prevent the bdi threads from waking up every 5 sec and wasting
power. Indeed, when the task does not wake up periodically anymore, it won't be
able to exit either.
This patch also moves the the 'wake_up_bit()' call from the bdi thread to the
forker thread as well. So now the forker thread sets the BDI_pending bit, then
forks the task or kills it, then clears the bit and wakes up the waiting
process.
The only process which may wain on the bit is 'bdi_wb_shutdown()'. This
function was changed as well - now it first removes the bdi from the
'bdi_list', then waits on the 'BDI_pending' bit. Once it wakes up, it is
guaranteed that the forker thread won't race with it, because the bdi is not
visible. Note, the forker thread sets the 'BDI_pending' bit under the
'bdi->wb_lock' which is essential for proper serialization.
And additionally, when we change 'bdi->wb.task', we now take the
'bdi->work_lock', to make sure that we do not lose wake-ups which we otherwise
would when raced with, say, 'bdi_queue_work()'.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:20 +07:00
|
|
|
/*
|
|
|
|
* If there is no work to do and the bdi thread was
|
|
|
|
* inactive long enough - kill it. The wb_lock is taken
|
|
|
|
* to make sure no-one adds more work to this bdi and
|
|
|
|
* wakes the bdi thread up.
|
|
|
|
*/
|
|
|
|
if (bdi->wb.task && !have_dirty_io &&
|
|
|
|
time_after(jiffies, bdi->wb.last_active +
|
|
|
|
bdi_longest_inactive())) {
|
|
|
|
task = bdi->wb.task;
|
|
|
|
bdi->wb.task = NULL;
|
|
|
|
spin_unlock(&bdi->wb_lock);
|
|
|
|
set_bit(BDI_pending, &bdi->state);
|
|
|
|
action = KILL_THREAD;
|
|
|
|
break;
|
|
|
|
}
|
2010-08-04 18:34:31 +07:00
|
|
|
spin_unlock(&bdi->wb_lock);
|
2009-09-09 14:08:54 +07:00
|
|
|
}
|
writeback: simplify bdi code a little
This patch simplifies bdi code a little by removing the 'pending_list' which is
redundant. Indeed, currently the forker thread ('bdi_forker_thread()') is
working like this:
1. In a loop, fetch all bdi's which have works but have no writeback thread and
move them to the 'pending_list'.
2. If the list is empty, sleep for 5 sec.
3. Otherwise, take one bdi from the list, fork the writeback thread for this
bdi, and repeat the loop.
IOW, it first moves everything to the 'pending_list', then process only one
element, and so on. This patch simplifies the algorithm, which is now as
follows.
1. Find the first bdi which has a work and remove it from the global list of
bdi's (bdi_list).
2. If there was not such bdi, sleep 5 sec.
3. Fork the writeback thread for this bdi and repeat the loop.
IOW, now we find the first bdi to process, process it, and so on. This is
simpler and involves less lists.
The bonus now is that we can get rid of a couple of functions, as well as
remove complications which involve 'rcu_call()' and 'bdi->rcu_head'.
This patch also makes sure we use 'list_add_tail_rcu()', instead of plain
'list_add_tail()', but this piece of code is going to be removed in the next
patch anyway.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:16 +07:00
|
|
|
spin_unlock_bh(&bdi_lock);
|
2009-09-09 14:08:54 +07:00
|
|
|
|
2010-07-25 18:29:14 +07:00
|
|
|
/* Keep working if default bdi still has things to do */
|
|
|
|
if (!list_empty(&me->bdi->work_list))
|
|
|
|
__set_current_state(TASK_RUNNING);
|
|
|
|
|
2010-07-25 18:29:19 +07:00
|
|
|
switch (action) {
|
|
|
|
case FORK_THREAD:
|
|
|
|
__set_current_state(TASK_RUNNING);
|
2010-08-27 14:15:09 +07:00
|
|
|
task = kthread_create(bdi_writeback_thread, &bdi->wb,
|
|
|
|
"flush-%s", dev_name(bdi->dev));
|
2010-07-25 18:29:19 +07:00
|
|
|
if (IS_ERR(task)) {
|
|
|
|
/*
|
|
|
|
* If thread creation fails, force writeout of
|
2011-05-05 08:54:37 +07:00
|
|
|
* the bdi from the thread. Hopefully 1024 is
|
|
|
|
* large enough for efficient IO.
|
2010-07-25 18:29:19 +07:00
|
|
|
*/
|
2011-10-08 10:54:10 +07:00
|
|
|
writeback_inodes_wb(&bdi->wb, 1024,
|
|
|
|
WB_REASON_FORKER_THREAD);
|
writeback: move bdi threads exiting logic to the forker thread
Currently, bdi threads can decide to exit if there were no useful activities
for 5 minutes. However, this causes nasty races: we can easily oops in the
'bdi_queue_work()' if the bdi thread decides to exit while we are waking it up.
And even if we do not oops, but the bdi tread exits immediately after we wake
it up, we'd lose the wake-up event and have an unnecessary delay (up to 5 secs)
in the bdi work processing.
This patch makes the forker thread to be the central place which not only
creates bdi threads, but also kills them if they were inactive long enough.
This better design-wise.
Another reason why this change was done is to prepare for the further changes
which will prevent the bdi threads from waking up every 5 sec and wasting
power. Indeed, when the task does not wake up periodically anymore, it won't be
able to exit either.
This patch also moves the the 'wake_up_bit()' call from the bdi thread to the
forker thread as well. So now the forker thread sets the BDI_pending bit, then
forks the task or kills it, then clears the bit and wakes up the waiting
process.
The only process which may wain on the bit is 'bdi_wb_shutdown()'. This
function was changed as well - now it first removes the bdi from the
'bdi_list', then waits on the 'BDI_pending' bit. Once it wakes up, it is
guaranteed that the forker thread won't race with it, because the bdi is not
visible. Note, the forker thread sets the 'BDI_pending' bit under the
'bdi->wb_lock' which is essential for proper serialization.
And additionally, when we change 'bdi->wb.task', we now take the
'bdi->work_lock', to make sure that we do not lose wake-ups which we otherwise
would when raced with, say, 'bdi_queue_work()'.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:20 +07:00
|
|
|
} else {
|
|
|
|
/*
|
|
|
|
* The spinlock makes sure we do not lose
|
|
|
|
* wake-ups when racing with 'bdi_queue_work()'.
|
2010-08-27 14:15:09 +07:00
|
|
|
* And as soon as the bdi thread is visible, we
|
|
|
|
* can start it.
|
writeback: move bdi threads exiting logic to the forker thread
Currently, bdi threads can decide to exit if there were no useful activities
for 5 minutes. However, this causes nasty races: we can easily oops in the
'bdi_queue_work()' if the bdi thread decides to exit while we are waking it up.
And even if we do not oops, but the bdi tread exits immediately after we wake
it up, we'd lose the wake-up event and have an unnecessary delay (up to 5 secs)
in the bdi work processing.
This patch makes the forker thread to be the central place which not only
creates bdi threads, but also kills them if they were inactive long enough.
This better design-wise.
Another reason why this change was done is to prepare for the further changes
which will prevent the bdi threads from waking up every 5 sec and wasting
power. Indeed, when the task does not wake up periodically anymore, it won't be
able to exit either.
This patch also moves the the 'wake_up_bit()' call from the bdi thread to the
forker thread as well. So now the forker thread sets the BDI_pending bit, then
forks the task or kills it, then clears the bit and wakes up the waiting
process.
The only process which may wain on the bit is 'bdi_wb_shutdown()'. This
function was changed as well - now it first removes the bdi from the
'bdi_list', then waits on the 'BDI_pending' bit. Once it wakes up, it is
guaranteed that the forker thread won't race with it, because the bdi is not
visible. Note, the forker thread sets the 'BDI_pending' bit under the
'bdi->wb_lock' which is essential for proper serialization.
And additionally, when we change 'bdi->wb.task', we now take the
'bdi->work_lock', to make sure that we do not lose wake-ups which we otherwise
would when raced with, say, 'bdi_queue_work()'.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:20 +07:00
|
|
|
*/
|
2010-07-25 18:29:22 +07:00
|
|
|
spin_lock_bh(&bdi->wb_lock);
|
2010-07-25 18:29:19 +07:00
|
|
|
bdi->wb.task = task;
|
2010-07-25 18:29:22 +07:00
|
|
|
spin_unlock_bh(&bdi->wb_lock);
|
2010-08-27 14:15:09 +07:00
|
|
|
wake_up_process(task);
|
writeback: move bdi threads exiting logic to the forker thread
Currently, bdi threads can decide to exit if there were no useful activities
for 5 minutes. However, this causes nasty races: we can easily oops in the
'bdi_queue_work()' if the bdi thread decides to exit while we are waking it up.
And even if we do not oops, but the bdi tread exits immediately after we wake
it up, we'd lose the wake-up event and have an unnecessary delay (up to 5 secs)
in the bdi work processing.
This patch makes the forker thread to be the central place which not only
creates bdi threads, but also kills them if they were inactive long enough.
This better design-wise.
Another reason why this change was done is to prepare for the further changes
which will prevent the bdi threads from waking up every 5 sec and wasting
power. Indeed, when the task does not wake up periodically anymore, it won't be
able to exit either.
This patch also moves the the 'wake_up_bit()' call from the bdi thread to the
forker thread as well. So now the forker thread sets the BDI_pending bit, then
forks the task or kills it, then clears the bit and wakes up the waiting
process.
The only process which may wain on the bit is 'bdi_wb_shutdown()'. This
function was changed as well - now it first removes the bdi from the
'bdi_list', then waits on the 'BDI_pending' bit. Once it wakes up, it is
guaranteed that the forker thread won't race with it, because the bdi is not
visible. Note, the forker thread sets the 'BDI_pending' bit under the
'bdi->wb_lock' which is essential for proper serialization.
And additionally, when we change 'bdi->wb.task', we now take the
'bdi->work_lock', to make sure that we do not lose wake-ups which we otherwise
would when raced with, say, 'bdi_queue_work()'.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:20 +07:00
|
|
|
}
|
2011-09-03 06:04:09 +07:00
|
|
|
bdi_clear_pending(bdi);
|
writeback: move bdi threads exiting logic to the forker thread
Currently, bdi threads can decide to exit if there were no useful activities
for 5 minutes. However, this causes nasty races: we can easily oops in the
'bdi_queue_work()' if the bdi thread decides to exit while we are waking it up.
And even if we do not oops, but the bdi tread exits immediately after we wake
it up, we'd lose the wake-up event and have an unnecessary delay (up to 5 secs)
in the bdi work processing.
This patch makes the forker thread to be the central place which not only
creates bdi threads, but also kills them if they were inactive long enough.
This better design-wise.
Another reason why this change was done is to prepare for the further changes
which will prevent the bdi threads from waking up every 5 sec and wasting
power. Indeed, when the task does not wake up periodically anymore, it won't be
able to exit either.
This patch also moves the the 'wake_up_bit()' call from the bdi thread to the
forker thread as well. So now the forker thread sets the BDI_pending bit, then
forks the task or kills it, then clears the bit and wakes up the waiting
process.
The only process which may wain on the bit is 'bdi_wb_shutdown()'. This
function was changed as well - now it first removes the bdi from the
'bdi_list', then waits on the 'BDI_pending' bit. Once it wakes up, it is
guaranteed that the forker thread won't race with it, because the bdi is not
visible. Note, the forker thread sets the 'BDI_pending' bit under the
'bdi->wb_lock' which is essential for proper serialization.
And additionally, when we change 'bdi->wb.task', we now take the
'bdi->work_lock', to make sure that we do not lose wake-ups which we otherwise
would when raced with, say, 'bdi_queue_work()'.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:20 +07:00
|
|
|
break;
|
|
|
|
|
|
|
|
case KILL_THREAD:
|
|
|
|
__set_current_state(TASK_RUNNING);
|
|
|
|
kthread_stop(task);
|
2011-09-03 06:04:09 +07:00
|
|
|
bdi_clear_pending(bdi);
|
2010-07-25 18:29:19 +07:00
|
|
|
break;
|
2009-09-09 14:08:54 +07:00
|
|
|
|
2010-07-25 18:29:19 +07:00
|
|
|
case NO_ACTION:
|
2010-07-25 18:29:21 +07:00
|
|
|
if (!wb_has_dirty_io(me) || !dirty_writeback_interval)
|
|
|
|
/*
|
|
|
|
* There are no dirty data. The only thing we
|
|
|
|
* should now care about is checking for
|
|
|
|
* inactive bdi threads and killing them. Thus,
|
|
|
|
* let's sleep for longer time, save energy and
|
|
|
|
* be friendly for battery-driven devices.
|
|
|
|
*/
|
|
|
|
schedule_timeout(bdi_longest_inactive());
|
2010-05-22 01:00:35 +07:00
|
|
|
else
|
2010-07-25 18:29:21 +07:00
|
|
|
schedule_timeout(msecs_to_jiffies(dirty_writeback_interval * 10));
|
2009-09-09 14:08:54 +07:00
|
|
|
try_to_freeze();
|
2011-09-03 06:04:09 +07:00
|
|
|
break;
|
2009-09-09 14:08:54 +07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-09-14 18:12:40 +07:00
|
|
|
/*
|
|
|
|
* Remove bdi from bdi_list, and ensure that it is no longer visible
|
|
|
|
*/
|
|
|
|
static void bdi_remove_from_list(struct backing_dev_info *bdi)
|
|
|
|
{
|
|
|
|
spin_lock_bh(&bdi_lock);
|
|
|
|
list_del_rcu(&bdi->bdi_list);
|
|
|
|
spin_unlock_bh(&bdi_lock);
|
|
|
|
|
2011-07-24 01:44:24 +07:00
|
|
|
synchronize_rcu_expedited();
|
2009-09-14 18:12:40 +07:00
|
|
|
}
|
|
|
|
|
2008-04-30 14:54:32 +07:00
|
|
|
int bdi_register(struct backing_dev_info *bdi, struct device *parent,
|
|
|
|
const char *fmt, ...)
|
|
|
|
{
|
|
|
|
va_list args;
|
|
|
|
struct device *dev;
|
|
|
|
|
2008-12-10 04:14:06 +07:00
|
|
|
if (bdi->dev) /* The driver needs to use separate queues per device */
|
writeback: cleanup bdi_register
This patch makes sure we first initialize everything and set the BDI_registered
flag, and only after this we add the bdi to 'bdi_list'. Current code adds the
bdi to the list too early, and as a result I the
WARN(!test_bit(BDI_registered, &bdi->state)
in bdi forker is triggered. Also, it is in general good practice to make things
visible only when they are fully initialized.
Also, this patch does few micro clean-ups:
1. Removes the 'exit' label which does not do anything, just returns. This
allows to get rid of few braces and 'ret' variable and make the code smaller.
2. If 'kthread_run()' fails, remove the error code it returns, not hard-coded
'-ENOMEM'. Theoretically, some day 'kthread_run()' can return something
else. Also, in case of failure it is not necessary to set 'bdi->wb.task' to
NULL.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:25 +07:00
|
|
|
return 0;
|
2008-12-03 01:31:50 +07:00
|
|
|
|
2008-04-30 14:54:32 +07:00
|
|
|
va_start(args, fmt);
|
2008-05-16 03:44:08 +07:00
|
|
|
dev = device_create_vargs(bdi_class, parent, MKDEV(0, 0), bdi, fmt, args);
|
2008-04-30 14:54:32 +07:00
|
|
|
va_end(args);
|
writeback: cleanup bdi_register
This patch makes sure we first initialize everything and set the BDI_registered
flag, and only after this we add the bdi to 'bdi_list'. Current code adds the
bdi to the list too early, and as a result I the
WARN(!test_bit(BDI_registered, &bdi->state)
in bdi forker is triggered. Also, it is in general good practice to make things
visible only when they are fully initialized.
Also, this patch does few micro clean-ups:
1. Removes the 'exit' label which does not do anything, just returns. This
allows to get rid of few braces and 'ret' variable and make the code smaller.
2. If 'kthread_run()' fails, remove the error code it returns, not hard-coded
'-ENOMEM'. Theoretically, some day 'kthread_run()' can return something
else. Also, in case of failure it is not necessary to set 'bdi->wb.task' to
NULL.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:25 +07:00
|
|
|
if (IS_ERR(dev))
|
|
|
|
return PTR_ERR(dev);
|
2009-09-02 14:19:46 +07:00
|
|
|
|
2008-04-30 14:54:32 +07:00
|
|
|
bdi->dev = dev;
|
|
|
|
|
2009-09-09 14:08:54 +07:00
|
|
|
/*
|
|
|
|
* Just start the forker thread for our default backing_dev_info,
|
|
|
|
* and add other bdi's to the list. They will get a thread created
|
|
|
|
* on-demand when they need it.
|
|
|
|
*/
|
|
|
|
if (bdi_cap_flush_forker(bdi)) {
|
|
|
|
struct bdi_writeback *wb = &bdi->wb;
|
|
|
|
|
2010-07-25 18:29:11 +07:00
|
|
|
wb->task = kthread_run(bdi_forker_thread, wb, "bdi-%s",
|
2009-09-09 14:08:54 +07:00
|
|
|
dev_name(dev));
|
writeback: cleanup bdi_register
This patch makes sure we first initialize everything and set the BDI_registered
flag, and only after this we add the bdi to 'bdi_list'. Current code adds the
bdi to the list too early, and as a result I the
WARN(!test_bit(BDI_registered, &bdi->state)
in bdi forker is triggered. Also, it is in general good practice to make things
visible only when they are fully initialized.
Also, this patch does few micro clean-ups:
1. Removes the 'exit' label which does not do anything, just returns. This
allows to get rid of few braces and 'ret' variable and make the code smaller.
2. If 'kthread_run()' fails, remove the error code it returns, not hard-coded
'-ENOMEM'. Theoretically, some day 'kthread_run()' can return something
else. Also, in case of failure it is not necessary to set 'bdi->wb.task' to
NULL.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:25 +07:00
|
|
|
if (IS_ERR(wb->task))
|
|
|
|
return PTR_ERR(wb->task);
|
2009-09-09 14:08:54 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
bdi_debug_register(bdi, dev_name(dev));
|
2009-09-09 14:10:25 +07:00
|
|
|
set_bit(BDI_registered, &bdi->state);
|
writeback: cleanup bdi_register
This patch makes sure we first initialize everything and set the BDI_registered
flag, and only after this we add the bdi to 'bdi_list'. Current code adds the
bdi to the list too early, and as a result I the
WARN(!test_bit(BDI_registered, &bdi->state)
in bdi forker is triggered. Also, it is in general good practice to make things
visible only when they are fully initialized.
Also, this patch does few micro clean-ups:
1. Removes the 'exit' label which does not do anything, just returns. This
allows to get rid of few braces and 'ret' variable and make the code smaller.
2. If 'kthread_run()' fails, remove the error code it returns, not hard-coded
'-ENOMEM'. Theoretically, some day 'kthread_run()' can return something
else. Also, in case of failure it is not necessary to set 'bdi->wb.task' to
NULL.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:25 +07:00
|
|
|
|
|
|
|
spin_lock_bh(&bdi_lock);
|
|
|
|
list_add_tail_rcu(&bdi->bdi_list, &bdi_list);
|
|
|
|
spin_unlock_bh(&bdi_lock);
|
|
|
|
|
2010-07-07 10:24:06 +07:00
|
|
|
trace_writeback_bdi_register(bdi);
|
writeback: cleanup bdi_register
This patch makes sure we first initialize everything and set the BDI_registered
flag, and only after this we add the bdi to 'bdi_list'. Current code adds the
bdi to the list too early, and as a result I the
WARN(!test_bit(BDI_registered, &bdi->state)
in bdi forker is triggered. Also, it is in general good practice to make things
visible only when they are fully initialized.
Also, this patch does few micro clean-ups:
1. Removes the 'exit' label which does not do anything, just returns. This
allows to get rid of few braces and 'ret' variable and make the code smaller.
2. If 'kthread_run()' fails, remove the error code it returns, not hard-coded
'-ENOMEM'. Theoretically, some day 'kthread_run()' can return something
else. Also, in case of failure it is not necessary to set 'bdi->wb.task' to
NULL.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:25 +07:00
|
|
|
return 0;
|
2008-04-30 14:54:32 +07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(bdi_register);
|
|
|
|
|
|
|
|
int bdi_register_dev(struct backing_dev_info *bdi, dev_t dev)
|
|
|
|
{
|
|
|
|
return bdi_register(bdi, NULL, "%u:%u", MAJOR(dev), MINOR(dev));
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(bdi_register_dev);
|
|
|
|
|
2009-09-09 14:08:54 +07:00
|
|
|
/*
|
|
|
|
* Remove bdi from the global list and shutdown any threads we have running
|
|
|
|
*/
|
|
|
|
static void bdi_wb_shutdown(struct backing_dev_info *bdi)
|
2009-09-02 14:19:46 +07:00
|
|
|
{
|
2012-01-30 01:17:33 +07:00
|
|
|
struct task_struct *task;
|
|
|
|
|
2009-09-09 14:08:54 +07:00
|
|
|
if (!bdi_cap_writeback_dirty(bdi))
|
|
|
|
return;
|
|
|
|
|
|
|
|
/*
|
writeback: move bdi threads exiting logic to the forker thread
Currently, bdi threads can decide to exit if there were no useful activities
for 5 minutes. However, this causes nasty races: we can easily oops in the
'bdi_queue_work()' if the bdi thread decides to exit while we are waking it up.
And even if we do not oops, but the bdi tread exits immediately after we wake
it up, we'd lose the wake-up event and have an unnecessary delay (up to 5 secs)
in the bdi work processing.
This patch makes the forker thread to be the central place which not only
creates bdi threads, but also kills them if they were inactive long enough.
This better design-wise.
Another reason why this change was done is to prepare for the further changes
which will prevent the bdi threads from waking up every 5 sec and wasting
power. Indeed, when the task does not wake up periodically anymore, it won't be
able to exit either.
This patch also moves the the 'wake_up_bit()' call from the bdi thread to the
forker thread as well. So now the forker thread sets the BDI_pending bit, then
forks the task or kills it, then clears the bit and wakes up the waiting
process.
The only process which may wain on the bit is 'bdi_wb_shutdown()'. This
function was changed as well - now it first removes the bdi from the
'bdi_list', then waits on the 'BDI_pending' bit. Once it wakes up, it is
guaranteed that the forker thread won't race with it, because the bdi is not
visible. Note, the forker thread sets the 'BDI_pending' bit under the
'bdi->wb_lock' which is essential for proper serialization.
And additionally, when we change 'bdi->wb.task', we now take the
'bdi->work_lock', to make sure that we do not lose wake-ups which we otherwise
would when raced with, say, 'bdi_queue_work()'.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:20 +07:00
|
|
|
* Make sure nobody finds us on the bdi_list anymore
|
2009-09-09 14:08:54 +07:00
|
|
|
*/
|
writeback: move bdi threads exiting logic to the forker thread
Currently, bdi threads can decide to exit if there were no useful activities
for 5 minutes. However, this causes nasty races: we can easily oops in the
'bdi_queue_work()' if the bdi thread decides to exit while we are waking it up.
And even if we do not oops, but the bdi tread exits immediately after we wake
it up, we'd lose the wake-up event and have an unnecessary delay (up to 5 secs)
in the bdi work processing.
This patch makes the forker thread to be the central place which not only
creates bdi threads, but also kills them if they were inactive long enough.
This better design-wise.
Another reason why this change was done is to prepare for the further changes
which will prevent the bdi threads from waking up every 5 sec and wasting
power. Indeed, when the task does not wake up periodically anymore, it won't be
able to exit either.
This patch also moves the the 'wake_up_bit()' call from the bdi thread to the
forker thread as well. So now the forker thread sets the BDI_pending bit, then
forks the task or kills it, then clears the bit and wakes up the waiting
process.
The only process which may wain on the bit is 'bdi_wb_shutdown()'. This
function was changed as well - now it first removes the bdi from the
'bdi_list', then waits on the 'BDI_pending' bit. Once it wakes up, it is
guaranteed that the forker thread won't race with it, because the bdi is not
visible. Note, the forker thread sets the 'BDI_pending' bit under the
'bdi->wb_lock' which is essential for proper serialization.
And additionally, when we change 'bdi->wb.task', we now take the
'bdi->work_lock', to make sure that we do not lose wake-ups which we otherwise
would when raced with, say, 'bdi_queue_work()'.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:20 +07:00
|
|
|
bdi_remove_from_list(bdi);
|
2009-09-09 14:08:54 +07:00
|
|
|
|
|
|
|
/*
|
writeback: move bdi threads exiting logic to the forker thread
Currently, bdi threads can decide to exit if there were no useful activities
for 5 minutes. However, this causes nasty races: we can easily oops in the
'bdi_queue_work()' if the bdi thread decides to exit while we are waking it up.
And even if we do not oops, but the bdi tread exits immediately after we wake
it up, we'd lose the wake-up event and have an unnecessary delay (up to 5 secs)
in the bdi work processing.
This patch makes the forker thread to be the central place which not only
creates bdi threads, but also kills them if they were inactive long enough.
This better design-wise.
Another reason why this change was done is to prepare for the further changes
which will prevent the bdi threads from waking up every 5 sec and wasting
power. Indeed, when the task does not wake up periodically anymore, it won't be
able to exit either.
This patch also moves the the 'wake_up_bit()' call from the bdi thread to the
forker thread as well. So now the forker thread sets the BDI_pending bit, then
forks the task or kills it, then clears the bit and wakes up the waiting
process.
The only process which may wain on the bit is 'bdi_wb_shutdown()'. This
function was changed as well - now it first removes the bdi from the
'bdi_list', then waits on the 'BDI_pending' bit. Once it wakes up, it is
guaranteed that the forker thread won't race with it, because the bdi is not
visible. Note, the forker thread sets the 'BDI_pending' bit under the
'bdi->wb_lock' which is essential for proper serialization.
And additionally, when we change 'bdi->wb.task', we now take the
'bdi->work_lock', to make sure that we do not lose wake-ups which we otherwise
would when raced with, say, 'bdi_queue_work()'.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:20 +07:00
|
|
|
* If setup is pending, wait for that to complete first
|
2009-09-09 14:08:54 +07:00
|
|
|
*/
|
writeback: move bdi threads exiting logic to the forker thread
Currently, bdi threads can decide to exit if there were no useful activities
for 5 minutes. However, this causes nasty races: we can easily oops in the
'bdi_queue_work()' if the bdi thread decides to exit while we are waking it up.
And even if we do not oops, but the bdi tread exits immediately after we wake
it up, we'd lose the wake-up event and have an unnecessary delay (up to 5 secs)
in the bdi work processing.
This patch makes the forker thread to be the central place which not only
creates bdi threads, but also kills them if they were inactive long enough.
This better design-wise.
Another reason why this change was done is to prepare for the further changes
which will prevent the bdi threads from waking up every 5 sec and wasting
power. Indeed, when the task does not wake up periodically anymore, it won't be
able to exit either.
This patch also moves the the 'wake_up_bit()' call from the bdi thread to the
forker thread as well. So now the forker thread sets the BDI_pending bit, then
forks the task or kills it, then clears the bit and wakes up the waiting
process.
The only process which may wain on the bit is 'bdi_wb_shutdown()'. This
function was changed as well - now it first removes the bdi from the
'bdi_list', then waits on the 'BDI_pending' bit. Once it wakes up, it is
guaranteed that the forker thread won't race with it, because the bdi is not
visible. Note, the forker thread sets the 'BDI_pending' bit under the
'bdi->wb_lock' which is essential for proper serialization.
And additionally, when we change 'bdi->wb.task', we now take the
'bdi->work_lock', to make sure that we do not lose wake-ups which we otherwise
would when raced with, say, 'bdi_queue_work()'.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-07-25 18:29:20 +07:00
|
|
|
wait_on_bit(&bdi->state, BDI_pending, bdi_sched_wait,
|
|
|
|
TASK_UNINTERRUPTIBLE);
|
2009-09-09 14:08:54 +07:00
|
|
|
|
|
|
|
/*
|
2010-06-20 04:08:06 +07:00
|
|
|
* Finally, kill the kernel thread. We don't need to be RCU
|
2011-11-22 03:32:23 +07:00
|
|
|
* safe anymore, since the bdi is gone from visibility.
|
2009-09-09 14:08:54 +07:00
|
|
|
*/
|
2012-01-30 01:17:33 +07:00
|
|
|
spin_lock_bh(&bdi->wb_lock);
|
|
|
|
task = bdi->wb.task;
|
|
|
|
bdi->wb.task = NULL;
|
|
|
|
spin_unlock_bh(&bdi->wb_lock);
|
|
|
|
|
|
|
|
if (task)
|
|
|
|
kthread_stop(task);
|
2009-09-02 14:19:46 +07:00
|
|
|
}
|
|
|
|
|
2009-10-29 17:46:12 +07:00
|
|
|
/*
|
|
|
|
* This bdi is going away now, make sure that no super_blocks point to it
|
|
|
|
*/
|
|
|
|
static void bdi_prune_sb(struct backing_dev_info *bdi)
|
|
|
|
{
|
|
|
|
struct super_block *sb;
|
|
|
|
|
|
|
|
spin_lock(&sb_lock);
|
|
|
|
list_for_each_entry(sb, &super_blocks, s_list) {
|
|
|
|
if (sb->s_bdi == bdi)
|
2011-03-17 17:13:12 +07:00
|
|
|
sb->s_bdi = &default_backing_dev_info;
|
2009-10-29 17:46:12 +07:00
|
|
|
}
|
|
|
|
spin_unlock(&sb_lock);
|
|
|
|
}
|
|
|
|
|
2008-04-30 14:54:32 +07:00
|
|
|
void bdi_unregister(struct backing_dev_info *bdi)
|
|
|
|
{
|
2012-01-30 01:17:33 +07:00
|
|
|
struct device *dev = bdi->dev;
|
|
|
|
|
|
|
|
if (dev) {
|
2011-07-26 07:11:57 +07:00
|
|
|
bdi_set_min_ratio(bdi, 0);
|
2010-07-07 10:24:06 +07:00
|
|
|
trace_writeback_bdi_unregister(bdi);
|
2009-11-04 02:18:44 +07:00
|
|
|
bdi_prune_sb(bdi);
|
2010-07-25 18:29:22 +07:00
|
|
|
del_timer_sync(&bdi->wb.wakeup_timer);
|
2009-11-04 02:18:44 +07:00
|
|
|
|
2009-09-09 14:08:54 +07:00
|
|
|
if (!bdi_cap_flush_forker(bdi))
|
|
|
|
bdi_wb_shutdown(bdi);
|
2008-04-30 14:54:36 +07:00
|
|
|
bdi_debug_unregister(bdi);
|
2012-01-30 01:17:33 +07:00
|
|
|
|
|
|
|
spin_lock_bh(&bdi->wb_lock);
|
2008-04-30 14:54:32 +07:00
|
|
|
bdi->dev = NULL;
|
2012-01-30 01:17:33 +07:00
|
|
|
spin_unlock_bh(&bdi->wb_lock);
|
|
|
|
|
|
|
|
device_unregister(dev);
|
2008-04-30 14:54:32 +07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(bdi_unregister);
|
2006-10-20 13:28:16 +07:00
|
|
|
|
2010-07-25 18:29:22 +07:00
|
|
|
static void bdi_wb_init(struct bdi_writeback *wb, struct backing_dev_info *bdi)
|
|
|
|
{
|
|
|
|
memset(wb, 0, sizeof(*wb));
|
|
|
|
|
|
|
|
wb->bdi = bdi;
|
|
|
|
wb->last_old_flush = jiffies;
|
|
|
|
INIT_LIST_HEAD(&wb->b_dirty);
|
|
|
|
INIT_LIST_HEAD(&wb->b_io);
|
|
|
|
INIT_LIST_HEAD(&wb->b_more_io);
|
2011-04-22 07:19:44 +07:00
|
|
|
spin_lock_init(&wb->list_lock);
|
2010-07-25 18:29:22 +07:00
|
|
|
setup_timer(&wb->wakeup_timer, wakeup_timer_fn, (unsigned long)bdi);
|
|
|
|
}
|
|
|
|
|
2010-08-30 00:22:30 +07:00
|
|
|
/*
|
|
|
|
* Initial write bandwidth: 100 MB/s
|
|
|
|
*/
|
|
|
|
#define INIT_BW (100 << (20 - PAGE_SHIFT))
|
|
|
|
|
2007-10-17 13:25:47 +07:00
|
|
|
int bdi_init(struct backing_dev_info *bdi)
|
|
|
|
{
|
2009-09-09 14:08:54 +07:00
|
|
|
int i, err;
|
2007-10-17 13:25:47 +07:00
|
|
|
|
2008-04-30 14:54:32 +07:00
|
|
|
bdi->dev = NULL;
|
|
|
|
|
2008-04-30 14:54:35 +07:00
|
|
|
bdi->min_ratio = 0;
|
2008-04-30 14:54:36 +07:00
|
|
|
bdi->max_ratio = 100;
|
|
|
|
bdi->max_prop_frac = PROP_FRAC_BASE;
|
2009-09-09 14:08:54 +07:00
|
|
|
spin_lock_init(&bdi->wb_lock);
|
2009-09-02 14:19:46 +07:00
|
|
|
INIT_LIST_HEAD(&bdi->bdi_list);
|
2009-09-09 14:08:54 +07:00
|
|
|
INIT_LIST_HEAD(&bdi->work_list);
|
|
|
|
|
|
|
|
bdi_wb_init(&bdi->wb, bdi);
|
|
|
|
|
2007-10-17 13:25:47 +07:00
|
|
|
for (i = 0; i < NR_BDI_STAT_ITEMS; i++) {
|
2008-12-26 21:08:55 +07:00
|
|
|
err = percpu_counter_init(&bdi->bdi_stat[i], 0);
|
2007-10-17 13:25:50 +07:00
|
|
|
if (err)
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
|
|
|
bdi->dirty_exceeded = 0;
|
2010-08-30 00:22:30 +07:00
|
|
|
|
|
|
|
bdi->bw_time_stamp = jiffies;
|
|
|
|
bdi->written_stamp = 0;
|
|
|
|
|
writeback: stabilize bdi->dirty_ratelimit
There are some imperfections in balanced_dirty_ratelimit.
1) large fluctuations
The dirty_rate used for computing balanced_dirty_ratelimit is merely
averaged in the past 200ms (very small comparing to the 3s estimation
period for write_bw), which makes rather dispersed distribution of
balanced_dirty_ratelimit.
It's pretty hard to average out the singular points by increasing the
estimation period. Considering that the averaging technique will
introduce very undesirable time lags, I give it up totally. (btw, the 3s
write_bw averaging time lag is much more acceptable because its impact
is one-way and therefore won't lead to oscillations.)
The more practical way is filtering -- most singular
balanced_dirty_ratelimit points can be filtered out by remembering some
prev_balanced_rate and prev_prev_balanced_rate. However the more
reliable way is to guard balanced_dirty_ratelimit with task_ratelimit.
2) due to truncates and fs redirties, the (write_bw <=> dirty_rate)
match could become unbalanced, which may lead to large systematical
errors in balanced_dirty_ratelimit. The truncates, due to its possibly
bumpy nature, can hardly be compensated smoothly. So let's face it. When
some over-estimated balanced_dirty_ratelimit brings dirty_ratelimit
high, dirty pages will go higher than the setpoint. task_ratelimit will
in turn become lower than dirty_ratelimit. So if we consider both
balanced_dirty_ratelimit and task_ratelimit and update dirty_ratelimit
only when they are on the same side of dirty_ratelimit, the systematical
errors in balanced_dirty_ratelimit won't be able to bring
dirty_ratelimit far away.
The balanced_dirty_ratelimit estimation may also be inaccurate near
@limit or @freerun, however is less an issue.
3) since we ultimately want to
- keep the fluctuations of task ratelimit as small as possible
- keep the dirty pages around the setpoint as long time as possible
the update policy used for (2) also serves the above goals nicely:
if for some reason the dirty pages are high (task_ratelimit < dirty_ratelimit),
and dirty_ratelimit is low (dirty_ratelimit < balanced_dirty_ratelimit),
there is no point to bring up dirty_ratelimit in a hurry only to hurt
both the above two goals.
So, we make use of task_ratelimit to limit the update of dirty_ratelimit
in two ways:
1) avoid changing dirty rate when it's against the position control target
(the adjusted rate will slow down the progress of dirty pages going
back to setpoint).
2) limit the step size. task_ratelimit is changing values step by step,
leaving a consistent trace comparing to the randomly jumping
balanced_dirty_ratelimit. task_ratelimit also has the nice smaller
errors in stable state and typically larger errors when there are big
errors in rate. So it's a pretty good limiting factor for the step
size of dirty_ratelimit.
Note that bdi->dirty_ratelimit is always tracking balanced_dirty_ratelimit.
task_ratelimit is merely used as a limiting factor.
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
2011-08-27 04:53:24 +07:00
|
|
|
bdi->balanced_dirty_ratelimit = INIT_BW;
|
writeback: dirty rate control
It's all about bdi->dirty_ratelimit, which aims to be (write_bw / N)
when there are N dd tasks.
On write() syscall, use bdi->dirty_ratelimit
============================================
balance_dirty_pages(pages_dirtied)
{
task_ratelimit = bdi->dirty_ratelimit * bdi_position_ratio();
pause = pages_dirtied / task_ratelimit;
sleep(pause);
}
On every 200ms, update bdi->dirty_ratelimit
===========================================
bdi_update_dirty_ratelimit()
{
task_ratelimit = bdi->dirty_ratelimit * bdi_position_ratio();
balanced_dirty_ratelimit = task_ratelimit * write_bw / dirty_rate;
bdi->dirty_ratelimit = balanced_dirty_ratelimit
}
Estimation of balanced bdi->dirty_ratelimit
===========================================
balanced task_ratelimit
-----------------------
balance_dirty_pages() needs to throttle tasks dirtying pages such that
the total amount of dirty pages stays below the specified dirty limit in
order to avoid memory deadlocks. Furthermore we desire fairness in that
tasks get throttled proportionally to the amount of pages they dirty.
IOW we want to throttle tasks such that we match the dirty rate to the
writeout bandwidth, this yields a stable amount of dirty pages:
dirty_rate == write_bw (1)
The fairness requirement gives us:
task_ratelimit = balanced_dirty_ratelimit
== write_bw / N (2)
where N is the number of dd tasks. We don't know N beforehand, but
still can estimate balanced_dirty_ratelimit within 200ms.
Start by throttling each dd task at rate
task_ratelimit = task_ratelimit_0 (3)
(any non-zero initial value is OK)
After 200ms, we measured
dirty_rate = # of pages dirtied by all dd's / 200ms
write_bw = # of pages written to the disk / 200ms
For the aggressive dd dirtiers, the equality holds
dirty_rate == N * task_rate
== N * task_ratelimit_0 (4)
Or
task_ratelimit_0 == dirty_rate / N (5)
Now we conclude that the balanced task ratelimit can be estimated by
write_bw
balanced_dirty_ratelimit = task_ratelimit_0 * ---------- (6)
dirty_rate
Because with (4) and (5) we can get the desired equality (1):
write_bw
balanced_dirty_ratelimit == (dirty_rate / N) * ----------
dirty_rate
== write_bw / N
Then using the balanced task ratelimit we can compute task pause times like:
task_pause = task->nr_dirtied / task_ratelimit
task_ratelimit with position control
------------------------------------
However, while the above gives us means of matching the dirty rate to
the writeout bandwidth, it at best provides us with a stable dirty page
count (assuming a static system). In order to control the dirty page
count such that it is high enough to provide performance, but does not
exceed the specified limit we need another control.
The dirty position control works by extending (2) to
task_ratelimit = balanced_dirty_ratelimit * pos_ratio (7)
where pos_ratio is a negative feedback function that subjects to
1) f(setpoint) = 1.0
2) df/dx < 0
That is, if the dirty pages are ABOVE the setpoint, we throttle each
task a bit more HEAVY than balanced_dirty_ratelimit, so that the dirty
pages are created less fast than they are cleaned, thus DROP to the
setpoints (and the reverse).
Based on (7) and the assumption that both dirty_ratelimit and pos_ratio
remains CONSTANT for the past 200ms, we get
task_ratelimit_0 = balanced_dirty_ratelimit * pos_ratio (8)
Putting (8) into (6), we get the formula used in
bdi_update_dirty_ratelimit():
write_bw
balanced_dirty_ratelimit *= pos_ratio * ---------- (9)
dirty_rate
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
2011-06-12 23:51:31 +07:00
|
|
|
bdi->dirty_ratelimit = INIT_BW;
|
2010-08-30 00:22:30 +07:00
|
|
|
bdi->write_bandwidth = INIT_BW;
|
|
|
|
bdi->avg_write_bandwidth = INIT_BW;
|
|
|
|
|
2007-10-17 13:25:50 +07:00
|
|
|
err = prop_local_init_percpu(&bdi->completions);
|
|
|
|
|
|
|
|
if (err) {
|
|
|
|
err:
|
2007-12-05 14:45:07 +07:00
|
|
|
while (i--)
|
2007-10-17 13:25:50 +07:00
|
|
|
percpu_counter_destroy(&bdi->bdi_stat[i]);
|
2007-10-17 13:25:47 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(bdi_init);
|
|
|
|
|
|
|
|
void bdi_destroy(struct backing_dev_info *bdi)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
2009-09-14 17:57:56 +07:00
|
|
|
/*
|
|
|
|
* Splice our entries to the default_backing_dev_info, if this
|
|
|
|
* bdi disappears
|
|
|
|
*/
|
|
|
|
if (bdi_has_dirty_io(bdi)) {
|
|
|
|
struct bdi_writeback *dst = &default_backing_dev_info.wb;
|
|
|
|
|
2011-04-22 07:19:44 +07:00
|
|
|
bdi_lock_two(&bdi->wb, dst);
|
2009-09-14 17:57:56 +07:00
|
|
|
list_splice(&bdi->wb.b_dirty, &dst->b_dirty);
|
|
|
|
list_splice(&bdi->wb.b_io, &dst->b_io);
|
|
|
|
list_splice(&bdi->wb.b_more_io, &dst->b_more_io);
|
2011-04-22 07:19:44 +07:00
|
|
|
spin_unlock(&bdi->wb.list_lock);
|
|
|
|
spin_unlock(&dst->list_lock);
|
2009-09-14 17:57:56 +07:00
|
|
|
}
|
2009-09-02 14:19:46 +07:00
|
|
|
|
2008-04-30 14:54:32 +07:00
|
|
|
bdi_unregister(bdi);
|
|
|
|
|
2011-11-11 19:29:04 +07:00
|
|
|
/*
|
|
|
|
* If bdi_unregister() had already been called earlier, the
|
|
|
|
* wakeup_timer could still be armed because bdi_prune_sb()
|
|
|
|
* can race with the bdi_wakeup_thread_delayed() calls from
|
|
|
|
* __mark_inode_dirty().
|
|
|
|
*/
|
|
|
|
del_timer_sync(&bdi->wb.wakeup_timer);
|
|
|
|
|
2007-10-17 13:25:47 +07:00
|
|
|
for (i = 0; i < NR_BDI_STAT_ITEMS; i++)
|
|
|
|
percpu_counter_destroy(&bdi->bdi_stat[i]);
|
2007-10-17 13:25:50 +07:00
|
|
|
|
|
|
|
prop_local_destroy_percpu(&bdi->completions);
|
2007-10-17 13:25:47 +07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(bdi_destroy);
|
|
|
|
|
2010-04-22 16:37:01 +07:00
|
|
|
/*
|
|
|
|
* For use from filesystems to quickly init and register a bdi associated
|
|
|
|
* with dirty writeback
|
|
|
|
*/
|
|
|
|
int bdi_setup_and_register(struct backing_dev_info *bdi, char *name,
|
|
|
|
unsigned int cap)
|
|
|
|
{
|
|
|
|
char tmp[32];
|
|
|
|
int err;
|
|
|
|
|
|
|
|
bdi->name = name;
|
|
|
|
bdi->capabilities = cap;
|
|
|
|
err = bdi_init(bdi);
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
|
|
|
sprintf(tmp, "%.28s%s", name, "-%d");
|
|
|
|
err = bdi_register(bdi, NULL, tmp, atomic_long_inc_return(&bdi_seq));
|
|
|
|
if (err) {
|
|
|
|
bdi_destroy(bdi);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(bdi_setup_and_register);
|
|
|
|
|
2006-10-20 13:28:16 +07:00
|
|
|
static wait_queue_head_t congestion_wqh[2] = {
|
|
|
|
__WAIT_QUEUE_HEAD_INITIALIZER(congestion_wqh[0]),
|
|
|
|
__WAIT_QUEUE_HEAD_INITIALIZER(congestion_wqh[1])
|
|
|
|
};
|
2010-10-27 04:21:45 +07:00
|
|
|
static atomic_t nr_bdi_congested[2];
|
2006-10-20 13:28:16 +07:00
|
|
|
|
2009-04-06 19:48:01 +07:00
|
|
|
void clear_bdi_congested(struct backing_dev_info *bdi, int sync)
|
2006-10-20 13:28:16 +07:00
|
|
|
{
|
|
|
|
enum bdi_state bit;
|
2009-04-06 19:48:01 +07:00
|
|
|
wait_queue_head_t *wqh = &congestion_wqh[sync];
|
2006-10-20 13:28:16 +07:00
|
|
|
|
2009-04-06 19:48:01 +07:00
|
|
|
bit = sync ? BDI_sync_congested : BDI_async_congested;
|
2010-10-27 04:21:45 +07:00
|
|
|
if (test_and_clear_bit(bit, &bdi->state))
|
|
|
|
atomic_dec(&nr_bdi_congested[sync]);
|
2006-10-20 13:28:16 +07:00
|
|
|
smp_mb__after_clear_bit();
|
|
|
|
if (waitqueue_active(wqh))
|
|
|
|
wake_up(wqh);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(clear_bdi_congested);
|
|
|
|
|
2009-04-06 19:48:01 +07:00
|
|
|
void set_bdi_congested(struct backing_dev_info *bdi, int sync)
|
2006-10-20 13:28:16 +07:00
|
|
|
{
|
|
|
|
enum bdi_state bit;
|
|
|
|
|
2009-04-06 19:48:01 +07:00
|
|
|
bit = sync ? BDI_sync_congested : BDI_async_congested;
|
2010-10-27 04:21:45 +07:00
|
|
|
if (!test_and_set_bit(bit, &bdi->state))
|
|
|
|
atomic_inc(&nr_bdi_congested[sync]);
|
2006-10-20 13:28:16 +07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(set_bdi_congested);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* congestion_wait - wait for a backing_dev to become uncongested
|
2009-07-09 19:52:32 +07:00
|
|
|
* @sync: SYNC or ASYNC IO
|
2006-10-20 13:28:16 +07:00
|
|
|
* @timeout: timeout in jiffies
|
|
|
|
*
|
|
|
|
* Waits for up to @timeout jiffies for a backing_dev (any backing_dev) to exit
|
|
|
|
* write congestion. If no backing_devs are congested then just wait for the
|
|
|
|
* next write to be completed.
|
|
|
|
*/
|
2009-07-09 19:52:32 +07:00
|
|
|
long congestion_wait(int sync, long timeout)
|
2006-10-20 13:28:16 +07:00
|
|
|
{
|
|
|
|
long ret;
|
2010-10-27 04:21:41 +07:00
|
|
|
unsigned long start = jiffies;
|
2006-10-20 13:28:16 +07:00
|
|
|
DEFINE_WAIT(wait);
|
2009-07-09 19:52:32 +07:00
|
|
|
wait_queue_head_t *wqh = &congestion_wqh[sync];
|
2006-10-20 13:28:16 +07:00
|
|
|
|
|
|
|
prepare_to_wait(wqh, &wait, TASK_UNINTERRUPTIBLE);
|
|
|
|
ret = io_schedule_timeout(timeout);
|
|
|
|
finish_wait(wqh, &wait);
|
2010-10-27 04:21:41 +07:00
|
|
|
|
|
|
|
trace_writeback_congestion_wait(jiffies_to_usecs(timeout),
|
|
|
|
jiffies_to_usecs(jiffies - start));
|
|
|
|
|
2006-10-20 13:28:16 +07:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(congestion_wait);
|
2007-10-17 13:25:50 +07:00
|
|
|
|
2010-10-27 04:21:45 +07:00
|
|
|
/**
|
|
|
|
* wait_iff_congested - Conditionally wait for a backing_dev to become uncongested or a zone to complete writes
|
|
|
|
* @zone: A zone to check if it is heavily congested
|
|
|
|
* @sync: SYNC or ASYNC IO
|
|
|
|
* @timeout: timeout in jiffies
|
|
|
|
*
|
|
|
|
* In the event of a congested backing_dev (any backing_dev) and the given
|
|
|
|
* @zone has experienced recent congestion, this waits for up to @timeout
|
|
|
|
* jiffies for either a BDI to exit congestion of the given @sync queue
|
|
|
|
* or a write to complete.
|
|
|
|
*
|
2011-03-31 08:57:33 +07:00
|
|
|
* In the absence of zone congestion, cond_resched() is called to yield
|
2010-10-27 04:21:45 +07:00
|
|
|
* the processor if necessary but otherwise does not sleep.
|
|
|
|
*
|
|
|
|
* The return value is 0 if the sleep is for the full timeout. Otherwise,
|
|
|
|
* it is the number of jiffies that were still remaining when the function
|
|
|
|
* returned. return_value == timeout implies the function did not sleep.
|
|
|
|
*/
|
|
|
|
long wait_iff_congested(struct zone *zone, int sync, long timeout)
|
|
|
|
{
|
|
|
|
long ret;
|
|
|
|
unsigned long start = jiffies;
|
|
|
|
DEFINE_WAIT(wait);
|
|
|
|
wait_queue_head_t *wqh = &congestion_wqh[sync];
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If there is no congestion, or heavy congestion is not being
|
|
|
|
* encountered in the current zone, yield if necessary instead
|
|
|
|
* of sleeping on the congestion queue
|
|
|
|
*/
|
|
|
|
if (atomic_read(&nr_bdi_congested[sync]) == 0 ||
|
|
|
|
!zone_is_reclaim_congested(zone)) {
|
|
|
|
cond_resched();
|
|
|
|
|
|
|
|
/* In case we scheduled, work out time remaining */
|
|
|
|
ret = timeout - (jiffies - start);
|
|
|
|
if (ret < 0)
|
|
|
|
ret = 0;
|
|
|
|
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Sleep until uncongested or a write happens */
|
|
|
|
prepare_to_wait(wqh, &wait, TASK_UNINTERRUPTIBLE);
|
|
|
|
ret = io_schedule_timeout(timeout);
|
|
|
|
finish_wait(wqh, &wait);
|
|
|
|
|
|
|
|
out:
|
|
|
|
trace_writeback_wait_iff_congested(jiffies_to_usecs(timeout),
|
|
|
|
jiffies_to_usecs(jiffies - start));
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(wait_iff_congested);
|