2005-04-17 05:20:36 +07:00
|
|
|
/*
|
|
|
|
* Created: Fri Jan 19 10:48:35 2001 by faith@acm.org
|
|
|
|
*
|
|
|
|
* Copyright 2001 VA Linux Systems, Inc., Sunnyvale, California.
|
|
|
|
* All Rights Reserved.
|
|
|
|
*
|
2014-05-19 18:39:07 +07:00
|
|
|
* Author Rickard E. (Rik) Faith <faith@valinux.com>
|
|
|
|
*
|
2005-04-17 05:20:36 +07:00
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
|
|
* to deal in the Software without restriction, including without limitation
|
|
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
|
|
*
|
|
|
|
* The above copyright notice and this permission notice (including the next
|
|
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
|
|
* Software.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
* PRECISION INSIGHT AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
|
|
|
|
* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
|
|
|
|
* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
|
|
* DEALINGS IN THE SOFTWARE.
|
|
|
|
*/
|
|
|
|
|
2014-07-23 17:29:56 +07:00
|
|
|
#include <linux/debugfs.h>
|
2014-01-03 20:09:47 +07:00
|
|
|
#include <linux/fs.h>
|
2005-04-17 05:20:36 +07:00
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/moduleparam.h>
|
2014-01-03 20:09:47 +07:00
|
|
|
#include <linux/mount.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 15:04:11 +07:00
|
|
|
#include <linux/slab.h>
|
2012-10-03 00:01:07 +07:00
|
|
|
#include <drm/drmP.h>
|
2016-06-21 21:37:09 +07:00
|
|
|
#include "drm_crtc_internal.h"
|
2014-07-24 17:10:04 +07:00
|
|
|
#include "drm_legacy.h"
|
2014-09-10 17:43:53 +07:00
|
|
|
#include "drm_internal.h"
|
2016-06-21 15:54:13 +07:00
|
|
|
#include "drm_crtc_internal.h"
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2016-04-20 23:45:03 +07:00
|
|
|
/*
|
|
|
|
* drm_debug: Enable debug output.
|
|
|
|
* Bitmask of DRM_UT_x. See include/drm/drmP.h for details.
|
|
|
|
*/
|
|
|
|
unsigned int drm_debug = 0;
|
2005-04-17 05:20:36 +07:00
|
|
|
EXPORT_SYMBOL(drm_debug);
|
|
|
|
|
drm: drop obsolete drm_core.h
The drm_core.h header contains a set of constants meant to be used
throughout DRM. However, as it turns out, they're each used just once and
don't bring any benefit. They're also grossly mis-named and lack
name-spacing. This patch inlines them, or moves them into drm_internal.h
as appropriate:
- CORE_AUTHOR and CORE_DESC are inlined into corresponding MODULE_*()
macros. It's just confusing having to follow 2 pointers when trying to
find the definition of these fields. Grep'ping for MODULE_AUTHOR()
should reveal the full information, if there's no strong reason not to.
- CORE_NAME, CORE_DATE, CORE_MAJOR, CORE_MINOR, and CORE_PATCHLEVEL are
inlined into the sysfs 'version' attribute. They're stripped
everywhere else (which is just some printk() statements). CORE_NAME
just doesn't make *any* sense, as we hard-code it in many places,
anyway. The other constants are outdated and just serve
binary-compatibility purposes. Hence, inline them in 'version' sysfs
attribute (we might even try dropping it..).
- DRM_IF_MAJOR and DRM_IF_MINOR are moved into drm_internal.h as they're
only used by the global ioctl handlers. Furthermore, versioning
interfaces breaks backports and as such is deprecated, anyway. We just
keep them for historic reasons. I doubt anyone will ever modify them
again.
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20160901124837.680-6-dh.herrmann@gmail.com
2016-09-01 19:48:36 +07:00
|
|
|
MODULE_AUTHOR("Gareth Hughes, Leif Delgass, José Fonseca, Jon Smirl");
|
|
|
|
MODULE_DESCRIPTION("DRM shared core routines");
|
2005-04-17 05:20:36 +07:00
|
|
|
MODULE_LICENSE("GPL and additional rights");
|
2016-04-20 23:45:03 +07:00
|
|
|
MODULE_PARM_DESC(debug, "Enable debug output, where each bit enables a debug category.\n"
|
|
|
|
"\t\tBit 0 (0x01) will enable CORE messages (drm core code)\n"
|
|
|
|
"\t\tBit 1 (0x02) will enable DRIVER messages (drm controller code)\n"
|
|
|
|
"\t\tBit 2 (0x04) will enable KMS messages (modesetting code)\n"
|
|
|
|
"\t\tBit 3 (0x08) will enable PRIME messages (prime code)\n"
|
|
|
|
"\t\tBit 4 (0x10) will enable ATOMIC messages (atomic code)\n"
|
|
|
|
"\t\tBit 5 (0x20) will enable VBL messages (vblank code)");
|
2005-10-04 02:02:20 +07:00
|
|
|
module_param_named(debug, drm_debug, int, 0600);
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2014-02-24 21:53:25 +07:00
|
|
|
static DEFINE_SPINLOCK(drm_minor_lock);
|
2014-07-23 17:29:56 +07:00
|
|
|
static struct idr drm_minors_idr;
|
2008-04-21 13:47:32 +07:00
|
|
|
|
2014-07-23 17:29:56 +07:00
|
|
|
static struct dentry *drm_debugfs_root;
|
2011-04-18 10:35:51 +07:00
|
|
|
|
2016-08-16 06:18:04 +07:00
|
|
|
#define DRM_PRINTK_FMT "[" DRM_NAME ":%s]%s %pV"
|
|
|
|
|
|
|
|
void drm_dev_printk(const struct device *dev, const char *level,
|
|
|
|
unsigned int category, const char *function_name,
|
|
|
|
const char *prefix, const char *format, ...)
|
2011-04-18 10:35:51 +07:00
|
|
|
{
|
|
|
|
struct va_format vaf;
|
|
|
|
va_list args;
|
|
|
|
|
2016-08-16 06:18:04 +07:00
|
|
|
if (category != DRM_UT_NONE && !(drm_debug & category))
|
|
|
|
return;
|
2011-04-18 10:35:51 +07:00
|
|
|
|
2016-08-16 06:18:04 +07:00
|
|
|
va_start(args, format);
|
2011-04-18 10:35:51 +07:00
|
|
|
vaf.fmt = format;
|
|
|
|
vaf.va = &args;
|
|
|
|
|
2016-08-19 14:37:50 +07:00
|
|
|
if (dev)
|
|
|
|
dev_printk(level, dev, DRM_PRINTK_FMT, function_name, prefix,
|
|
|
|
&vaf);
|
|
|
|
else
|
|
|
|
printk("%s" DRM_PRINTK_FMT, level, function_name, prefix, &vaf);
|
2011-04-18 10:35:51 +07:00
|
|
|
|
|
|
|
va_end(args);
|
|
|
|
}
|
2016-08-16 06:18:04 +07:00
|
|
|
EXPORT_SYMBOL(drm_dev_printk);
|
2011-04-18 10:35:51 +07:00
|
|
|
|
2016-08-16 06:18:04 +07:00
|
|
|
void drm_printk(const char *level, unsigned int category,
|
|
|
|
const char *function_name, const char *prefix,
|
|
|
|
const char *format, ...)
|
drm: add separate drm debugging levels
Now all the DRM debug info will be reported if the boot option of
"drm.debug=1" is added. Sometimes it is inconvenient to get the debug
info in KMS mode. We will get too much unrelated info.
This will separate several DRM debug levels and the debug level can be used
to print the different debug info. And the debug level is controlled by the
module parameter of drm.debug
In this patch it is divided into four debug levels;
drm_core, drm_driver, drm_kms, drm_mode.
At the same time we can get the different debug info by changing the debug
level. This can be done by adding the module parameter. Of course it can
be changed through the /sys/module/drm/parameters/debug after the system is
booted.
Four debug macro definitions are provided.
DRM_DEBUG(fmt, args...)
DRM_DEBUG_DRIVER(prefix, fmt, args...)
DRM_DEBUG_KMS(prefix, fmt, args...)
DRM_DEBUG_MODE(prefix, fmt, args...)
When the boot option of "drm.debug=4" is added, it will print the debug info
using DRM_DEBUG_KMS macro definition.
When the boot option of "drm.debug=6" is added, it will print the debug info
using DRM_DEBUG_KMS/DRM_DEBUG_DRIVER.
Sometimes we expect to print the value of an array.
For example: SDVO command,
In such case the following four DRM debug macro definitions are added:
DRM_LOG(fmt, args...)
DRM_LOG_DRIVER(fmt, args...)
DRM_LOG_KMS(fmt, args...)
DRM_LOG_MODE(fmt, args...)
Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
2009-06-02 13:09:47 +07:00
|
|
|
{
|
2013-11-18 04:25:02 +07:00
|
|
|
struct va_format vaf;
|
drm: add separate drm debugging levels
Now all the DRM debug info will be reported if the boot option of
"drm.debug=1" is added. Sometimes it is inconvenient to get the debug
info in KMS mode. We will get too much unrelated info.
This will separate several DRM debug levels and the debug level can be used
to print the different debug info. And the debug level is controlled by the
module parameter of drm.debug
In this patch it is divided into four debug levels;
drm_core, drm_driver, drm_kms, drm_mode.
At the same time we can get the different debug info by changing the debug
level. This can be done by adding the module parameter. Of course it can
be changed through the /sys/module/drm/parameters/debug after the system is
booted.
Four debug macro definitions are provided.
DRM_DEBUG(fmt, args...)
DRM_DEBUG_DRIVER(prefix, fmt, args...)
DRM_DEBUG_KMS(prefix, fmt, args...)
DRM_DEBUG_MODE(prefix, fmt, args...)
When the boot option of "drm.debug=4" is added, it will print the debug info
using DRM_DEBUG_KMS macro definition.
When the boot option of "drm.debug=6" is added, it will print the debug info
using DRM_DEBUG_KMS/DRM_DEBUG_DRIVER.
Sometimes we expect to print the value of an array.
For example: SDVO command,
In such case the following four DRM debug macro definitions are added:
DRM_LOG(fmt, args...)
DRM_LOG_DRIVER(fmt, args...)
DRM_LOG_KMS(fmt, args...)
DRM_LOG_MODE(fmt, args...)
Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
2009-06-02 13:09:47 +07:00
|
|
|
va_list args;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2016-08-16 06:18:04 +07:00
|
|
|
if (category != DRM_UT_NONE && !(drm_debug & category))
|
|
|
|
return;
|
|
|
|
|
drm: Pull the test on drm_debug in the logging macros
In the logging code, we are currently checking is we need to output in
drm_ut_debug_printk(). This is too late. The problem is that when we write
something like:
DRM_DEBUG_DRIVER("ELD on [CONNECTOR:%d:%s], [ENCODER:%d:%s]\n",
connector->base.id,
drm_get_connector_name(connector),
connector->encoder->base.id,
drm_get_encoder_name(connector->encoder));
We start by evaluating the arguments (so call drm_get_connector_name() and
drm_get_connector_name()) before ending up in drm_ut_debug_printk() which will
then does nothing.
This means we execute a lot of instructions (drm_get_connector_name(), in turn,
calls snprintf() for example) to happily discard them in the normal case,
drm.debug=0.
So, let's put the test on drm_debug earlier, in the macros themselves.
Sprinkle an unlikely() as well for good measure.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
2014-03-24 22:53:15 +07:00
|
|
|
va_start(args, format);
|
|
|
|
vaf.fmt = format;
|
|
|
|
vaf.va = &args;
|
|
|
|
|
2016-08-16 06:18:04 +07:00
|
|
|
printk("%s" DRM_PRINTK_FMT, level, function_name, prefix, &vaf);
|
drm: Pull the test on drm_debug in the logging macros
In the logging code, we are currently checking is we need to output in
drm_ut_debug_printk(). This is too late. The problem is that when we write
something like:
DRM_DEBUG_DRIVER("ELD on [CONNECTOR:%d:%s], [ENCODER:%d:%s]\n",
connector->base.id,
drm_get_connector_name(connector),
connector->encoder->base.id,
drm_get_encoder_name(connector->encoder));
We start by evaluating the arguments (so call drm_get_connector_name() and
drm_get_connector_name()) before ending up in drm_ut_debug_printk() which will
then does nothing.
This means we execute a lot of instructions (drm_get_connector_name(), in turn,
calls snprintf() for example) to happily discard them in the normal case,
drm.debug=0.
So, let's put the test on drm_debug earlier, in the macros themselves.
Sprinkle an unlikely() as well for good measure.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
2014-03-24 22:53:15 +07:00
|
|
|
|
|
|
|
va_end(args);
|
drm: add separate drm debugging levels
Now all the DRM debug info will be reported if the boot option of
"drm.debug=1" is added. Sometimes it is inconvenient to get the debug
info in KMS mode. We will get too much unrelated info.
This will separate several DRM debug levels and the debug level can be used
to print the different debug info. And the debug level is controlled by the
module parameter of drm.debug
In this patch it is divided into four debug levels;
drm_core, drm_driver, drm_kms, drm_mode.
At the same time we can get the different debug info by changing the debug
level. This can be done by adding the module parameter. Of course it can
be changed through the /sys/module/drm/parameters/debug after the system is
booted.
Four debug macro definitions are provided.
DRM_DEBUG(fmt, args...)
DRM_DEBUG_DRIVER(prefix, fmt, args...)
DRM_DEBUG_KMS(prefix, fmt, args...)
DRM_DEBUG_MODE(prefix, fmt, args...)
When the boot option of "drm.debug=4" is added, it will print the debug info
using DRM_DEBUG_KMS macro definition.
When the boot option of "drm.debug=6" is added, it will print the debug info
using DRM_DEBUG_KMS/DRM_DEBUG_DRIVER.
Sometimes we expect to print the value of an array.
For example: SDVO command,
In such case the following four DRM debug macro definitions are added:
DRM_LOG(fmt, args...)
DRM_LOG_DRIVER(fmt, args...)
DRM_LOG_KMS(fmt, args...)
DRM_LOG_MODE(fmt, args...)
Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
2009-06-02 13:09:47 +07:00
|
|
|
}
|
2016-08-16 06:18:04 +07:00
|
|
|
EXPORT_SYMBOL(drm_printk);
|
2011-04-18 10:35:51 +07:00
|
|
|
|
2014-02-24 21:53:25 +07:00
|
|
|
/*
|
|
|
|
* DRM Minors
|
|
|
|
* A DRM device can provide several char-dev interfaces on the DRM-Major. Each
|
|
|
|
* of them is represented by a drm_minor object. Depending on the capabilities
|
|
|
|
* of the device-driver, different interfaces are registered.
|
2005-04-17 05:20:36 +07:00
|
|
|
*
|
2014-02-24 21:53:25 +07:00
|
|
|
* Minors can be accessed via dev->$minor_name. This pointer is either
|
|
|
|
* NULL or a valid drm_minor pointer and stays valid as long as the device is
|
|
|
|
* valid. This means, DRM minors have the same life-time as the underlying
|
|
|
|
* device. However, this doesn't mean that the minor is active. Minors are
|
|
|
|
* registered and unregistered dynamically according to device-state.
|
2005-04-17 05:20:36 +07:00
|
|
|
*/
|
2014-02-24 21:53:25 +07:00
|
|
|
|
2014-01-29 18:43:56 +07:00
|
|
|
static struct drm_minor **drm_minor_get_slot(struct drm_device *dev,
|
|
|
|
unsigned int type)
|
|
|
|
{
|
|
|
|
switch (type) {
|
2016-08-04 01:04:25 +07:00
|
|
|
case DRM_MINOR_PRIMARY:
|
2014-01-29 18:43:56 +07:00
|
|
|
return &dev->primary;
|
|
|
|
case DRM_MINOR_RENDER:
|
|
|
|
return &dev->render;
|
|
|
|
case DRM_MINOR_CONTROL:
|
|
|
|
return &dev->control;
|
|
|
|
default:
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static int drm_minor_alloc(struct drm_device *dev, unsigned int type)
|
|
|
|
{
|
|
|
|
struct drm_minor *minor;
|
2014-07-23 15:34:52 +07:00
|
|
|
unsigned long flags;
|
|
|
|
int r;
|
2014-01-29 18:43:56 +07:00
|
|
|
|
|
|
|
minor = kzalloc(sizeof(*minor), GFP_KERNEL);
|
|
|
|
if (!minor)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
minor->type = type;
|
|
|
|
minor->dev = dev;
|
|
|
|
|
2014-07-23 15:34:52 +07:00
|
|
|
idr_preload(GFP_KERNEL);
|
|
|
|
spin_lock_irqsave(&drm_minor_lock, flags);
|
|
|
|
r = idr_alloc(&drm_minors_idr,
|
|
|
|
NULL,
|
|
|
|
64 * type,
|
|
|
|
64 * (type + 1),
|
|
|
|
GFP_NOWAIT);
|
|
|
|
spin_unlock_irqrestore(&drm_minor_lock, flags);
|
|
|
|
idr_preload_end();
|
|
|
|
|
|
|
|
if (r < 0)
|
|
|
|
goto err_free;
|
|
|
|
|
|
|
|
minor->index = r;
|
|
|
|
|
2014-07-23 16:38:38 +07:00
|
|
|
minor->kdev = drm_sysfs_minor_alloc(minor);
|
|
|
|
if (IS_ERR(minor->kdev)) {
|
|
|
|
r = PTR_ERR(minor->kdev);
|
|
|
|
goto err_index;
|
|
|
|
}
|
|
|
|
|
2014-01-29 18:43:56 +07:00
|
|
|
*drm_minor_get_slot(dev, type) = minor;
|
|
|
|
return 0;
|
2014-07-23 15:34:52 +07:00
|
|
|
|
2014-07-23 16:38:38 +07:00
|
|
|
err_index:
|
|
|
|
spin_lock_irqsave(&drm_minor_lock, flags);
|
|
|
|
idr_remove(&drm_minors_idr, minor->index);
|
|
|
|
spin_unlock_irqrestore(&drm_minor_lock, flags);
|
2014-07-23 15:34:52 +07:00
|
|
|
err_free:
|
|
|
|
kfree(minor);
|
|
|
|
return r;
|
2014-01-29 18:43:56 +07:00
|
|
|
}
|
|
|
|
|
2014-01-29 18:55:48 +07:00
|
|
|
static void drm_minor_free(struct drm_device *dev, unsigned int type)
|
|
|
|
{
|
2014-07-23 15:34:52 +07:00
|
|
|
struct drm_minor **slot, *minor;
|
|
|
|
unsigned long flags;
|
2014-01-29 18:55:48 +07:00
|
|
|
|
|
|
|
slot = drm_minor_get_slot(dev, type);
|
2014-07-23 15:34:52 +07:00
|
|
|
minor = *slot;
|
|
|
|
if (!minor)
|
|
|
|
return;
|
|
|
|
|
2014-07-23 16:38:38 +07:00
|
|
|
put_device(minor->kdev);
|
2014-07-23 15:34:52 +07:00
|
|
|
|
|
|
|
spin_lock_irqsave(&drm_minor_lock, flags);
|
|
|
|
idr_remove(&drm_minors_idr, minor->index);
|
|
|
|
spin_unlock_irqrestore(&drm_minor_lock, flags);
|
|
|
|
|
|
|
|
kfree(minor);
|
|
|
|
*slot = NULL;
|
2014-01-29 18:55:48 +07:00
|
|
|
}
|
|
|
|
|
2014-01-29 18:57:05 +07:00
|
|
|
static int drm_minor_register(struct drm_device *dev, unsigned int type)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2014-07-23 15:34:52 +07:00
|
|
|
struct drm_minor *minor;
|
2014-02-24 21:53:25 +07:00
|
|
|
unsigned long flags;
|
2005-04-17 05:20:36 +07:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
DRM_DEBUG("\n");
|
|
|
|
|
2014-07-23 15:34:52 +07:00
|
|
|
minor = *drm_minor_get_slot(dev, type);
|
|
|
|
if (!minor)
|
2014-01-29 18:43:56 +07:00
|
|
|
return 0;
|
|
|
|
|
2014-07-23 15:34:52 +07:00
|
|
|
ret = drm_debugfs_init(minor, minor->index, drm_debugfs_root);
|
2009-02-18 08:08:49 +07:00
|
|
|
if (ret) {
|
2009-06-02 13:01:37 +07:00
|
|
|
DRM_ERROR("DRM: Failed to initialize /sys/kernel/debug/dri.\n");
|
2014-07-23 15:34:52 +07:00
|
|
|
return ret;
|
2009-02-18 08:08:49 +07:00
|
|
|
}
|
2008-04-21 13:47:32 +07:00
|
|
|
|
2014-07-23 16:38:38 +07:00
|
|
|
ret = device_add(minor->kdev);
|
|
|
|
if (ret)
|
2013-08-08 20:41:34 +07:00
|
|
|
goto err_debugfs;
|
2008-04-21 13:47:32 +07:00
|
|
|
|
2014-02-24 21:53:25 +07:00
|
|
|
/* replace NULL with @minor so lookups will succeed from now on */
|
|
|
|
spin_lock_irqsave(&drm_minor_lock, flags);
|
2014-07-23 15:34:52 +07:00
|
|
|
idr_replace(&drm_minors_idr, minor, minor->index);
|
2014-02-24 21:53:25 +07:00
|
|
|
spin_unlock_irqrestore(&drm_minor_lock, flags);
|
2008-04-21 13:47:32 +07:00
|
|
|
|
2014-07-23 15:34:52 +07:00
|
|
|
DRM_DEBUG("new minor registered %d\n", minor->index);
|
2008-04-21 13:47:32 +07:00
|
|
|
return 0;
|
|
|
|
|
2013-08-08 20:41:34 +07:00
|
|
|
err_debugfs:
|
2014-07-23 15:34:52 +07:00
|
|
|
drm_debugfs_cleanup(minor);
|
2005-04-17 05:20:36 +07:00
|
|
|
return ret;
|
|
|
|
}
|
2005-09-25 11:28:13 +07:00
|
|
|
|
2014-01-29 18:57:05 +07:00
|
|
|
static void drm_minor_unregister(struct drm_device *dev, unsigned int type)
|
2013-10-20 23:55:40 +07:00
|
|
|
{
|
2014-01-29 18:57:05 +07:00
|
|
|
struct drm_minor *minor;
|
2014-02-24 21:53:25 +07:00
|
|
|
unsigned long flags;
|
2014-01-29 18:57:05 +07:00
|
|
|
|
|
|
|
minor = *drm_minor_get_slot(dev, type);
|
2014-07-23 16:38:38 +07:00
|
|
|
if (!minor || !device_is_registered(minor->kdev))
|
2013-10-20 23:55:40 +07:00
|
|
|
return;
|
|
|
|
|
2014-07-23 15:34:52 +07:00
|
|
|
/* replace @minor with NULL so lookups will fail from now on */
|
2014-02-24 21:53:25 +07:00
|
|
|
spin_lock_irqsave(&drm_minor_lock, flags);
|
2014-07-23 15:34:52 +07:00
|
|
|
idr_replace(&drm_minors_idr, NULL, minor->index);
|
2014-02-24 21:53:25 +07:00
|
|
|
spin_unlock_irqrestore(&drm_minor_lock, flags);
|
2013-10-20 23:55:43 +07:00
|
|
|
|
2014-07-23 16:38:38 +07:00
|
|
|
device_del(minor->kdev);
|
|
|
|
dev_set_drvdata(minor->kdev, NULL); /* safety belt */
|
2013-10-20 23:55:43 +07:00
|
|
|
drm_debugfs_cleanup(minor);
|
2013-10-20 23:55:40 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2014-01-29 16:49:19 +07:00
|
|
|
* drm_minor_acquire - Acquire a DRM minor
|
|
|
|
* @minor_id: Minor ID of the DRM-minor
|
|
|
|
*
|
|
|
|
* Looks up the given minor-ID and returns the respective DRM-minor object. The
|
|
|
|
* refence-count of the underlying device is increased so you must release this
|
|
|
|
* object with drm_minor_release().
|
|
|
|
*
|
|
|
|
* As long as you hold this minor, it is guaranteed that the object and the
|
|
|
|
* minor->dev pointer will stay valid! However, the device may get unplugged and
|
|
|
|
* unregistered while you hold the minor.
|
2013-10-20 23:55:40 +07:00
|
|
|
*
|
2014-01-29 16:49:19 +07:00
|
|
|
* Returns:
|
|
|
|
* Pointer to minor-object with increased device-refcount, or PTR_ERR on
|
|
|
|
* failure.
|
2005-04-17 05:20:36 +07:00
|
|
|
*/
|
2014-01-29 16:49:19 +07:00
|
|
|
struct drm_minor *drm_minor_acquire(unsigned int minor_id)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2014-01-29 16:49:19 +07:00
|
|
|
struct drm_minor *minor;
|
2014-02-24 21:53:25 +07:00
|
|
|
unsigned long flags;
|
2014-01-29 16:49:19 +07:00
|
|
|
|
2014-02-24 21:53:25 +07:00
|
|
|
spin_lock_irqsave(&drm_minor_lock, flags);
|
2014-01-29 16:49:19 +07:00
|
|
|
minor = idr_find(&drm_minors_idr, minor_id);
|
2014-02-24 21:53:25 +07:00
|
|
|
if (minor)
|
|
|
|
drm_dev_ref(minor->dev);
|
|
|
|
spin_unlock_irqrestore(&drm_minor_lock, flags);
|
|
|
|
|
|
|
|
if (!minor) {
|
|
|
|
return ERR_PTR(-ENODEV);
|
|
|
|
} else if (drm_device_is_unplugged(minor->dev)) {
|
|
|
|
drm_dev_unref(minor->dev);
|
2014-01-29 16:49:19 +07:00
|
|
|
return ERR_PTR(-ENODEV);
|
2014-02-24 21:53:25 +07:00
|
|
|
}
|
2008-07-31 02:06:12 +07:00
|
|
|
|
2014-01-29 16:49:19 +07:00
|
|
|
return minor;
|
|
|
|
}
|
2005-09-25 11:28:13 +07:00
|
|
|
|
2014-01-29 16:49:19 +07:00
|
|
|
/**
|
|
|
|
* drm_minor_release - Release DRM minor
|
|
|
|
* @minor: Pointer to DRM minor object
|
|
|
|
*
|
|
|
|
* Release a minor that was previously acquired via drm_minor_acquire().
|
|
|
|
*/
|
|
|
|
void drm_minor_release(struct drm_minor *minor)
|
|
|
|
{
|
|
|
|
drm_dev_unref(minor->dev);
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
2009-01-05 04:55:33 +07:00
|
|
|
|
2015-09-29 02:46:35 +07:00
|
|
|
/**
|
|
|
|
* DOC: driver instance overview
|
|
|
|
*
|
|
|
|
* A device instance for a drm driver is represented by struct &drm_device. This
|
|
|
|
* is allocated with drm_dev_alloc(), usually from bus-specific ->probe()
|
|
|
|
* callbacks implemented by the driver. The driver then needs to initialize all
|
|
|
|
* the various subsystems for the drm device like memory management, vblank
|
|
|
|
* handling, modesetting support and intial output configuration plus obviously
|
2016-06-21 15:54:16 +07:00
|
|
|
* initialize all the corresponding hardware bits. Finally when everything is up
|
|
|
|
* and running and ready for userspace the device instance can be published
|
|
|
|
* using drm_dev_register().
|
2015-09-29 02:46:35 +07:00
|
|
|
*
|
|
|
|
* There is also deprecated support for initalizing device instances using
|
|
|
|
* bus-specific helpers and the ->load() callback. But due to
|
|
|
|
* backwards-compatibility needs the device instance have to be published too
|
|
|
|
* early, which requires unpretty global locking to make safe and is therefore
|
|
|
|
* only support for existing drivers not yet converted to the new scheme.
|
|
|
|
*
|
|
|
|
* When cleaning up a device instance everything needs to be done in reverse:
|
|
|
|
* First unpublish the device instance with drm_dev_unregister(). Then clean up
|
|
|
|
* any other resources allocated at device initialization and drop the driver's
|
|
|
|
* reference to &drm_device using drm_dev_unref().
|
|
|
|
*
|
|
|
|
* Note that the lifetime rules for &drm_device instance has still a lot of
|
|
|
|
* historical baggage. Hence use the reference counting provided by
|
|
|
|
* drm_dev_ref() and drm_dev_unref() only carefully.
|
|
|
|
*
|
|
|
|
* Also note that embedding of &drm_device is currently not (yet) supported (but
|
|
|
|
* it would be easy to add). Drivers can store driver-private data in the
|
|
|
|
* dev_priv field of &drm_device.
|
|
|
|
*/
|
|
|
|
|
2016-06-21 15:54:16 +07:00
|
|
|
static int drm_dev_set_unique(struct drm_device *dev, const char *name)
|
|
|
|
{
|
|
|
|
kfree(dev->unique);
|
|
|
|
dev->unique = kstrdup(name, GFP_KERNEL);
|
|
|
|
|
|
|
|
return dev->unique ? 0 : -ENOMEM;
|
|
|
|
}
|
|
|
|
|
2009-01-05 04:55:33 +07:00
|
|
|
/**
|
2014-05-19 18:39:07 +07:00
|
|
|
* drm_put_dev - Unregister and release a DRM device
|
|
|
|
* @dev: DRM device
|
2009-01-05 04:55:33 +07:00
|
|
|
*
|
2014-05-19 18:39:07 +07:00
|
|
|
* Called at module unload time or when a PCI device is unplugged.
|
2009-01-05 04:55:33 +07:00
|
|
|
*
|
2014-05-19 18:39:07 +07:00
|
|
|
* Cleans up all DRM device, calling drm_lastclose().
|
2015-09-29 02:46:35 +07:00
|
|
|
*
|
|
|
|
* Note: Use of this function is deprecated. It will eventually go away
|
|
|
|
* completely. Please use drm_dev_unregister() and drm_dev_unref() explicitly
|
|
|
|
* instead to make sure that the device isn't userspace accessible any more
|
|
|
|
* while teardown is in progress, ensuring that userspace can't access an
|
|
|
|
* inconsistent state.
|
2009-01-05 04:55:33 +07:00
|
|
|
*/
|
|
|
|
void drm_put_dev(struct drm_device *dev)
|
|
|
|
{
|
|
|
|
DRM_DEBUG("\n");
|
|
|
|
|
|
|
|
if (!dev) {
|
|
|
|
DRM_ERROR("cleanup called no dev\n");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2013-10-02 16:23:38 +07:00
|
|
|
drm_dev_unregister(dev);
|
drm: provide device-refcount
Lets not trick ourselves into thinking "drm_device" objects are not
ref-counted. That's just utterly stupid. We manage "drm_minor" objects on
each drm-device and each minor can have an unlimited number of open
handles. Each of these handles has the drm_minor (and thus the drm_device)
as private-data in the file-handle. Therefore, we may not destroy
"drm_device" until all these handles are closed.
It is *not* possible to reset all these pointers atomically and restrict
access to them, and this is *not* how this is done! Instead, we use
ref-counts to make sure the object is valid and not freed.
Note that we currently use "dev->open_count" for that, which is *exactly*
the same as a reference-count, just open coded. So this patch doesn't
change any semantics on DRM devices (well, this patch just introduces the
ref-count, anyway. Follow-up patches will replace open_count by it).
Also note that generic VFS revoke support could allow us to drop this
ref-count again. We could then just synchronously disable any fops->xy()
calls. However, this is not the case, yet, and no such patches are
in sight (and I seriously question the idea of dropping the ref-cnt
again).
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-01-29 16:21:36 +07:00
|
|
|
drm_dev_unref(dev);
|
2009-01-05 04:55:33 +07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(drm_put_dev);
|
2012-02-20 21:18:07 +07:00
|
|
|
|
|
|
|
void drm_unplug_dev(struct drm_device *dev)
|
|
|
|
{
|
|
|
|
/* for a USB device */
|
2016-06-24 21:36:20 +07:00
|
|
|
drm_dev_unregister(dev);
|
2012-02-20 21:18:07 +07:00
|
|
|
|
|
|
|
mutex_lock(&drm_global_mutex);
|
|
|
|
|
|
|
|
drm_device_set_unplugged(dev);
|
|
|
|
|
|
|
|
if (dev->open_count == 0) {
|
|
|
|
drm_put_dev(dev);
|
|
|
|
}
|
|
|
|
mutex_unlock(&drm_global_mutex);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(drm_unplug_dev);
|
2013-10-02 16:23:34 +07:00
|
|
|
|
2014-01-03 20:09:47 +07:00
|
|
|
/*
|
|
|
|
* DRM internal mount
|
|
|
|
* We want to be able to allocate our own "struct address_space" to control
|
|
|
|
* memory-mappings in VRAM (or stolen RAM, ...). However, core MM does not allow
|
|
|
|
* stand-alone address_space objects, so we need an underlying inode. As there
|
|
|
|
* is no way to allocate an independent inode easily, we need a fake internal
|
|
|
|
* VFS mount-point.
|
|
|
|
*
|
|
|
|
* The drm_fs_inode_new() function allocates a new inode, drm_fs_inode_free()
|
|
|
|
* frees it again. You are allowed to use iget() and iput() to get references to
|
|
|
|
* the inode. But each drm_fs_inode_new() call must be paired with exactly one
|
|
|
|
* drm_fs_inode_free() call (which does not have to be the last iput()).
|
|
|
|
* We use drm_fs_inode_*() to manage our internal VFS mount-point and share it
|
|
|
|
* between multiple inode-users. You could, technically, call
|
|
|
|
* iget() + drm_fs_inode_free() directly after alloc and sometime later do an
|
|
|
|
* iput(), but this way you'd end up with a new vfsmount for each inode.
|
|
|
|
*/
|
|
|
|
|
|
|
|
static int drm_fs_cnt;
|
|
|
|
static struct vfsmount *drm_fs_mnt;
|
|
|
|
|
|
|
|
static const struct dentry_operations drm_fs_dops = {
|
|
|
|
.d_dname = simple_dname,
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct super_operations drm_fs_sops = {
|
|
|
|
.statfs = simple_statfs,
|
|
|
|
};
|
|
|
|
|
|
|
|
static struct dentry *drm_fs_mount(struct file_system_type *fs_type, int flags,
|
|
|
|
const char *dev_name, void *data)
|
|
|
|
{
|
|
|
|
return mount_pseudo(fs_type,
|
|
|
|
"drm:",
|
|
|
|
&drm_fs_sops,
|
|
|
|
&drm_fs_dops,
|
|
|
|
0x010203ff);
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct file_system_type drm_fs_type = {
|
|
|
|
.name = "drm",
|
|
|
|
.owner = THIS_MODULE,
|
|
|
|
.mount = drm_fs_mount,
|
|
|
|
.kill_sb = kill_anon_super,
|
|
|
|
};
|
|
|
|
|
|
|
|
static struct inode *drm_fs_inode_new(void)
|
|
|
|
{
|
|
|
|
struct inode *inode;
|
|
|
|
int r;
|
|
|
|
|
|
|
|
r = simple_pin_fs(&drm_fs_type, &drm_fs_mnt, &drm_fs_cnt);
|
|
|
|
if (r < 0) {
|
|
|
|
DRM_ERROR("Cannot mount pseudo fs: %d\n", r);
|
|
|
|
return ERR_PTR(r);
|
|
|
|
}
|
|
|
|
|
|
|
|
inode = alloc_anon_inode(drm_fs_mnt->mnt_sb);
|
|
|
|
if (IS_ERR(inode))
|
|
|
|
simple_release_fs(&drm_fs_mnt, &drm_fs_cnt);
|
|
|
|
|
|
|
|
return inode;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void drm_fs_inode_free(struct inode *inode)
|
|
|
|
{
|
|
|
|
if (inode) {
|
|
|
|
iput(inode);
|
|
|
|
simple_release_fs(&drm_fs_mnt, &drm_fs_cnt);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-10-02 16:23:34 +07:00
|
|
|
/**
|
2016-06-15 19:17:46 +07:00
|
|
|
* drm_dev_init - Initialise new DRM device
|
|
|
|
* @dev: DRM device
|
|
|
|
* @driver: DRM driver
|
2013-10-02 16:23:34 +07:00
|
|
|
* @parent: Parent device object
|
|
|
|
*
|
2016-06-15 19:17:46 +07:00
|
|
|
* Initialize a new DRM device. No device registration is done.
|
2013-10-02 16:23:35 +07:00
|
|
|
* Call drm_dev_register() to advertice the device to user space and register it
|
2015-09-29 02:46:35 +07:00
|
|
|
* with other core subsystems. This should be done last in the device
|
|
|
|
* initialization sequence to make sure userspace can't access an inconsistent
|
|
|
|
* state.
|
2013-10-02 16:23:34 +07:00
|
|
|
*
|
drm: provide device-refcount
Lets not trick ourselves into thinking "drm_device" objects are not
ref-counted. That's just utterly stupid. We manage "drm_minor" objects on
each drm-device and each minor can have an unlimited number of open
handles. Each of these handles has the drm_minor (and thus the drm_device)
as private-data in the file-handle. Therefore, we may not destroy
"drm_device" until all these handles are closed.
It is *not* possible to reset all these pointers atomically and restrict
access to them, and this is *not* how this is done! Instead, we use
ref-counts to make sure the object is valid and not freed.
Note that we currently use "dev->open_count" for that, which is *exactly*
the same as a reference-count, just open coded. So this patch doesn't
change any semantics on DRM devices (well, this patch just introduces the
ref-count, anyway. Follow-up patches will replace open_count by it).
Also note that generic VFS revoke support could allow us to drop this
ref-count again. We could then just synchronously disable any fops->xy()
calls. However, this is not the case, yet, and no such patches are
in sight (and I seriously question the idea of dropping the ref-cnt
again).
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-01-29 16:21:36 +07:00
|
|
|
* The initial ref-count of the object is 1. Use drm_dev_ref() and
|
|
|
|
* drm_dev_unref() to take and drop further ref-counts.
|
|
|
|
*
|
2014-11-25 02:01:58 +07:00
|
|
|
* Note that for purely virtual devices @parent can be NULL.
|
|
|
|
*
|
2016-06-15 19:17:46 +07:00
|
|
|
* Drivers that do not want to allocate their own device struct
|
|
|
|
* embedding struct &drm_device can call drm_dev_alloc() instead.
|
|
|
|
*
|
2013-10-02 16:23:34 +07:00
|
|
|
* RETURNS:
|
2016-06-15 19:17:46 +07:00
|
|
|
* 0 on success, or error code on failure.
|
2013-10-02 16:23:34 +07:00
|
|
|
*/
|
2016-06-15 19:17:46 +07:00
|
|
|
int drm_dev_init(struct drm_device *dev,
|
|
|
|
struct drm_driver *driver,
|
|
|
|
struct device *parent)
|
2013-10-02 16:23:34 +07:00
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
drm: provide device-refcount
Lets not trick ourselves into thinking "drm_device" objects are not
ref-counted. That's just utterly stupid. We manage "drm_minor" objects on
each drm-device and each minor can have an unlimited number of open
handles. Each of these handles has the drm_minor (and thus the drm_device)
as private-data in the file-handle. Therefore, we may not destroy
"drm_device" until all these handles are closed.
It is *not* possible to reset all these pointers atomically and restrict
access to them, and this is *not* how this is done! Instead, we use
ref-counts to make sure the object is valid and not freed.
Note that we currently use "dev->open_count" for that, which is *exactly*
the same as a reference-count, just open coded. So this patch doesn't
change any semantics on DRM devices (well, this patch just introduces the
ref-count, anyway. Follow-up patches will replace open_count by it).
Also note that generic VFS revoke support could allow us to drop this
ref-count again. We could then just synchronously disable any fops->xy()
calls. However, this is not the case, yet, and no such patches are
in sight (and I seriously question the idea of dropping the ref-cnt
again).
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-01-29 16:21:36 +07:00
|
|
|
kref_init(&dev->ref);
|
2013-10-02 16:23:34 +07:00
|
|
|
dev->dev = parent;
|
|
|
|
dev->driver = driver;
|
|
|
|
|
|
|
|
INIT_LIST_HEAD(&dev->filelist);
|
|
|
|
INIT_LIST_HEAD(&dev->ctxlist);
|
|
|
|
INIT_LIST_HEAD(&dev->vmalist);
|
|
|
|
INIT_LIST_HEAD(&dev->maplist);
|
|
|
|
INIT_LIST_HEAD(&dev->vblank_event_list);
|
|
|
|
|
2013-12-16 17:21:06 +07:00
|
|
|
spin_lock_init(&dev->buf_lock);
|
2013-10-02 16:23:34 +07:00
|
|
|
spin_lock_init(&dev->event_lock);
|
|
|
|
mutex_init(&dev->struct_mutex);
|
2016-04-27 00:29:41 +07:00
|
|
|
mutex_init(&dev->filelist_mutex);
|
2013-10-02 16:23:34 +07:00
|
|
|
mutex_init(&dev->ctxlist_mutex);
|
2014-02-26 01:57:44 +07:00
|
|
|
mutex_init(&dev->master_mutex);
|
2013-10-02 16:23:34 +07:00
|
|
|
|
2014-01-03 20:24:19 +07:00
|
|
|
dev->anon_inode = drm_fs_inode_new();
|
|
|
|
if (IS_ERR(dev->anon_inode)) {
|
|
|
|
ret = PTR_ERR(dev->anon_inode);
|
|
|
|
DRM_ERROR("Cannot allocate anonymous inode: %d\n", ret);
|
2013-10-02 16:23:34 +07:00
|
|
|
goto err_free;
|
2014-01-03 20:24:19 +07:00
|
|
|
}
|
|
|
|
|
2014-01-29 18:43:56 +07:00
|
|
|
if (drm_core_check_feature(dev, DRIVER_MODESET)) {
|
|
|
|
ret = drm_minor_alloc(dev, DRM_MINOR_CONTROL);
|
|
|
|
if (ret)
|
|
|
|
goto err_minors;
|
|
|
|
}
|
|
|
|
|
2014-03-16 20:38:40 +07:00
|
|
|
if (drm_core_check_feature(dev, DRIVER_RENDER)) {
|
2014-01-29 18:43:56 +07:00
|
|
|
ret = drm_minor_alloc(dev, DRM_MINOR_RENDER);
|
|
|
|
if (ret)
|
|
|
|
goto err_minors;
|
|
|
|
}
|
|
|
|
|
2016-08-04 01:04:25 +07:00
|
|
|
ret = drm_minor_alloc(dev, DRM_MINOR_PRIMARY);
|
2014-01-29 18:43:56 +07:00
|
|
|
if (ret)
|
|
|
|
goto err_minors;
|
|
|
|
|
2016-06-15 19:17:46 +07:00
|
|
|
ret = drm_ht_create(&dev->map_hash, 12);
|
|
|
|
if (ret)
|
2014-01-29 18:43:56 +07:00
|
|
|
goto err_minors;
|
2013-10-02 16:23:34 +07:00
|
|
|
|
2015-06-23 16:22:36 +07:00
|
|
|
drm_legacy_ctxbitmap_init(dev);
|
2013-10-02 16:23:34 +07:00
|
|
|
|
2014-09-30 21:49:56 +07:00
|
|
|
if (drm_core_check_feature(dev, DRIVER_GEM)) {
|
2013-10-02 16:23:34 +07:00
|
|
|
ret = drm_gem_init(dev);
|
|
|
|
if (ret) {
|
|
|
|
DRM_ERROR("Cannot initialize graphics execution manager (GEM)\n");
|
|
|
|
goto err_ctxbitmap;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-06-21 15:54:14 +07:00
|
|
|
/* Use the parent device name as DRM device unique identifier, but fall
|
|
|
|
* back to the driver name for virtual devices like vgem. */
|
|
|
|
ret = drm_dev_set_unique(dev, parent ? dev_name(parent) : driver->name);
|
|
|
|
if (ret)
|
|
|
|
goto err_setunique;
|
2015-12-11 17:20:28 +07:00
|
|
|
|
2016-06-15 19:17:46 +07:00
|
|
|
return 0;
|
2013-10-02 16:23:34 +07:00
|
|
|
|
2015-12-11 17:20:28 +07:00
|
|
|
err_setunique:
|
|
|
|
if (drm_core_check_feature(dev, DRIVER_GEM))
|
|
|
|
drm_gem_destroy(dev);
|
2013-10-02 16:23:34 +07:00
|
|
|
err_ctxbitmap:
|
2014-07-24 17:10:04 +07:00
|
|
|
drm_legacy_ctxbitmap_cleanup(dev);
|
2013-10-02 16:23:34 +07:00
|
|
|
drm_ht_remove(&dev->map_hash);
|
2014-01-29 18:43:56 +07:00
|
|
|
err_minors:
|
2016-08-04 01:04:25 +07:00
|
|
|
drm_minor_free(dev, DRM_MINOR_PRIMARY);
|
2014-01-29 18:55:48 +07:00
|
|
|
drm_minor_free(dev, DRM_MINOR_RENDER);
|
|
|
|
drm_minor_free(dev, DRM_MINOR_CONTROL);
|
2014-01-03 20:24:19 +07:00
|
|
|
drm_fs_inode_free(dev->anon_inode);
|
2013-10-02 16:23:34 +07:00
|
|
|
err_free:
|
2014-02-26 01:57:44 +07:00
|
|
|
mutex_destroy(&dev->master_mutex);
|
2016-06-15 19:17:46 +07:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(drm_dev_init);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* drm_dev_alloc - Allocate new DRM device
|
|
|
|
* @driver: DRM driver to allocate device for
|
|
|
|
* @parent: Parent device object
|
|
|
|
*
|
|
|
|
* Allocate and initialize a new DRM device. No device registration is done.
|
|
|
|
* Call drm_dev_register() to advertice the device to user space and register it
|
|
|
|
* with other core subsystems. This should be done last in the device
|
|
|
|
* initialization sequence to make sure userspace can't access an inconsistent
|
|
|
|
* state.
|
|
|
|
*
|
|
|
|
* The initial ref-count of the object is 1. Use drm_dev_ref() and
|
|
|
|
* drm_dev_unref() to take and drop further ref-counts.
|
|
|
|
*
|
|
|
|
* Note that for purely virtual devices @parent can be NULL.
|
|
|
|
*
|
|
|
|
* Drivers that wish to subclass or embed struct &drm_device into their
|
|
|
|
* own struct should look at using drm_dev_init() instead.
|
|
|
|
*
|
|
|
|
* RETURNS:
|
|
|
|
* Pointer to new DRM device, or NULL if out of memory.
|
|
|
|
*/
|
|
|
|
struct drm_device *drm_dev_alloc(struct drm_driver *driver,
|
|
|
|
struct device *parent)
|
|
|
|
{
|
|
|
|
struct drm_device *dev;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
dev = kzalloc(sizeof(*dev), GFP_KERNEL);
|
|
|
|
if (!dev)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
ret = drm_dev_init(dev, driver, parent);
|
|
|
|
if (ret) {
|
|
|
|
kfree(dev);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return dev;
|
2013-10-02 16:23:34 +07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(drm_dev_alloc);
|
2013-10-02 16:23:35 +07:00
|
|
|
|
drm: provide device-refcount
Lets not trick ourselves into thinking "drm_device" objects are not
ref-counted. That's just utterly stupid. We manage "drm_minor" objects on
each drm-device and each minor can have an unlimited number of open
handles. Each of these handles has the drm_minor (and thus the drm_device)
as private-data in the file-handle. Therefore, we may not destroy
"drm_device" until all these handles are closed.
It is *not* possible to reset all these pointers atomically and restrict
access to them, and this is *not* how this is done! Instead, we use
ref-counts to make sure the object is valid and not freed.
Note that we currently use "dev->open_count" for that, which is *exactly*
the same as a reference-count, just open coded. So this patch doesn't
change any semantics on DRM devices (well, this patch just introduces the
ref-count, anyway. Follow-up patches will replace open_count by it).
Also note that generic VFS revoke support could allow us to drop this
ref-count again. We could then just synchronously disable any fops->xy()
calls. However, this is not the case, yet, and no such patches are
in sight (and I seriously question the idea of dropping the ref-cnt
again).
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-01-29 16:21:36 +07:00
|
|
|
static void drm_dev_release(struct kref *ref)
|
2013-10-02 16:23:37 +07:00
|
|
|
{
|
drm: provide device-refcount
Lets not trick ourselves into thinking "drm_device" objects are not
ref-counted. That's just utterly stupid. We manage "drm_minor" objects on
each drm-device and each minor can have an unlimited number of open
handles. Each of these handles has the drm_minor (and thus the drm_device)
as private-data in the file-handle. Therefore, we may not destroy
"drm_device" until all these handles are closed.
It is *not* possible to reset all these pointers atomically and restrict
access to them, and this is *not* how this is done! Instead, we use
ref-counts to make sure the object is valid and not freed.
Note that we currently use "dev->open_count" for that, which is *exactly*
the same as a reference-count, just open coded. So this patch doesn't
change any semantics on DRM devices (well, this patch just introduces the
ref-count, anyway. Follow-up patches will replace open_count by it).
Also note that generic VFS revoke support could allow us to drop this
ref-count again. We could then just synchronously disable any fops->xy()
calls. However, this is not the case, yet, and no such patches are
in sight (and I seriously question the idea of dropping the ref-cnt
again).
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-01-29 16:21:36 +07:00
|
|
|
struct drm_device *dev = container_of(ref, struct drm_device, ref);
|
2013-10-20 23:55:45 +07:00
|
|
|
|
2014-09-30 21:49:56 +07:00
|
|
|
if (drm_core_check_feature(dev, DRIVER_GEM))
|
2013-10-02 16:23:37 +07:00
|
|
|
drm_gem_destroy(dev);
|
|
|
|
|
2014-07-24 17:10:04 +07:00
|
|
|
drm_legacy_ctxbitmap_cleanup(dev);
|
2013-10-02 16:23:37 +07:00
|
|
|
drm_ht_remove(&dev->map_hash);
|
2014-01-03 20:24:19 +07:00
|
|
|
drm_fs_inode_free(dev->anon_inode);
|
2013-10-02 16:23:37 +07:00
|
|
|
|
2016-08-04 01:04:25 +07:00
|
|
|
drm_minor_free(dev, DRM_MINOR_PRIMARY);
|
2014-01-29 18:55:48 +07:00
|
|
|
drm_minor_free(dev, DRM_MINOR_RENDER);
|
|
|
|
drm_minor_free(dev, DRM_MINOR_CONTROL);
|
|
|
|
|
2014-02-26 01:57:44 +07:00
|
|
|
mutex_destroy(&dev->master_mutex);
|
2014-04-11 20:23:00 +07:00
|
|
|
kfree(dev->unique);
|
2013-10-02 16:23:37 +07:00
|
|
|
kfree(dev);
|
|
|
|
}
|
drm: provide device-refcount
Lets not trick ourselves into thinking "drm_device" objects are not
ref-counted. That's just utterly stupid. We manage "drm_minor" objects on
each drm-device and each minor can have an unlimited number of open
handles. Each of these handles has the drm_minor (and thus the drm_device)
as private-data in the file-handle. Therefore, we may not destroy
"drm_device" until all these handles are closed.
It is *not* possible to reset all these pointers atomically and restrict
access to them, and this is *not* how this is done! Instead, we use
ref-counts to make sure the object is valid and not freed.
Note that we currently use "dev->open_count" for that, which is *exactly*
the same as a reference-count, just open coded. So this patch doesn't
change any semantics on DRM devices (well, this patch just introduces the
ref-count, anyway. Follow-up patches will replace open_count by it).
Also note that generic VFS revoke support could allow us to drop this
ref-count again. We could then just synchronously disable any fops->xy()
calls. However, this is not the case, yet, and no such patches are
in sight (and I seriously question the idea of dropping the ref-cnt
again).
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-01-29 16:21:36 +07:00
|
|
|
|
|
|
|
/**
|
|
|
|
* drm_dev_ref - Take reference of a DRM device
|
|
|
|
* @dev: device to take reference of or NULL
|
|
|
|
*
|
|
|
|
* This increases the ref-count of @dev by one. You *must* already own a
|
|
|
|
* reference when calling this. Use drm_dev_unref() to drop this reference
|
|
|
|
* again.
|
|
|
|
*
|
|
|
|
* This function never fails. However, this function does not provide *any*
|
|
|
|
* guarantee whether the device is alive or running. It only provides a
|
|
|
|
* reference to the object and the memory associated with it.
|
|
|
|
*/
|
|
|
|
void drm_dev_ref(struct drm_device *dev)
|
|
|
|
{
|
|
|
|
if (dev)
|
|
|
|
kref_get(&dev->ref);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(drm_dev_ref);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* drm_dev_unref - Drop reference of a DRM device
|
|
|
|
* @dev: device to drop reference of or NULL
|
|
|
|
*
|
|
|
|
* This decreases the ref-count of @dev by one. The device is destroyed if the
|
|
|
|
* ref-count drops to zero.
|
|
|
|
*/
|
|
|
|
void drm_dev_unref(struct drm_device *dev)
|
|
|
|
{
|
|
|
|
if (dev)
|
|
|
|
kref_put(&dev->ref, drm_dev_release);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(drm_dev_unref);
|
2013-10-02 16:23:37 +07:00
|
|
|
|
2013-10-02 16:23:35 +07:00
|
|
|
/**
|
|
|
|
* drm_dev_register - Register DRM device
|
|
|
|
* @dev: Device to register
|
2014-05-19 18:39:07 +07:00
|
|
|
* @flags: Flags passed to the driver's .load() function
|
2013-10-02 16:23:35 +07:00
|
|
|
*
|
|
|
|
* Register the DRM device @dev with the system, advertise device to user-space
|
|
|
|
* and start normal device operation. @dev must be allocated via drm_dev_alloc()
|
2016-06-17 15:25:17 +07:00
|
|
|
* previously.
|
2013-10-02 16:23:35 +07:00
|
|
|
*
|
|
|
|
* Never call this twice on any device!
|
|
|
|
*
|
2015-09-29 02:46:35 +07:00
|
|
|
* NOTE: To ensure backward compatibility with existing drivers method this
|
|
|
|
* function calls the ->load() method after registering the device nodes,
|
|
|
|
* creating race conditions. Usage of the ->load() methods is therefore
|
|
|
|
* deprecated, drivers must perform all initialization before calling
|
|
|
|
* drm_dev_register().
|
|
|
|
*
|
2013-10-02 16:23:35 +07:00
|
|
|
* RETURNS:
|
|
|
|
* 0 on success, negative error code on failure.
|
|
|
|
*/
|
|
|
|
int drm_dev_register(struct drm_device *dev, unsigned long flags)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
mutex_lock(&drm_global_mutex);
|
|
|
|
|
2014-01-29 18:57:05 +07:00
|
|
|
ret = drm_minor_register(dev, DRM_MINOR_CONTROL);
|
2014-01-29 18:43:56 +07:00
|
|
|
if (ret)
|
|
|
|
goto err_minors;
|
2013-10-02 16:23:35 +07:00
|
|
|
|
2014-01-29 18:57:05 +07:00
|
|
|
ret = drm_minor_register(dev, DRM_MINOR_RENDER);
|
2014-01-29 18:43:56 +07:00
|
|
|
if (ret)
|
|
|
|
goto err_minors;
|
2013-10-02 16:23:35 +07:00
|
|
|
|
2016-08-04 01:04:25 +07:00
|
|
|
ret = drm_minor_register(dev, DRM_MINOR_PRIMARY);
|
2013-10-02 16:23:35 +07:00
|
|
|
if (ret)
|
2014-01-29 18:43:56 +07:00
|
|
|
goto err_minors;
|
2013-10-02 16:23:35 +07:00
|
|
|
|
|
|
|
if (dev->driver->load) {
|
|
|
|
ret = dev->driver->load(dev, flags);
|
|
|
|
if (ret)
|
2014-01-29 18:43:56 +07:00
|
|
|
goto err_minors;
|
2013-10-02 16:23:35 +07:00
|
|
|
}
|
|
|
|
|
2016-06-18 20:46:41 +07:00
|
|
|
if (drm_core_check_feature(dev, DRIVER_MODESET))
|
2016-06-21 21:37:09 +07:00
|
|
|
drm_modeset_register_all(dev);
|
2016-06-17 15:25:17 +07:00
|
|
|
|
2013-10-02 16:23:35 +07:00
|
|
|
ret = 0;
|
|
|
|
goto out_unlock;
|
|
|
|
|
2014-01-29 18:43:56 +07:00
|
|
|
err_minors:
|
2016-08-04 01:04:25 +07:00
|
|
|
drm_minor_unregister(dev, DRM_MINOR_PRIMARY);
|
2014-01-29 18:57:05 +07:00
|
|
|
drm_minor_unregister(dev, DRM_MINOR_RENDER);
|
|
|
|
drm_minor_unregister(dev, DRM_MINOR_CONTROL);
|
2013-10-02 16:23:35 +07:00
|
|
|
out_unlock:
|
|
|
|
mutex_unlock(&drm_global_mutex);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(drm_dev_register);
|
2013-10-02 16:23:38 +07:00
|
|
|
|
|
|
|
/**
|
|
|
|
* drm_dev_unregister - Unregister DRM device
|
|
|
|
* @dev: Device to unregister
|
|
|
|
*
|
|
|
|
* Unregister the DRM device from the system. This does the reverse of
|
|
|
|
* drm_dev_register() but does not deallocate the device. The caller must call
|
drm: provide device-refcount
Lets not trick ourselves into thinking "drm_device" objects are not
ref-counted. That's just utterly stupid. We manage "drm_minor" objects on
each drm-device and each minor can have an unlimited number of open
handles. Each of these handles has the drm_minor (and thus the drm_device)
as private-data in the file-handle. Therefore, we may not destroy
"drm_device" until all these handles are closed.
It is *not* possible to reset all these pointers atomically and restrict
access to them, and this is *not* how this is done! Instead, we use
ref-counts to make sure the object is valid and not freed.
Note that we currently use "dev->open_count" for that, which is *exactly*
the same as a reference-count, just open coded. So this patch doesn't
change any semantics on DRM devices (well, this patch just introduces the
ref-count, anyway. Follow-up patches will replace open_count by it).
Also note that generic VFS revoke support could allow us to drop this
ref-count again. We could then just synchronously disable any fops->xy()
calls. However, this is not the case, yet, and no such patches are
in sight (and I seriously question the idea of dropping the ref-cnt
again).
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-01-29 16:21:36 +07:00
|
|
|
* drm_dev_unref() to drop their final reference.
|
2015-09-29 02:46:35 +07:00
|
|
|
*
|
|
|
|
* This should be called first in the device teardown code to make sure
|
|
|
|
* userspace can't access the device instance any more.
|
2013-10-02 16:23:38 +07:00
|
|
|
*/
|
|
|
|
void drm_dev_unregister(struct drm_device *dev)
|
|
|
|
{
|
|
|
|
struct drm_map_list *r_list, *list_temp;
|
|
|
|
|
|
|
|
drm_lastclose(dev);
|
|
|
|
|
2016-06-18 20:46:41 +07:00
|
|
|
if (drm_core_check_feature(dev, DRIVER_MODESET))
|
2016-06-21 21:37:09 +07:00
|
|
|
drm_modeset_unregister_all(dev);
|
2016-06-17 15:25:17 +07:00
|
|
|
|
2013-10-02 16:23:38 +07:00
|
|
|
if (dev->driver->unload)
|
|
|
|
dev->driver->unload(dev);
|
|
|
|
|
2013-12-11 17:34:38 +07:00
|
|
|
if (dev->agp)
|
|
|
|
drm_pci_agp_destroy(dev);
|
2013-10-02 16:23:38 +07:00
|
|
|
|
|
|
|
drm_vblank_cleanup(dev);
|
|
|
|
|
|
|
|
list_for_each_entry_safe(r_list, list_temp, &dev->maplist, head)
|
2014-08-29 17:12:28 +07:00
|
|
|
drm_legacy_rmmap(dev, r_list->map);
|
2013-10-02 16:23:38 +07:00
|
|
|
|
2016-08-04 01:04:25 +07:00
|
|
|
drm_minor_unregister(dev, DRM_MINOR_PRIMARY);
|
2014-01-29 18:57:05 +07:00
|
|
|
drm_minor_unregister(dev, DRM_MINOR_RENDER);
|
|
|
|
drm_minor_unregister(dev, DRM_MINOR_CONTROL);
|
2013-10-02 16:23:38 +07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(drm_dev_unregister);
|
2014-04-11 20:23:00 +07:00
|
|
|
|
2014-07-23 17:29:56 +07:00
|
|
|
/*
|
|
|
|
* DRM Core
|
|
|
|
* The DRM core module initializes all global DRM objects and makes them
|
|
|
|
* available to drivers. Once setup, drivers can probe their respective
|
|
|
|
* devices.
|
|
|
|
* Currently, core management includes:
|
|
|
|
* - The "DRM-Global" key/value database
|
|
|
|
* - Global ID management for connectors
|
|
|
|
* - DRM major number allocation
|
|
|
|
* - DRM minor management
|
|
|
|
* - DRM sysfs class
|
|
|
|
* - DRM debugfs root
|
|
|
|
*
|
|
|
|
* Furthermore, the DRM core provides dynamic char-dev lookups. For each
|
|
|
|
* interface registered on a DRM device, you can request minor numbers from DRM
|
|
|
|
* core. DRM core takes care of major-number management and char-dev
|
|
|
|
* registration. A stub ->open() callback forwards any open() requests to the
|
|
|
|
* registered minor.
|
|
|
|
*/
|
|
|
|
|
|
|
|
static int drm_stub_open(struct inode *inode, struct file *filp)
|
|
|
|
{
|
|
|
|
const struct file_operations *new_fops;
|
|
|
|
struct drm_minor *minor;
|
|
|
|
int err;
|
|
|
|
|
|
|
|
DRM_DEBUG("\n");
|
|
|
|
|
|
|
|
mutex_lock(&drm_global_mutex);
|
|
|
|
minor = drm_minor_acquire(iminor(inode));
|
|
|
|
if (IS_ERR(minor)) {
|
|
|
|
err = PTR_ERR(minor);
|
|
|
|
goto out_unlock;
|
|
|
|
}
|
|
|
|
|
|
|
|
new_fops = fops_get(minor->dev->driver->fops);
|
|
|
|
if (!new_fops) {
|
|
|
|
err = -ENODEV;
|
|
|
|
goto out_release;
|
|
|
|
}
|
|
|
|
|
|
|
|
replace_fops(filp, new_fops);
|
|
|
|
if (filp->f_op->open)
|
|
|
|
err = filp->f_op->open(inode, filp);
|
|
|
|
else
|
|
|
|
err = 0;
|
|
|
|
|
|
|
|
out_release:
|
|
|
|
drm_minor_release(minor);
|
|
|
|
out_unlock:
|
|
|
|
mutex_unlock(&drm_global_mutex);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct file_operations drm_stub_fops = {
|
|
|
|
.owner = THIS_MODULE,
|
|
|
|
.open = drm_stub_open,
|
|
|
|
.llseek = noop_llseek,
|
|
|
|
};
|
|
|
|
|
drm: cleanup drm_core_{init,exit}()
Various cleanups to the DRM core initialization and exit handlers:
- Register chrdev last: Once register_chrdev() returns, open() will
succeed on the given chrdevs. This is usually not an issue, as no
chardevs are registered, yet. However, nodes can be created by
user-space via mknod(2), even though such major/minor combinations are
unknown to the kernel. Avoid calling into drm_stub_open() in those
cases.
Again, drm_stub_open() would just bail out as the inode is unknown,
but it's really non-obvious if you hack on drm_stub_open().
- Unify error-paths into just one label. All the error-path helpers can
be called even though the constructors were not called yet, or failed.
Hence, just call all cleanups unconditionally.
- Call into drm_global_release(). This is a no-op, but provides
debugging helpers in case there're GLOBALS left on module unload. This
function was unused until now.
- Use DRM_ERROR() instead of printk(), and also print the error-code on
failure (even if it is static!).
- Don't throw away error-codes of register_chrdev()!
- Don't hardcode -1 as errno. This is just plain wrong.
- Order exit-handlers in the exact reverse order of initialization
(except if the order actually matters for syncing-reasons, which is
not the case here, though).
v2:
- Call drm_core_exit() directly from the init-error-handler. Requires to
drop __exit annotation, though.
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20160901124837.680-7-dh.herrmann@gmail.com
2016-09-01 19:48:37 +07:00
|
|
|
static void drm_core_exit(void)
|
|
|
|
{
|
|
|
|
unregister_chrdev(DRM_MAJOR, "drm");
|
|
|
|
debugfs_remove(drm_debugfs_root);
|
|
|
|
drm_sysfs_destroy();
|
|
|
|
idr_destroy(&drm_minors_idr);
|
|
|
|
drm_connector_ida_destroy();
|
|
|
|
drm_global_release();
|
|
|
|
}
|
|
|
|
|
2014-07-23 17:29:56 +07:00
|
|
|
static int __init drm_core_init(void)
|
|
|
|
{
|
drm: cleanup drm_core_{init,exit}()
Various cleanups to the DRM core initialization and exit handlers:
- Register chrdev last: Once register_chrdev() returns, open() will
succeed on the given chrdevs. This is usually not an issue, as no
chardevs are registered, yet. However, nodes can be created by
user-space via mknod(2), even though such major/minor combinations are
unknown to the kernel. Avoid calling into drm_stub_open() in those
cases.
Again, drm_stub_open() would just bail out as the inode is unknown,
but it's really non-obvious if you hack on drm_stub_open().
- Unify error-paths into just one label. All the error-path helpers can
be called even though the constructors were not called yet, or failed.
Hence, just call all cleanups unconditionally.
- Call into drm_global_release(). This is a no-op, but provides
debugging helpers in case there're GLOBALS left on module unload. This
function was unused until now.
- Use DRM_ERROR() instead of printk(), and also print the error-code on
failure (even if it is static!).
- Don't throw away error-codes of register_chrdev()!
- Don't hardcode -1 as errno. This is just plain wrong.
- Order exit-handlers in the exact reverse order of initialization
(except if the order actually matters for syncing-reasons, which is
not the case here, though).
v2:
- Call drm_core_exit() directly from the init-error-handler. Requires to
drop __exit annotation, though.
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20160901124837.680-7-dh.herrmann@gmail.com
2016-09-01 19:48:37 +07:00
|
|
|
int ret;
|
2014-07-23 17:29:56 +07:00
|
|
|
|
|
|
|
drm_global_init();
|
|
|
|
drm_connector_ida_init();
|
|
|
|
idr_init(&drm_minors_idr);
|
|
|
|
|
2015-09-09 19:21:30 +07:00
|
|
|
ret = drm_sysfs_init();
|
|
|
|
if (ret < 0) {
|
drm: cleanup drm_core_{init,exit}()
Various cleanups to the DRM core initialization and exit handlers:
- Register chrdev last: Once register_chrdev() returns, open() will
succeed on the given chrdevs. This is usually not an issue, as no
chardevs are registered, yet. However, nodes can be created by
user-space via mknod(2), even though such major/minor combinations are
unknown to the kernel. Avoid calling into drm_stub_open() in those
cases.
Again, drm_stub_open() would just bail out as the inode is unknown,
but it's really non-obvious if you hack on drm_stub_open().
- Unify error-paths into just one label. All the error-path helpers can
be called even though the constructors were not called yet, or failed.
Hence, just call all cleanups unconditionally.
- Call into drm_global_release(). This is a no-op, but provides
debugging helpers in case there're GLOBALS left on module unload. This
function was unused until now.
- Use DRM_ERROR() instead of printk(), and also print the error-code on
failure (even if it is static!).
- Don't throw away error-codes of register_chrdev()!
- Don't hardcode -1 as errno. This is just plain wrong.
- Order exit-handlers in the exact reverse order of initialization
(except if the order actually matters for syncing-reasons, which is
not the case here, though).
v2:
- Call drm_core_exit() directly from the init-error-handler. Requires to
drop __exit annotation, though.
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20160901124837.680-7-dh.herrmann@gmail.com
2016-09-01 19:48:37 +07:00
|
|
|
DRM_ERROR("Cannot create DRM class: %d\n", ret);
|
|
|
|
goto error;
|
2014-07-23 17:29:56 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
drm_debugfs_root = debugfs_create_dir("dri", NULL);
|
|
|
|
if (!drm_debugfs_root) {
|
drm: cleanup drm_core_{init,exit}()
Various cleanups to the DRM core initialization and exit handlers:
- Register chrdev last: Once register_chrdev() returns, open() will
succeed on the given chrdevs. This is usually not an issue, as no
chardevs are registered, yet. However, nodes can be created by
user-space via mknod(2), even though such major/minor combinations are
unknown to the kernel. Avoid calling into drm_stub_open() in those
cases.
Again, drm_stub_open() would just bail out as the inode is unknown,
but it's really non-obvious if you hack on drm_stub_open().
- Unify error-paths into just one label. All the error-path helpers can
be called even though the constructors were not called yet, or failed.
Hence, just call all cleanups unconditionally.
- Call into drm_global_release(). This is a no-op, but provides
debugging helpers in case there're GLOBALS left on module unload. This
function was unused until now.
- Use DRM_ERROR() instead of printk(), and also print the error-code on
failure (even if it is static!).
- Don't throw away error-codes of register_chrdev()!
- Don't hardcode -1 as errno. This is just plain wrong.
- Order exit-handlers in the exact reverse order of initialization
(except if the order actually matters for syncing-reasons, which is
not the case here, though).
v2:
- Call drm_core_exit() directly from the init-error-handler. Requires to
drop __exit annotation, though.
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20160901124837.680-7-dh.herrmann@gmail.com
2016-09-01 19:48:37 +07:00
|
|
|
ret = -ENOMEM;
|
|
|
|
DRM_ERROR("Cannot create debugfs-root: %d\n", ret);
|
|
|
|
goto error;
|
2014-07-23 17:29:56 +07:00
|
|
|
}
|
|
|
|
|
drm: cleanup drm_core_{init,exit}()
Various cleanups to the DRM core initialization and exit handlers:
- Register chrdev last: Once register_chrdev() returns, open() will
succeed on the given chrdevs. This is usually not an issue, as no
chardevs are registered, yet. However, nodes can be created by
user-space via mknod(2), even though such major/minor combinations are
unknown to the kernel. Avoid calling into drm_stub_open() in those
cases.
Again, drm_stub_open() would just bail out as the inode is unknown,
but it's really non-obvious if you hack on drm_stub_open().
- Unify error-paths into just one label. All the error-path helpers can
be called even though the constructors were not called yet, or failed.
Hence, just call all cleanups unconditionally.
- Call into drm_global_release(). This is a no-op, but provides
debugging helpers in case there're GLOBALS left on module unload. This
function was unused until now.
- Use DRM_ERROR() instead of printk(), and also print the error-code on
failure (even if it is static!).
- Don't throw away error-codes of register_chrdev()!
- Don't hardcode -1 as errno. This is just plain wrong.
- Order exit-handlers in the exact reverse order of initialization
(except if the order actually matters for syncing-reasons, which is
not the case here, though).
v2:
- Call drm_core_exit() directly from the init-error-handler. Requires to
drop __exit annotation, though.
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20160901124837.680-7-dh.herrmann@gmail.com
2016-09-01 19:48:37 +07:00
|
|
|
ret = register_chrdev(DRM_MAJOR, "drm", &drm_stub_fops);
|
|
|
|
if (ret < 0)
|
|
|
|
goto error;
|
|
|
|
|
drm: drop obsolete drm_core.h
The drm_core.h header contains a set of constants meant to be used
throughout DRM. However, as it turns out, they're each used just once and
don't bring any benefit. They're also grossly mis-named and lack
name-spacing. This patch inlines them, or moves them into drm_internal.h
as appropriate:
- CORE_AUTHOR and CORE_DESC are inlined into corresponding MODULE_*()
macros. It's just confusing having to follow 2 pointers when trying to
find the definition of these fields. Grep'ping for MODULE_AUTHOR()
should reveal the full information, if there's no strong reason not to.
- CORE_NAME, CORE_DATE, CORE_MAJOR, CORE_MINOR, and CORE_PATCHLEVEL are
inlined into the sysfs 'version' attribute. They're stripped
everywhere else (which is just some printk() statements). CORE_NAME
just doesn't make *any* sense, as we hard-code it in many places,
anyway. The other constants are outdated and just serve
binary-compatibility purposes. Hence, inline them in 'version' sysfs
attribute (we might even try dropping it..).
- DRM_IF_MAJOR and DRM_IF_MINOR are moved into drm_internal.h as they're
only used by the global ioctl handlers. Furthermore, versioning
interfaces breaks backports and as such is deprecated, anyway. We just
keep them for historic reasons. I doubt anyone will ever modify them
again.
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20160901124837.680-6-dh.herrmann@gmail.com
2016-09-01 19:48:36 +07:00
|
|
|
DRM_INFO("Initialized\n");
|
2014-07-23 17:29:56 +07:00
|
|
|
return 0;
|
|
|
|
|
drm: cleanup drm_core_{init,exit}()
Various cleanups to the DRM core initialization and exit handlers:
- Register chrdev last: Once register_chrdev() returns, open() will
succeed on the given chrdevs. This is usually not an issue, as no
chardevs are registered, yet. However, nodes can be created by
user-space via mknod(2), even though such major/minor combinations are
unknown to the kernel. Avoid calling into drm_stub_open() in those
cases.
Again, drm_stub_open() would just bail out as the inode is unknown,
but it's really non-obvious if you hack on drm_stub_open().
- Unify error-paths into just one label. All the error-path helpers can
be called even though the constructors were not called yet, or failed.
Hence, just call all cleanups unconditionally.
- Call into drm_global_release(). This is a no-op, but provides
debugging helpers in case there're GLOBALS left on module unload. This
function was unused until now.
- Use DRM_ERROR() instead of printk(), and also print the error-code on
failure (even if it is static!).
- Don't throw away error-codes of register_chrdev()!
- Don't hardcode -1 as errno. This is just plain wrong.
- Order exit-handlers in the exact reverse order of initialization
(except if the order actually matters for syncing-reasons, which is
not the case here, though).
v2:
- Call drm_core_exit() directly from the init-error-handler. Requires to
drop __exit annotation, though.
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20160901124837.680-7-dh.herrmann@gmail.com
2016-09-01 19:48:37 +07:00
|
|
|
error:
|
|
|
|
drm_core_exit();
|
2014-07-23 17:29:56 +07:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
module_init(drm_core_init);
|
|
|
|
module_exit(drm_core_exit);
|